• Aleksey Midenkov's avatar
    MDEV-25803 Inplace ALTER breaks MyISAM/Aria table when order of keys is changed · b3bdc1c1
    Aleksey Midenkov authored
    mysql_prepare_create_table() does my_qsort(sort_keys) on key
    info. This sorting is indeterministic: a table is created with one
    order and inplace alter may overwrite frm with another order. Since
    inplace alter does nothing about key info for MyISAM/Aria storage
    engines this results in discrepancy between frm and storage engine key
    definitions.
    
    The fix avoids the sorting of keys when no new keys added by ALTER
    (and this is ok for MyISAM/Aria since it cannot add new keys inplace).
    
    There is a case when implicit primary key may be changed when removing
    NOT NULL from the part of unique key. In that case we update
    modified_primary_key which is then used to not skip key sorting.
    
    According to is_candidate_key() there is no other cases when primary
    key may be changed implicitly.
    
    Notes:
    
    mi_keydef_write()/mi_keyseg_write() are used only in mi_create(). They
    should be used in ha_inplace_alter_table() as well.
    
    Aria corruption detection is unimplemented: maria_check_definition()
    is never used!
    
    MySQL 8.0 has this bug as well as of 8.0.26.
    b3bdc1c1
sql_table.cc 402 KB