• Ramil Kalimullin's avatar
    Fix for bug#35383: binlog playback and replication breaks · bce4c76a
    Ramil Kalimullin authored
    due to name_const substitution
    
    Problem:
    "In general, statements executed within a stored procedure
    are written to the binary log using the same rules that
    would apply were the statements to be executed in standalone
    fashion. Some special care is taken when logging procedure
    statements because statement execution within procedures
    is not quite the same as in non-procedure context".
    
    For example, each reference to a local variable in SP's
    statements is replaced by NAME_CONST(var_name, var_value).
    Queries like
    "CREATE TABLE ... SELECT FUNC(local_var ..."
    are logged as
    "CREATE TABLE ... SELECT FUNC(NAME_CONST("local_var", var_value) ..."
    that leads to differrent field names and
    might result in "Incorrect column name" if var_value is long enough.
    
    Fix: in 5.x we'll issue a warning in such a case.
    In 6.0 we should get rid of NAME_CONST().
    
    Note: this issue and change should be described in the documentation
    ("Binary Logging of Stored Programs").
    
    
    mysql-test/r/binlog.result:
      Fix for bug#35383: binlog playback and replication breaks
      due to name_const substitution
        - test result.
    mysql-test/t/binlog.test:
      Fix for bug#35383: binlog playback and replication breaks
      due to name_const substitution
        - test case.
    sql/sp_head.cc:
      Fix for bug#35383: binlog playback and replication breaks 
      due to name_const substitution
        - set thd->query_name_consts if there's NAME_CONST()
      substitution(s).
    sql/sql_parse.cc:
      Fix for bug#35383: binlog playback and replication breaks 
      due to name_const substitution
        - issue a warning if there's NAME_CONST() substitution and
      binary logging is on for "CREATE TABLE ... SELECT ...".
    bce4c76a
sql_parse.cc 241 KB