• Sven Sandberg's avatar
    BUG#38350: Many tests don't clean up after themselves on exit. · ca59e88c
    Sven Sandberg authored
    Problem: Many test cases don't clean up after themselves (fail
    to drop tables or fail to reset variables). This implies that:
    (1) check-testcase in the new mtr that currently lives in
    5.1-rpl failed. (2) it may cause unexpected results in
    subsequent tests.
    Fix: make all tests clean up.
    Also: cleaned away unnecessary output in rpl_packet.result
    Also: fixed bug where rpl_log called RESET MASTER with a running
    slave. This is not supposed to work.
    Also: removed unnecessary code from rpl_stm_EE_err2 and made it
    verify that an error occurred.
    Also: removed unnecessary code from rpl_ndb_ctype_ucs2_def.
    
    
    mysql-test/extra/rpl_tests/rpl_loaddata.test:
      Made test clean up after itself.
    mysql-test/extra/rpl_tests/rpl_stm_EE_err2.test:
      Made test clean up after itself.
      Also removed unnecessary save_master_pos.
      Also made test verify that an error occurred.
    mysql-test/extra/rpl_tests/rpl_truncate_helper.test:
      Made test clean up after itself.
    mysql-test/include/query_cache.inc:
      Made test clean up after itself.
    mysql-test/suite/binlog/t/binlog_auto_increment_bug33029.test:
      Made test clean up after itself.
    mysql-test/suite/rpl/t/rpl_alter_db.test:
      Made test clean up after itself.
      Easiest to refactor the test a little, to use an auxiliary database instead of mysql:
      Then we don't need to read the collation at the start of the test and reset it at the
      end of the test. We can just drop the database.
    mysql-test/suite/rpl/t/rpl_drop_db.test:
      Made test clean up after itself.
    mysql-test/suite/rpl/t/rpl_drop_view.test:
      Made test clean up after itself.
    mysql-test/suite/rpl/t/rpl_events.test:
      Made test clean up after itself.
    mysql-test/suite/rpl/t/rpl_idempotency.test:
      Made test clean up after itself.
    mysql-test/suite/rpl/t/rpl_ignore_table.test:
      Made test clean up after itself.
      The existing cleanup code didn't work, because the --replicate-*
      options prevented the "drop table" from being replicated. Moved
      "drop table t4" to a statement of its own.
    mysql-test/suite/rpl/t/rpl_packet.test:
      Made test clean up after itself.
      Also replaced SHOW SLAVE STATUS by query_get_value(SHOW SLAVE STATUS...),
      since only one column of the result was interesting.
    mysql-test/suite/rpl/t/rpl_row_max_relay_size.test:
      Made test clean up after itself.
      Instead of setting binlog format at the beginning of the test, we just
      do 'source include/have_binlog_format_row.inc' like all other tests.
    mysql-test/suite/rpl_ndb/t/rpl_ndb_2other.test:
      Made test clean up after itself.
    mysql-test/suite/rpl_ndb/t/rpl_ndb_ctype_ucs2_def.test:
      Made test clean up after itself.
      Also removed unnecessary 'create table; drop table'
      Also removed unnecessary use of --command
    mysql-test/suite/rpl_ndb/t/rpl_ndb_multi.test:
      Made test clean up after itself.
    mysql-test/t/innodb-autoinc-optimize.test:
      Made test clean up after itself.
    mysql-test/t/innodb.test:
      Made test clean up after itself.
    mysql-test/t/log_tables.test:
      Made test clean up after itself.
    mysql-test/t/mysql_client_test.test:
      Made test clean up after itself.
    mysql-test/t/partition.test:
      Made test clean up after itself.
    mysql-test/t/status.test:
      Made test clean up after itself.
    ca59e88c
innodb.test 72.7 KB