• unknown's avatar
    (manual port from 4.0 - was needed) · cc3953ac
    unknown authored
    Fix for BUG#4971 "CREATE TABLE ... TYPE=HEAP SELECT ... stops slave (wrong DELETE in binlog)":
    replacing the no_log argument of mysql_create_table() by some safer method
    (temporarily setting OPTION_BIN_LOG to 0) which guarantees that even the automatic
    DELETE FROM heap_table does not get into the binlog when a not-yet-existing HEAP table
    is opened by mysql_create_table().
    
    
    mysql-test/r/rpl_heap.result:
      result update
    mysql-test/t/rpl_heap.test:
      changing test to test a bug (but anyway, mysql-test-run --manager looks like not working in 4.1 currently,
      so this test is never run).
    sql/log.cc:
      new class Disable_binlog used to temporarily disable binlogging for one thread.
    sql/mysql_priv.h:
      removing argument no_log from mysql_create_table(); no_log was not perfect as some
      binlogging could still be done by open_unireg_entry() for a HEAP table.
    sql/sql_class.h:
      new class Disable_binlog used to temporarily disable binlogging for one thread.
    sql/sql_parse.cc:
      removing no_log arg from mysql_create_table()
    sql/sql_table.cc:
      removing no_log from mysql_create_table(); instead using new class Disable_binlog.
      Disabling binlogging in some cases, where the binlogging is done later by some other code
      (case of CREATE SELECT and ALTER).
    cc3953ac
sql_table.cc 100 KB