Commit 04b7b3a0 authored by Sergei Golubchik's avatar Sergei Golubchik

mtr bug: even if the test is skipped, process combinations

otherwise, e.g.

  ./mtr main.mysql_install_db_win_admin,innodb

results in sporadic

mysql-test-run: *** ERROR: Could not run main.mysql_install_db_win_admin with 'innodb' combination(s)

depending on whether it'll process the skip (not windows admin)
or the innodb.combinations first (if skip is processed first,
innodb combination wasn't, making the further code think that the test
doesn't have innodb combination)
parent 87d1ab9a
...@@ -614,7 +614,7 @@ sub make_combinations($$@) ...@@ -614,7 +614,7 @@ sub make_combinations($$@)
{ {
my ($test, $test_combs, @combinations) = @_; my ($test, $test_combs, @combinations) = @_;
return ($test) if $test->{'skip'} or not @combinations; return ($test) unless @combinations;
if ($combinations[0]->{skip}) { if ($combinations[0]->{skip}) {
$test->{skip} = 1; $test->{skip} = 1;
$test->{comment} = $combinations[0]->{skip} unless $test->{comment}; $test->{comment} = $combinations[0]->{skip} unless $test->{comment};
...@@ -647,6 +647,8 @@ sub make_combinations($$@) ...@@ -647,6 +647,8 @@ sub make_combinations($$@)
} }
} }
return ($test) if $test->{'skip'};
my @cases; my @cases;
foreach my $comb (@combinations) foreach my $comb (@combinations)
{ {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment