Fix for bug #23254: COMPRESS(NULL) makes all futher COMPRESS() calls on same Item return NULL

We don't set null_value to 0 in the Item_func_compress::val_str() for 
not-NULL results.
parent 2db82814
...@@ -79,3 +79,13 @@ uncompress(a) uncompressed_length(a) ...@@ -79,3 +79,13 @@ uncompress(a) uncompressed_length(a)
NULL NULL NULL NULL
a 1 a 1
drop table t1; drop table t1;
create table t1(a blob);
insert into t1 values ('0'), (NULL), ('0');
select compress(a), compress(a) from t1;
select compress(a) is null from t1;
compress(a) is null
0
1
0
drop table t1;
End of 4.1 tests
...@@ -54,4 +54,16 @@ insert into t1 values(NULL), (compress('a')); ...@@ -54,4 +54,16 @@ insert into t1 values(NULL), (compress('a'));
select uncompress(a), uncompressed_length(a) from t1; select uncompress(a), uncompressed_length(a) from t1;
drop table t1; drop table t1;
# End of 4.1 tests #
# Bug #23254: problem with compress(NULL)
#
create table t1(a blob);
insert into t1 values ('0'), (NULL), ('0');
--disable_result_log
select compress(a), compress(a) from t1;
--enable_result_log
select compress(a) is null from t1;
drop table t1;
--echo End of 4.1 tests
...@@ -2838,6 +2838,7 @@ String *Item_func_compress::val_str(String *str) ...@@ -2838,6 +2838,7 @@ String *Item_func_compress::val_str(String *str)
null_value= 1; null_value= 1;
return 0; return 0;
} }
null_value= 0;
if (res->is_empty()) return res; if (res->is_empty()) return res;
/* /*
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment