Merge a lost changeset jimmy.yang@oracle.com-20100624021010-oh2hnp8e1xbaax6u

mysql-test/suite/innodb/r/innodb_bug54044.result

-CREATE TEMPORARY TABLE TABLE_54044 ENGINE = INNODB
-AS SELECT IF(NULL  IS NOT NULL, NULL, NULL);
-ERROR HY000: Can't create table 'test.TABLE_54044' (errno: -1)

mysql-test/suite/innodb/t/innodb_bug54044.test

-# This is the test for bug #54044. Special handle MYSQL_TYPE_NULL type
-# during create table, so it will not trigger assertion failure.
-
---source include/have_innodb.inc
-
-# This 'create table' operation should fail because of
-# using NULL datatype
---error ER_CANT_CREATE_TABLE
-CREATE TEMPORARY TABLE TABLE_54044 ENGINE = INNODB
- AS SELECT IF(NULL  IS NOT NULL, NULL, NULL); 
-

mysql-test/suite/innodb_plugin/r/innodb_bug54044.result

-CREATE TEMPORARY TABLE TABLE_54044 ENGINE = INNODB
-AS SELECT IF(NULL  IS NOT NULL, NULL, NULL);
-ERROR HY000: Can't create table 'test.TABLE_54044' (errno: -1)

mysql-test/suite/innodb_plugin/t/innodb_bug54044.test

-# This is the test for bug #54044. Special handle MYSQL_TYPE_NULL type
-# during create table, so it will not trigger assertion failure.
-
---source include/have_innodb.inc
-
-# This 'create table' operation should fail because of
-# using NULL datatype
---error ER_CANT_CREATE_TABLE
-CREATE TEMPORARY TABLE TABLE_54044 ENGINE = INNODB
- AS SELECT IF(NULL  IS NOT NULL, NULL, NULL); 
-

storage/innobase/handler/ha_innodb.cc

@@ -3242,11 +3242,6 @@ get_innobase_type_from_mysql_type(
 	case MYSQL_TYPE_BLOB:
 	case MYSQL_TYPE_LONG_BLOB:
 		return(DATA_BLOB);
-	case MYSQL_TYPE_NULL:
-		/* MySQL currently accepts "NULL" datatype, but will
-		reject such datatype in the next release. We will cope
-		with it and not trigger assertion failure in 5.1 */
-		break;
 	default:
 		assert(0);
 	}
@@ -5269,21 +5264,6 @@ create_table_def(
 
 		col_type = get_innobase_type_from_mysql_type(&unsigned_type,
 									field);
-
-		if (!col_type) {
-			push_warning_printf(
-				(THD*) trx->mysql_thd,
-				MYSQL_ERROR::WARN_LEVEL_WARN,
-				ER_CANT_CREATE_TABLE,
-				"Error creating table '%s' with "
-				"column '%s'. Please check its "
-				"column type and try to re-create "
-				"the table with an appropriate "
-				"column type.",
-				table->name, (char*) field->field_name);
-			goto err_col;
-		}
-
 		if (field->null_ptr) {
 			nulls_allowed = 0;
 		} else {
@@ -5340,7 +5320,7 @@ create_table_def(
 				"different column name.",
 				table->name, (char*) field->field_name,
 				(char*) field->field_name);
-err_col:
+
 			dict_mem_table_free(table);
 			trx_commit_for_mysql(trx);
 

storage/innodb_plugin/ChangeLog

-2010-06-22	The InnoDB Team
-
-	* handler/ha_innodb.cc, innodb_bug54044.test, innodb_bug54044.result
-	Fix Bug#54044, Create temporary tables and using innodb crashes.
-
 2010-06-22	The InnoDB Team
 
 	* dict/dict0dict.c, dict/dict0mem.c, include/dict0mem.h,

storage/innodb_plugin/handler/ha_innodb.cc

@@ -3950,11 +3950,6 @@ get_innobase_type_from_mysql_type(
 	case MYSQL_TYPE_BLOB:
 	case MYSQL_TYPE_LONG_BLOB:
 		return(DATA_BLOB);
-	case MYSQL_TYPE_NULL:
-		/* MySQL currently accepts "NULL" datatype, but will
-		reject such datatype in the next release. We will cope
-		with it and not trigger assertion failure in 5.1 */
-		break;
 	default:
 		ut_error;
 	}
@@ -6006,21 +6001,6 @@ create_table_def(
 
 		col_type = get_innobase_type_from_mysql_type(&unsigned_type,
 									field);
-
-		if (!col_type) {
-			push_warning_printf(
-				(THD*) trx->mysql_thd,
-				MYSQL_ERROR::WARN_LEVEL_WARN,
-				ER_CANT_CREATE_TABLE,
-				"Error creating table '%s' with "
-				"column '%s'. Please check its "
-				"column type and try to re-create "
-				"the table with an appropriate "
-				"column type.",
-				table->name, (char*) field->field_name);
-			goto err_col;
-		}
-
 		if (field->null_ptr) {
 			nulls_allowed = 0;
 		} else {
@@ -6078,7 +6058,7 @@ create_table_def(
 		if (dict_col_name_is_reserved(field->field_name)){
 			my_error(ER_WRONG_COLUMN_NAME, MYF(0),
 				 field->field_name);
-err_col:
+
 			dict_mem_table_free(table);
 			trx_commit_for_mysql(trx);