Commit 8b51bacf authored by Nirbhay Choubey's avatar Nirbhay Choubey

MDEV-10735: Valgrind warnings around Galera SST

While copying the received state Id (uuid:seqno) to an uninitialized
buffer, it was not properly null-terminated.
parent 6eca463c
...@@ -476,13 +476,11 @@ static void* sst_joiner_thread (void* a) ...@@ -476,13 +476,11 @@ static void* sst_joiner_thread (void* a)
} else { } else {
// Scan state ID first followed by wsrep_gtid_domain_id. // Scan state ID first followed by wsrep_gtid_domain_id.
char uuid[512];
unsigned long int domain_id; unsigned long int domain_id;
size_t len= pos - out + 1;
if (len > sizeof(uuid)) goto err; // safety check // Null-terminate the state-id.
memcpy(uuid, out, len); // including '\0' out[pos - out]= 0;
err= sst_scan_uuid_seqno (uuid, &ret_uuid, &ret_seqno); err= sst_scan_uuid_seqno (out, &ret_uuid, &ret_seqno);
if (err) if (err)
{ {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment