Commit a37384fb authored by unknown's avatar unknown

some ammendments (comments and code style)


mysql-test/t/func_str.test:
  add skipped new line
sql/item_strfunc.cc:
  rewrote some comments for Item_func_elt
parent 28a8a9ea
...@@ -162,4 +162,4 @@ DROP TABLE t1; ...@@ -162,4 +162,4 @@ DROP TABLE t1;
CREATE TABLE t1 (i int, j int); CREATE TABLE t1 (i int, j int);
INSERT INTO t1 VALUES (1,1),(2,2); INSERT INTO t1 VALUES (1,1),(2,2);
SELECT DISTINCT i, ELT(j, '345', '34') FROM t1; SELECT DISTINCT i, ELT(j, '345', '34') FROM t1;
DROP TABLE t1; DROP TABLE t1;
\ No newline at end of file
...@@ -1507,7 +1507,14 @@ void Item_func_elt::fix_length_and_dec() ...@@ -1507,7 +1507,14 @@ void Item_func_elt::fix_length_and_dec()
{ {
max_length=0; max_length=0;
decimals=0; decimals=0;
for (uint i= 0; i < arg_count ; i++) // first number argument isn't in list! /*
first numeric argument isn't in args (3.23 and 4.0)
but since 4.1 the cycle should start from 1
so this change
should NOT be merged into 4.1!!!
*/
for (uint i= 0; i < arg_count ; i++)
{ {
set_if_bigger(max_length,args[i]->max_length); set_if_bigger(max_length,args[i]->max_length);
set_if_bigger(decimals,args[i]->decimals); set_if_bigger(decimals,args[i]->decimals);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment