Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
M
MariaDB
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
nexedi
MariaDB
Commits
b6464dda
Commit
b6464dda
authored
Jan 06, 2011
by
Jimmy Yang
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix Bug #55397 cannot select from innodb_trx when trx_query contains blobs
that aren't strings
rb://560
approved by Sunny Bains
parent
2cf90cb3
Changes
4
Show whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
19 additions
and
3 deletions
+19
-3
storage/innodb_plugin/ChangeLog
storage/innodb_plugin/ChangeLog
+5
-0
storage/innodb_plugin/handler/i_s.cc
storage/innodb_plugin/handler/i_s.cc
+10
-2
storage/innodb_plugin/include/trx0i_s.h
storage/innodb_plugin/include/trx0i_s.h
+2
-0
storage/innodb_plugin/trx/trx0i_s.c
storage/innodb_plugin/trx/trx0i_s.c
+2
-1
No files found.
storage/innodb_plugin/ChangeLog
View file @
b6464dda
2011-01-06 The InnoDB Team
* handler/i_s.cc, include/trx0i_s.h, trx/trx0i_s.c:
Fix Bug#55397 cannot select from innodb_trx when trx_query contains
blobs that aren't strings
2011-01-04 The InnoDB Team
2011-01-04 The InnoDB Team
* dict/dict0dict.c:
* dict/dict0dict.c:
Fix Bug#59197 double quote in field comment prevents foreign
Fix Bug#59197 double quote in field comment prevents foreign
...
...
storage/innodb_plugin/handler/i_s.cc
View file @
b6464dda
...
@@ -371,8 +371,16 @@ fill_innodb_trx_from_cache(
...
@@ -371,8 +371,16 @@ fill_innodb_trx_from_cache(
row
->
trx_mysql_thread_id
));
row
->
trx_mysql_thread_id
));
/* trx_query */
/* trx_query */
OK
(
field_store_string
(
fields
[
IDX_TRX_QUERY
],
if
(
row
->
trx_query
)
{
row
->
trx_query
));
/* store will do appropriate character set
conversion check */
fields
[
IDX_TRX_QUERY
]
->
store
(
row
->
trx_query
,
strlen
(
row
->
trx_query
),
row
->
trx_query_cs
);
fields
[
IDX_TRX_QUERY
]
->
set_notnull
();
}
else
{
fields
[
IDX_TRX_QUERY
]
->
set_null
();
}
OK
(
schema_table_store_record
(
thd
,
table
));
OK
(
schema_table_store_record
(
thd
,
table
));
}
}
...
...
storage/innodb_plugin/include/trx0i_s.h
View file @
b6464dda
...
@@ -110,6 +110,8 @@ struct i_s_trx_row_struct {
...
@@ -110,6 +110,8 @@ struct i_s_trx_row_struct {
/*!< thd_get_thread_id() */
/*!< thd_get_thread_id() */
const
char
*
trx_query
;
/*!< MySQL statement being
const
char
*
trx_query
;
/*!< MySQL statement being
executed in the transaction */
executed in the transaction */
struct
charset_info_st
*
trx_query_cs
;
/*!< charset encode the MySQL
statement */
};
};
/** This structure represents INFORMATION_SCHEMA.innodb_lock_waits row */
/** This structure represents INFORMATION_SCHEMA.innodb_lock_waits row */
...
...
storage/innodb_plugin/trx/trx0i_s.c
View file @
b6464dda
...
@@ -498,7 +498,6 @@ fill_trx_row(
...
@@ -498,7 +498,6 @@ fill_trx_row(
stmt
=
innobase_get_stmt
(
trx
->
mysql_thd
,
&
stmt_len
);
stmt
=
innobase_get_stmt
(
trx
->
mysql_thd
,
&
stmt_len
);
if
(
stmt
!=
NULL
)
{
if
(
stmt
!=
NULL
)
{
char
query
[
TRX_I_S_TRX_QUERY_MAX_LEN
+
1
];
char
query
[
TRX_I_S_TRX_QUERY_MAX_LEN
+
1
];
if
(
stmt_len
>
TRX_I_S_TRX_QUERY_MAX_LEN
)
{
if
(
stmt_len
>
TRX_I_S_TRX_QUERY_MAX_LEN
)
{
...
@@ -512,6 +511,8 @@ fill_trx_row(
...
@@ -512,6 +511,8 @@ fill_trx_row(
cache
->
storage
,
stmt
,
stmt_len
+
1
,
cache
->
storage
,
stmt
,
stmt_len
+
1
,
MAX_ALLOWED_FOR_STORAGE
(
cache
));
MAX_ALLOWED_FOR_STORAGE
(
cache
));
row
->
trx_query_cs
=
innobase_get_charset
(
trx
->
mysql_thd
);
if
(
row
->
trx_query
==
NULL
)
{
if
(
row
->
trx_query
==
NULL
)
{
return
(
FALSE
);
return
(
FALSE
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment