Fix 'make distcheck' problems with new unittest code, and a small

portability problem.


BitKeeper/etc/ignore:
  Use a wildcard to ignore all unittest *.t files
unittest/Makefile.am:
  Add unit to DISTCLEANFILES, and make sure to copy it from srcdir
unittest/examples/Makefile.am:
  Use srcdir to find mytap header
unittest/mysys/Makefile.am:
  Use srcdir to find mytap header
unittest/mytap/t/Makefile.am:
  Use builddir for finding mytap library
unittest/mytap/tap.c:
  Fix portability problem (declarations after code in C code)

.bzrignore

@@ -1760,3 +1760,7 @@ zlib/*.ds?
 zlib/*.vcproj
 mysql-test/r/*.log
 client/mysql_upgrade
+unittest/examples/*.t
+unittest/mysys/*.t
+unittest/mytap/t/*.t
+unittest/unit

unittest/Makefile.am

@@ -2,6 +2,8 @@ SUBDIRS      = mytap . mysys examples
 
 noinst_SCRIPTS = unit
 
+DISTCLEANFILES = unit
+
 unittests = mysys examples
 
 .PHONY: all mytap mysys examples test
@@ -18,6 +20,6 @@ mysys:
 examples:
 	cd examples && $(MAKE)
 
-unit: unit.pl
+unit: $(srcdir)/unit.pl
 	cp $< $@
 	chmod +x $@

unittest/examples/Makefile.am

 AM_CPPFLAGS        = -I$(srcdir) -I$(top_builddir)/include
-AM_CPPFLAGS       += -I$(top_builddir)/unittest/mytap
+AM_CPPFLAGS       += -I$(top_srcdir)/unittest/mytap
 
 AM_LDFLAGS         = -L$(top_builddir)/unittest/mytap
 

unittest/mysys/Makefile.am

 
 AM_CPPFLAGS      = @ZLIB_INCLUDES@ -I$(top_builddir)/include 
-AM_CPPFLAGS     += -I$(top_srcdir)/include -I$(top_builddir)/unittest/mytap
+AM_CPPFLAGS     += -I$(top_srcdir)/include -I$(top_srcdir)/unittest/mytap
 
 AM_LDFLAGS       = -L$(top_builddir)/unittest/mytap -L$(top_builddir)/mysys
 AM_LDFLAGS      += -L$(top_builddir)/strings -L$(top_builddir)/dbug

unittest/mytap/t/Makefile.am

@@ -2,7 +2,7 @@
 AM_CPPFLAGS     = -I$(srcdir) -I$(top_builddir)/include
 AM_CPPFLAGS    += -I$(srcdir)/..
 
-AM_LDFLAGS      = -L$(srcdir)/..
+AM_LDFLAGS      = -L$(top_builddir)/unittest/mytap
 
 AM_CFLAGS       = -Wall -ansi -pedantic
 

unittest/mytap/tap.c

@@ -138,11 +138,12 @@ skip_all(char const *reason, ...)
 void
 ok(int const pass, char const *fmt, ...)
 {
+  va_list ap;
+  va_start(ap, fmt);
+
   if (!pass && *g_test.todo == '\0')
     ++g_test.failed;
 
-  va_list ap;
-  va_start(ap, fmt);
   emit_tap(pass, fmt, ap);
   va_end(ap);
   if (*g_test.todo != '\0')