post-review cleanup

mysql-test/suite/roles/drop_current_user-5176.test

 #
 # MDEV-5176 Server crashes in fill_schema_applicable_roles on select from APPLICABLE_ROLES after a suicide
 #
+--source include/not_embedded.inc
 
 grant create user on *.* to foo@localhost;
 --connect (foo,localhost,foo,,)

sql/log_event.cc

@@ -2866,7 +2866,7 @@ bool Query_log_event::write(IO_CACHE* file)
       else
       {
         user.str= ctx->priv_role;
-        host= null_lex_str; // XXX FIXME or empty_lex_str ?
+        host= empty_lex_str;
       }
       user.length= strlen(user.str);
     }

sql/sql_parse.cc

@@ -3908,8 +3908,6 @@ case SQLCOM_PREPARE:
   case SQLCOM_REVOKE_ROLE:
   case SQLCOM_GRANT_ROLE:
   {
-    /* TODO access check */
-
     if (!(res= mysql_grant_role(thd, lex->users_list,
                                 lex->sql_command != SQLCOM_GRANT_ROLE)))
       my_ok(thd);

sql/sql_view.cc

@@ -822,6 +822,10 @@ static int mysql_register_view(THD *thd, TABLE_LIST *view,
     goto err;   
   }
 
+  /*
+    version 1 - before 10.0.5
+    version 2 - empty definer_host means a role
+  */
   view->file_version= 2;
   view->calc_md5(md5);
   if (!(view->md5.str= (char*) thd->memdup(md5, 32)))