1. 03 Aug, 2005 2 commits
    • unknown's avatar
      ha_innodb.cc: · 076c375a
      unknown authored
        Fix compilation error in previous commit
      
      
      sql/ha_innodb.cc:
        Fix compilation error in previous commit
      076c375a
    • unknown's avatar
      ha_innodb.cc: · 43b1710c
      unknown authored
        Backport of Bug #9670 to 4.0: assertion failure in ut_a(cursor->old_stored == BTR_PCUR_OLD_STORED)
      
      
      sql/ha_innodb.cc:
        Backport of Bug #9670 to 4.0: assertion failure in ut_a(cursor->old_stored == BTR_PCUR_OLD_STORED)
      43b1710c
  2. 02 Aug, 2005 1 commit
    • unknown's avatar
      BUG#11684 fix. · 451ec64d
      unknown authored
      Repair crashes mysql when table has fulltext index.
      
      
      myisam/sort.c:
        Use static ft_buf instead of dynamic mergebuf. Latter could be NULL if record has long words.
      mysql-test/r/fulltext.result:
        Test case for BUG#11684 - repair crashes mysql when table has fulltext index.
      mysql-test/t/fulltext.test:
        Test case for BUG#11684 - repair crashes mysql when table has fulltext index.
      451ec64d
  3. 26 Jul, 2005 1 commit
    • unknown's avatar
      Review fixes: · 90e41fac
      unknown authored
      Fixed portability problem with bool in C programs
      Moved close_thread_tables out from LOCK_thread_count mutex (safety fix)
      my_sleep() -> pthread_cond_timedwait()
      
      
      include/thr_lock.h:
        bool -> my_bool (bool is not portable in C programs)
      mysys/thr_lock.c:
        bool -> my_bool (bool is not portable in C programs)
      sql/lock.cc:
        Added comment
        Don't use | on bool variable
      sql/mysql_priv.h:
        Added comment
      sql/slave.cc:
        Moved close_thread_tables out from LOCK_thread_count mutex (safety fix)
      sql/sql_base.cc:
        Added comments
        my_sleep() -> pthread_cond_timedwait() to get less code and potentitally faster loop
      BitKeeper/etc/ignore:
        added ac_available_languages_fragment
      90e41fac
  4. 25 Jul, 2005 1 commit
    • unknown's avatar
      - Make sure the scripts make_binary_distribution, make_sharedlib_distribution and · 1f36f6f4
      unknown authored
        make_win_src_distribution are created, but not installed
      - removed make_win_binary_distribution.sh as it's obsolete and outdated
      
      
      BitKeeper/deleted/.del-make_win_binary_distribution.sh~e0fbb0a75af0dcd3:
        Delete: scripts/make_win_binary_distribution.sh
      scripts/Makefile.am:
        - Make sure the scripts make_binary_distribution, make_sharedlib_distribution and
          make_win_src_distribution are created, but not installed. This is the proper fix
          for what I began in the previous ChangeSet
        - removed make_win_binary_distribution.sh from the distribution, as it's obsolete
          and outdated
      1f36f6f4
  5. 22 Jul, 2005 3 commits
  6. 21 Jul, 2005 2 commits
  7. 20 Jul, 2005 2 commits
    • unknown's avatar
      Bug #10600 After review fixes · af1dfb61
      unknown authored
      
      sql/lock.cc:
        Used flags immediately in call
      sql/mysql_priv.h:
        Added RTFC (short for remove_table_from_cache)
        for constants and used hex syntax to clarify it is bits
        in the flags
      sql/sql_base.cc:
        Use flags parameter immediately and use flags immediately in call
        Change to other variant of eternal loop variant
      sql/sql_table.cc:
        Use flags immediately in call
      af1dfb61
    • unknown's avatar
      - don't install the Mac OS X support files when running "make install" - · d207bd81
      unknown authored
        they're not needed outside of the source tree (BUG#12057)
      - Removed some more unneeded files from "make install" along the way
      
      
      scripts/Makefile.am:
        - don't install the following files with "make install", as they are
          not needed to be installed: 
          make_win_src_distribution, make_win_binary_distribution,
          make_binary_distribution, make_sharedlib_distribution
      support-files/MacOSX/Makefile.am:
        - don't install the Mac OS X support files when running "make install" -
          they're not needed outside of the source tree (BUG#12057)
      support-files/Makefile.am:
        - don't install the RPM spec files with "make install" - they are not
          needed outside of the source tree
      d207bd81
  8. 18 Jul, 2005 1 commit
    • unknown's avatar
      Bug #10600 · 6d29b23b
      unknown authored
      remove_table_from_cache fails to signal other thread and gets
      blocked when other thread also gets blocked
      
      
      include/thr_lock.h:
        Report if any threads was signalled
      mysys/thr_lock.c:
        Report if any threads was signalled
      sql/lock.cc:
        Report if any threads was signalled
        Use new interface for remove_table_from_cache
      sql/mysql_priv.h:
        New interface for remove_table_from_cache
        + mysql_lock_abort_for_thread
      sql/sql_base.cc:
        Use new interface of remove_table_cache
        Rewrote remove_table_from_cache to fix bug
      sql/sql_table.cc:
        Use new interface of remove_table_from_cache
      6d29b23b
  9. 15 Jul, 2005 1 commit
    • unknown's avatar
      RPM spec file improvements: · 5c27ff06
      unknown authored
      - create a "mysql" user group and assign the mysql user account to that group
        in the server postinstall section. (BUG 10984)
      - backported some changes from the 4.1 RPM spec file (cleanups: removed the incomplete
        Brazilian translations, more consequent use of macros)
      
      
      support-files/mysql.spec.sh:
        - create a "mysql" user group and assign the mysql user account to that group
          in the server postinstall section. (BUG 10984)
        - backported some changes from the 4.1 RPM spec file (cleanups: removed the incomplete
          Brazilian translations, more consequent use of macros)
      5c27ff06
  10. 14 Jul, 2005 1 commit
    • unknown's avatar
      BUG#11384 drop database causes mysqld to core · 7f8b2334
      unknown authored
      Only reproducable in 5.1-wl2325, although the missing code is missing from 4.0 and up.
      
      
      sql/slave.cc:
        Clean up after slave sql thread when exiting.
        
        Wasn't calling close_thread_tables().
        
        This was causing a crashing bug in the 5.1-wl2325 tree. It is conceivable that this
        could cause a problem in earlier versions, but we have not been able to reproduce.
      7f8b2334
  11. 06 Jul, 2005 1 commit
    • unknown's avatar
      - backported a change for make_binary_distribution.sh from 5.0 for easier building of · 2a04d155
      unknown authored
        all versions: added an option "--machine" that allows to override the autodetected
        architecture string (e.g. "i386") that becomes part of the binary package name with 
        a different one
      - moved the removal of the BASE directory to the end of the make_binary_distribution
        script
      
      
      scripts/make_binary_distribution.sh:
        - backported and fixed a change from 5.0 for easier building of all versions: added an
          option "--machine" that allows to override the autodetected architecture string 
          (e.g. "i386") that becomes part of the binary package name with a different one
        - moved the removal of the BASE directory to the end of the script
      2a04d155
  12. 05 Jul, 2005 1 commit
  13. 04 Jul, 2005 2 commits
  14. 02 Jul, 2005 1 commit
    • unknown's avatar
      configure.in: · 2fec2ba4
      unknown authored
        Enable build with CXX=gcc and gcc version 4
      
      
      configure.in:
        Enable build with CXX=gcc and gcc version 4
      2fec2ba4
  15. 30 Jun, 2005 1 commit
  16. 23 Jun, 2005 1 commit
  17. 08 Jun, 2005 1 commit
    • unknown's avatar
      Fix for · 59445ce4
      unknown authored
      BUG#10675 - MySQL fails to build with --openssl on Mac OS X 10.4
      BUG#11150 - HP-UX yaSSL/OpenSSL configure/header problem
      Remove obsolete code.
      
      
      include/my_global.h:
        Obsolete code removed. OpenSSL doesn't have crypt anymore (it was dropped in ~2003).
        This patch fixes compilation failures with both OpenSSL and yaSSL on systems where
        crypt was defined in unistd.h.
        Conclusion is we do not use OpenSSL's crypt unless it wasn't defined in
        unistd.h/crypt.h and it was defined in old OpenSSL.
      59445ce4
  18. 06 Jun, 2005 1 commit
  19. 03 Jun, 2005 5 commits
    • unknown's avatar
      Bug #10901 · 26bd1582
      unknown authored
      After review fix
      Copy from internal state to share state only when in lock write
      mode (happens only when lock table x write has been performed since
      update_state_info is only called when holding a TL_READ_NO_INSERT
      lock normally. Previous patch would have failed in combination with
      delayed writes.
      
      
      26bd1582
    • unknown's avatar
      Bug #10901 · f956ecd0
      unknown authored
      Analyze table corrupts the state on
      data_file_length, records, index_file_length...
      by writing the shared state when there is an updated internal
      state due to inserts or deletes
      Fixed by synching the shared state with the internal state before
      writing it to disk
      Added test cases of 2 error cases and a normal case in new
      analyze test case
      
      
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      f956ecd0
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-4.0/ · ef30cc61
      unknown authored
      into serg.mylan:/usr/home/serg/Abk/mysql-4.0
      
      
      ef30cc61
    • unknown's avatar
      *don't* mess with kernel defines, boy. · 78fc4172
      unknown authored
      and HAVE_ATOMIC_ADD/HAVE_ATOMIC_SUB is tested in configure
      
      
      78fc4172
    • unknown's avatar
      sql_repl.cc: · 74dd6421
      unknown authored
        Bug #11064  	some read error not detected in replication on 64-bit platform
      
      
      sql/sql_repl.cc:
        Bug #11064  	some read error not detected in replication on 64-bit platform
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      74dd6421
  20. 01 Jun, 2005 1 commit
    • unknown's avatar
      - removed references to some obsolete files (BUG#10824) · 0d4b1184
      unknown authored
      - removed obsolete mysql-max.spec.sc RPM spec file (Max is built out of the standard
        spec file)
      
      
      BitKeeper/deleted/.del-mysql-max.spec.sh~ca055d86585c1010:
        Delete: support-files/mysql-max.spec.sh
      configure.in:
        - removed references to some obsolete files
      scripts/make_binary_distribution.sh:
        - removed references to some obsolete files
      0d4b1184
  21. 31 May, 2005 1 commit
    • unknown's avatar
      Bug#10224 - ANALYZE TABLE crashing with simultaneous CREATE ... SELECT statement. · cf2188ca
      unknown authored
      1.) Added a new option to mysql_lock_tables() for ignoring FLUSH TABLES.
      Used the new option in create_table_from_items().
      It is necessary to prevent the SELECT table from being reopend.
      It would get new storage assigned for its fields, while the
      SELECT part of the command would still use the old (freed) storage.
      2.) Protected the CREATE TABLE and CREATE TABLE ... SELECT commands
      against a global read lock. This prevents a deadlock in
      CREATE TABLE ... SELECT in conjunction with FLUSH TABLES WITH READ LOCK
      and avoids the creation of new tables during a global read lock.
      3.) Replaced set_protect_against_global_read_lock() and
      unset_protect_against_global_read_lock() by
      wait_if_global_read_lock() and start_waiting_global_read_lock()
      in the INSERT DELAYED handling.
      
      
      mysql-test/r/create.result:
        Bug#10224 - ANALYZE TABLE crashing with simultaneous CREATE ... SELECT statement.
        Added test results.
      mysql-test/t/create.test:
        Bug#10224 - ANALYZE TABLE crashing with simultaneous CREATE ... SELECT statement.
        Added tests which do not require concurrency.
      sql/lock.cc:
        Bug#10224 - ANALYZE TABLE crashing with simultaneous CREATE ... SELECT statement.
        Added a new option to mysql_lock_tables() for ignoring FLUSH TABLES.
        Changed the parameter list.
        Removed two unnecessary functions. Their functionality is included in
        wait_if_global_read_lock() and start_waiting_global_read_lock().
      sql/mysql_priv.h:
        Bug#10224 - ANALYZE TABLE crashing with simultaneous CREATE ... SELECT statement.
        Changed the declaration of mysql_lock_tables().
        Added definitions for the new options.
      sql/sql_acl.cc:
        Bug#10224 - ANALYZE TABLE crashing with simultaneous CREATE ... SELECT statement.
        Adjusted mysql_lock_tables() calls to the new argument list.
      sql/sql_base.cc:
        Bug#10224 - ANALYZE TABLE crashing with simultaneous CREATE ... SELECT statement.
        Adjusted mysql_lock_tables() calls to the new argument list.
      sql/sql_handler.cc:
        Bug#10224 - ANALYZE TABLE crashing with simultaneous CREATE ... SELECT statement.
        Adjusted mysql_lock_tables() calls to the new argument list.
      sql/sql_insert.cc:
        Bug#10224 - ANALYZE TABLE crashing with simultaneous CREATE ... SELECT statement.
        Replaced set_protect_against_global_read_lock() and
        unset_protect_against_global_read_lock() by
        wait_if_global_read_lock() and start_waiting_global_read_lock()
        in the INSERT DELAYED handling.
        Adjusted mysql_lock_tables() calls to the new argument list.
      sql/sql_parse.cc:
        Bug#10224 - ANALYZE TABLE crashing with simultaneous CREATE ... SELECT statement.
        Protected the CREATE TABLE and CREATE TABLE ... SELECT commands
        against a global read lock. This prevents a deadlock in
        CREATE TABLE ... SELECT in conjunction with FLUSH TABLES WITH READ LOCK
        and avoids the creation of new tables during a global read lock.
      sql/sql_table.cc:
        Bug#10224 - ANALYZE TABLE crashing with simultaneous CREATE ... SELECT statement.
        Adjusted mysql_lock_tables() calls to the new argument list.
        Used the new option in create_table_from_items().
      cf2188ca
  22. 26 May, 2005 2 commits
  23. 25 May, 2005 1 commit
  24. 18 May, 2005 2 commits
  25. 15 May, 2005 2 commits
    • unknown's avatar
      Merge spetrunia@bk-internal.mysql.com:/home/bk/mysql-4.0 · b11b13e9
      unknown authored
      into mysql.com:/home/psergey/mysql-4.0-bug10095
      
      
      b11b13e9
    • unknown's avatar
      Fix for BUG#10095: {wrong query results because of incorrect constant propagation} · 06736ab4
      unknown authored
      The problem: base_list::remove didn't modify base_list::last when removing 
      the last list element.
      The fix: If we remove the last element, find the element before it (by walking
      from the beginning of the list) and set base_list::last accordingly.
      
      The list gets corrupted in both 4.0 and 4.1. There are no visible problems in 
      current 4.1 because current 4.1 doesn't call where_cond->fix_fields() after 
      constant propagation step.
      
      
      mysql-test/r/select.result:
        Testcase for BUG#10095
      mysql-test/t/select.test:
        Testcase for BUG#10095
      sql/sql_list.h:
        Fix for BUG#10095: {wrong query results because of incorrect constant propagation} 
        The problem: base_list::remove didn't modify base_list::last when removing 
        the last list element.
        The fix: If we remove the last element, find the element before it (by walking
        from the beginning of the list) and set base_list::last accordingly.
      06736ab4
  26. 14 May, 2005 1 commit
  27. 13 May, 2005 1 commit
    • unknown's avatar
      Fixed wrong buffer usage for auto-increment key with blob part that caused... · cdd6bc9b
      unknown authored
      Fixed wrong buffer usage for auto-increment key with blob part that caused CHECK TABLE to report that the table was wrong. (Bug #10045)
      
      
      myisam/mi_key.c:
        Fixed wrong buffer usage for auto-increment key with blob part that caused
        CHECK TABLE to report that the table was wrong. (Bug #10045)
      mysql-test/r/auto_increment.result:
        New test case
      mysql-test/t/auto_increment.test:
        New test case
      cdd6bc9b