- 12 Aug, 2008 1 commit
-
-
Davi Arnaut authored
-
- 11 Aug, 2008 9 commits
-
-
Davi Arnaut authored
Post-merge fix: mysql_client_test.c is compiled by C compilers and some C compilers don't support mixed declarations and code and it's explicitly forbidden by ISO C90. tests/mysql_client_test.c: Don't mix declarations and code.
-
Marc Alff authored
-
Marc Alff authored
Fixed missing DBUG_RETURN in the function find_key_block
-
Chad MILLER authored
-
Marc Alff authored
This fix is for 5.0 only : back porting the 6.0 patch manually The parser code in sql/sql_yacc.yy needs to be more robust to out of memory conditions, so that when parsing a query fails due to OOM, the thread gracefully returns an error. Before this fix, a new/alloc returning NULL could: - cause a crash, if dereferencing the NULL pointer, - produce a corrupted parsed tree, containing NULL nodes, - alter the semantic of a query, by silently dropping token values or nodes With this fix: - C++ constructors are *not* executed with a NULL "this" pointer when operator new fails. This is achieved by declaring "operator new" with a "throw ()" clause, so that a failed new gracefully returns NULL on OOM conditions. - calls to new/alloc are tested for a NULL result, - The thread diagnostic area is set to an error status when OOM occurs. This ensures that a request failing in the server properly returns an ER_OUT_OF_RESOURCES error to the client. - OOM conditions cause the parser to stop immediately (MYSQL_YYABORT). This prevents causing further crashes when using a partially built parsed tree in further rules in the parser. No test scripts are provided, since automating OOM failures is not instrumented in the server. Tested under the debugger, to verify that an error in alloc_root cause the thread to returns gracefully all the way to the client application, with an ER_OUT_OF_RESOURCES error.
-
Chad MILLER authored
-
Davi Arnaut authored
client/mysql_upgrade.c: Silence warning due to type mismatch.
-
Kristofer Pettersson authored
-
Kristofer Pettersson authored
Server side cursors were not initialized properly and this caused a reference to uninitialized memory.
-
- 07 Aug, 2008 1 commit
-
-
Chad MILLER authored
running on Windows We used two OS-specific methods of looking up the executable name, which don't work outside of those two kinds of OSes (Linux+Solaris and Windows). We assume that if the user ran this program with a certain name, we can run the other sibling programs with a similar name. (re-patch in bzr)
-
- 06 Aug, 2008 2 commits
-
-
Chad MILLER authored
Fall back to "find" if bzr is unavailable. Don't fail for paths that have spaces in them.
-
Chad MILLER authored
bk sfiles -> bzr ls
-
- 04 Aug, 2008 1 commit
-
-
Kristofer Pettersson authored
-
- 31 Jul, 2008 1 commit
-
-
Georgi Kodinov authored
Reset session sql_mode before creating system tables as it is done in the mysql_fix_privilege_tables.sql script. scripts/mysql_system_tables.sql: reset sql mode
-
- 30 Jul, 2008 1 commit
-
-
Georgi Kodinov authored
min() and max() functions are implemented in MySQL as macros. This means that max(a,b) is expanded to: ((a) > (b) ? (a) : (b)) Note how 'a' is quoted two times. Now imagine 'a' is a recursive function call that's several 10s of levels deep. And the recursive function does max() with a function arg as well to dive into recursion. This means that simple function call can take most of the clock time. Identified and fixed several such calls to max()/min() : including the IF() sql function implementation. mysql-test/r/func_if.result: Bug#37662 test case mysql-test/t/func_if.test: Bug#37662 test case sql/item.cc: Bug#37662 don't call expensive functions as arguments to min/max sql/item_cmpfunc.cc: Bug#37662 don't call expensive functions as arguments to min/max sql/item_func.cc: Bug#37662 don't call expensive functions as arguments to min/max
-
- 29 Jul, 2008 3 commits
-
-
Kristofer Pettersson authored
Community contribution fix for Serbian translation in error message list.
-
Kristofer Pettersson authored
Fixed typo and removed duplicate call to get_current_user.
-
Kristofer Pettersson authored
-
- 28 Jul, 2008 1 commit
-
-
Igor Babaev authored
-
- 26 Jul, 2008 1 commit
-
-
Igor Babaev authored
Calling List<Cached_item>::delete_elements for the same list twice caused a crash of the server in the function JOIN::cleaunup. Ensured that delete_elements() in JOIN::cleanup would be called only once. mysql-test/r/subselect.result: Added a test case for bug #38191. mysql-test/t/subselect.test: Added a test case for bug #38191. sql/sql_select.cc: Fixed bug #38191. Ensured that delete_elements() in JOIN::cleanup would be called only once.
-
- 24 Jul, 2008 1 commit
-
-
Davi Arnaut authored
-
- 23 Jul, 2008 1 commit
-
-
Georgi Kodinov authored
Range scan in descending order for c <= <col> <= c type of ranges was ignoring the DESC flag. However some engines like InnoDB have the primary key parts as a suffix for every secondary key. When such primary key suffix is used for ordering ignoring the DESC is not valid. But we generally would like to do this because it's faster. Fixed by performing only reverse scan if the primary key is used. Removed some dead code in the process. mysql-test/r/innodb_mysql.result: Bug#37830 : test case mysql-test/t/innodb_mysql.test: Bug#37830 : test case sql/opt_range.cc: Bug#37830 : - preserve and use used_key_parts to distinguish when a primary key suffix is used - removed some dead code sql/opt_range.h: Bug#37830 : - preserve used_key_parts - dead code removed sql/sql_select.cc: Bug#37830 : Do only reverse order traversal if the primary key suffix is used.
-
- 22 Jul, 2008 1 commit
-
-
Kristofer Pettersson authored
-
- 21 Jul, 2008 1 commit
-
-
Kristofer Pettersson authored
-
- 24 Jul, 2008 1 commit
-
-
Kristofer Pettersson authored
If the server failed to expired log files during start up it could crash. sql/log.cc: Added predicate to protect againt cases when current_thd might be NULL.
-
- 21 Jul, 2008 1 commit
-
-
Timothy Smith authored
-
- 19 Jul, 2008 2 commits
-
-
Timothy Smith authored
-
unknown authored
-
- 18 Jul, 2008 2 commits
-
-
Georgi Kodinov authored
- Revert the fix for bug 33812 - fixed a win32 warning client/mysql.cc: revert the fix for bug 33812 mysql-test/r/mysql.result: revert the fix for bug 33812 mysql-test/t/mysql_delimiter.sql: revert the fix for bug 33812 mysys/default.c: fixed a win32 warning
-
Alexander Barkov authored
Problem: missing initialization, if the previous test fails leaving table t1, client_xml fails as well. Fix: adding initialization.
-
- 17 Jul, 2008 2 commits
-
-
Timothy Smith authored
Includes fix for Bug #38180, "options are read from ~/my.cnf instead of ~/.my.cnf"
-
Georgi Kodinov authored
Don't initalize federated if it's disabled by a command line option. sql/ha_federated.cc: Folow-up on Bug#37069: Don't initalize federated if it's disabled by a command line option.
-
- 16 Jul, 2008 5 commits
-
-
unknown authored
-
Timothy Smith authored
Pull out some of unpack_dirname() into normalize_dirname(); this new function does not expand "~" to the home directory. Use this function in unpack_dirname(), and use it during init_default_directories() to remove duplicate entries without losing track of which directory is a user's home dir.
-
Marc Alff authored
Reverting the previous patch
-
Kristofer Pettersson authored
-
Jonathan Perkin authored
-
- 15 Jul, 2008 2 commits
-
-
Sergey Petrunia authored
-
Kristofer Pettersson authored
-