1. 31 Oct, 2007 13 commits
    • unknown's avatar
      Merge endora.local:/Users/davi/mysql/bugs/31669-5.1 · 17d22305
      unknown authored
      into  endora.local:/Users/davi/mysql/mysql-5.1-runtime
      
      
      17d22305
    • unknown's avatar
      Post merge fix for bug 31669. · 10ed5ae7
      unknown authored
      
      tests/mysql_client_test.c:
        Macro name changed in 5.1
      10ed5ae7
    • unknown's avatar
      Cleanup: rename select_send::status to select_send::is_result_set_started. · 9ad4366b
      unknown authored
      Add select_send::cleanup.
      Fix a compilation warning.
      Issues spotted while working on the fix for Bug#12713.
      
      
      sql-common/client.c:
        Fix a warning.
      sql/sql_class.cc:
        Give a variable a more specific name. Rewrite an incorrect comment.
        Add a cleanup for select_send. The only case now this cleanup can be
        necessary is when we have a prepared statement inside a stored procedure, 
        and a continue handler. At first execution, the statement is killed
        after having executed select_send::send_fields. At the second execution
        it is killed after having executed select_send::send_fields.
      sql/sql_class.h:
        Rename a member. Add comments.
      9ad4366b
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · 6c763974
      unknown authored
      into  bodhi.(none):/opt/local/work/mysql-5.1-runtime-inc
      
      
      libmysql/libmysql.c:
        Auto merged
      6c763974
    • unknown's avatar
      Cleanup: use helper functions to set an error in MYSQL or MYSQL_STMT. · 70987ab9
      unknown authored
      No functionality added or changed.
      This is a pre-requisite for the fix for Bug#12713 Error in a stored 
      function called from a SELECT doesn't cause ROLLBACK of statem
      
      Address post-review comments.
      
      
      include/sql_common.h:
        Declare auxiliary functions to manipulate mysql.net.last_er* and 
        mysql_stmt.last_er*
      libmysql/libmysql.c:
        Use helper functions to set an error in MYSQL or MYSQL_STMT
      libmysqld/lib_sql.cc:
        Use helper functions to set an error in MYSQL or MYSQL_STMT
      sql-common/client.c:
        Use helper functions to set an error in MYSQL or MYSQL_STMT
      70987ab9
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · 44068505
      unknown authored
      into  station.:/mnt/raid/alik/MySQL/devel/5.1-rt-bug31649
      
      
      44068505
    • unknown's avatar
      Merge adventure.(none):/home/thek/Development/cpp/bug31347/my51-bug31347 · ce55bb75
      unknown authored
      into  adventure.(none):/home/thek/Development/cpp/mysql-5.1-runtime
      
      
      sql/sql_acl.cc:
        Auto merged
      ce55bb75
    • unknown's avatar
      Merge adventure.(none):/home/thek/Development/cpp/bug31347/my50-bug31347 · 61c6024c
      unknown authored
      into  adventure.(none):/home/thek/Development/cpp/bug31347/my51-bug31347
      
      
      sql/sql_acl.cc:
        Auto merged
      61c6024c
    • unknown's avatar
      Bug#31347 Increase in memory usage after many DROP USER statements · 8d69dd39
      unknown authored
      Dropping users causes huge increase in memory usage because field values were
      allocated on the server memory root for temporary usage but never deallocated.
      
      This patch changes the target memory root to be that of the thread handler
      instead since this root is cleared between each statement.
      
      
      sql/sql_acl.cc:
        Changed memory root from server life time memory to thread life time memory.
      8d69dd39
    • unknown's avatar
      Fix for a BUG#31649: events.test fails: NULL "state" field of · 47d17e5d
      unknown authored
      SHOW PROCESSLIST.
      
      The problem was a race condition: if the Event Scheduler was not
      quick enough, the following scenario happens:
        - The Event Scheduler picks up the created event;
        - The event is executed;
        - event_scheduler_thread->proc_info is set to NULL;
        - The client issues SELECT FROM I_S.
      
      The fix is to wait for the Event Scheduler to reach 'Waiting
      for next activation' state. 
      
      
      mysql-test/t/events.test:
        Wait for the Event Scheduler to start waiting for the activation.
      47d17e5d
    • unknown's avatar
      Fix result files after patch for BUG#31035. · 77c8c76f
      unknown authored
      
      mysql-test/r/group_min_max.result:
        Update result file.
      mysql-test/r/index_merge_myisam.result:
        Update result file.
      77c8c76f
    • unknown's avatar
      Merge endora.local:/Users/davi/mysql/bugs/31669-5.1 · be4ea151
      unknown authored
      into  endora.local:/Users/davi/mysql/mysql-5.1-runtime
      
      
      be4ea151
    • unknown's avatar
      Merge endora.local:/Users/davi/mysql/mysql-5.0-runtime · 41974cf1
      unknown authored
      into  endora.local:/Users/davi/mysql/bugs/31669-5.1
      
      
      sql/sql_table.cc:
        Auto merged
      libmysql/libmysql.c:
        Manual merge
      tests/mysql_client_test.c:
        Manual merge
      41974cf1
  2. 30 Oct, 2007 8 commits
    • unknown's avatar
      Merge endora.local:/Users/davi/mysql/bugs/30904-5.1 · d2a1fe14
      unknown authored
      into  endora.local:/Users/davi/mysql/mysql-5.1-runtime
      
      
      d2a1fe14
    • unknown's avatar
      Bug#30904 SET PASSWORD statement is non-transactional · bf18f6d4
      unknown authored
      The SET PASSWORD statement is non-transactional (no explicit transaction
      boundaries) in nature and hence is forbidden inside stored functions and
      triggers, but it weren't being effectively forbidden.
      
      The implemented fix is to issue a implicit commit with every SET PASSWORD
      statement, effectively prohibiting these statements in stored functions
      and triggers. 
      
      
      mysql-test/r/sp-error.result:
        Add test case result for Bug#30904
      mysql-test/t/sp-error.test:
        Add test case for Bug#30904
      sql/sql_lex.h:
        Add variable to set that a statement with SET PASSWORD causes a implicit
        commit.
      sql/sql_parse.cc:
        End active transaction in SET PASSWORD.
      sql/sql_yacc.yy:
        Set the correct flag on SET PASSWORD if inside a SP, thus effectively
        prohibiting SET PASSWORD statements in stored functions and triggers.
      bf18f6d4
    • unknown's avatar
      In ha_delete_table, use a standard mechanism to intercept the error message · 8365a74e
      unknown authored
      and convert it to a warning instead of direct manipulation with the
      thread error stack.
      Fix a bug in handler::print_erorr when a garbled message was
      printed for HA_ERR_NO_SUCH_TABLE.
      This is a pre-requisite patch for the fix for Bug#12713 Error in a stored
      function called from a SELECT doesn't cause ROLLBACK of statem
      
      
      sql/handler.cc:
        Use a standard mechanism to intercept the error message, instead
        of direct manipulation with thread error stack. 
        Fix a bug when for HA_ERR_NO_SUCH_TABLE handler::print_error() would
        print a garbled message.
      sql/log.cc:
        Extend internal error handler interface to carry the message text.
      sql/mysqld.cc:
        Extend internal error handler interface to carry the message text.
      sql/sql_base.cc:
        Extend internal error handler interface to carry the message text.
      sql/sql_class.cc:
        Extend internal error handler interface to carry the message text.
      sql/sql_class.h:
        Extend internal error handler interface to carry the message text.
      sql/sql_error.cc:
        Extend internal error handler interface to carry the message text.
      8365a74e
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · 1430f4de
      unknown authored
      into  bodhi.(none):/opt/local/work/mysql-5.1-runtime-inc-2
      
      
      sql/sql_connect.cc:
        Manual merge.
      1430f4de
    • unknown's avatar
      Use an inline getter method (thd->is_error()) to query if there is an error · 24370012
      unknown authored
      in THD.
      In future the error may be stored elsewhere (not in net.report_error) and 
      it's important to start using an opaque getter to simplify merges.
      
      
      sql/filesort.cc:
        net.report_error -> is_error()
      sql/ha_ndbcluster_binlog.cc:
        net.report_error -> is_error()
      sql/item_func.cc:
        net.report_error -> is_error()
      sql/item_subselect.cc:
        net.report_error -> is_error()
      sql/set_var.cc:
        net.report_error -> is_error()
      sql/sp.cc:
        net.report_error -> is_error()
      sql/sp_head.cc:
        net.report_error -> is_error()
      sql/sql_base.cc:
        net.report_error -> is_error()
      sql/sql_class.cc:
        net.report_error -> is_error()
      sql/sql_class.h:
        net.report_error -> is_error()
      sql/sql_connect.cc:
        net.report_error -> is_error()
      sql/sql_delete.cc:
        net.report_error -> is_error()
      sql/sql_insert.cc:
        net.report_error -> is_error()
      sql/sql_parse.cc:
        net.report_error -> is_error()
      sql/sql_prepare.cc:
        net.report_error -> is_error()
      sql/sql_select.cc:
        net.report_error -> is_error()
      sql/sql_union.cc:
        net.report_error -> is_error()
      sql/sql_update.cc:
        net.report_error -> is_error()
      sql/sql_view.cc:
        net.report_error -> is_error()
      sql/sql_yacc.yy:
        net.report_error -> is_error()
      24370012
    • unknown's avatar
      Merge moksha.local:/Users/davi/mysql/bugs/31669-5.0 · 157645f4
      unknown authored
      into  moksha.local:/Users/davi/mysql/mysql-5.0-runtime
      
      
      libmysql/libmysql.c:
        Auto merged
      tests/mysql_client_test.c:
        Auto merged
      157645f4
    • unknown's avatar
      Fix failing init_connect.test (5.1-runtime). · d4d4ba9a
      unknown authored
      
      sql/sql_connect.cc:
        Fix failing init_connect.test (5.1-runtime). Add comments for the unjustified use
        of thd->is_slave_error.
      d4d4ba9a
    • unknown's avatar
      Make sure rpl.rpl_innodb_mixed_dml passes even if rpl_mixed.dat is read-only. · 5f4783cf
      unknown authored
      This is important for a development environment where not all source files
      are checked out.
      
      
      5f4783cf
  3. 29 Oct, 2007 5 commits
    • unknown's avatar
      Merge lambda.weblab:/home/malff/TREE/mysql-5.1-base · f1390330
      unknown authored
      into  lambda.weblab:/home/malff/TREE/mysql-5.1-rt-merge
      
      
      mysql-test/include/mix1.inc:
        Auto merged
      mysql-test/r/innodb_mysql.result:
        Auto merged
      mysql-test/r/select.result:
        Auto merged
      sql/handler.cc:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/protocol.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      f1390330
    • unknown's avatar
      Merge malff@bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · 08edbe4e
      unknown authored
      into  lambda.weblab:/home/malff/TREE/mysql-5.1-rt-merge
      
      
      mysql-test/r/udf.result:
        Auto merged
      mysql-test/t/udf.test:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/udf_example.c:
        Auto merged
      sql/udf_example.def:
        Auto merged
      08edbe4e
    • unknown's avatar
      Merge lambda.weblab:/home/malff/TREE/mysql-5.0-base · 24ede323
      unknown authored
      into  lambda.weblab:/home/malff/TREE/mysql-5.0-rt-merge
      
      
      sql/sql_table.cc:
        Auto merged
      24ede323
    • unknown's avatar
      Fix for BUG#27610: ALTER TABLE ROW_FORMAT=... does not · 7c92f118
      unknown authored
      rebuild the table.
      
      The problem was that ROW_FORMAT clause in ALTER TABLE did not trigger
      table reconstruction.
      
      The fix is to rebuild a table if ROW_FORMAT is specified.
      
      
      mysql-test/include/mix1.inc:
        Add a test case for BUG#27610: ALTER TABLE ROW_FORMAT=... does not
        rebuild the table.
      mysql-test/r/innodb_mysql.result:
        Update result file.
      sql/sql_table.cc:
        Rebuild a table if ROW_FORMAT was specified in ALTER TABLE.
      7c92f118
    • unknown's avatar
      Merge sgluhov@bk-internal.mysql.com:/home/bk/mysql-5.1 · 7d9c59b7
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.1-opt
      
      
      7d9c59b7
  4. 25 Oct, 2007 2 commits
    • unknown's avatar
      Mimic a rename which Daniel already did in 6.0, · a71a829a
      unknown authored
      to get rid of a name clash among *deleted* files on case-insignificant file systems.
      
      
      BitKeeper/deleted/.del-changelog-bleh:
        Rename: BitKeeper/deleted/.del-changelog -> BitKeeper/deleted/.del-changelog-bleh
      a71a829a
    • unknown's avatar
      Bug#30854 (Tables name show as binary in slave err msg on vm-win2003-64-b) · 35ca78a0
      unknown authored
      The root cause of this defect is that a call to my_error() is using a
      'LEX_STRING' parameter instead of a 'char*'
      
      This patch fixes the failing calls to my_error(), as well as similar calls
      found during investigation.
      
      This is a compiling bug (see the instrumentation in the bug report), no test cases provided.
      
      
      sql/sql_base.cc:
        Fix broken calls to "..." (va_args) functions.
      sql/sql_table.cc:
        Fix broken calls to "..." (va_args) functions.
      35ca78a0
  5. 24 Oct, 2007 2 commits
  6. 23 Oct, 2007 10 commits
    • unknown's avatar
      result fix · b987945d
      unknown authored
      b987945d
    • unknown's avatar
      Merge mysql.com:/home/gluh/MySQL/Merge/5.0-opt · e085211d
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.1-opt
      
      
      client/mysqldump.c:
        Auto merged
      include/config-win.h:
        Auto merged
      libmysql/libmysql.c:
        Auto merged
      mysql-test/r/func_sapdb.result:
        Auto merged
      mysql-test/r/type_decimal.result:
        Auto merged
      mysql-test/r/variables.result:
        Auto merged
      mysql-test/t/type_datetime.test:
        Auto merged
      mysql-test/t/type_decimal.test:
        Auto merged
      mysql-test/t/variables.test:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      sql/item_timefunc.h:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      storage/innobase/handler/ha_innodb.cc:
        Auto merged
      storage/myisam/sort.c:
        Auto merged
      tests/mysql_client_test.c:
        Auto merged
      mysql-test/r/type_datetime.result:
        after merge fix
      e085211d
    • unknown's avatar
      Merge mysql.com:/home/gluh/MySQL/Merge/4.1-opt · fa0e1d6b
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.0-opt
      
      
      fa0e1d6b
    • unknown's avatar
      after merge fix · 985e4a64
      unknown authored
      985e4a64
    • unknown's avatar
      Merge mysql.com:/home/gluh/MySQL/Merge/5.1 · 95a8bb20
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.1-opt
      
      
      client/client_priv.h:
        Auto merged
      client/mysqldump.c:
        Auto merged
      include/config-win.h:
        Auto merged
      libmysql/libmysql.c:
        Auto merged
      mysql-test/mysql-test-run.pl:
        Auto merged
      mysql-test/r/create.result:
        Auto merged
      mysql-test/r/func_sapdb.result:
        Auto merged
      mysql-test/r/information_schema.result:
        Auto merged
      mysql-test/r/variables.result:
        Auto merged
      mysql-test/t/information_schema.test:
        Auto merged
      mysql-test/t/variables.test:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/ha_partition.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/item_func.h:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      sql/item_timefunc.h:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/protocol.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      sql/table.cc:
        Auto merged
      storage/innobase/handler/ha_innodb.cc:
        Auto merged
      storage/myisam/sort.c:
        Auto merged
      tests/mysql_client_test.c:
        Auto merged
      mysql-test/r/query_cache.result:
        manual merge
      mysql-test/include/mix1.inc:
        manual merge
      mysql-test/r/innodb_mysql.result:
        manual merge
      mysql-test/r/type_datetime.result:
        manual merge
      mysql-test/r/type_decimal.result:
        manual merge
      mysql-test/t/query_cache.test:
        manual merge
      mysql-test/t/type_datetime.test:
        manual merge
      mysql-test/t/type_decimal.test:
        manual merge
      sql/item.cc:
        manual merge
      95a8bb20
    • unknown's avatar
      Patch for BUG#30736: Row Size Too Large Error Creating a Table and · 6044965c
      unknown authored
      Inserting Data.
      
      The problem was that under some circumstances Field class was not
      properly initialized before calling create_length_to_internal_length()
      function, which led to assert failure.
      
      The fix is to do the proper initialization.
      
      The user-visible problem was that under some circumstances
      CREATE TABLE ... SELECT statement crashed the server or led
      to wrong error message (wrong results).
      
      
      mysql-test/r/select.result:
        Update result file.
      mysql-test/t/select.test:
        Add a test case for BUG#30736: Row Size Too Large Error
        Creating a Table and Inserting Data.
      sql/sql_table.cc:
        Move sql_field->decimals initialization before
        sql_field->create_length_to_internal_length() call.
      6044965c
    • unknown's avatar
      Merge mysql.com:/home/gluh/MySQL/Merge/5.0 · 8479eb1d
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.0-opt
      
      
      client/mysqldump.c:
        Auto merged
      include/config-win.h:
        Auto merged
      libmysql/libmysql.c:
        Auto merged
      myisam/sort.c:
        Auto merged
      mysql-test/r/func_sapdb.result:
        Auto merged
      mysql-test/r/variables.result:
        Auto merged
      mysql-test/t/variables.test:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/ha_innodb.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      sql/item_timefunc.h:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      tests/mysql_client_test.c:
        Auto merged
      mysql-test/r/type_datetime.result:
        manual merge
      mysql-test/r/type_decimal.result:
        manual merge
      mysql-test/t/type_datetime.test:
        manual merge
      mysql-test/t/type_decimal.test:
        manual merge
      sql/item.cc:
        manual merge
      8479eb1d
    • unknown's avatar
      Merge mysql.com:/home/gluh/MySQL/Merge/5.0-opt · 6e8919b0
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.1-opt
      
      
      6e8919b0
    • unknown's avatar
      Merge abotchkov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · c448d2ed
      unknown authored
      into  mysql.com:/home/hf/work/30638/my50-30638
      
      
      c448d2ed
    • unknown's avatar
      Merge ssh://bk-internal.mysql.com//home/bk/mysql-5.0-opt · 72bd96ae
      unknown authored
      into  polly.(none):/home/kaa/src/opt/mysql-5.0-opt
      
      
      72bd96ae