1. 24 Oct, 2007 1 commit
    • unknown's avatar
      Fix for bug #31566: my_write(fd, 0x0, 0, flags) fails with EFAULT on · 1c862d0c
      unknown authored
      some platforms
      
      Since the behavior of write(fd, buf, 0) is undefined, it may fail with
      EFAULT on some architectures when buf == NULL. The error was propagated
      up to a caller, since my_write() code did not handle it properly.
      
      Fixed by checking the 'number of bytes' argument in my_write() and
      returning before calling the write() system call when there is nothing
      to write.
      
      
      mysys/my_write.c:
        Return from my_write() before calling the write() system call when the
        number of bytes to be written is 0, since the behavior of write() in
        this case is not portable.
      1c862d0c
  2. 12 Oct, 2007 4 commits
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/maint/bug31254/my50-bug31254 · ebe9a0be
      unknown authored
      into  polly.(none):/home/kaa/src/maint/mysql-5.0-maint
      
      ebe9a0be
    • unknown's avatar
      Fix for bug #31254: "Max_data_length" truncated / reported wrong · c414c0bf
      unknown authored
      (compiler issue ?)
      
      Problem:
      
      Improper compile-time flags on AIX prevented use of files > 2 GB. This
      resulted in Max_data_length being truncated to 2 GB by MyISAM code.
      
      Solution:
      
      Reverted large-file changes from the fix for bug10776. We need to define
      _LARGE_FILES on AIX to have support for files > 2 GB.
      
       Since _LARGE_FILE_API is incompatible with _LARGE_FILES and may be
      automatically defined by including standards.h, we also need a
      workaround to avoid this conflict.
      
      
      config/ac-macros/large_file.m4:
        Reverted large-file changes from the fix for bug10776. We need to define
        _LARGE_FILES on AIX to have support for files > 2 GB.
      include/my_global.h:
        _LARGE_FILE_API is defined in standards.h that is automatically included
        by at least some C++ compilers on AIX. Since it is also incompatible
        with _LARGE_FILES which is required for POSIX IO calls to be
        largefile-safe, the only workaround is to explicitely #undef
        _LARGE_FILE_API.
      c414c0bf
    • unknown's avatar
      Merge tnurnberg@bk-internal.mysql.com:/home/bk/mysql-5.0-maint · fcfe0aa0
      unknown authored
      into  sin.intern.azundris.com:/home/tnurnberg/30821/50-30821
      
      
      sql/mysqld.cc:
        Auto merged
      fcfe0aa0
    • unknown's avatar
      Bug#30821: setting --tc_heuristic_recover tries to set myisam_stats_method · eba2ae13
      unknown authored
      Options to mysqld were not processed correctly because switch statement
      was missing some "break"s. CS adds them.
      
      No test case; would require .opt file and server restart. Manually tested.
      
      
      sql/mysqld.cc:
        Add missing "break"s to switch() in mysqld to fix option processing.
      eba2ae13
  3. 11 Oct, 2007 1 commit
  4. 10 Oct, 2007 6 commits
  5. 09 Oct, 2007 8 commits
    • unknown's avatar
      Merge ramayana.hindu.god:/home/tsmith/m/bk/maint/41 · 03ae735a
      unknown authored
      into  ramayana.hindu.god:/home/tsmith/m/bk/maint/50
      
      03ae735a
    • unknown's avatar
      Merge tsmith@bk-internal.mysql.com:/home/bk/mysql-5.0-maint · 13cf2d99
      unknown authored
      into  ramayana.hindu.god:/home/tsmith/m/bk/maint/50
      
      
      sql/mysqld.cc:
        Auto merged
      13cf2d99
    • unknown's avatar
      metadata test of bug # 31249: problem with convert(..., datetime) removed · 461e4668
      unknown authored
      as PS protocol gives slightly different metadata.
      
      461e4668
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0-maint · 0d6a6566
      unknown authored
      into  zippy.cornsilk.net:/home/cmiller/work/mysql/mysql-5.0-maint
      
      0d6a6566
    • unknown's avatar
      Merge rkalimullin@bk-internal.mysql.com:/home/bk/mysql-5.0-maint · a4ed5f59
      unknown authored
      into  mysql.com:/home/ram/work/b31249/b31249.5.0
      
      
      mysql-test/r/type_datetime.result:
        manual merge
      mysql-test/t/type_datetime.test:
        manual merge
      a4ed5f59
    • unknown's avatar
      Fix for bug #31249: Assertion `!table || (!table->write_set || · 0602a4fe
      unknown authored
      bitmap_is_set(table->write_set, fiel
      
      Problem: creating a temporary table we allocate the group buffer if needed
      followed by table bitmaps (see create_tmp_table()). Reserving less memory for 
      the group buffer than actually needed (used) for values retrieval may lead 
      to overlapping with followed bitmaps in the memory pool that in turn leads 
      to unpredictable consequences.
      
      As we use Item->max_length sometimes to calculate group buffer size,
      it must be set to proper value. In this particular case 
      Item_datetime_typecast::max_length is too small.
      
      Another problem is that we use max_length to calculate the group buffer
      key length for items represented as DATE/TIME fields which is superfluous.
      
      Fix: set Item_datetime_typecast::max_length properly,
      accurately calculate the group buffer key length for items 
      represented as DATE/TIME fields in the buffer.
      
      
      mysql-test/r/type_datetime.result:
        Fix for bug #31249: Assertion `!table || (!table->write_set || 
        bitmap_is_set(table->write_set, fiel
          - test result.
      mysql-test/t/type_datetime.test:
        Fix for bug #31249: Assertion `!table || (!table->write_set || 
        bitmap_is_set(table->write_set, fiel
          - test case.
      sql/item_timefunc.h:
        Fix for bug #31249: Assertion `!table || (!table->write_set || 
        bitmap_is_set(table->write_set, fiel
          - set Item_datetime_typecast::max_length properly.
      sql/sql_select.cc:
        Fix for bug #31249: Assertion `!table || (!table->write_set || 
        bitmap_is_set(table->write_set, fiel
          - the group buffer key length for items represented as 
        DATE/TIME fields in the buffer should be calculated using
        the maximum pack length of such fields (== 8), using 
        max_length here is redundant.
      0602a4fe
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0-maint · edc809c5
      unknown authored
      into  alf.(none):/src/bug28774/my50-bug28774
      
      edc809c5
    • unknown's avatar
      Bug#28774 mysql_upgrade creates tempfiles in root-dir (C:\) and · 36773be2
      unknown authored
      doesn't clean them up
      - Make sure to cleanup temporary files after use.
      
      
      client/mysql_upgrade.c:
        Bug#28774 mysql_upgrade creates tempfiles in root-dir (C:\) and 
        doesn't clean them up
        - Close file handle and delete temporary file when write fails.
      36773be2
  6. 06 Oct, 2007 1 commit
  7. 05 Oct, 2007 13 commits
    • unknown's avatar
      Merge tnurnberg@bk-internal.mysql.com:/home/bk/mysql-5.0-maint · 2eedfee7
      unknown authored
      into  sin.intern.azundris.com:/home/tnurnberg/19828/50-19828
      
      
      mysql-test/r/grant.result:
        Auto merged
      2eedfee7
    • unknown's avatar
      Merge pilot.mysql.com:/data/msvensson/mysql/bug27789/my50-bug27789 · 782812b3
      unknown authored
      into  pilot.mysql.com:/data/msvensson/mysql/mysql-5.0-maint
      
      782812b3
    • unknown's avatar
      Fixed Bug #27789 "Wrong permissions of sql/share/language directories" · 2ae04125
      unknown authored
      
      extra/comp_err.c:
        Override my_mkdir() umask setting. The default is 0700 which perfectly 
        makes sense for the server but leads to Bug #27789 when applied to comp_err
        generated directories in the souce tree. Generated directories and the
        files within won't be accessible to other users, sometimes including root 
        if on a non-local filesystem, making "sudo make install" fail.
      2ae04125
    • unknown's avatar
      Merge msvensson2.mysql.internal:mysql/mysql-5.0-maint · 2f05d99e
      unknown authored
      into  pilot.mysql.com:/data/msvensson/mysql/mysql-5.0-maint
      
      2f05d99e
    • unknown's avatar
    • unknown's avatar
      Bug#27753 enable mysql-test-run.pl to ignore tests based on wildcard · 1ad11ec5
      unknown authored
      
      mysql-test/lib/mtr_cases.pl:
        Allow --skip-test and --do-test to take a perl regex
      mysql-test/mysql-test-run.pl:
        Update usage for --skip-test and --do-test
      1ad11ec5
    • unknown's avatar
      Change URLs. · 4c43b78b
      unknown authored
      Our web server has been restructured several times, and references
      to it in our source code has stayed the same.  This patch from Paul
      DuBois updates all URLs to modern semantics.
      
      
      debian/po/ca.po:
        Change URLs.
      debian/po/cs.po:
        Change URLs.
      debian/po/da.po:
        Change URLs.
      debian/po/gl.po:
        Change URLs.
      debian/po/ja.po:
        Change URLs.
      debian/po/pt_BR.po:
        Change URLs.
      debian/po/sv.po:
        Change URLs.
      debian/po/tr.po:
        Change URLs.
      mysql-test/lib/mtr_report.pl:
        Change URLs.
      mysql-test/mysql-test-run-shell.sh:
        Change URLs.
      ndb/include/ndbapi/Ndb.hpp:
        Change URLs.
      netware/mysql_test_run.c:
        Change URLs.
      scripts/mysqld_safe.sh:
        Change URLs.
      sql/mysqld.cc:
        Change URLs.
      4c43b78b
    • unknown's avatar
      Bug#30560 Valgrind option to mysql-test-run with spaces in cause strange error · cd8f7b19
      unknown authored
      
      mysql-test/mysql-test-run.pl:
        Just pass the $opt_valgrind_options to mtr_add_arg - it does a
        "push(@$args, sprintf($format, @fargs));" behind the scenes
      cd8f7b19
    • unknown's avatar
      Bug#31398 problems with mysql-test-run, part2 · e3f9d538
      unknown authored
      Write .reject file to r/ if it's writable else use opt_logdir 
      
      
      client/mysqltest.c:
        Write .reject file to r/ if it's writable else use opt_logdir
      e3f9d538
    • unknown's avatar
      Bug#31398 problems with mysql-test-run · d3f052ec
      unknown authored
       - "mysqld --verbose --help" need to be started in a writable directory 
      
      
      mysql-test/mysql-test-run.pl:
        Create a tmpdir where mysqld can peform it's lowercase or uppercase test
      d3f052ec
    • unknown's avatar
      Bug #31253: crash comparing datetime to double · ea3a3aa8
      unknown authored
      convert(<invalid time>, datetime) in WHERE caused crash as function
      returned (void*)NULL, but did not flag SQL NULL. It does now.
      
      
      mysql-test/r/type_datetime.result:
        show that convert() to datetime in a WHERE-clause will no longer crash
        the server on invalid input.
      mysql-test/t/type_datetime.test:
        show that convert() to datetime in a WHERE-clause will no longer crash
        the server on invalid input.
      sql/item.cc:
        When failing to process time values, do not just return (void*)NULL,
        but flag SQL NULL as well so no caller will try to process the 0x0L.
        This makes behaviour for Item::Item::val_decimal_from_date() and
        Item::Item::val_decimal_from_time() identical.
      ea3a3aa8
    • unknown's avatar
      Merge tnurnberg@bk-internal.mysql.com:/home/bk/mysql-5.0-maint · 66b6c5d7
      unknown authored
      into  sin.intern.azundris.com:/home/tnurnberg/31227/50-31227
      
      66b6c5d7
    • unknown's avatar
      Bug#31227: memory overrun with decimal (6,6) and zerofill and group_concat · 08149199
      unknown authored
      Reserve the space for the leading 0 (before the decimal point) in DECIMAL(a,a) ZEROFILL.
      
      
      mysql-test/r/type_decimal.result:
        show that we allocate a large enough buffer for output of DECIMAL(a,a) [ZEROFILL].
      mysql-test/t/type_decimal.test:
        show that we allocate a large enough buffer for output of DECIMAL(a,a) [ZEROFILL].
        without patch for bug#31227, valgrind will complain here; so will a
        debug build.
      sql/my_decimal.cc:
        Reserve the space for the leading 0 (before the decimal point) in DECIMAL(a,a) ZEROFILL.
        Doxygenise preamble of my_decimal2string().
      08149199
  8. 04 Oct, 2007 6 commits