1. 08 Jan, 2018 3 commits
    • Marko Mäkelä's avatar
      Merge 10.0 into 10.1 · 29b6e809
      Marko Mäkelä authored
      29b6e809
    • Marko Mäkelä's avatar
      MDEV-13205 InnoDB: Failing assertion: !dict_index_is_online_ddl(index) upon ALTER TABLE · c903ba2f
      Marko Mäkelä authored
      dict_foreign_find_index(): Ignore incompletely created indexes.
      After a failed ADD UNIQUE INDEX, an incompletely created index
      could be left behind until the next ALTER TABLE statement.
      c903ba2f
    • Marko Mäkelä's avatar
      MDEV-14874 innodb_encrypt_log corrupts the log when the LSN crosses 32-bit boundary · 16d308e2
      Marko Mäkelä authored
      This bug affects both writing and reading encrypted redo log in
      MariaDB 10.1, starting from version 10.1.3 which added support for
      innodb_encrypt_log. That is, InnoDB crash recovery and Mariabackup
      will sometimes fail when innodb_encrypt_log is used.
      
      MariaDB 10.2 or Mariabackup 10.2 or later versions are not affected.
      
      log_block_get_start_lsn(): Remove. This function would cause trouble if
      a log segment that is being read is crossing a 32-bit boundary of the LSN,
      because this function does not allow the most significant 32 bits of the
      LSN to change.
      
      log_blocks_crypt(), log_encrypt_before_write(), log_decrypt_after_read():
      Add the parameter "lsn" for the start LSN of the block.
      
      log_blocks_encrypt(): Remove (unused function).
      16d308e2
  2. 05 Jan, 2018 2 commits
    • Vladislav Vaintroub's avatar
      Fix conf_to_src build. · 3a22d6c1
      Vladislav Vaintroub authored
      2cd31691 broke conf_to_src,
      because strings library is now dependend on mysys (my_alloc etc are used
      now directly in string lib)
      
      Fix by adding appropriate dependency.
      
      Also exclude conf_to_src from VS IDE builds. EXCLUDE_FROM_ALL
      is not enough for that.
      3a22d6c1
    • Aleksey Midenkov's avatar
      Tests: detect table count for some encryption tests · d9e0c06b
      Aleksey Midenkov authored
      debug_key_management
      encrypt_and_grep
      innodb_encryption
      
      If real table count is different from what is expected by the test, it
      just hangs on waiting to fulfill hardcoded number. And then exits with
      **failed** after 10 minutes of wait: quite unfriendly and hard to
      figure out what's going on.
      d9e0c06b
  3. 04 Jan, 2018 2 commits
  4. 03 Jan, 2018 3 commits
  5. 02 Jan, 2018 4 commits
  6. 28 Dec, 2017 2 commits
  7. 27 Dec, 2017 3 commits
  8. 25 Dec, 2017 4 commits
    • Sergei Golubchik's avatar
      MDEV-14026 ALTER TABLE ... DELAY_KEY_WRITE=1 creates table copy for... · 5377242f
      Sergei Golubchik authored
      MDEV-14026 ALTER TABLE ... DELAY_KEY_WRITE=1 creates table copy for partitioned MyISAM table with DATA DIRECTORY/INDEX DIRECTORY options
      
      set data_file_name and index_file_name in HA_CREATE_INFO
      before calling check_if_incompatible_data()
      5377242f
    • Sergei Golubchik's avatar
      6d8b1bd6
    • Sergei Golubchik's avatar
      cleanup: ha_myisam::data_file_name and index_file_name · c881d82c
      Sergei Golubchik authored
      don't allocate them on THD::mem_root on every init(HA_STATUS_CONST) call,
      do it once in open() (because they don't change) on TABLE::mem_root
      (so they stay valid until the table is closed)
      c881d82c
    • Sachin Setiya's avatar
      MDEV-10715 Galera: Replicate MariaDB GTID to other nodes in the cluster · 2fe61861
      Sachin Setiya authored
      Problem:- Gtid are not transferred in Galera Cluster.
      
      Solution:- We need to transfer gtid in the case on either when cluster is
      slave/master in async replication. In normal Gtid replication gtid are generated on
      recieving node itself and it is always on sync with other nodes. Because galera keeps
      node in sync , So all nodes get same no of event groups. So the issue arises when
      say galera is slave in async replication.
      A
      |    (Async replication)
      D <-> E <-> F  {Galera replication}
      So what should happen is that all node should apply the master gtid but this does
      node happen, becuase node E, F does not recieve gtid from D in write set , So what E(or F)
      does is that it applies wsrep_gtid_domain_id, D server-id , E gtid next seq no. This
      generated gtid does not always work when say A has different domain id.
      
      So In this commit, on galera node when we see that this event is recieved from master
      we simply write Gtid_Log_Event in write_set and send it to other nodes.
      2fe61861
  9. 22 Dec, 2017 2 commits
  10. 21 Dec, 2017 6 commits
    • Vicențiu Ciorbaru's avatar
      Follow up to MDEV-12366: FLUSH privileges can break hierarchy of roles · 24efee91
      Vicențiu Ciorbaru authored
      A suggestion to make role propagation simpler from serg@mariadb.org.
      
      Instead of gathering the leaf roles in an array, which for very wide
      graphs could potentially mean a big part of the whole roles schema, keep
      the previous logic. When finally merging a role, set its counter
      to something positive.
      
      This will effectively mean that a role has been merged, thus a random pass
      through roles hash that touches a previously merged role won't cause the problem
      described in MDEV-12366 any more, as propagate_role_grants_action will stop
      attempting to merge from that role.
      24efee91
    • Marko Mäkelä's avatar
      Make a test more robust · 461cf3e5
      Marko Mäkelä authored
      Sometimes, the test would fail with a result difference for
      the READ UNCOMMITTED read, because the incremental backup
      would finish before redo log was written for all the rows
      that were inserted in the second batch.
      
      To fix that, cause a redo log write by creating another
      transaction. The transaction rollback (which internally does commit)
      will be flushed to the redo log, and before that, all the preceding
      changes will be flushed to the redo log as well.
      461cf3e5
    • Marko Mäkelä's avatar
      Merge 10.0 into 10.1 · 9d7c0882
      Marko Mäkelä authored
      9d7c0882
    • Marko Mäkelä's avatar
      MDEV-12827 Assertion failure when reporting duplicate key error in online table rebuild · 0202e472
      Marko Mäkelä authored
      row_log_table_apply_insert_low(), row_log_table_apply_update():
      When reporting the error_key_num, only count the clustered index
      if it corresponds to a key in the SQL layer.
      
      The assertion failure was probably introduced by the (incomplete)
      MySQL 5.6.28 bug fix
      Bug #21364096 THE BOGUS DUPLICATE KEY ERROR IN ONLINE DDL
      WITH INCORRECT KEY NAME
      which we are improving.
      
      Side note: the fix was incorrectly merged to MySQL 5.7.10;
      incorrect key names will continue to be reported in MySQL 5.7.
      0202e472
    • Marko Mäkelä's avatar
      MDEV-6247 post-fix: Re-enable some debug assertions · 1cf28964
      Marko Mäkelä authored
      These assertions were disabled in MariaDB 10.1.1 in
      commit df4dd593
      with a bogus comment referring to the function wsrep_fake_trx_id()
      that was introduced in the very same commit.
      1cf28964
    • Elena Stepanova's avatar
      5f896b36
  11. 20 Dec, 2017 9 commits