1. 20 Nov, 2011 1 commit
    • Alexey Botchkov's avatar
      Fix for bug #809849 spatial operations must be KILL-able. · 3daafb82
      Alexey Botchkov authored
        Checks for thd->killed state added to the long loops in geometry calculations.
      
      per-file comments:
        sql/gcalc_slicescan.cc
      Fix for bug #809849 spatial operations must be KILL-able.
              checks for TERMINATED_STATE added.
        sql/gcalc_slicescan.h
      Fix for bug #809849 spatial operations must be KILL-able.
              defines added to include checks for termination in the
              library.
        sql/gcalc_tools.cc
      Fix for bug #809849 spatial operations must be KILL-able.
              checks for TERMINATED_STATE added.
        sql/gcalc_tools.h
      Fix for bug #809849 spatial operations must be KILL-able.
              TERMINATED_STATE pointers added.
        sql/item_geofunc.cc
      Fix for bug #809849 spatial operations must be KILL-able.
        sql/item_geofunc.h
      Fix for bug #809849 spatial operations must be KILL-able.
      3daafb82
  2. 18 Nov, 2011 5 commits
    • Igor Babaev's avatar
      Fixed LP bug #891995. · 35d51210
      Igor Babaev authored
      This bug in the function setup_semijoin_dups_elimination() could 
      lead to invalid choice of the sequence of tables for which semi-join
      duplicate elimination was applied.
      35d51210
    • Igor Babaev's avatar
      Fixed LP bug #891953. · d4fc2b17
      Igor Babaev authored
      Due to this bug the function SEL_IMERGE::or_sel_tree_with_checks()
      could build an inconsistent merge tree if one of the SEL_TREEs in the
      resulting index merge happened to contain a full key range.
      This could trigger an assertion failure.
      
      
      d4fc2b17
    • Alexey Botchkov's avatar
      unused variable removed. · 08df7b68
      Alexey Botchkov authored
      08df7b68
    • Alexey Botchkov's avatar
      GCALC_CHECK_WITH_FLOAT disabled. · 199a0202
      Alexey Botchkov authored
      That's not a good option for an onrdinary user.
      199a0202
    • Igor Babaev's avatar
      Fixed LP bug #800184. · ce02ad78
      Igor Babaev authored
      The function key_and() erroneously called SEL_ARG::increment_use_count()
      when SEL_ARG::incr_refs() should had been called. This could lead to
      wrong values of use_count for some SEL_ARG trees.
      ce02ad78
  3. 17 Nov, 2011 6 commits
  4. 16 Nov, 2011 2 commits
    • unknown's avatar
      Fix bug lp:869036 · f33f9848
      unknown authored
      Apart from the fix, the patch also adds few more unrelated test
      cases for partial matching, and fixes few typos.
      
      Analysis:
      This bug uncovered that partial matching via rowid intersection
      didn't handle the case when:
      - the left IN argument has some NULLs,
      - there are no non-null value matches, and there is no non-null
        column,
      - the subquery columns that are not covered with the NULLs in
        the left IN argument contain at least one row, such that it
        has NULL values in all columns where the left IN operand has
        no NULLs.
      In this case there is a partial match.
      
      In addition the analysis of the related code uncovered incorrect
      handling of few other related cases.
      
      Solution:
      The solution for the bug is to check if there exists a row with
      NULLs in all columns other than the ones having NULL in the
      let IN operand.
      
      The check is implemented via checking whether the bitmaps that
      store NULL information in class Ordered_key have a non-empty
      intersection for the relevant columns.
      
      The intersection itself is implemented via the function
      bitmap_exists_intersection() in my_bitmap.c.
      f33f9848
    • Igor Babaev's avatar
      Fixed LP bug #887479. · 57eb3928
      Igor Babaev authored
      The function setup_semijoin_dups_elimination erroneously assumed
      that if join_cache_level is set to 3 or 4 then the type of the
      access to a table cannot be JT_REF or JT_EQ_REF. This could lead
      to wrong query result sets.
      57eb3928
  5. 15 Nov, 2011 2 commits
    • Igor Babaev's avatar
      Merge. · 36a39780
      Igor Babaev authored
      36a39780
    • Igor Babaev's avatar
      Fixed LP bug #889750. · 315b13a6
      Igor Babaev authored
      If the optimizer switch 'semijoin_with_cache' is set to 'off' then 
      join cache cannot be used to join inner tables of a semijoin.
      
      Also fixed a bug in the function check_join_cache_usage() that led
      to wrong output of the EXPLAIN commands for some test cases.
      315b13a6
  6. 14 Nov, 2011 1 commit
    • unknown's avatar
      Fix bug lp:889744 · 2f2cbbb9
      unknown authored
      MariaDB 5.5 merges changes from MySQL 5.5 where all constant
      expressions are wrapped into an Item_cache. As a result, constant
      single-row subqueries were also wrapped in an Item_cache.
      When analyzing the where clause for constant expressions that
      can be evaluated during optimization, subqueries wrapped into
      an Item_cache did not appear as expensive, and were therefore
      evaluated during optimization. Such evaluation is against the
      current architecture of MariaDB 5.3 where subquries are executed
      during the execute phase.
      
      The patch adds the is_expensive() predicate to Item_cache.
      This makes Item_cache consistent with other wrapping Item
      classes that need to look at the properties of the wrapped
      object.
      2f2cbbb9
  7. 13 Nov, 2011 6 commits
  8. 12 Nov, 2011 9 commits
    • Sergei Golubchik's avatar
      increase feedback plugin version · 717724e0
      Sergei Golubchik authored
      717724e0
    • Sergei Golubchik's avatar
      5.2->5.3 merge · 608c2dac
      Sergei Golubchik authored
      608c2dac
    • Alexey Botchkov's avatar
      merging. · 3e0be3fe
      Alexey Botchkov authored
      3e0be3fe
    • Sergei Golubchik's avatar
      5.1 merge · ab181e4e
      Sergei Golubchik authored
      ab181e4e
    • Sergei Golubchik's avatar
      feedback plugin: · 5ed92036
      Sergei Golubchik authored
        fix for mem_total on windows
        report the time of the data snapshot
      5ed92036
    • Igor Babaev's avatar
      Merge. · c5d20efb
      Igor Babaev authored
      c5d20efb
    • Igor Babaev's avatar
      Fixed LP bug #823301. · 4715a10e
      Igor Babaev authored
      A bug in the code of the function key_or could lead to a situation
      when performing of an OR operation for one index changes the result
      the operation for another index. This bug is fixed with this patch.
      
      Also corrected the specification and the code of the function 
      or_sel_tree_with_checks.
      4715a10e
    • unknown's avatar
      Remove unused variable detected by GCC 4.6.1. · 3a46bdfa
      unknown authored
      3a46bdfa
    • unknown's avatar
      Fix MySQL BUG#12329653 · 1eb2eb4b
      unknown authored
      In MariaDB, when running in ONLY_FULL_GROUP_BY mode,
      the server produced in incorrect error message that there
      is an aggregate function without GROUP BY, for artificially
      created MIN/MAX functions during subquery MIN/MAX optimization.
      
      The fix introduces a way to distinguish between artifially
      created MIN/MAX functions as a result of a rewrite, and normal
      ones present in the query. The test for ONLY_FULL_GROUP_BY violation
      now tests in addition if a MIN/MAX function was part of a MIN/MAX
      subquery rewrite.
      
      In order to be able to distinguish these MIN/MAX functions, the
      patch introduces an additional flag in Item_in_subselect::in_strategy -
      SUBS_STRATEGY_CHOSEN. This flag is set when the optimizer makes its
      final choice of a subuqery strategy. In order to make the choice
      consistent, access to Item_in_subselect::in_strategy is provided
      via new class methods.
      ******
      Fix MySQL BUG#12329653
      
      In MariaDB, when running in ONLY_FULL_GROUP_BY mode,
      the server produced in incorrect error message that there
      is an aggregate function without GROUP BY, for artificially
      created MIN/MAX functions during subquery MIN/MAX optimization.
      
      The fix introduces a way to distinguish between artifially
      created MIN/MAX functions as a result of a rewrite, and normal
      ones present in the query. The test for ONLY_FULL_GROUP_BY violation
      now tests in addition if a MIN/MAX function was part of a MIN/MAX
      subquery rewrite.
      
      In order to be able to distinguish these MIN/MAX functions, the
      patch introduces an additional flag in Item_in_subselect::in_strategy -
      SUBS_STRATEGY_CHOSEN. This flag is set when the optimizer makes its
      final choice of a subuqery strategy. In order to make the choice
      consistent, access to Item_in_subselect::in_strategy is provided
      via new class methods.
      1eb2eb4b
  9. 11 Nov, 2011 1 commit
    • Igor Babaev's avatar
      Fixed LP bug #879871. · d01a7e4f
      Igor Babaev authored
      The function add_ref_to_table_cond missed updating the value of
      join_tab->pre_idx_push_select_cond after having updated the value
      of join_tab->select->pre_idx_push_select_cond.
      d01a7e4f
  10. 10 Nov, 2011 1 commit
  11. 08 Nov, 2011 2 commits
  12. 07 Nov, 2011 2 commits
  13. 06 Nov, 2011 2 commits
    • Igor Babaev's avatar
      Merge. · dad1b651
      Igor Babaev authored
      dad1b651
    • Igor Babaev's avatar
      Fixed LP bug #886145. · 2d9c8c2e
      Igor Babaev authored
      The bug happened because in some cases the function JOIN::exec
      did not save the value of TABLE::pre_idx_push_select_cond in
      TABLE::select->pre_idx_push_select_cond for the sort table.
      
      Noticed and fixed a bug in the function make_cond_remainder
      that builds the remainder condition after extraction of an index
      pushdown condition from the where condition. The code
      erroneously assumed that the function make_cond_for_table left
      the value of ICP_COND_USES_INDEX_ONLY in sub-condition markers.
      Adjusted many result files from the regression test suite
      after this fix .
      2d9c8c2e