1. 07 Oct, 2008 2 commits
    • Mats Kindahl's avatar
      Fixing some missing table drops. · 4f3c4b5d
      Mats Kindahl authored
      mysql-test/suite/rpl/r/rpl_misc_functions.result:
        Using temporary table to avoid leaving a table after test.
      mysql-test/suite/rpl/t/rpl_ps.test:
        Adding drop of table t1.
      4f3c4b5d
    • Mats Kindahl's avatar
      Post-merge fixes. · df346862
      Mats Kindahl authored
      mysql-test/extra/rpl_tests/rpl_log.test:
        Removing extreneous start slave.
        Added missing drop of table t1.
      mysql-test/suite/rpl/t/rpl_binlog_query_filter_rules.test:
        Replaced $MYSQLTEST_VARDIR/log with $MYSQLD_DATADIR
      mysql-test/suite/rpl/t/rpl_misc_functions.test:
        Using temporary table instead to remove need for drop table.
      df346862
  2. 06 Oct, 2008 2 commits
  3. 04 Oct, 2008 1 commit
  4. 29 Sep, 2008 1 commit
  5. 28 Sep, 2008 1 commit
    • He Zhenxing's avatar
      BUG#38734 rpl_server_id2 sync_with_master failed · a4cd8862
      He Zhenxing authored
      Rotate event is automatically generated and written when rotating binary
      log or relay log. Rotate events for relay logs are usually ignored by slave
      SQL thread becuase they have the same server id as that of the slave.
      However, if --replicate-same-server-id is enabled, rotate event
      for relay log would be treated as if it's a rotate event from master, and
      would be executed by slave to update the rli->group_master_log_name and
      rli->group_master_log_pos to a wrong value and cause the MASTER_POS_WAIT
      function to fail and return NULL.
      
      This patch fixed this problem by setting a flag bit (LOG_EVENT_RELAY_LOG_F)
      in the event to tell the SQL thread to ignore these Rotate events generated
      for relay logs.
      
      This patch also added another binlog event flag bit (LOG_EVENT_ARTIFICIAL_F)
      to distinquish faked events, the method used before this was by checking if
      log_pos was zero.
      
      
      sql/log.h:
        Add a member to MYSQL_BIN_LOG to distinguish binary log from relay log.
      sql/log_event.cc:
        Change artificial_event member to LOG_EVENT_ARTIFICIAL_F flag
        
        If LOG_EVENT_RELAY_LOG_F is set in the event flags for a rotate event, ignore it when updating position
        
        Refactored the code in Rotate_log_event::do_update_pos
      sql/log_event.h:
        Add LOG_EVENT_RELAY_LOG_F flag to Log_event flags
        Add RELAY_LOG flag to Rotate_log_event flags
      sql/sql_repl.cc:
        Set LOG_EVENT_ARTIFICIAL_F for fake rotate events
      a4cd8862
  6. 22 Sep, 2008 4 commits
  7. 20 Sep, 2008 4 commits
  8. 15 Sep, 2008 5 commits
  9. 11 Sep, 2008 4 commits
  10. 10 Sep, 2008 6 commits
  11. 09 Sep, 2008 8 commits
    • Ramil Kalimullin's avatar
      Merge · 3363e185
      Ramil Kalimullin authored
      3363e185
    • Ramil Kalimullin's avatar
      Merge · c29da10e
      Ramil Kalimullin authored
      c29da10e
    • Martin Hansson's avatar
      Bug#35600: Auto merged. · da8fecaa
      Martin Hansson authored
      da8fecaa
    • Ramil Kalimullin's avatar
      Fix for bug#37526: asymertic operator <=> in trigger · 835f3528
      Ramil Kalimullin authored
      Problem: <=> operator may return wrong results 
      comparing NULL and a DATE/DATETIME/TIME value.
      
      Fix: properly check NULLs.
      
      
      mysql-test/r/type_datetime.result:
        Fix for bug#37526: asymertic operator <=> in trigger
          - test result.
      mysql-test/t/type_datetime.test:
        Fix for bug#37526: asymertic operator <=> in trigger
          - test case.
      sql/item_cmpfunc.cc:
        Fix for bug#37526: asymertic operator <=> in trigger
          - if is_nulls_eq is TRUE Arg_comparator::compare_datetime() 
        should return 1 only if both arguments are NULL.
      835f3528
    • Mats Kindahl's avatar
      Merging with 5.1-5.1.29-rc · 4fa5cd08
      Mats Kindahl authored
      4fa5cd08
    • Martin Hansson's avatar
      Bug#35600: Security breach via view, I_S table and prepared · 2f9486e4
      Martin Hansson authored
      statement/stored procedure
      
      View privileges are properly checked after the fix for bug no 
      36086, so the method TABLE_LIST::get_db_name() must be used 
      instead of field TABLE_LIST::db, as this only works for tables.
      Bug appears when accessing views in prepared statements.
      
      mysql-test/r/view_grant.result:
        Bug#35600: Extended existing test case.
      mysql-test/t/view_grant.test:
        Bug#35600: Extended existing test result.
      sql/sql_parse.cc:
        Bug#35600: Using method to retrieve database name instead of
        field.
      2f9486e4
    • Mats Kindahl's avatar
      Bug #39106: · 0dcca07f
      Mats Kindahl authored
      SUPER is not required to change binlog format for session
      
      A user without SUPER privileges can change the value of the
      session variable BINLOG_FORMAT, causing problems for a DBA.
      
      This changeset requires a user to have SUPER privileges to
      change the value of the session variable BINLOG_FORMAT, and
      not only the global variable BINLOG_FORMAT.
      
      
      mysql-test/suite/binlog/t/binlog_grant.test:
        Adding test to test grants needed for SQL_LOG_BIN and BINLOG_FORMAT.
      sql/set_var.cc:
        Adding code to check that user has SUPER permission
        needed to change the value of BINLOG_FORMAT.
      sql/set_var.h:
        Adding function sys_var_thd_binlog_format::check()
      0dcca07f
    • Magnus Svensson's avatar
      WL#4350 Add missing 'exit' · a9965cb9
      Magnus Svensson authored
      a9965cb9
  12. 08 Sep, 2008 2 commits