- 29 May, 2006 1 commit
-
-
unknown authored
The order of acquiring LOCK_mysql_create_db and wait_if_global_read_lock() was wrong. It could happen that a thread held LOCK_mysql_create_db while waiting for the global read lock to be released. The thread with the global read lock could try to administrate a database too. It would first try to lock LOCK_mysql_create_db and hang... The check if the current thread has the global read lock is done in wait_if_global_read_lock(), which could not be reached because of the hang in LOCK_mysql_create_db. Now I exchanged the order of acquiring LOCK_mysql_create_db and wait_if_global_read_lock(). This makes wait_if_global_read_lock() fail with an error message for the thread with the global read lock. No deadlock happens. mysql-test/r/lock_multi.result: Bug#19815 - CREATE/RENAME/DROP DATABASE can deadlock on a global read lock The test result mysql-test/t/lock_multi.test: Bug#19815 - CREATE/RENAME/DROP DATABASE can deadlock on a global read lock The test case sql/sql_db.cc: Bug#19815 - CREATE/RENAME/DROP DATABASE can deadlock on a global read lock Exchanged the order of acquiring LOCK_mysql_create_db and wait_if_global_read_lock().
-
- 18 May, 2006 1 commit
-
-
unknown authored
into april.(none):/home/svoj/devel/mysql/BUG18233/mysql-5.0
-
- 10 May, 2006 1 commit
-
-
unknown authored
SELECT WHERE a= AND b= Selecting data from memory table with varchar column and hash index over it returns only first row matched. Problem was that key length calculation for varchar columns didn't include number of bytes to store length. Fixed key length for varchar fields to include number of bytes to store length. heap/hp_create.c: Fixed key length for varchar fields to include number of bytes to store length. mysql-test/r/heap.result: Testcase for BUG#18233. mysql-test/t/heap.test: Testcase for BUG#18233.
-
- 09 May, 2006 8 commits
-
-
unknown authored
into xiphis.org:/home/antony/work2/mysql-5.0-engines-merge
-
unknown authored
into xiphis.org:/home/antony/work2/p1-bug10952.1 sql/handler.h: Auto merged sql/sql_table.cc: Auto merged
-
unknown authored
"alter table from MyISAM to MERGE lost data without errors and warnings" Add new handlerton flag which prevent user from altering table storage engine to storage engines which would lose data. Both 'blackhole' and 'merge' are marked with the new flag. Tests included. mysql-test/r/blackhole.result: test for bug#10952 mysql-test/r/merge.result: test for bug#10952 mysql-test/t/blackhole.test: test for bug#10952 mysql-test/t/merge.test: test for bug#10952 sql/ha_blackhole.cc: Bug#10952 shouldn't be able to alter a table into a blackhole sql/ha_myisammrg.cc: Bug#10952 shouldn't be able to alter a table into a merge sql/handler.h: Bug#10952 new handlerton flag sql/sql_table.cc: Bug#10952 If alter is changing engine, check if new engine allows creating table via ALTER statement.
-
unknown authored
into mysql.com:/home/marty/MySQL/mysql-5.0
-
unknown authored
into mysql.com:/home/marty/MySQL/mysql-5.0 ndb/src/kernel/blocks/dbtc/DbtcInit.cpp: Auto merged
-
unknown authored
-
unknown authored
into neptunus.(none):/home/msvensson/mysql/mysql-5.0 sql/item_func.cc: Auto merged sql/sql_acl.cc: Auto merged
-
unknown authored
into neptunus.(none):/home/msvensson/mysql/mysql-5.0-maint client/mysqltest.c: Auto merged mysql-test/mysql-test-run.pl: Auto merged sql/mysql_priv.h: Auto merged
-
- 08 May, 2006 5 commits
-
-
unknown authored
No commit message
-
unknown authored
into mysql.com:/Users/kent/mysql/bk/mysql-5.0-new configure.in: Auto merged
-
unknown authored
Add function 'vio_end' that will cleanup resources allocated by vio and the components it uses. include/violite.h: Import patch warnings.patch libmysql/libmysql.c: Import patch warnings.patch sql/mysqld.cc: Import patch warnings.patch vio/test-ssl.c: Import patch warnings.patch vio/test-sslclient.c: Import patch warnings.patch vio/test-sslserver.c: Import patch warnings.patch vio/vio.c: Import patch warnings.patch vio/viosslfactories.c: Import patch warnings.patch
-
unknown authored
into neptunus.(none):/home/msvensson/mysql/mysql-5.0-maint
-
unknown authored
into neptunus.(none):/home/msvensson/mysql/mysql-5.0-maint extra/yassl/src/ssl.cpp: Auto merged extra/yassl/taocrypt/src/make.bat: Auto merged extra/yassl/testsuite/test.hpp: Auto merged
-
- 07 May, 2006 10 commits
-
-
unknown authored
into rurik.mysql.com:/home/igor/mysql-5.0 mysql-test/r/rpl_user_variables.result: Auto merged sql/item_func.cc: Auto merged sql/sql_select.cc: Auto merged mysql-test/t/rpl_user_variables.test: Manual merge
-
unknown authored
-
unknown authored
into rurik.mysql.com:/home/igor/dev/mysql-5.0-0 mysql-test/r/having.result: Auto merged mysql-test/t/having.test: Auto merged sql/item_func.cc: Auto merged sql/sql_lex.h: Auto merged mysql-test/r/rpl_user_variables.result: Manual merge mysql-test/t/rpl_user_variables.test: Manual merge sql/sql_lex.cc: Manual merge sql/sql_prepare.cc: Manual merge sql/sql_select.cc: Manual merge
-
unknown authored
into rurik.mysql.com:/home/igor/mysql-4.1
-
unknown authored
into mysql.com:/usr_rh9/home/elkin.rh9/MySQL/Merge/5.0-bug19136 sql/sql_select.cc: Auto merged
-
unknown authored
recalculating results mysql-test/r/rpl_user_variables.result: fixing results
-
unknown authored
-
unknown authored
into mysql.com:/usr_rh9/home/elkin.rh9/MySQL/Merge/5.0-bug19136 sql/item_func.cc: Auto merged sql/sql_select.cc: Auto merged mysql-test/r/rpl_user_variables.result: manual merge use local mysql-test/t/rpl_user_variables.test: manual merge use version 5.0's "show binlog events from 98"
-
unknown authored
into mysql.com:/usr_rh9/home/elkin.rh9/MySQL/FIXES/4.1-bug19136_unass_user_var sql/item_func.cc: Auto merged
-
unknown authored
A query with a group by and having clauses could return a wrong result set if the having condition contained a constant conjunct evaluated to FALSE. It happened because the pushdown condition for table with grouping columns lost its constant conjuncts. Pushdown conditions are always built by the function make_cond_for_table that ignores constant conjuncts. This is apparently not correct when constant false conjuncts are present. mysql-test/r/having.result: Added a test case for bug #14927. mysql-test/t/having.test: Added a test case for bug #14927. sql/sql_lex.cc: Fixed bug #14927. Initialized fields for having conditions in st_select_lex::init_query(). sql/sql_lex.h: Fixed bug #14927. Added a field to restore having condititions for execution in SP and PS. sql/sql_prepare.cc: Fixed bug #14927. Added code to restore havinf conditions for execution in SP and PS. sql/sql_select.cc: Fixed bug #14927. Performed evaluation of constant expressions in having clauses. If the having condition contains a constant conjunct that is always false an empty result set is returned after the optimization phase. In this case the corresponding EXPLAIN command now returns "Impossible HAVING" in the last column.
-
- 06 May, 2006 14 commits
-
-
unknown authored
into mysql.com:/home/psergey/mysql-5.0-bug16798-merge
-
unknown authored
into mysql.com:/home/psergey/mysql-4.1-bug16798
-
unknown authored
into mysql.com:/home/tomash/src/mysql_ab/mysql-5.0-merge mysql-test/r/func_misc.result: Auto merged mysql-test/t/func_misc.test: Auto merged
-
unknown authored
into mysql.com:/home/tomash/src/mysql_ab/mysql-4.1-bug16501
-
unknown authored
into mysql.com:/home/tomash/src/mysql_ab/mysql-4.1-bug16501
-
unknown authored
mysql-test/r/func_misc.result: Update the result.
-
unknown authored
into mysql.com:/home/mydev/mysql-4.1-bug10405
-
unknown authored
into mysql.com:/home/mydev/mysql-5.0-bug10405
-
unknown authored
into mysql.com:/home/psergey/mysql-4.1-bug16798
-
unknown authored
into mysql.com:/home/psergey/mysql-5.0-bug16798-merge sql/sql_select.cc: Auto merged
-
unknown authored
The bug was as follows: When merge_key_fields() encounters "t.key=X OR t.key=Y" it will try to join them into ref_or_null access via "t.key=X OR NULL". In order to make this inference it checks if Y<=>NULL, ignoring the fact that value of Y may be not yet known. The fix is that the check if Y<=>NULL is made only if value of Y is known (i.e. it is a constant). TODO: When merging to 5.0, replace used_tables() with const_item() everywhere in merge_key_fields(). mysql-test/r/innodb_mysql.result: Testcase for BUG16798 mysql-test/t/innodb_mysql.test: Testcase for BUG16798 sql/sql_select.cc: BUG#16798: Inapplicable ref_or_null query plan and bad query result on random occasions In merge_key_fields() don't call val->is_null() if the value of val is not known.
-
unknown authored
after merge. Concurrent read and update of privilege structures (like simultaneous run of SHOW GRANTS and ADD USER) could result in server crash. Ensure that proper locking of ACL structures is done. No test case is provided because this bug can't be reproduced deterministically. sql/sql_acl.cc: Ensure that access to ACL data is protected by acl_cache->lock mutex. Use system_charset_info for host names consistently. Remove check_acl_user(). Use find_acl_user() instead. sql/sql_acl.h: Remove check_acl_user() declaration. sql/sql_parse.cc: Use is_acl_user() instead of check_acl_user().
-
unknown authored
into mysql.com:/home/tomash/src/mysql_ab/mysql-5.0-merge mysql-test/r/func_misc.result: Manual merge of the fix for bug#16501. mysql-test/t/func_misc.test: Manual merge of the fix for bug#16501. sql/item_func.cc: Manual merge of the fix for bug#16501. sql/sql_acl.cc: For the fix of bug#16372, use local version, since the fix for 5.0 is different, and will go in separate ChangeSet.
-
unknown authored
into mysql.com:/home/tomash/src/mysql_ab/mysql-5.0-real
-