1. 06 May, 2004 4 commits
    • unknown's avatar
      Fixed (portability) bug in handler.h, and tried to silence cast warnings on some platforms. · 52656969
      unknown authored
      
      sql/handler.h:
        Fixed (portability) bug. No qualified method names in the class definition.
      sql/item_cmpfunc.h:
        Attempt to silence cast warnings on some platforms.
      sql/item_subselect.h:
        Attempt to silence cast warnings on some platforms.
      sql/set_var.cc:
        Silence warning (missing cast).
      sql/spatial.h:
        Attempt to silence cast warnings on some platforms.
      sql/sql_cache.cc:
        Silence warning (wrong cast).
      sql/sql_lex.h:
        Attempt to silence cast warnings on some platforms.
      52656969
    • unknown's avatar
      Few cleanups to client_test.c · f088cf99
      unknown authored
      
      tests/client_test.c:
        Few cleanups
      f088cf99
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · cc7a8d9b
      unknown authored
      into mysql.com:/home/my/mysql-4.1
      
      
      cc7a8d9b
    • unknown's avatar
      Fixed wrong key usage which caused wrong result for some "WHERE... · d91477ce
      unknown authored
      Fixed wrong key usage which caused wrong result for some "WHERE primary_key=constant" queries where MySQL could use 'only index' (Bug #3666)
      The bug was introduced in a patch in the 4.1.2 source tree.
      
      
      mysql-test/r/key.result:
        New result
      mysql-test/t/key.test:
        Added test case for bug in key read
      sql/sql_select.cc:
        Fixed wrong key usage which caused wrong result for some "WHERE primary_key=constant" queries where MySQL could use 'only index' (Bug #3666)
      d91477ce
  2. 05 May, 2004 24 commits
    • unknown's avatar
      Merge spetrunia@bk-internal.mysql.com:/home/bk/mysql-4.1 · cd57fc8b
      unknown authored
      into mysql.com:/dbdata/psergey/mysql-4.1-code-cleanup
      
      
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      cd57fc8b
    • unknown's avatar
      fixed test results · 1f32e9a1
      unknown authored
      1f32e9a1
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/mysql-4.1 · 66842d6e
      unknown authored
      into sanja.is.com.ua:/home/bell/mysql/bk/work-ndb-4.1
      
      
      66842d6e
    • unknown's avatar
      Replication: · 974ce66b
      unknown authored
      as the I/O thread filters on the server id, we must test replicate_same_server_id in it (on top of in the SQL thread).
      
      
      mysql-test/r/rpl_server_id2.result:
        result update
      sql/slave.cc:
        As the I/O thread filters on the server id, we must test replicate_same_server_id in it (on top of in the SQL thread).
      974ce66b
    • unknown's avatar
      merge · b52317df
      unknown authored
      
      mysql-test/r/subselect.result:
        Auto merged
      sql/sql_union.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      b52317df
    • unknown's avatar
      After merge fixes · 19d3f588
      unknown authored
      19d3f588
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · e5d43578
      unknown authored
      into mysql.com:/home/my/mysql-4.1
      
      
      sql/item_strfunc.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_union.cc:
        Auto merged
      e5d43578
    • unknown's avatar
      after merge fixes · 000f76cf
      unknown authored
      
      client/mysqldump.c:
        Fixed problem with multiple tables (--skip-quote didn't work properly for second table)
      myisam/myisamchk.c:
        after merge fix
      000f76cf
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/mysql-4.1 · 2c95f97c
      unknown authored
      into sanja.is.com.ua:/home/bell/mysql/bk/work-ndb-4.1
      
      
      mysql-test/r/subselect.result:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_union.cc:
        Auto merged
      sql/sql_update.cc:
        Auto merged
      2c95f97c
    • unknown's avatar
      caching of queries with isammerge tables forbiden using general way · f6428e8b
      unknown authored
      SQL_SELECT_LIMIT as default will be applied only for SELECT statement if there was not explicit LIMIT clause
      correct table list passed to class constructor of select_update
      
      
      mysql-test/r/subselect.result:
        do not show limit if it is not explicit
      mysql-test/r/union.result:
        test of LIMIT + ORDER
      mysql-test/t/union.test:
        test of LIMIT + ORDER
      sql/ha_isammrg.h:
        caching of queries with isammerge tables forbiden
      sql/sql_cache.cc:
        removed check on isammerge
      sql/sql_lex.cc:
        tag of explicit limit in statement
      sql/sql_lex.h:
        tag of explicit limit in statement
      sql/sql_parse.cc:
        blanks in empty line removed
        no limit by default (SQL_SELECT_LIMIT as default will be applied only for SELECT statement if there was not explicit LIMIT clause)
      sql/sql_union.cc:
        reverted incorrect patch
      sql/sql_update.cc:
        reverted incorrect patch
        correct table list passed to class constructor
      sql/sql_yacc.yy:
        explicit LIMIT marked
      f6428e8b
    • unknown's avatar
      Make Item_param::val_int and Item_param::val_str follow the used convention... · e1fc5423
      unknown authored
      Make Item_param::val_int and Item_param::val_str follow the used convention and return 0 if null_value==1.
      
      
      sql/item.h:
        Added comments about Item::valxx() behavior if Item's value is NULL.
      e1fc5423
    • unknown's avatar
      Merge with 4.0.19 · cd21f7ce
      unknown authored
      
      BitKeeper/etc/logging_ok:
        auto-union
      VC++Files/client/mysqlclient.dsp:
        Auto merged
      VC++Files/mysql.dsw:
        Auto merged
      extra/perror.c:
        Auto merged
      extra/replace.c:
        Auto merged
      innobase/configure.in:
        Auto merged
      innobase/include/lock0lock.h:
        Auto merged
      innobase/include/row0mysql.h:
        Auto merged
      innobase/include/sync0sync.h:
        Auto merged
      innobase/lock/lock0lock.c:
        Auto merged
      ltmain.sh:
        Auto merged
      BitKeeper/deleted/.del-libmysqld.def~8edf7b8780ce943c:
        Auto merged
      innobase/os/os0file.c:
        Auto merged
      innobase/pars/lexyy.c:
        Auto merged
      innobase/row/row0mysql.c:
        Auto merged
      innobase/srv/srv0srv.c:
        Auto merged
      innobase/srv/srv0start.c:
        Auto merged
      innobase/sync/sync0arr.c:
        Auto merged
      innobase/sync/sync0sync.c:
        Auto merged
      innobase/trx/trx0trx.c:
        Auto merged
      mysql-test/r/alias.result:
        Auto merged
      mysql-test/t/system_mysql_db_fix-master.opt:
        Auto merged
      mysql-test/r/func_time.result:
        Automatic merge
      mysql-test/r/innodb.result:
        Automatic merge
      mysql-test/t/alias.test:
        Automatic merge
      mysql-test/t/create.test:
        Automatic merge
      mysql-test/t/func_time.test:
        Automatic merge
      sql/ha_innodb.cc:
        Automatic merge
      sql/mysql_priv.h:
        Automatic merge
      mysql-test/r/rpl_multi_update.result:
        Automatic merge
      mysql-test/t/rpl_error_ignored_table.test:
        Automatic merge
      mysql-test/t/rpl_multi_update.test:
        Automatic merge
      sql/slave.h:
        Automatic merge
      sql/sql_base.cc:
        Automatic merge
      sql/sql_db.cc:
        Automatic merge
      sql/sql_insert.cc:
        Automatic merge
      sql/structs.h:
        Automatic merge
      sql/table.cc:
        Automatic merge
      strings/longlong2str-x86.s:
        Automatic merge
      strings/strings-x86.s:
        Automatic merge
      support-files/my-medium.cnf.sh:
        Automatic merge
      cd21f7ce
    • unknown's avatar
      Merge miguel@bk-internal.mysql.com:/home/bk/mysql-4.1 · b30d0883
      unknown authored
      into hegel.local:/home/miguel/bk/mysql-4.1
      
      
      sql/sql_parse.cc:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      b30d0883
    • unknown's avatar
      Fixes for prior commit · cf8463ac
      unknown authored
      
      mysys/my_getsystime.c:
        Applied Sergei's fixes
      sql/sql_prepare.cc:
        Fix prior commit
      cf8463ac
    • unknown's avatar
      Portability fix · 7d918f21
      unknown authored
      7d918f21
    • unknown's avatar
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · 575541b9
      unknown authored
      into mysql.com:/home/my/mysql-4.1
      
      
      mysql-test/r/subselect.result:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_update.cc:
        Auto merged
      tests/client_test.c:
        Auto merged
      575541b9
    • unknown's avatar
      Delete Items created during Prepared Stat (memory leak bug) (Bug #3451) · e75a26ba
      unknown authored
      
      sql/sql_parse.cc:
        Delete Items created during Prepared Stat (memory leak bug)
      sql/sql_prepare.cc:
        Delete Items created during Prepared Stat (memory leak bug)
      e75a26ba
    • unknown's avatar
      Fixed crashing bug with alter table when table was in use (Bug #3643) · 68d07cbc
      unknown authored
      We didn't use 'only index' for tables of type 'const'. (Bug #3497)
      
      
      mysql-test/r/func_str.result:
        New testfin
      mysql-test/r/key.result:
        New test
      mysql-test/r/key_primary.result:
        Update after "We didn't use 'only index' for tables of type 'const'" fix.
      mysql-test/r/null_key.result:
        Update after "We didn't use 'only index' for tables of type 'const'" fix.
      mysql-test/r/subselect.result:
        Update after "We didn't use 'only index' for tables of type 'const'" fix.
      mysql-test/t/func_str.test:
        Updated bug texts
        Added test for conversion of long string value to integer (Bug #3472)
      mysql-test/t/key.test:
        Test of key read with primary key (Bug #3497)
      sql/item.cc:
        Added assert
      sql/sql_base.cc:
        Fixed crashing bug with alter table when table was in use (Bug #3643)
      sql/sql_load.cc:
        Indentation fixes
      sql/sql_select.cc:
        We didn't use 'only index' for tables of type 'const'. (Bug #3497)
      68d07cbc
    • unknown's avatar
      InnoDB: Truncate "<datadir>/innodb.status.<pid>" to its actual size · b33f8fa7
      unknown authored
      (Bug #3596)
      
      
      innobase/srv/srv0srv.c:
        Truncate "<datadir>/innodb.status.<pid>" to its actual size (Bug #3596)
      sql/ha_innodb.cc:
        Truncate "<datadir>/innodb.status.<pid>" to its actual size (Bug #3596)
      b33f8fa7
    • unknown's avatar
      InnoDB: os0file.c: Lock files exclusively (Bug #3608) · f44fb5fd
      unknown authored
      
      innobase/os/os0file.c:
        Lock files unless #defined __WIN__ or UNIV_HOTBACKUP (Bug #3608)
      f44fb5fd
    • unknown's avatar
      avoid using ndb tables in query cache · ea646dce
      unknown authored
      
      sql/ha_ndbcluster.h:
        fixed layout
        prohibit using query cache with ndb tables
      sql/handler.h:
        new caching type
      sql/sql_cache.cc:
        support of new caching type (caching prohibited)
      ea646dce
    • unknown's avatar
      Merge marko@build.mysql.com:/home/bk/mysql-4.0 · aee9a548
      unknown authored
      into hundin.mysql.fi:/home/marko/l/mysql-4.0
      
      
      aee9a548
    • unknown's avatar
      Windows fixes for VC++ compiler compability · bddee0c1
      unknown authored
      
      myisam/myisam_ftdump.c:
        VC++ compiler compability fix
      mysys/my_getsystime.c:
        Applied Sergei's code for Windows (still subject to changes by him)
      sql/handler.cc:
        VC++ compiler compability fix
      sql/item_geofunc.cc:
        Removed non-used variable
      sql/item_strfunc.cc:
        VC++ compiler compability fix
      sql/opt_range.cc:
        VC++ compiler compability fix
      sql/sql_insert.cc:
        VC++ compiler compability fix
      sql/sql_lex.cc:
        VC++ compiler compability fix
      sql/sql_parse.cc:
        VC++ compiler compability fix
      sql/sql_prepare.cc:
        VC++ compiler compability fix
      sql/sql_union.cc:
        Removed non-used variable and VC++ compiler compability fix
      bddee0c1
  3. 04 May, 2004 12 commits
    • unknown's avatar
      Fixes to Windows project files for 4.0.19 · e35921a1
      unknown authored
      
      VC++Files/client/mysqlclient.dsp:
        Add strxnmov to project files
      VC++Files/mysql.dsw:
        Add dependency to prevent compile error
      e35921a1
    • unknown's avatar
      Merge sinisa@bk-internal.mysql.com:/home/bk/mysql-4.1 · af847c22
      unknown authored
      into sinisa.nasamreza.org:/mnt/work/mysql-4.1
      
      
      sql/sql_union.cc:
        Auto merged
      af847c22
    • unknown's avatar
      Fix for a multi table updates when one of the tables is not updated · 5bd7b50c
      unknown authored
      but used in a nested query.
      
      
      5bd7b50c
    • unknown's avatar
      After merge fix. · 4df5d6d6
      unknown authored
      Now test_bug1664() uses new statement checking macros.
      
      
      tests/client_test.c:
        Now test_bug1664() uses new statement checking macros.
      4df5d6d6
    • unknown's avatar
      Manual merge of bugfix for Bug #1664. · 5c9f01a7
      unknown authored
      
      sql/sql_prepare.cc:
        Auto merged
      tests/client_test.c:
        Manual merge.
      5c9f01a7
    • unknown's avatar
      Fix for remaining issues described in Bug #1664 · 6ca75754
      unknown authored
      "mysql_send_long_data() API call is completely broken".
      
      Now we are resetting some members (long_data_supplied/null_value...) of Item_param to its 
      initial state after each execution of prepared statement. We also manipulating 
      Item_param::maybe_null/null_value only via Item_param::set_* setters which makes code a bit 
      more robust.
      
      
      sql/item.cc:
        Now we are assuming that Item_param may be NULL until we know this fact exactly.
        Added non-empty implementation of Item_param::reset() method which should be used
        for restoring Item_param state after each statment execution. (We need to clear 
        long_data_supplied flag, we also clear some other Item_param members here since it
        makes code simpler.)
      sql/item.h:
        Now Item_param::reset() method really does something.
      sql/sql_prepare.cc:
        Now we are calling Item_param::reset() for each parameter after execution for resetting Item_param
        to initial state. So we no longer don't need Prepared_statement::long_data_flag. We also 
        set Item_param::null_value/maybe_null value in Item_param::set_* and reset() methods 
        instead of doing it explicitly in insert_params_* functions (this by the way lowers 
        probability that we will forget to update one of such functions).
      tests/client_test.c:
        Added test for Bug#1664 "mysql_send_long_data() API call is broken".
      6ca75754
    • unknown's avatar
      useless fixes for --report-password and --show-slave-auth-info (almost undocumented options), · 40dba5a8
      unknown authored
      just for beauty of truth.
      
      
      sql/mysqld.cc:
        correcting sentence (even if option is not really usable,
        as it depends on report-user and report-password which are undocumented
        (and will stay like this)).
      sql/slave.cc:
        report password when you must report password.
      40dba5a8
    • unknown's avatar
      Merge gbichot@bk-internal.mysql.com:/home/bk/mysql-4.0 · a1ec6140
      unknown authored
      into mysql.com:/home/mysql_src/mysql-4.0
      
      
      a1ec6140
    • unknown's avatar
      Fix for Bug#3357 "If the statement is long, the error message is trunc and important info is lost"; · ed3f472a
      unknown authored
      in hard-coded replication messages, always put small-length info (error codes, explanation of the error) at the beginning,
      so that it is not cut by truncation if the query is very long (which happens if the query goes first).
      
      
      sql/log_event.cc:
        in hard-coded replication messages, always put small-length info (error codes, explanation of the error) at the beginning,
        so that it is not cut by truncation if the query is very long (which happens if the query goes first).
      ed3f472a
    • unknown's avatar
      union.result: · af794dde
      unknown authored
        fixing typo
      union.test:
        fixing type
      
      
      mysql-test/t/union.test:
        fixing type
      mysql-test/r/union.result:
        fixing typo
      af794dde
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/mysql-4.1 · a0c07c28
      unknown authored
      into sanja.is.com.ua:/home/bell/mysql/bk/work-prep-4.1
      
      
      a0c07c28
    • unknown's avatar
      repetable test replaced with inline function · aaff8391
      unknown authored
      aaff8391