1. 12 Oct, 2007 1 commit
    • unknown's avatar
      Merge kindahl-laptop.dnsalias.net:/home/bkroot/mysql-5.1-rpl · 589ef1a7
      unknown authored
      into  kindahl-laptop.dnsalias.net:/home/bk/b29549-mysql-5.1-target-5.1.22
      
      
      mysql-test/suite/rpl/t/disabled.def:
        Auto merged
      mysql-test/suite/rpl_ndb/t/disabled.def:
        Auto merged
      sql/log.cc:
        Auto merged
      sql/rpl_record.cc:
        Auto merged
      sql/sql_show.cc:
        Auto merged
      BitKeeper/deleted/.del-rpl_ndb_innodb2ndb.result~1:
        Delete: mysql-test/suite/rpl_ndb/r/rpl_ndb_innodb2ndb.result
      BitKeeper/deleted/.del-rpl_ndb_myisam2ndb.result~1:
        Delete: mysql-test/suite/rpl_ndb/r/rpl_ndb_myisam2ndb.result
      mysql-test/suite/rpl_ndb/t/rpl_ndb_innodb2ndb-slave.opt:
        Manual merge
      mysql-test/suite/rpl_ndb/t/rpl_ndb_innodb2ndb.test:
        Manual merge
      mysql-test/suite/rpl_ndb/t/rpl_ndb_myisam2ndb-slave.opt:
        Manual merge
      mysql-test/suite/rpl_ndb/t/rpl_ndb_myisam2ndb.test:
        Manual merge
      sql/log_event.cc:
        Manual merge
      sql/field.cc:
        Manual merge and adding comment.
      sql/field.h:
        Manual merge.
      589ef1a7
  2. 11 Oct, 2007 1 commit
    • unknown's avatar
      BUG#29549 (Endians: test failures on Solaris): · 38b24c7a
      unknown authored
      Refactoring code to add parameter to pack() and unpack() functions with
      purpose of indicating if data should be packed in little-endian or
      native order. Using new functions to always pack data for binary log
      in little-endian order. The purpose of this refactoring is to allow
      proper implementation of endian-agnostic pack() and unpack() functions.
      
      Eliminating several versions of virtual pack() and unpack() functions
      in favor for one single virtual function which is overridden in
      subclasses.
      
      Implementing pack() and unpack() functions for some field types that
      packed data in native format regardless of the value of the
      st_table_share::db_low_byte_first flag.
      
      The field types that were packed in native format regardless are:
      Field_real, Field_decimal, Field_tiny, Field_short, Field_medium,
      Field_long, Field_longlong, and Field_blob.
      
      Before the patch, row-based logging wrote the rows incorrectly on
      big-endian machines where the storage engine defined its own
      low_byte_first() to be FALSE on big-endian machines (the default
      is TRUE), while little-endian machines wrote the fields in correct
      order. The only known storage engine that does this is NDB. In effect,
      this means that row-based replication from or to a big-endian
      machine where the table was using NDB as storage engine failed if the
      other engine was either non-NDB or on a little-endian machine.
      
      With this patch, row-based logging is now always done in little-endian
      order, while ORDER BY uses the native order if the storage engine
      defines low_byte_first() to return FALSE for big-endian machines.
      
      In addition, the max_data_length() function available in Field_blob
      was generalized to the entire Field hierarchy to give the maximum
      number of bytes that Field::pack() will write.
      
      
      mysql-test/extra/rpl_tests/rpl_extraMaster_Col.test:
        Sorting by columns that produces deterministic order.
      mysql-test/suite/rpl/r/rpl_extraColmaster_innodb.result:
        Result change.
      mysql-test/suite/rpl/r/rpl_extraColmaster_myisam.result:
        Result change.
      mysql-test/suite/rpl/r/rpl_row_extraColmaster_ndb.result:
        Result change.
      mysql-test/suite/rpl/t/disabled.def:
        Enabling tests.
      mysql-test/suite/rpl/t/rpl_row_mysqlbinlog.test:
        Adding missing sync_slave_with_master causing slave to keep tables
        after shutdown.
      mysql-test/suite/rpl_ndb/t/disabled.def:
        Enabling tests.
      mysql-test/suite/rpl_ndb/t/rpl_ndb_innodb2ndb-slave.opt:
        Adding --new option
      mysql-test/suite/rpl_ndb/t/rpl_ndb_innodb2ndb.test:
        Adding have_log_bin.
      mysql-test/suite/rpl_ndb/t/rpl_ndb_myisam2ndb-slave.opt:
        Adding --new option
      mysql-test/suite/rpl_ndb/t/rpl_ndb_myisam2ndb.test:
        Adding have_log_bin
      mysql-test/t/partition.test:
        Adding have_archive, since that is used in the test.
      sql/field.cc:
        Eliminating all two-argument pack() and unpack() functions and moving
        functionality into the four-argument version. The four argument version
        is introduced so that it is possible to avoid using the storage engine
        default when writing and reading the packed format (the unpacked format
        still uses the storage engine's default). This is used by row-based
        replication to write the fields in a storage engine- and endian-agnostic
        format.
        
        Packing integral and floating-point numbers in little-endian format
        (if requested).
        
        Using pad_char for the field instead of spaces (0x20) when unpacking.
        
        Adding some Doxygen documentation.
        ---
        Adding max_data_length() to denote the maximum number of bytes that
        pack() will write.
        
        Adding casts to remove warnings for debug printouts.
      sql/field.h:
        Eliminating all virtual pack() and unpack() functions except the four-
        argument version, which now is the function that shall be overridden.
        The two-argument versions are convenience functions, to prevent changes
        to code that uses these.
        
        Adding code to pack integer numbers and floating-point numbers in
        little-endian format, if requested.
        ---
        Adding max_data_length() to denote the maximum number of bytes that
        pack() will write.
      sql/log.cc:
        Removing debug printout causing crash when starting NDB on Solaris.
      sql/log_event.cc:
        Adding missing #ifndef causing compile failure. Adding debug printouts.
      sql/rpl_record.cc:
        Debriding code. Using new pack() and unpack() functions to always pack
        fields little-endian. Adding debug printouts.
        ---
        Using max_data_length() when packing field into row.
        
        Adding casts to debug printouts.
      sql/sql_show.cc:
        Adding code that causes crash on Solaris machines since printf() cannot
        handle NULL values for strings properly.
      mysql-test/suite/rpl_ndb/r/rpl_ndb_innodb2ndb.result:
        New BitKeeper file ``mysql-test/suite/rpl_ndb/r/rpl_ndb_innodb2ndb.result''
      mysql-test/suite/rpl_ndb/r/rpl_ndb_myisam2ndb.result:
        New BitKeeper file ``mysql-test/suite/rpl_ndb/r/rpl_ndb_myisam2ndb.result''
      38b24c7a
  3. 24 Sep, 2007 2 commits
  4. 21 Sep, 2007 1 commit
  5. 20 Sep, 2007 2 commits
    • unknown's avatar
      Merge kindahl-laptop.dnsalias.net:/home/bkroot/mysql-5.1-rpl · 0ade39d4
      unknown authored
      into  kindahl-laptop.dnsalias.net:/home/bk/b31076-mysql-5.1-rpl
      
      
      sql/log_event.cc:
        Auto merged
      0ade39d4
    • unknown's avatar
      BUG#31076 (Server crashes when start slave is issued): · 0cbf0f8e
      unknown authored
      Row-based replication crashes when replicating from pre-5.1.22 to 5.1.22
      due to an uninitialized variable.
      
      
      sql/log_event.cc:
        Initializing m_null_bits to null so that it can be detected that it
        was not initialized later.
      mysql-test/suite/rpl/r/rpl_bug31076.result:
        New BitKeeper file ``mysql-test/suite/rpl/r/rpl_bug31076.result''
      mysql-test/suite/rpl/t/rpl_bug31076.test:
        New BitKeeper file ``mysql-test/suite/rpl/t/rpl_bug31076.test''
      0cbf0f8e
  6. 17 Sep, 2007 4 commits
    • unknown's avatar
      Merge lthalmann@bk-internal.mysql.com:/home/bk/mysql-5.1-new-rpl · 6fedb24e
      unknown authored
      into  mysql.com:/nfsdisk1/lars/bkroot/mysql-5.1-new-rpl
      
      6fedb24e
    • unknown's avatar
      Merge mysql.com:/nfsdisk1/lars/MERGE/mysql-5.0-merge · d71b5e56
      unknown authored
      into  mysql.com:/nfsdisk1/lars/MERGE/mysql-5.1-merge
      
      
      sql/sql_insert.cc:
        Auto merged
      d71b5e56
    • unknown's avatar
      Merge mysql.com:/nfsdisk1/lars/bkroot/mysql-5.1-new-rpl · cbcc5bb6
      unknown authored
      into  mysql.com:/nfsdisk1/lars/MERGE/mysql-5.1-merge
      
      
      sql/field.cc:
        Auto merged
      sql/log_event.cc:
        Auto merged
      sql/rpl_utility.cc:
        Auto merged
      sql/rpl_utility.h:
        Auto merged
      sql/slave.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_update.cc:
        Auto merged
      cbcc5bb6
    • unknown's avatar
      Merge: bug@27417,23333 and bug#28960 tests with 5.1 · 534a8370
      unknown authored
      
      mysql-test/suite/binlog/r/binlog_row_mix_innodb_myisam.result:
        results changed
      mysql-test/suite/binlog/r/binlog_stm_mix_innodb_myisam.result:
        results changed
      mysql-test/suite/binlog/t/binlog_row_mix_innodb_myisam.test:
        calling included file with testing bug#27417,23333. bug#28960 is not an rbr bug.
      mysql-test/suite/binlog/t/binlog_stm_mix_innodb_myisam.test:
        moved SF() with side effects bugs to a separate includable file.
        This test verifies STMT format whereas binlog_row test is reposible for
        ROW format.
      mysql-test/extra/binlog_tests/mix_innodb_myisam_side_effects.test:
        sourced part for bugs with SF() etc having side effects of midifying
        non-transactional tables.
      534a8370
  7. 16 Sep, 2007 2 commits
    • unknown's avatar
      Merge: bug#27417,23333 manual work for fixing tests and a source code. · 9f8b990b
      unknown authored
      
      mysql-test/suite/binlog/r/binlog_stm_mix_innodb_myisam.result:
        results changed due to 
        1. tt table made temporary is it's supposed to; 
        2. show master status is turned into binlog pos masking-out macro
        3. merge defect for select_insert::abort()
      mysql-test/suite/binlog/t/binlog_stm_mix_innodb_myisam.test:
        masking-out binlog postions in the results via 
        source include/show_binlog_events.inc;
      sql/sql_insert.cc:
        merging defect in not applied hunk for select_insert::abort() is fixed
      9f8b990b
    • unknown's avatar
      Manual merge fixes/tests for bugs_28960,27417,23333. · c6055e7a
      unknown authored
      
      mysql-test/extra/binlog_tests/mix_innodb_myisam_binlog.test:
        follow-up of the previous manual resolve. The snippet is moved into the heading
        file.
      mysql-test/suite/binlog/r/binlog_stm_mix_innodb_myisam.result:
        results changed
      mysql-test/suite/binlog/t/binlog_stm_mix_innodb_myisam.test:
        removing explicit offsets from report;
        appending bug#27417,23333,28960 related snippet, addressing left TODO:s.
      mysql-test/suite/rpl/r/rpl_packet.result:
        results changed
      mysql-test/suite/rpl/t/rpl_packet.test:
        fixing row/stmt compatibility with #-ing out unneeded values
      c6055e7a
  8. 15 Sep, 2007 1 commit
    • unknown's avatar
      Merge dl145j.mysql.com:/tmp/andrei/mysql-5.0-rpl · d5c25b0c
      unknown authored
      into  dl145j.mysql.com:/tmp/andrei/5.1-merge
      
      
      BitKeeper/deleted/.del-sp_trans_log.result:
        Auto merged
      BitKeeper/deleted/.del-sp_trans_log.test:
        Auto merged
      mysql-test/suite/rpl/r/rpl_packet.result:
        Auto merged
      sql/sql_delete.cc:
        Auto merged
      sql/sql_update.cc:
        Auto merged
      mysql-test/suite/binlog/r/binlog_stm_mix_innodb_myisam.result:
        should be re-recorded
      mysql-test/extra/binlog_tests/mix_innodb_myisam_binlog.test:
        manual merge
      mysql-test/suite/rpl/t/rpl_packet.test:
        manual merge
      sql/slave.cc:
        manual merge
      sql/sql_insert.cc:
        manual merge - installing 5.0 patch logics
      sql/sql_load.cc:
        manual merge
      d5c25b0c
  9. 14 Sep, 2007 2 commits
    • unknown's avatar
      Merge mysql_cab_desk.:C:/source/c++/mysql-5.1-new-rpl · 6ffea6be
      unknown authored
      into  mysql_cab_desk.:C:/source/c++/mysql-5.1_BUG_30790
      
      6ffea6be
    • unknown's avatar
      BUG#30790 : Suspicious code in rpl_utility.cc · d458d941
      unknown authored
      This patch clarifies some of the coding choices with documentationa and
      removes a limitation in the code for future expansion of the CHAR and
      BINARY fields to length > 255.
      
      
      sql/field.cc:
        BUG#30790 : Suspicious code in rpl_utility.cc
        
        This patch adds an assertion to ensure we are not attempting to encode
        negative values.
      sql/log_event.cc:
        BUG#30790 : Suspicious code in rpl_utility.cc
        
        This patch adds comments to help explain the choice of variable types.
      sql/rpl_utility.cc:
        BUG#30790 : Suspicious code in rpl_utility.cc
        
        This patch removes code from the calc_field_size that is not needed and
        was ambiguous. Originally intended to future expansion, the code was
        not needed.
        
        Also added are comments to help explain some portions of the code.
        
        A change was made to the korr method to use the unsigned version to 
        avoid extended sign problems.
      sql/rpl_utility.h:
        BUG#30790 : Suspicious code in rpl_utility.cc
        
        This patch corrects some type discrepencies and removes an extra cast.
      d458d941
  10. 10 Sep, 2007 4 commits
    • unknown's avatar
      Merge mysql.com:/nfsdisk1/lars/MERGE/mysql-4.1-merge · 6e104d69
      unknown authored
      into  mysql.com:/nfsdisk1/lars/MERGE/mysql-5.0-merge
      
      6e104d69
    • unknown's avatar
      Merge mysql.com:/nfsdisk1/lars/bkroot/mysql-5.1-new-rpl · 36906fb7
      unknown authored
      into  mysql.com:/nfsdisk1/lars/MERGE/mysql-5.1-merge
      
      
      mysql-test/suite/ndb/r/ndb_dd_basic.result:
        Auto merged
      mysql-test/suite/rpl/include/rpl_mixed_dml.inc:
        Auto merged
      mysql-test/suite/rpl/r/rpl_innodb_mixed_dml.result:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/handler.cc:
        Auto merged
      sql/log.cc:
        Auto merged
      sql/log_event_old.cc:
        Auto merged
      sql/log_event_old.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/rpl_record.cc:
        Auto merged
      sql/rpl_record.h:
        Auto merged
      sql/rpl_utility.cc:
        Auto merged
      sql/rpl_utility.h:
        Auto merged
      sql/slave.cc:
        Auto merged
      sql/slave.h:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_string.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      sql/unireg.h:
        Auto merged
      mysql-test/suite/rpl/t/disabled.def:
        Manual merge
      mysql-test/suite/rpl_ndb/t/disabled.def:
        Manual merge
      sql/log_event.cc:
        Manual merge
      sql/log_event.h:
        Manual merge
      sql/sql_yacc.yy:
        Manual merge
      36906fb7
    • unknown's avatar
      Merge mysql.com:/nfsdisk1/lars/bkroot/mysql-5.0-rpl · 37c591ce
      unknown authored
      into  mysql.com:/nfsdisk1/lars/MERGE/mysql-5.0-merge
      
      
      sql/sql_insert.cc:
        Auto merged
      37c591ce
    • unknown's avatar
      Merge mysql.com:/nfsdisk1/lars/bkroot/mysql-4.1-rpl · 98d1973f
      unknown authored
      into  mysql.com:/nfsdisk1/lars/MERGE/mysql-4.1-merge
      
      98d1973f
  11. 07 Sep, 2007 1 commit
  12. 06 Sep, 2007 4 commits
  13. 05 Sep, 2007 5 commits
    • unknown's avatar
      Merge omega.weblab:/home/malff/TREE/mysql-5.1-base · 1a96ea56
      unknown authored
      into  omega.weblab:/home/malff/TREE/mysql-5.1-rt-merge
      
      1a96ea56
    • unknown's avatar
      Merge malff@bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · 9b64b7ab
      unknown authored
      into  omega.weblab:/home/malff/TREE/mysql-5.1-cleanup
      
      9b64b7ab
    • unknown's avatar
      Test events_logs_tests cleanup · c8f104fd
      unknown authored
      Fixed test failure under heavy load, in case truncate table is slow.
      
      
      mysql-test/r/events_logs_tests.result:
        Fixed test failure under heavy load, in case truncate table is slow.
      mysql-test/t/events_logs_tests.test:
        Fixed test failure under heavy load, in case truncate table is slow.
      c8f104fd
    • unknown's avatar
      The test case for Bug#29936 doesn't work with the embedded version, · c6119599
      unknown authored
      the first query is not running while we are doing wait queries on
      a second connection.
      
      
      mysql-test/r/sp.result:
        Remove test case result for Bug#29936, moving to sp_notembedded.result
      mysql-test/r/sp_notembedded.result:
        Test case result for Bug#29936, moved from sp.result
      mysql-test/t/sp.test:
        Remove test case for Bug#29936, moving to sp_notembedded.test
      mysql-test/t/sp_notembedded.test:
        Test case result for Bug#29936, moved from sp.test
      c6119599
    • unknown's avatar
      Discovered a bug while working with backup. Since it is possible to execute a... · 9bc74eef
      unknown authored
      Discovered a bug while working with backup. Since it is possible to execute a statement in a pre/post statment clause that can return a result, we need to test for that and free it. 
      
      
      client/mysqlslap.c:
        Cleanup resuls if rows are returned.
      9bc74eef
  14. 04 Sep, 2007 7 commits
  15. 03 Sep, 2007 3 commits