1. 03 Feb, 2023 1 commit
  2. 02 Feb, 2023 39 commits
    • Monty's avatar
      Added test cases for preceding test · 727491b7
      Monty authored
      This includes all test changes from
      "Changing all cost calculation to be given in milliseconds"
      and forwards.
      
      Some of the things that caused changes in the result files:
      
      - As part of fixing tests, I added 'echo' to some comments to be able to
        easier find out where things where wrong.
      - MATERIALIZED has now a higher cost compared to X than before. Because
        of this some MATERIALIZED types have changed to DEPENDEND SUBQUERY.
        - Some test cases that required MATERIALIZED to repeat a bug was
          changed by adding more rows to force MATERIALIZED to happen.
      - 'Filtered' in SHOW EXPLAIN has in many case changed from 100.00 to
        something smaller. This is because now filtered also takes into
        account the smallest possible ref access and filters, even if they
        where not used. Another reason for 'Filtered' being smaller is that
        we now also take into account implicit filtering done for subqueries
        using FIRSTMATCH.
        (main.subselect_no_exists_to_in)
        This is caluculated in best_access_path() and stored in records_out.
      - Table orders has changed because more accurate costs.
      - 'index' and 'ALL' for small tables has changed to use 'range' or
         'ref' because of optimizer_scan_setup_cost.
      - index can be changed to 'range' as 'range' optimizer assumes we don't
        have to read the blocks from disk that range optimizer has already read.
        This can be confusing in the case where there is no obvious where clause
        but instead there is a hidden 'key_column > NULL' added by the optimizer.
        (main.subselect_no_exists_to_in)
      - Scan on primary clustered key does not report 'Using Index' anymore
        (It's a table scan, not an index scan).
      - For derived tables, the number of rows is now 100 instead of 2,
        which can be seen in EXPLAIN.
      - More tests have "Using index for group by" as the cost of this
        optimization is now more correct (lower).
      - A primary key could be preferred for a normal key, even if it would
        access more rows, as it's faster to do 1 lokoup and 3 'index_next' on a
        clustered primary key than one lookup trough a secondary.
        (main.stat_tables_innodb)
      
      Notes:
      
      - There was a 4.7% more calls to best_extension_by_limited_search() in
        the main.greedy_optimizer test.  However examining the test results
        it looked that the plans where slightly better (eq_ref where more
        chained together) so I assume this is ok.
      - I have verified a few test cases where there was notable/unexpected
        changes in the plan and in all cases the new optimizer plans where
        faster.  (main.greedy_optimizer and some others)
      727491b7
    • Monty's avatar
      Added range_index to 'range' optimizer_trace output · eb68023c
      Monty authored
      Other things:
      - Renamed "rowid_filter_key" to "rowid_filter_index" to keep things
        consistent
      eb68023c
    • Vicențiu Ciorbaru's avatar
      Fix bug in WITH ties · 367c780d
      Vicențiu Ciorbaru authored
      The old code had a bug when the normal sorting code where
      where eliminated as part of "Using index for group-by" optimization.
      The effect was that the result contained more rows than expected
      367c780d
    • Monty's avatar
      MDEV-29677 Wrong result with join query and innodb fulltext search · aa5e7880
      Monty authored
      InnoDB FTS scan was used by a subquery. A subquery execution may start
      a table read and continue until it finds the first matching record
      combination. This can happen before the table read returns EOF.
      
      The next time the subquery is executed, it will start another table read.
      InnoDB FTS table read fails to re-initialize its data structures in this
      scenario and will try to continue the scan started at the first execution.
      
      Fixed by ha_innobase::ft_init() to stop the FTS scan if there is one.
      
      Author: Sergei Petrunia <sergey@mariadb.com>
      Reviewer: Monty
      aa5e7880
    • Monty's avatar
      Fixes for 'Filtering' · 66d9c1b2
      Monty authored
      - table_after_join_selectivity() should use records_init (new bug)
      - get_examined_rows() changed to double to get similar results
        as in MariaDB 10.11
      - Fixed bug where table_after_join_selectivity() did not correct
        selectivity in the case where a RANGE is used instead of a REF.
        This can happen if the range can use more key_parts than the REF.
        WHERE key_part1=10 and key_part2 < 10
      
      Other things:
      - Use JT_RANGE instead of JT_ALL for RANGE access in all parts of the code.
        Before we used JT_ALL for RANGE.
      - Force RANGE be used in best_access_path() if the range used more key
        parts than ref. In the original code, this was done much later in
        make_join_select)(). However we need to know in
        table_after_join_selectivity() if we have used RANGE or not.
      - Added more information about filtering to optimizer_trace.
      66d9c1b2
    • Monty's avatar
      Updated number of expected rows from 2 to 100 for information_schema tables · 4464aa46
      Monty authored
      The reason is that 2 is usually way to low and as information_schema
      tables may have implicit locks when accessing rows, it is better that
      the optimizer doesn't think that these tables are 'very small and fast'.
      
      This change will affect a very small set of test cases.
      4464aa46
    • Monty's avatar
      Added optimizer_trace info for index_intersects · 15cce52b
      Monty authored
      15cce52b
    • Monty's avatar
      Removed worst_seek argument for cost_for_index_read() · 0fada9c2
      Monty authored
      The argument was not used.
      0fada9c2
    • Monty's avatar
      Changed aggregate distinct optimization with indexes to be cost based. · 43dc831e
      Monty authored
      Before the cost of an aggregate distinct (COUNT(DISTINCT ...)) was set
      to 0 if the values where part of an index and the cost of grouping
      was higher than the best cost so far.  This was shown in explain with
      "Using index for group-by (scanning)".
      
      This patch fixes it by calculating the cost of aggregate distinct
      and using scanning only if the cost was better than group-by-optimization.
      
      Thing taken into account:
      - When using aggregate distinct on index, the filtering is done before
        the row is checked against the WHERE and we have thus less WHERE cost.
      - When comparing a cost from aggregate distinct, we add to the compared
        to plan the cost of doing the filtering later in the SQL level.
      43dc831e
    • Monty's avatar
      Fixes some issues in Firstmatch optimization · 2eb6b801
      Monty authored
      Allows FirstMatch to handle the case where the fanout of firstmatch tables
      is already less than 1.
      Also Fixes LooseScan strategy to set position->{records_init, records_out}
      (They were set to 0 which also caused assertion failures)
      
      Author: Sergei Petrunia <sergey@mariadb.com>
      Reviewer: Monty
      2eb6b801
    • Monty's avatar
      804c91ba
    • Monty's avatar
      Indexes where not used for sorting in sub queries · 99db92f6
      Monty authored
      This happens when the subquery marks some index fields as constant
      but the fields are still present in GROUP BY
      
      Fixed by checking if the 'constant field' is still part of GROUP BY before
      skipping it.
      
      Other things:
      - Added Item_field::contains() to make it easier to check if a field
        is equal to a Item_field or part of Item_equal.
      99db92f6
    • Monty's avatar
      Add limits for how many IO operations a table access will do · d9d0e780
      Monty authored
      This solves the current problem in the optimizer
      - SELECT FROM big_table
        - SELECT from small_table where small_table.eq_ref_key=big_table.id
      
      The old code assumed that each eq_ref access will cause an IO.
      As the cost of IO is high, this dominated the cost for the later table
      which caused the optimizer to prefer table scans + join cache over
      index reads.
      
      This patch fixes this issue by limit the number of expected IO calls,
      for rows and index separately, to the size of the table or index or
      the number of accesses that we except in a range for the index.
      
      The major changes are:
      
      - Adding a new structure ALL_READ_COST that is mainly used in
        best_access_path() to hold the costs parts of the cost we are
        calculating. This allows us to limit the number of IO when multiplying
        the cost with the previous row combinations.
      - All storage engine cost functions are changed to return IO_AND_CPU_COST.
        The virtual cost functions should now return in IO_AND_CPU_COST.io
        the number of disk blocks that will be accessed instead of the cost
        of the access.
      - We are not limiting the io_blocks for table or index scans as we
        assume that engines may not store these in the 'hot' part of the
        cache. Table and index scan also uses much less IO blocks than
        key accesses, so the original issue is not as critical with scans.
      
      Other things:
        OPT_RANGE now holds a 'Cost_estimate cost' instead a lot of different
        costs. All the old costs, like index_only_read, can be extracted
        from 'cost'.
      - Added to the start of some functions 'handler *file= table->file'
        to shorten the code that is using the handler.
      - handler->cost() is used to change a ALL_READ_COST or IO_AND_CPU_COST
        to 'cost in milliseconds'
      - New functions:  handler::index_blocks() and handler::row_blocks()
        which are used to limit the IO.
      - Added index_cost and row_cost to Cost_estimate and removed all not
        needed members.
      - Removed cost coefficients from Cost_estimate as these don't make sense
        when costs (except IO_BLOCKS) are in milliseconds.
      - Removed handler::avg_io_cost() and replaced it with DISK_READ_COST.
      - Renamed best_range_rowid_filter_for_partial_join() to
        best_range_rowid_filter() as using the old name made rows too long.
      - Changed all SJ_MATERIALIZATION_INFO 'Cost_estimate' variables to
        'double' as Cost_estimate power was not used for these and thus
        just caused storage and performance overhead.
      - Changed cost_for_index_read() to use 'worst_seeks' to only limit
        IO, not number of table accesses. With this patch worst_seeks is
        probably not needed anymore, but I kept it around just in case.
      - Applying cost for filter got to be much shorter and easier thanks
        to the API changes.
      - Adjusted cost for fulltext keys in collaboration with Sergei Golubchik.
      - Most test changes caused by this patch is that table scans are changed
        to use indexes.
      - Added ha_seq::keyread_time() and ha_seq::key_scan_time() to get
        make checking number of potential IO blocks easier during debugging.
      d9d0e780
    • Monty's avatar
      Fix cost calculation for get_best_group_min_max() · 7afa819f
      Monty authored
      If the final range restrictions (SEL_ARG tree) over GROUP BY
      columns are single-point, we can compute the number of GROUP BY groups.
      
      Example: in the query:
      SELECT ... FROM tbl
      WHERE keypart1 IN (1,2,3) and keypart2 IN ('foo','bar')
      
      Other things:
      - Fixed cost calculation to more correctly count the number of blocks
        that may be read. The old code could use the total blocks in the file
        even if a range was available.
      7afa819f
    • Monty's avatar
      Fixed limit optimization in range optimizer · 009db228
      Monty authored
      The issue was that when limit is used,
      SQL_SELECT::test_quick_select would set the cost of table scan to be
      unreasonable high to force a range to be used.
      The problem with this approach was that range was used even when the
      cost of range, when it would only read 'limit rows' would be higher
      than the cost of a table scan.
      
      This patch fixes it by not accepting ranges when the range can never
      have a lower cost than a table scan, even if every row would match the
      WHERE clause.
      009db228
    • Monty's avatar
      Changing all cost calculation to be given in milliseconds · b66cdbd1
      Monty authored
      This makes it easier to compare different costs and also allows
      the optimizer to optimizer different storage engines more reliably.
      
      - Added tests/check_costs.pl, a tool to verify optimizer cost calculations.
        - Most engine costs has been found with this program. All steps to
          calculate the new costs are documented in Docs/optimizer_costs.txt
      
      - User optimizer_cost variables are given in microseconds (as individual
        costs can be very small). Internally they are stored in ms.
      - Changed DISK_READ_COST (was DISK_SEEK_BASE_COST) from a hard disk cost
        (9 ms) to common SSD cost (400MB/sec).
      - Removed cost calculations for hard disks (rotation etc).
      - Changed the following handler functions to return IO_AND_CPU_COST.
        This makes it easy to apply different cost modifiers in ha_..time()
        functions for io and cpu costs.
        - scan_time()
        - rnd_pos_time() & rnd_pos_call_time()
        - keyread_time()
      - Enhanched keyread_time() to calculate the full cost of reading of a set
        of keys with a given number of ranges and optional number of blocks that
        need to be accessed.
      - Removed read_time() as keyread_time() + rnd_pos_time() can do the same
        thing and more.
      - Tuned cost for: heap, myisam, Aria, InnoDB, archive and MyRocks.
        Used heap table costs for json_table. The rest are using default engine
        costs.
      - Added the following new optimizer variables:
        - optimizer_disk_read_ratio
        - optimizer_disk_read_cost
        - optimizer_key_lookup_cost
        - optimizer_row_lookup_cost
        - optimizer_row_next_find_cost
        - optimizer_scan_cost
      - Moved all engine specific cost to OPTIMIZER_COSTS structure.
      - Changed costs to use 'records_out' instead of 'records_read' when
        recalculating costs.
      - Split optimizer_costs.h to optimizer_costs.h and optimizer_defaults.h.
        This allows one to change costs without having to compile a lot of
        files.
      - Updated costs for filter lookup.
      - Use a better cost estimate in best_extension_by_limited_search()
        for the sorting cost.
      - Fixed previous issues with 'filtered' explain column as we are now
        using 'records_out' (min rows seen for table) to calculate filtering.
        This greatly simplifies the filtering code in
        JOIN_TAB::save_explain_data().
      
      This change caused a lot of queries to be optimized differently than
      before, which exposed different issues in the optimizer that needs to
      be fixed.  These fixes are in the following commits.  To not have to
      change the same test case over and over again, the changes in the test
      cases are done in a single commit after all the critical change sets
      are done.
      
      InnoDB changes:
      - Updated InnoDB to not divide big range cost with 2.
      - Added cost for InnoDB (innobase_update_optimizer_costs()).
      - Don't mark clustered primary key with HA_KEYREAD_ONLY. This will
        prevent that the optimizer is trying to use index-only scans on
        the clustered key.
      - Disabled ha_innobase::scan_time() and ha_innobase::read_time() and
        ha_innobase::rnd_pos_time() as the default engine cost functions now
        works good for InnoDB.
      
      Other things:
      - Added  --show-query-costs (\Q) option to mysql.cc to show the query
        cost after each query (good when working with query costs).
      - Extended my_getopt with GET_ADJUSTED_VALUE which allows one to adjust
        the value that user is given. This is used to change cost from
        microseconds (user input) to milliseconds (what the server is
        internally using).
      - Added include/my_tracker.h  ; Useful include file to quickly test
        costs of a function.
      - Use handler::set_table() in all places instead of 'table= arg'.
      - Added SHOW_OPTIMIZER_COSTS to sys variables. These are input and
        shown in microseconds for the user but stored as milliseconds.
        This is to make the numbers easier to read for the user (less
        pre-zeros).  Implemented in 'Sys_var_optimizer_cost' class.
      - In test_quick_select() do not use index scans if 'no_keyread' is set
        for the table. This is what we do in other places of the server.
      - Added THD parameter to Unique::get_use_cost() and
        check_index_intersect_extension() and similar functions to be able
        to provide costs to called functions.
      - Changed 'records' to 'rows' in optimizer_trace.
      - Write more information to optimizer_trace.
      - Added INDEX_BLOCK_FILL_FACTOR_MUL (4) and INDEX_BLOCK_FILL_FACTOR_DIV (3)
        to calculate usage space of keys in b-trees. (Before we used numeric
        constants).
      - Removed code that assumed that b-trees has similar costs as binary
        trees. Replaced with engine calls that returns the cost.
      - Added Bitmap::find_first_bit()
      - Added timings to join_cache for ANALYZE table (patch by Sergei Petrunia).
      - Added records_init and records_after_filter to POSITION to remember
        more of what best_access_patch() calculates.
      - table_after_join_selectivity() changed to recalculate 'records_out'
        based on the new fields from best_access_patch()
      
      Bug fixes:
      - Some queries did not update last_query_cost (was 0). Fixed by moving
        setting thd->...last_query_cost in JOIN::optimize().
      - Write '0' as number of rows for const tables with a matching row.
      
      Some internals:
      - Engine cost are stored in OPTIMIZER_COSTS structure.  When a
        handlerton is created, we also created a new cost variable for the
        handlerton. We also create a new variable if the user changes a
        optimizer cost for a not yet loaded handlerton either with command
        line arguments or with SET
        @@global.engine.optimizer_cost_variable=xx.
      - There are 3 global OPTIMIZER_COSTS variables:
        default_optimizer_costs   The default costs + changes from the
                                  command line without an engine specifier.
        heap_optimizer_costs      Heap table costs, used for temporary tables
        tmp_table_optimizer_costs The cost for the default on disk internal
                                  temporary table (MyISAM or Aria)
      - The engine cost for a table is stored in table_share. To speed up
        accesses the handler has a pointer to this. The cost is copied
        to the table on first access. If one wants to change the cost one
        must first update the global engine cost and then do a FLUSH TABLES.
        This was done to be able to access the costs for an open table
        without any locks.
      - When a handlerton is created, the cost are updated the following way:
        See sql/keycaches.cc for details:
        - Use 'default_optimizer_costs' as a base
        - Call hton->update_optimizer_costs() to override with the engines
          default costs.
        - Override the costs that the user has specified for the engine.
        - One handler open, copy the engine cost from handlerton to TABLE_SHARE.
        - Call handler::update_optimizer_costs() to allow the engine to update
          cost for this particular table.
        - There are two costs stored in THD. These are copied to the handler
          when the table is used in a query:
          - optimizer_where_cost
          - optimizer_scan_setup_cost
      - Simply code in best_access_path() by storing all cost result in a
        structure. (Idea/Suggestion by Igor)
      b66cdbd1
    • Sergei Petrunia's avatar
      590416e2
    • Sergei Petrunia's avatar
      6d179ad1
    • Michael Widenius's avatar
      Fixed some issues with FORCE INDEX · 33fc8037
      Michael Widenius authored
      Added code to support that force index can be used to force an index scan
      instead of a full table scan. Currently this code is disable but I added
      a test to verify that things works if the code is ever enabled.
      
      Other things:
      
      - FORCE INDEX will now work with "Range checked for each record" and
        join cache (see main/type_time_6065)
      - Removed code ifdef with BAD_OPTIMIZATION (New cost calculations should
        fix this).
      - Removed TABLE_LIST->force_index and comment that it should be removed
      - Added TABLE->force_index_join and use in the corresponding places.
        This means that FORCE INDEX FOR ORDER BY will not affect keys used
        in joins anymore.
        Remove TODO that the above should be added.
        I still kept TABLE->force_index as it's used in
        test_if_cheaper_ordering() and opt_range.cc
      - Removed setting table->force_index when calling test_quick_select() as
        it's not needed (force_index is an argument to test_quick_select())
      33fc8037
    • Monty's avatar
      Fix cost calculation in test_if_cheaper_ordering() to be cost based · 013ba37a
      Monty authored
      The original code was mostly rule based and preferred clustered or
      covering indexed independent of cost.
      
      There where a few test changes:
      - Some test changed from using filesort to index or table scan. This
        happened when most of the rows had to be sorted and the ORDER BY could
        use covering or a clustered index (innodb_mysql, create_spatial_index).
      - Some test changed range to filesort. This where mainly because the range
        was scanning most of the rows or using index scan + row lookup and
        filesort with table scan is cheaper. (order_by).
      - Change in join_cache was because sorting 2 rows is faster than retrieving
        10 rows.
      - In selectivity_innodb.test one test changed to use a cheaper index.
      013ba37a
    • Vicențiu Ciorbaru's avatar
      Implement cost_of_filesort() · 59193ef6
      Vicențiu Ciorbaru authored
      The sort length is extracted similarly to how sortlength() function does
      it. The function makes use of filesort_use_addons function to compute
      the length of addon fields. Finally, by calling compute_sort_costs we
      get the fastest_sort possible.
      
      Other changes:
      * Sort_param::using_addon_fields() assumes addon fields are already
        allocated. This makes the use of Sort_param unusable for
        compute_sort_costs *if* we don't want to allocate addon fields.
      
        As a preliminary fix, pass "with_addon_fields" as bool value to
        compute_sort_costs() and make the internal functions use that value
        instead of Sort_param::using_addon_fields() method.
      
        The ideal fix would be to define a "leaner" struct with only the
        necessary members, but this can be done as a separate commit.
      
      Reviewer: Monty
      59193ef6
    • Vicențiu Ciorbaru's avatar
      Refactor Sort_param::init_for_filesort · b7029086
      Vicențiu Ciorbaru authored
      No logic changes.
      Extract some of init_for_filesort logic into a separate function:
      * Sort_param::setup_lengths_and_limit can be used to fill in the various
        xxx_length members of Sort_param, without having to allocate any of the
        other buffers.
      
      Reviewer: Monty
      b7029086
    • Vicențiu Ciorbaru's avatar
      Rewrite cost computation for filesort operations · 50e9f7ae
      Vicențiu Ciorbaru authored
      This is a rework of how filesort calculates costs to allow functions
      like test_if_skip_sort_order() to calculate the cost of filesort to
      decide between filesort and using a key to resolve ORDER BY.
      
      Changes:
      - Split cost calculation of qsort + optional merge sort and priority queue
        to dedicated functions.
      - Fixed some wrong calculations of cost in old code (use of log() instead
        of log2()).
      - Added costs realted to fetching the rows if addon fields are not used.
      - Updated get_merge_cost() to take into account that we are going to
        read data from temporary files in big chuncks (DISK_CHUNCK_SIZE (64K) and
        not in IO_SIZE (4K).
      - More code documentation including various variables in Sort_param.
      
      One effect of the cost update is that the cost of priority queue
      with addon field has decreased slightly and is used in more cases.
      When the rowid is large (like with InnoDB where rowid is the priority key),
      using addon fields is in many cases preferable.
      
      Reviewer: Monty
      50e9f7ae
    • Vicențiu Ciorbaru's avatar
      cleanup: Don't pass THD to get_merge_many_buff_cost_fast · 06be2c64
      Vicențiu Ciorbaru authored
      We can pass the cost directly.
      
      Reviewer: Monty
      06be2c64
    • Vicențiu Ciorbaru's avatar
      cleanup: Make tempfile creation uniform with DISK_CHUNK_SIZE · ca2851d1
      Vicențiu Ciorbaru authored
      Replace READ_RECORD_SIZE and DISK_BUFFER_SIZE (renamed to
      DISK_CHUNK_SIZE) to be used across all open_cached_file calls.
      
      Reviewer: Monty
      ca2851d1
    • Vicențiu Ciorbaru's avatar
      cleanup: Rename Sort_param::max_rows to limit_rows · fa90ac61
      Vicențiu Ciorbaru authored
      This makes the code easier to read as the intent of the parameter is
      clearer.
      
      Reviewer: Monty
      fa90ac61
    • Monty's avatar
      Added checking of arguments to COST_ADD and COST_MULT · 488148dd
      Monty authored
      These functions don't work with negative values and should never be
      called with negative values. Added an assert to ensure this will
      not happen.
      488148dd
    • Monty's avatar
      Adjust cost for re-creating a row from the JOIN CACHE · 07df2029
      Monty authored
      Creating a record from the join cache is faster than getting a row from
      the engine (less and simpler code to execute).
      
      Added JOIN_CACHE_ROW_COPY_COST_FACTOR (0.5 for now) as the factor to
      take this into account. This is multiplied with ROW_COPY_COST.
      
      Other things:
      - Added cost of copying rows to hash join, similar to join_cache joins.
      07df2029
    • Monty's avatar
      Fixed cost calculations for materialized tables · 4515a898
      Monty authored
      One effect of this change in the test suite is that tests with very few
      rows changed to use sub queries instead of materialization. This is
      correct and expected as for these the materialization overhead is too high.
      
      A lot of tests where fixed to still use materialization by adding a
      few rows to the tables (most tests has only 2-3 rows and are thus easily
      affected when cost computations are changed).
      
      Other things:
      - Added more variables to TMPTABLE_COSTS for better cost calculation
      - Added cost of copying rows to TMPTABLE_COSTS lookup and write
      - Added THD::optimizer_cache_hit_ratio for easier cost calculations
      - Added DISK_FAST_READ_SIZE to be used when calculating costs when
        reading big blocks from a disk
      4515a898
    • Monty's avatar
      Move join->emb_smj_nest setting to choose_plan() · 1d82e5da
      Monty authored
      This cleans up the interface for choose_plan() as it is not depending
      on setting join->emb_sj_nest.
      
      choose_plan() now sets up join->emb_sj_nest and join->allowed_tables before
      calling optimize_straight_join() and best_extension_by_limited_search().
      
      Other things:
      - Converted some 'if' to DBUG_ASSERT() as these should always be true.
      - Calculate 'allowed_tables' in choose_plan() as this never changes in
        the childs.
      - Added assert to check that next_emb->nested_join->n_tables doesn't
        get to a wrong value.
      - Documented some variables in sql_select.h
      1d82e5da
    • Sergei Petrunia's avatar
      249475b9
    • Monty's avatar
    • Monty's avatar
      Derived tables and union can now create distinct keys · 5e5a8eda
      Monty authored
      The idea is that instead of marking all select_lex's with DISTINCT, we
      only mark those that really need distinct result.
      
      Benefits of this change:
      - Temporary tables used with derived tables, UNION, IN are now smaller
        as duplicates are removed already on the insert phase.
      - The optimizer can now produce better plans with EQ_REF. This can be
        seen from the tests where several queries does not anymore materialize
        derived tables twice.
      - Queries affected by 'in_predicate_conversion_threshold' where large IN
        lists are converted to sub query produces better plans.
      
      Other things:
      - Removed on duplicate call to sel->init_select() in
        LEX::add_primary_to_query_expression_body()
      - I moved the testing of
        tab->table->pos_in_table_list->is_materialized_derived()
        in join_read_const_table() to the caller as it caused problems for
        derived tables that could be proven to be const tables.
        This also is likely to fix some bugs as if join_read_const_table()
        was aborted, the table was left marked as JT_CONST, which cannot
        be good.  I added an ASSERT there for now that can be removed when
        the code has been properly tested.
      5e5a8eda
    • Monty's avatar
      Fixed crashing bug in create_internal_tmp_table_from_heap() · 868d577c
      Monty authored
      An assert/crash could happen if newtable.alias would be reallocated,
      (for example if newtable.alias.safe_c_ptr() was called) when doing
      *table= newtable.
      Fixed by ensuring that we keep the original state of the alias in 'table'.
      868d577c
    • Monty's avatar
      Add test cases for MDEV-20595 and MDEV-21633 to show these are solved · 2d70ff42
      Monty authored
      MDEV-21633 Assertion `tmp >= 0' failed in best_access_path with
                 rowid_filter=ON
      MDEV-20595 Assertion `0 < sel && sel <= 2.0' failed in
                 table_cond_selectivity
      2d70ff42
    • Monty's avatar
      Added 'records_out' and join_type to POSITION · 2387ee9b
      Monty authored
      records_out is the numbers of rows expected to be accepted from a table.
      records_read is in contrast the number of rows that the optimizer excepts
      to read from the engine.
      
      This patch causes not plan changes. The differences in test results comes
      from renaming "records" to "records_read" and printing of record_out in
      the optimizer trace.
      
      Other things:
      - Renamed table_cond_selectivity() to table_after_join_selectivity()
        to make the purpose of the function more clear.
      2387ee9b
    • Monty's avatar
      Align elements in struct system_variables · 9db877c9
      Monty authored
      This reduces the size of THD from 1128 to 1104 (24 bytes)
      Note much but will still save some memory accesses
      9db877c9
    • Sergei Petrunia's avatar
    • Monty's avatar
      Make the most important optimizer constants user variables · 5e651c9a
      Monty authored
      Variables added:
      - optimizer_index_block_copy_cost
      - optimizer_key_copy_cost
      - optimizer_key_next_find_cost
      - optimizer_key_compare_cost
      - optimizer_row_copy_cost
      - optimizer_where_compare_cost
      
      Some rename of defines was done to make the internal defines similar to
      the visible ones:
      TIME_FOR_COMPARE -> WHERE_COST; WHERE_COST was also "inverted" to be
      a number between 0 and 1 that is multiply with accepted records
      (similar to other optimizer variables).
      TIME_FOR_COMPARE_IDX -> KEY_COMPARE_COST. This is also inverted,
      similar to TIME_FOR_COMPARE.
      TIME_FOR_COMPARE_ROWID -> ROWID_COMPARE_COST. This is also inverted,
      similar to TIME_FOR_COMPARE.
      
      All default costs are identical to what they where before this patch.
      
      Other things:
      - Compare factor in get_merge_buffers_cost() was inverted.
      - Changed namespace to static in filesort_utils.cc
      5e651c9a