1. 14 Dec, 2011 3 commits
  2. 12 Dec, 2011 4 commits
  3. 08 Dec, 2011 2 commits
    • unknown's avatar
      Bug #13116225 LIVE DOWNGRADE CRASHES WITH INNODB_PAGE_SIZE=4K · 8e198589
      unknown authored
      This bug ensures that a live downgrade from an InnoDB 5.6 with WL5756 and
      a database created with innodb-page-size=8k or 4k will make a version 5.5
      installation politely refuse to start. Instead of crashing or giving some
      indication about a corrupted database, it will indicate the page size
      difference. 
      
      This patch takes only that part of the Wl5756 patch that is needed to
      protect against opening a tablespace that is stamped with a different
      page size.
      
      It also contains the change in dict_index_find_on_id_low() just in case
      a database with another page size is created by recompiling a pre-WL5756
      InnoDB.
      8e198589
    • Jimmy Yang's avatar
      Fix Bug #13083023 - 60229: BROKEN COMPATIBILITY: ERROR WHILE CREATE TABLE · 9b42c9b9
      Jimmy Yang authored
      WITH FOREIGN KEY CONSTRAI
      
      rb://844 approved by marko
      9b42c9b9
  4. 07 Dec, 2011 1 commit
    • Inaam Rana's avatar
      Bug#11759044 - 51325: DROPPING AN EMPTY INNODB TABLE TAKES A LONG TIME · c0bddb52
      Inaam Rana authored
      WITH LARGE BUFFER POOL
      
      (Note: this a backport of revno:3472 from mysql-trunk)
      
      rb://845
      approved by: Marko
      
        When dropping a table (with an .ibd file i.e.: with
        innodb_file_per_table set) we scan entire LRU to invalidate pages from
        that table. This can be painful in case of large buffer pools as we hold
        the buf_pool->mutex for the scan. Note that gravity of the problem does
        not depend on the size of the table. Even with an empty table but a
        large and filled up buffer pool we'll end up scanning a very long LRU
        list.
        
        The fix is to scan flush_list and just remove the blocks belonging to
        the table from the flush_list, marking them as non-dirty. The blocks
        are left in the LRU list for eventual eviction due to aging. The
        flush_list is typically much smaller than the LRU list but for cases
        where it is very long we have the solution of releasing the
        buf_pool->mutex after scanning 1K pages.
        
        buf_page_[set|unset]_sticky(): Use new IO-state BUF_IO_PIN to ensure
        that a block stays in the flush_list and LRU list when we release
        buf_pool->mutex. Previously we have been abusing BUF_IO_READ to achieve
        this.
      c0bddb52
  5. 05 Dec, 2011 1 commit
    • Tor Didriksen's avatar
      Bug#13013970 MORE CRASHES IN FIELD_BLOB::GET_KEY_IMAGE · 1d5607fc
      Tor Didriksen authored
      The predicate is re-written from
      ((`test`.`g1`.`a` = geometryfromtext('')) or ...
      to
      ((`test`.`g1`.`a` = <cache>(geometryfromtext(''))) or ...
      
      The range optimizer calls save_in_field_no_warnings, in order to fetch keys.
      save_in_field_no_warnings returns 0 because of the cache wrapper,
      and get_mm_leaf() proceeded to call Field_blob::get_key_image() 
      which accesses un-initialized data.
      
      
      
      
      mysql-test/r/gis.result:
        New test case.
      mysql-test/t/gis.test:
        New test case.
      sql/item.cc:
        If we have cached a null_value, then verify that the Field can accept it.
      1d5607fc
  6. 02 Dec, 2011 2 commits
  7. 01 Dec, 2011 4 commits
  8. 30 Nov, 2011 5 commits
  9. 29 Nov, 2011 6 commits
    • Andrei Elkin's avatar
    • Andrei Elkin's avatar
      Bug#13437900 - VALGRIND REPORTS A LEAK FOR REPL_IGNORE_SERVER_IDS · ca128143
      Andrei Elkin authored
      There was memory leak when running some tests on PB2.
      The reason of the failure is an early return from change_master()
      that was supposed to deallocate a dyn-array.
      
      Fixed with relocating the dyn-array's destructor at ~LEX() that is
      the end of the session, per Gleb's patch idea.
      Two optimizations were done: the static buffer for the dyn-array to base on,
      and the array initialization is called precisely when it's necessary rather than
      per each CHANGE-MASTER as before.
       
      
      mysql-test/suite/rpl/t/rpl_empty_master_host.test:
        the test is binlog-format insensitive so it will be run with MIXED mode only.
      sql/sql_lex.cc:
        the new flag is initialized.
      sql/sql_lex.h:
        A new bool flag new member to LEX.mi is added to stay UP since after
        LEX.mi.repl_ignore_server_ids dynarray initialization was called
        for the first time on the session. So it is set once and its life time 
        is session.
        
        The array is destroyed at the end of the session.
      sql/sql_repl.cc:
        dyn-array destruction is relocated to ~LEX.
      sql/sql_yacc.yy:
        Refining logics of Lex->mi.repl_ignore_server_ids initialization.
        The array is initialized once a corresponding option in CHANGE MASTER token sequence
        is found.
        The fact of initialization is memorized into the new flag.
      ca128143
    • Tor Didriksen's avatar
      Build broken for gcc 4.5.1 in optimized mode. · 4775084b
      Tor Didriksen authored
      readline.cc: In function char* batch_readline(LINE_BUFFER*):
      readline.cc:60:9: error: out_length may be used uninitialized in this function
      log.cc: In function int find_uniq_filename(char*):
      log.cc:1857:8: error: number may be used uninitialized in this function
      4775084b
    • Luis Soares's avatar
      BUG#11745230 · d896e623
      Luis Soares authored
      Automerged approved bzr bundle into latest mysql-5.5.
      d896e623
    • Nirbhay Choubey's avatar
      d40db893
    • Nirbhay Choubey's avatar
      Bug#11756764 48726: MYSQLD KEEPS CRASHING WITH SIGSEGV · 11b2a2fe
      Nirbhay Choubey authored
                          WITH MYISAM_USE_MMAP ENABLED
      
      MySQL server can crash due to segmentation fault when
      started with myisam_use_mmap.
      
      The reason behind this being, while making a request to
      unmap (munmap) the previously mapped memory (mmap), the
      size passed was 7 bytes larger than the size requested at
      the time of mapping. This can eventually unmap the adjacent
      memory mapped block, belonging to some other memory-map pool.
      Hence the subsequent call to mmap can map a region which was
      still a valid memory mapped area.
      
      Fixed by removing the extra 7-byte margin which was erroneously
      added to the size, used for unmappping.
      
      
      storage/myisam/mi_close.c:
        Bug#11756764 48726: MYSQLD KEEPS CRASHING WITH SIGSEGV
                            WITH MYISAM_USE_MMAP ENABLED
        
        Added a condition to call _mi_unmap_file() in case
        of compressed records. mi_munmap_file() is called
        otherwise.
      storage/myisam/mi_packrec.c:
        Bug#11756764 48726: MYSQLD KEEPS CRASHING WITH SIGSEGV
                            WITH MYISAM_USE_MMAP ENABLED
        
        mi_dynmap_file() function, after successfully executing
        mmap, stores the total size in info->s->mapped_length
        variable. Now, if mi_dynmap_file() is invoked with a size
        with an extra 7-byte margin (MEMMAP_EXTRA_MARGIN),
        the margin will eventually also get stored in mapped_length.
        So, un-mapping function can simply use the value stored in
        mapped_length in order to unmap the previously mapped
        region.
      11b2a2fe
  10. 24 Nov, 2011 3 commits
    • Luis Soares's avatar
      BUG#11745230: 12133: MASTER.INDEX FILE KEEPS MYSQLD FROM STARTING IF · 52935833
      Luis Soares authored
                    BIN LOG HAS BEEN MOVED 
      
      When moving the binary/relay log files from one location to
      another and restarting the server with a different log-bin or
      relay-log paths, would cause the startup process to abort. The
      root cause was that the server would not be able to find the log
      files because it would consider old paths for entries in the
      index file instead of the new location.  What's even worse, the
      relative paths would not be considered relative to the path
      provided in log-bin and relay-log, but to mysql_data_dir.
            
      We fix the cases where the server contains relative paths. When
      the server is reading from the index file, it checks whether the
      entry contains relative paths. If it does, we replace it with the
      absolute path set in log-bin/relay-log option. Absolute paths
      remain unchanged and the index must be manually edited to
      consider the new log-bin and/or relay-log path (this should be
      documented). This is a fix for a GA version, that does not break
      behavior (that much).
            
      For development versions, we should go with Zhenxing's approach 
      that removes paths altogether from index files.
      
      mysql-test/include/begin_include_file.inc:
        Added parameter to keep the begin_include_file.inc silent. Useful when 
        including scripts that contain platform dependent parameters, for example:
        
        --let $rpl_server_parameters=--log-bin=$tmpdir/slave-bin --relay-log=$tmpdir/slave-relay-bin
        --let $keep_include_silent=1
        source include/rpl_start_server.inc;
        --let $keep_include_silent=0
        
        We want the paths ($tmpdir/slave-bin and $tmpdir/slave-relay-bin) not to be in the 
        result file.
      mysql-test/suite/rpl/t/rpl_binlog_index.test:
        Test case.
      sql/log.cc:
        When finding the corresponding log entry in the index file, we first 
        normalize the paths before doing the comparison. This will make relative
        paths to be turned into absolute paths (based on the opt_bin_logname or
        opt_relay_logname) and then compared against also, expanded paths entered, 
        through CHANGE MASTER for instance.
      sql/log.h:
        Added normalize_binlog_name, which turns relative paths, into absolute paths
        given the parameter: is_relay_log ? opt_relay_logname : opt_bin_logname .
      sql/mysqld.cc:
        Exposing opt_bin_logname.
      sql/mysqld.h:
        Exposing opt_bin_logname.
      52935833
    • Luis Soares's avatar
      BUG#13427949 · 6818c8ba
      Luis Soares authored
      Automerged against latest mysql-5.5.
      6818c8ba
    • Luis Soares's avatar
      BUG#13427949: CHANGE MASTER TO USER='' (EMPTY USER) CAUSES ERRORS ON VALGRING · 20736851
      Luis Soares authored
        
      When passing an empty user to the connect function will cause
      valgrind warnings. Seems that the client code is not prepared 
      to handle empty users. On 5.6 this can even be triggered by 
      START SLAVE PASSWORD='...'; i.e., without setting USER='...' on
      the START SLAVE command (see WL#4143 for details on the new
      additional START SLAVE commands).
        
      To fix this, we disallow empty users when configuring the slave
      connection parameters (this decision might be revisited if the 
      client code accepts empty users in the future).
      
      sql/slave.cc:
        We throw an error if an empty user is supplied to the connection 
        function.
      20736851
  11. 23 Nov, 2011 3 commits
  12. 22 Nov, 2011 2 commits
  13. 21 Nov, 2011 1 commit
  14. 22 Nov, 2011 2 commits
  15. 21 Nov, 2011 1 commit
    • Sneha Modi's avatar
      Bug#11748731:SOME 'BIG' TESTS FAILING ON 6.0 · fe97bc3a
      Sneha Modi authored
      A patch for alter_table-big.test has been committed earlier.
      This is a patch for create-big.test:
      The test used to time-out after 900 seconds. 
      It relied on debug sleeps that are no longer present in the 
      code. Since the sleeps are long gone, fixing the problem didn't 
      involve just updating the result file or using macro 
      "show_binlog_events2.inc" instead of "show binlog events" 
      statement. The test needed to be rewritten using debug sync 
      points, and result then needed to be updated.
      So, the sleeps have been replaced by debug_sync points and the test execution time has 
      been reduced significantly.
      fe97bc3a