- 26 Apr, 2018 2 commits
-
-
Marko Mäkelä authored
MariaDB uses HAVE_LZO, not HAVE_LZO1X (which was never defined). Also, the variable srv_lzo_disabled was never defined or read (only declared and assigned to, in unreachable code).
-
Marko Mäkelä authored
The InnoDB system table column SYS_TABLES.MIX_LEN was repurposed in InnoDB Plugin for MySQL 5.1, in commit 91111174 (MySQL 5.1.46). Until MySQL 5.6, it only contained a flag DICT_TF2_TEMPORARY. MySQL 5.6 introduced a number of flags that were transient in nature. One of these was introduced in 5.6.5, originally called DICT_TF2_USE_TABLESPACE and later renamed to DICT_TF2_USE_FILE_PER_TABLE. MySQL 5.7.6 introduced logic that insists that the flag be set for any table that does not reside in a shared tablespace, breaking upgrade from MySQL 5.5. MariaDB does not support shared tablespaces other than the InnoDB system tablespace. Also, some dependencies on SYS_TABLES.MIX_LEN were removed in an earlier fix: MDEV-13084 MariaDB 10.2 crashes on corrupted SYS_TABLES.MIX_LEN field (commit e813fe86). dict_check_sys_tables(): Remove a bogus debug assertion, and add a comment that explains how DICT_TF2_USE_FILE_PER_TABLE is used. dict_table_is_file_per_table(): Remove a bogus debug assertion.
-
- 24 Apr, 2018 10 commits
-
-
Igor Babaev authored
It has been done to demonstrate that the fix of this bug is good for 10.3 as well. The previous test case is not good for this purpose because 10.2 and 10.3 use different rules for determining the types of recursive CTEs.
-
Marko Mäkelä authored
Pool::mem_free(): Poison the freed memory. Assert that it was fully initialized, because the reuse of trx_t objects will assume that the objects were previously initialized. Pool::~Pool(), Pool::get(): Unpoison the allocated memory, and mark it initialized. trx_free(): After invoking Pool::mem_free(), unpoison trx_t::mutex and trx_t::undo_mutex, because MutexMonitor will access these even for freed trx_t objects.
-
Marko Mäkelä authored
-
Eugene Kosov authored
-
Marko Mäkelä authored
Modern compilers (such as GCC 8) emit warnings that the 'register' keyword is deprecated and not valid C++17. Let us remove most use of the 'register' keyword. Code in 'extra/' is not touched.
-
Marko Mäkelä authored
-
Marko Mäkelä authored
Apply the contributed patch from MySQL Bug #89126 create table panic on innobase_parse_hint_from_comment by Yan Huang.
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
xb_assign_undo_space_start(): Correctly pass the length of the buffer, so that the file name will not be truncated.
-
- 23 Apr, 2018 9 commits
-
-
Marko Mäkelä authored
dict_load_table_low(): When flagging an error, assign *table = NULL. Failure to do so could cause a crash if an error was flagged when accessing INFORMATION_SCHEMA.INNODB_SYS_TABLES.
-
Jan Lindström authored
MDEV-15948 Fix error "Lost connection to MySQL server..." in test gal…
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
While the test case crashes a MariaDB 10.2 debug build only, let us apply the fix to the earliest applicable MariaDB series (10.0) to avoid any data corruption on a table-rebuilding ALTER TABLE using ALGORITHM=INPLACE. innobase_create_key_defs(): Use altered_table->s->primary_key when a new primary key is being created.
-
Daniele Sciascia authored
* Increased timeout counter in galera_wait_ready.inc * Replaced useless include/wait_until_ready.inc after start_mysqld.inc in galera_st_*.inc with wait_condition on cluster size.
-
Marko Mäkelä authored
-
Thirunarayanan Balathandayuthapani authored
MDEV-15374 Server hangs and aborts with long semaphore wait or assertion `len < ((ulint) srv_page_size)' fails in trx_undo_rec_copy upon ROLLBACK on temporary table Problem: ======= InnoDB cleans all temporary undo logs during commit. During rollback of secondary index entry, InnoDB tries to build the previous version of clustered index. It leads to access of freed undo page during previous transaction commit and it leads to undo log corruption. Solution: ========= During rollback, temporary undo logs should not try to build the previous version of the record.
-
Jan Lindström authored
MDEV-15929 Fix lock wait timeout on `SELECT @@GLOBAL.WSREP_ON`
-
- 21 Apr, 2018 3 commits
-
-
Marko Mäkelä authored
-
Sergei Golubchik authored
followup for a3c980b3 same change in Locked_tables_list::unlink_from_list(), otherwise thd->locked_tables_list will keep pointers to a free'd TABLE if prelocked under lock tables. This fixes a crash in main.create_or_replace on debug Win builds after bcb36ee2
-
Marko Mäkelä authored
-
- 20 Apr, 2018 5 commits
-
-
Sergei Golubchik authored
do_stmt_close() is embedded-aware. this fixes the failure of innodb.innodb_bug48024 --ps --embed
-
Daniele Sciascia authored
Test galera_sst_mysqldump often fails with error "2013: Lost connection to MySQL server during query". The connection is lost after the test restart one of the nodes. This happens because the server closes client connections if it is joining a cluster through SST method mysqldump. On unlucky runs of the test it is possible that mysqld is restarted, and then mtr client is disconnected while it tries to determine if galera is ready before going on with the test. This patch rewrites galera_wait_ready.inc so that it is immune to being disconnected.
-
Sergei Golubchik authored
-
Sergei Golubchik authored
MDEV-15456 Server crashes upon adding or dropping a partition in ALTER under LOCK TABLE after ER_SAME_NAME_PARTITION ALTER TABLE ... ADD PARTITION modifies the open TABLE structure, and sets table->need_reopen=1 to reset these modifications in case of an error. But under LOCK TABLES the table isn't get reopened, despite need_reopen. Fixed by reopening need_reopen tables under LOCK TABLE.
-
Sergei Golubchik authored
bad merge
-
- 19 Apr, 2018 9 commits
-
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
Sergei Golubchik authored
in a specially crafted invalid packet, one can get end_pos < pos here
-
Sergei Golubchik authored
disable online alter add primary key for innodb, if the table is opened/locked more than once in the current connection (see assert in ha_innobase::add_index())
-
Sergei Golubchik authored
test case
-
Sergei Golubchik authored
-
Sergei Petrunia authored
MyRocks internally will print non-critical messages to sql_print_verbose_info() which will do what InnoDB does in similar cases: check if (global_system_variables.log_warnings > 2).
-
Sachin Setiya authored
slave node killed himself. Problem:- If we try to delete table with foreign key and table whom it is referring with wsrep_slave_threads>1 then galera tries to execute both Delete_rows_log-event in parallel, which should not happen. Solution:- This is happening because we do not have foreign key info in write set. Upto version 10.2.7 it used to work fine. Actually it happening because of issue in commit 2f342c45. wsrep_must_process_fk has changed to make it similar to original condition.
-
Daniele Sciascia authored
This patch fixes a lock wait timeout error on `SELECT @@GLOBAL.WSREP_ON` in `wait_wsrep_ready.inc`: ``` --connection node_2 ... --source include/kill_galera.inc --connection node_1 --source include/wait_until_connected_again.inc # This includes wait_wsrep_ready.inc ``` The problem is that on node_2, kill_galera.inc may return before the node is killed. So node_1 may still see that node_1 is alive and will attempt to sync wait when doing those `SELECT` statements. But sync wait is doomed to fail given that node_1 is killed, hence the lock wait timeout. One possible fix is to disable wsrep_sync_wait before including wait_until_connected_again. However, it appears that including wait_until_connected_again is not necessary at all in node_1, so this patch removes it altogether.
-
- 18 Apr, 2018 2 commits
-
-
Thirunarayanan Balathandayuthapani authored
- If select query chooses the index 'b' over clustered index then the issue can happen. Changed the test case to use primary index for the select query.
-
Thirunarayanan Balathandayuthapani authored
- During rollback, redo segments priorities over no-redo rollback segments and it leads to failure of redo rollback segment undo logs truncation.
-