1. 21 May, 2009 13 commits
    • Alexey Kopytov's avatar
      Automerge. · 6ffa3c6b
      Alexey Kopytov authored
      6ffa3c6b
    • Alexey Kopytov's avatar
      Automerge. · 7acfe3bd
      Alexey Kopytov authored
      7acfe3bd
    • Alexey Kopytov's avatar
      Attempt #2 to fix PB failures introduced by the patch for bug #44796. · e39ba045
      Alexey Kopytov authored
      Since max_allowed_packet is a read-only variable in 5.1 and up,
      disable warnings to avoid unnecessary test case complication.
      e39ba045
    • Alexey Kopytov's avatar
      Automerge. · 14a3a02b
      Alexey Kopytov authored
      14a3a02b
    • Alexey Kopytov's avatar
      Automerge. · 95a1439a
      Alexey Kopytov authored
      95a1439a
    • Alexey Kopytov's avatar
      Fixed a PB failure introduced by the patch for bug #44796. · 7fe1db37
      Alexey Kopytov authored
      Set max_allowed_packet to get a consistent error message.
      7fe1db37
    • Alexey Kopytov's avatar
      Automerge. · 71cdad93
      Alexey Kopytov authored
      71cdad93
    • Alexey Kopytov's avatar
      Automerge. · 93d0483e
      Alexey Kopytov authored
      93d0483e
    • Alexey Kopytov's avatar
      Automerge. · bc72b431
      Alexey Kopytov authored
      bc72b431
    • Alexey Kopytov's avatar
      Automerge. · 4d2c428c
      Alexey Kopytov authored
      4d2c428c
    • Ramil Kalimullin's avatar
      Auto-merge. · 319f998c
      Ramil Kalimullin authored
      319f998c
    • Alfranio Correia's avatar
      882038ee
    • Ramil Kalimullin's avatar
      Fix for bug#44743: Join in combination with concat does not always work · 3d7601ae
      Ramil Kalimullin authored
              bug#44766: valgrind error when using convert() in a subquery
      
      Problem: input and output buffers may be the same 
      converting a string to some charset. 
      That may lead to wrong results/valgrind warnings.  
      
      Fix: use different buffers.
      
      
      mysql-test/r/cast.result:
        Fix for bug#44743: Join in combination with concat does not always work
                bug#44766: valgrind error when using convert() in a subquery
          - test result.
      mysql-test/r/func_concat.result:
        Fix for bug#44743: Join in combination with concat does not always work
                bug#44766: valgrind error when using convert() in a subquery
          - test result.
      mysql-test/t/cast.test:
        Fix for bug#44743: Join in combination with concat does not always work
                bug#44766: valgrind error when using convert() in a subquery
          - test case.
      mysql-test/t/func_concat.test:
        Fix for bug#44743: Join in combination with concat does not always work
                bug#44766: valgrind error when using convert() in a subquery
          - test case.
      sql/item.cc:
        Fix for bug#44743: Join in combination with concat does not always work
                bug#44766: valgrind error when using convert() in a subquery
          - comment added.
      sql/item_strfunc.cc:
        Fix for bug#44743: Join in combination with concat does not always work
                bug#44766: valgrind error when using convert() in a subquery
          - '&args[0]->str_value' used as a parameter of args[0]->val_str(),
            as 'str' may be equal to 'str_value' which we use as the output buffer
            converting strings.
      sql/sql_string.cc:
        Fix for bug#44743: Join in combination with concat does not always work
                bug#44766: valgrind error when using convert() in a subquery
          - input and output buffers must NOT be the same.
      3d7601ae
  2. 20 May, 2009 9 commits
  3. 19 May, 2009 1 commit
    • Sergey Glukhov's avatar
      Bug#39793 Foreign keys not constructed when column has a '#' in a comment or default value · b51ebe25
      Sergey Glukhov authored
      Internal InnoDN FK parser does not recognize '\'' as quotation symbol.
      Suggested fix is to add '\'' symbol check for quotation condition
      (dict_strip_comments() function).
      
      
      innobase/dict/dict0dict.c:
        Internal InnoDN FK parser does not recognize '\'' as quotation symbol.
        Suggested fix is to add '\'' symbol check for quotation condition
        (dict_strip_comments() function).
      mysql-test/r/innodb_mysql.result:
        test result
      mysql-test/t/innodb_mysql.test:
        test case
      b51ebe25
  4. 18 May, 2009 2 commits
    • Gleb Shchepa's avatar
      Bug#40825: Error 1356 while selecting from a view · 2d55cc51
      Gleb Shchepa authored
                 with a "HAVING" clause though query works
      
      SELECT from views defined like:
      
        CREATE VIEW v1 (view_column)
          AS SELECT c AS alias FROM t1 HAVING alias
      
      fails with an error 1356:
        View '...' references invalid table(s) or column(s)
        or function(s) or definer/invoker of view lack rights
        to use them
      
      
      CREATE VIEW form with a (column list) substitutes
      SELECT column names/aliases with names from a
      view column list.
      However, alias references in HAVING clause was
      not substituted.
      
      
      The Item_ref::print function has been modified
      to write correct aliased names of underlying
      items into VIEW definition generation/.frm file.
      
      
      mysql-test/r/view.result:
        Added test file for bug #40825.
      mysql-test/t/view.test:
        Added test file for bug #40825.
      sql/item.cc:
        Bug#40825: Error 1356 while selecting from a view
                   with a "HAVING" clause though query works
        
        The Item_ref::print function has been modified
        to write correct aliased names of underlying
        items into VIEW definition generation/.frm file.
      2d55cc51
    • Gleb Shchepa's avatar
      Bug #44768: SIGFPE crash when selecting rand from a view containing null · 4054d13f
      Gleb Shchepa authored
      The RAND(N) function where the N is a field of "constant" table
      (table of single row) failed with a SIGFPE.
      
      Evaluation of RAND(N) rely on constant status of its argument.
      Current server "seeded" random value for each constant argument
      only once, in the Item_func_rand::fix_fields method.
      Then the server skipped a call to seed_random() in the
      Item_func_rand::val_real method for such constant arguments.
      
      However, non-constant state of an argument may be changed
      after the call to fix_fields, if an argument is a field of
      "constant" table. Thus, pre-initialization of random value
      in the fix_fields method is too early.
      
      
      Initialization of random value by seed_random() has been
      removed from Item_func_rand::fix_fields method.
      The Item_func_rand::val_real method has been modified to
      call seed_random() on the first evaluation of this method
      if an argument is a function.
      
      
      mysql-test/r/func_math.result:
        Added test case for bug #44768.
      mysql-test/t/func_math.test:
        Added test case for bug #44768.
      sql/item_func.cc:
        Bug #44768: SIGFPE crash when selecting rand from a view containing null
        
        1. Initialization of random value by seed_random() has been
           removed from Item_func_rand::fix_fields method.
        2. The Item_func_rand::val_real method has been modified to
           call seed_random() on the first evaluation of this method
           if an argument is a function.
      sql/item_func.h:
        Bug #44768: SIGFPE crash when selecting rand from a view containing null
        
        1. The Item_func_rand::first_eval has been added to trace
           the first evaluation of the val_real method.
        2. The Item_func_rand::cleanup method has been added to
           cleanup the first_eval flag.
      4054d13f
  5. 17 May, 2009 3 commits
    • Kristofer Pettersson's avatar
      Bug#19027 MySQL 5.0 starts even with Fatal InnoDB errors · d5b1921d
      Kristofer Pettersson authored
      Fix bug in mtr_cases.pm script visible only when InnoDB isn't configured.
      
      mysql-test/lib/mtr_cases.pm:
        If InnoDB isn't configured the help texts won't show the "innodb" option and mysqld_variables will not contain any "innodb" entry.
      d5b1921d
    • Narayanan V's avatar
      Bug#44856 IBMDB2I gives misleading 2504 error · 0cbabcb8
      Narayanan V authored
      Occasionally, if both the partition_pruning
      and partition_range tests are run sequentially
      against the IBMDB2I engine, the partition_range
      test will fail.
      
      Compiler padding on a 64-bit build allowed
      garbage data in the hash key used for
      caching open iconv descriptors. As a
      result, cached descriptors were not found,
      and multiple duplicate iconv descriptors
      were opened for a single character set.
      Eventually, the maximum number of open
      iconv descriptors was reached, and further
      iconv_open() calls would fail, leading the
      storage engine to report incorrectly that
      the character set was not supported.
      
      This patch widens the 16-bit members of the
      hash key to 32 bits to eliminate compiler
      padding. The entire length of the hash key
      is now initialized correctly on both 32-bit
      and 64-bit builds.
      
      storage/ibmdb2i/db2i_charsetSupport.cc:
        Bug#44856 IBMDB2I gives misleading 2504 error
        
        widen the 16-bit members of the
        hash key to 32 bits to eliminate
        compiler padding.
      0cbabcb8
    • Narayanan V's avatar
      Bug#44610 RCDFMT clause requested when creating DB2 table · 3a854447
      Narayanan V authored
      In order to better support the usage of
      IBMDB2I tables from within RPG programs,
      the storage engine should ensure that the
      RCDFMT name is consistent and predictable
      for DB2 tables.
      
      This patch appends a "RCDFMT <name>"
      clause to the CREATE TABLE statement
      that is passed to DB2.  <name> is
      generated from the original name of
      the table itself. This ensures a
      consistent and deterministic mapping
      from the original table.
      
      For the sake of simplicity only
      the alpha-numeric characters are
      preserved when generating the new
      name, and these are upper-cased;
      other characters are replaced with
      an underscore (_). Following DB2
      system identifier rules, the name
      always begins with an alpha-character
      and has a maximum of ten characters.
      If no usable characters are found in
      the table name, the name X is used.
      
      mysql-test/suite/ibmdb2i/r/ibmdb2i_bug_44610.result:
        Bug#44610 RCDFMT clause requested when creating DB2 table
        
        Result file for the test case.
      mysql-test/suite/ibmdb2i/t/ibmdb2i_bug_44610.test:
        Bug#44610 RCDFMT clause requested when creating DB2 table
        
        Test case that confirms that the names that are being generated are valid.
      storage/ibmdb2i/ha_ibmdb2i.cc:
        Bug#44610 RCDFMT clause requested when creating DB2 table
        
        This patch appends a "RCDFMT <name>"
        clause to the CREATE TABLE statement
        that is passed to DB2.  <name> is
        generated from the original name of
        the table itself. This ensures a
        consistent and deterministic mapping
        from the original table.
      storage/ibmdb2i/ha_ibmdb2i.h:
        Bug#44610 RCDFMT clause requested when creating DB2 table
        
        This patch appends a "RCDFMT <name>"
        clause to the CREATE TABLE statement
        that is passed to DB2.  <name> is
        generated from the original name of
        the table itself. This ensures a
        consistent and deterministic mapping
        from the original table.
      3a854447
  6. 15 May, 2009 12 commits