1. 21 Apr, 2007 3 commits
  2. 20 Apr, 2007 17 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/data0/bk/mysql-5.0 · e06bc9e9
      unknown authored
      into  bk-internal.mysql.com:/data0/bk/mysql-5.0-opt
      
      
      sql/item_cmpfunc.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_show.cc:
        Auto merged
      sql/sql_view.cc:
        Auto merged
      e06bc9e9
    • unknown's avatar
      Merge moonbone.local:/mnt/gentoo64/work/bk-trees/mysql-5.0-opt · 49907421
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/bk-trees/mysql-5.1-opt
      
      
      mysql-test/r/func_str.result:
        Auto merged
      mysql-test/r/key.result:
        Auto merged
      mysql-test/r/row.result:
        Auto merged
      mysql-test/r/subselect.result:
        Auto merged
      mysql-test/r/subselect3.result:
        Auto merged
      mysql-test/r/view.result:
        Auto merged
      mysql-test/t/func_str.test:
        Auto merged
      mysql-test/t/key.test:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/item_cmpfunc.h:
        Auto merged
      sql/item_strfunc.h:
        Auto merged
      sql/item_subselect.h:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_show.cc:
        Auto merged
      sql/sql_view.cc:
        Auto merged
      mysql-test/t/view.test:
        Manually merged
      sql/sql_lex.h:
        Manually merged
      49907421
    • unknown's avatar
      Merge whalegate.ndb.mysql.com:/home/tomas/mysql-5.0 · 7925f977
      unknown authored
      into  whalegate.ndb.mysql.com:/home/tomas/mysql-5.1
      
      
      BitKeeper/deleted/.del-rpl_critical_errors.result:
        Delete: mysql-test/r/rpl_critical_errors.result
      7925f977
    • unknown's avatar
      Added missing result file for rpl_critical_errors. · b7d2d38e
      unknown authored
      
      mysql-test/r/rpl_critical_errors.result:
        New BitKeeper file ``mysql-test/r/rpl_critical_errors.result''
      b7d2d38e
    • unknown's avatar
      Adding missing result file for rpl_critical_errors. · bea102d6
      unknown authored
      
      mysql-test/r/rpl_critical_errors.result:
        New BitKeeper file ``mysql-test/r/rpl_critical_errors.result''
      bea102d6
    • unknown's avatar
      Merge gshchepa.loc:/home/uchum/work/bk-trees/mysql-5.0-opt · 69ed5e93
      unknown authored
      into  gshchepa.loc:/home/uchum/work/bk-trees/mysql-5.0-opt-27704
      
      69ed5e93
    • unknown's avatar
      Merge gshchepa.loc:/home/uchum/work/bk-trees/mysql-4.1-opt-27704 · cfc3d36b
      unknown authored
      into  gshchepa.loc:/home/uchum/work/bk-trees/mysql-5.0-opt-27704
      
      
      mysql-test/r/subselect.result:
        Auto merged
      mysql-test/t/row.test:
        Auto merged
      mysql-test/r/row.result:
        Test case updated for Bug#27704 (incorrect comparison
        of rows with NULL components).
      sql/item_cmpfunc.cc:
        Bug#27704: incorrect comparison of rows with NULL components.
      sql/item_cmpfunc.h:
        Bug#27704: incorrect comparison of rows with NULL components.
        Cosmetic fix.
      cfc3d36b
    • unknown's avatar
      Bug#27704: incorrect comparison of rows with NULL components · 986508fc
      unknown authored
      Support for NULL components was incomplete for row comparison,
      fixed.  Added support for abort_on_null at compare_row() like
      in 5.x
      
      
      sql/item_cmpfunc.h:
        Bug#27704: incorrect comparison of rows with NULL components
        Added support for abort_on_null at Item_bool_func2
        like in 5.x
      sql/item_cmpfunc.cc:
        Bug#27704: incorrect comparison of rows with NULL components
        Support for NULL components was incomplete for row comparison,
        fixed. Added support for abort_on_null at compare_row() like
        in 5.x
      mysql-test/t/row.test:
        Test case updated for Bug#27704 (incorrect comparison 
        of rows with NULL components)
      mysql-test/r/row.result:
        Test case updated for Bug#27704 (incorrect comparison 
        of rows with NULL components)
      mysql-test/r/subselect.result:
        Test case updated for Bug#27704 (incorrect comparison 
        of rows with NULL components)
      986508fc
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · c9cd7956
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B27786-5.0-opt
      
      c9cd7956
    • unknown's avatar
      Bug #24778: Innodb: No result when using ORDER BY · 04bc5f89
      unknown authored
      This bug was intruduced by the fix for bug#17212 (in 4.1). It is not 
      ok to call test_if_skip_sort_order since this function will 
      alter the execution plan. By contract it is not ok to call 
      test_if_skip_sort_order in this context.
      
      This bug appears only in the case when the optimizer has chosen 
      an index for accessing a particular table but finds a covering 
      index that enables it to skip ORDER BY. This happens in 
      test_if_skip_sort_order.
      
      
      mysql-test/r/key.result:
        Bug#24778
        
        test case.
        
        The bug causes the result to be the empty set.
      mysql-test/t/key.test:
        Bug#24778
        
        The minimal test case that reveals the bug. The reason for such a 
        complicated schema is that we have to convince the optimizer to 
        pick one index, then discard it in order to be able to skip 
        ORDER BY.
      sql/sql_select.cc:
        bug#24778
        
        Removed the call to test_if_skip_sort_order that constituted the
        bug.
      04bc5f89
    • unknown's avatar
      Merge romeo.(none):/home/bk/merge-mysql-5.0 · ae91025e
      unknown authored
      into  romeo.(none):/home/bk/merge-mysql-5.1
      
      
      client/mysql.cc:
        Auto merged
      sql/ha_ndbcluster.cc:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_delete.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      configure.in:
        Merging 5.0 into 5.1
      sql/slave.cc:
        Merging 5.0 into 5.1
      ae91025e
    • unknown's avatar
      Merge romeo.(none):/home/bkroot/mysql-5.1-rpl · cffd4f88
      unknown authored
      into  romeo.(none):/home/bk/merge-mysql-5.1
      
      
      BitKeeper/etc/ignore:
        auto-union
      client/mysql.cc:
        Auto merged
      client/mysqlbinlog.cc:
        Auto merged
      configure.in:
        Auto merged
      client/mysqltest.c:
        Auto merged
      mysql-test/r/rpl_ndb_basic.result:
        Auto merged
      mysql-test/t/disabled.def:
        Auto merged
      sql/CMakeLists.txt:
        Auto merged
      sql/ha_ndbcluster.cc:
        Auto merged
      sql/ha_ndbcluster.h:
        Auto merged
      sql/ha_ndbcluster_binlog.cc:
        Auto merged
      sql/log.cc:
        Auto merged
      sql/log_event.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/slave.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_repl.cc:
        Auto merged
      cffd4f88
    • unknown's avatar
      Merge romeo.(none):/home/bkroot/mysql-5.0-rpl · 46a82c19
      unknown authored
      into  romeo.(none):/home/bk/merge-mysql-5.0
      
      
      client/mysql.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/slave.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      46a82c19
    • unknown's avatar
      Merge mkindahl@bk-internal.mysql.com:/home/bk/mysql-5.0-rpl · ba95432e
      unknown authored
      into  romeo.(none):/home/bkroot/mysql-5.0-rpl
      
      ba95432e
    • unknown's avatar
      Merge romeo.(none):/home/bkroot/mysql-5.1-rpl · 3c7a22b2
      unknown authored
      into  romeo.(none):/home/bk/b27779-mysql-5.1-rpl
      
      3c7a22b2
    • unknown's avatar
      Disabling test case rpl_ndb_circular_simplex · 740fcc76
      unknown authored
      740fcc76
    • unknown's avatar
      Bug #27786: · d8aa3a12
      unknown authored
      When merging views into the enclosing statement
      the ORDER BY clause of the view is merged to the
      parent's ORDER BY clause.
      However when the VIEW is merged into an UNION
      branch the ORDER BY should be ignored. 
      Use of ORDER BY for individual SELECT statements
      implies nothing about the order in which the rows
      appear in the final result because UNION by default
      produces unordered set of rows.
      Fixed by ignoring the ORDER BY clause from the merge
      view when expanded in an UNION branch.
      
      
      mysql-test/r/view.result:
        Bug #27786: test case
      mysql-test/t/view.test:
        Bug #27786: test case
      sql/sql_lex.h:
        Bug #27786: add a is_union() inlined function
        Returns true if the unit represents an UNION.
      sql/sql_view.cc:
        Bug #27786: ignore ORDER BY in mergeable views when in UNION context
      d8aa3a12
  3. 19 Apr, 2007 3 commits
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 81dc94e7
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B27530-5.0-opt
      
      81dc94e7
    • unknown's avatar
      Bug#27499 DROP TABLE race with SHOW TABLE STATUS · 61975440
      unknown authored
      They can drop table after table names list creation and before table opening.
      We open non existing table and get ER_NO_SUCH_TABLE error.
      In this case we do not store the record into I_S table and clear error.
      
      
      sql/sql_show.cc:
        Hide error for not existing table
      61975440
    • unknown's avatar
      corrrection of test case · bdb59262
      unknown authored
      
      mysql-test/r/ndb_binlog_ddl_multi.result:
        corrrection of test case
        (this was actually a bug that had not been spotted, that was fixed by previous patch)
      bdb59262
  4. 18 Apr, 2007 5 commits
    • unknown's avatar
      revert back to old show_binlog_events asto many test failures, and create a... · 46f187b9
      unknown authored
      revert back to old show_binlog_events asto many test failures, and create a show_binlog_events2 instead
      
      
      BitKeeper/etc/ignore:
        Added client/log_event_old.cc client/log_event_old.h client/rpl_record_old.cc client/rpl_record_old.h libmysqld/log_event_old.cc libmysqld/rpl_record.cc libmysqld/rpl_record_old.cc to the ignore list
      mysql-test/include/show_binlog_events2.inc:
        New BitKeeper file ``mysql-test/include/show_binlog_events2.inc''
      46f187b9
    • unknown's avatar
      Bug #27076 · 18eec637
      unknown authored
       - test case
      
      
      sql/ha_ndbcluster_binlog.cc:
        drop table not logged when it should
      mysql-test/r/ndb_binlog_log_bin.result:
        New BitKeeper file ``mysql-test/r/ndb_binlog_log_bin.result''
      mysql-test/t/ndb_binlog_log_bin.test:
        New BitKeeper file ``mysql-test/t/ndb_binlog_log_bin.test''
      18eec637
    • unknown's avatar
      Bug #27076 Cluster does not honor SQL_LOG_BIN flag · 33582e01
      unknown authored
      - both for data schema operations
      - also make sure schema events vet the right server id when injected into the binlog
      - use same mechanism to signal server_id in bug#17095, and reserve some "id's" for flagging special conditions on the event, in this case do not log it
      - enable printing of server ids in the testcases to show that we cot it right
      
      33582e01
    • unknown's avatar
      Bug#17095 circular replication · 7f5fd989
      unknown authored
      - make sure any value is set for linked operations as well, e.g. blob tables
      
      7f5fd989
    • unknown's avatar
      Fixed bug #27870. The bug that causes crashes manifests itself at some · e9446176
      unknown authored
      conditions when executing an equijoin query with WHERE condition
      containing a subquery predicate of the form join_attr NOT IN (SELECT ...).
      
      To resolve a problem of the correct evaluation of the expression
        attr NOT IN (SELECT ...)
      an array of guards is created to make it possible to filter out some 
      predicates of the EXISTS subquery into which the original subquery 
      predicate is transformed, in the cases when a takes the NULL value. 
      If attr is defined as a field that cannot be NULL than such an array 
      is not needed and is not created. 
      However if the field a occurred also an an equijoin predicate t2.a=t1.b
      and table t1 is accessed before table t2 then it may happen that the 
      the EXISTS subquery is pushed down to the condition evaluated just after
      table t1 has been accessed. In this case any occurrence of t2.a is 
      substituted for t1.b. When t1.b takes the value of NULL an attempt is 
      made to turn on the corresponding guard. This action caused a crash as 
      no guard array had been created.
      
      Now the code of Item_in_subselect::set_cond_guard_var checks that the guard
      array has been created before setting a guard variable on. Otherwise the
      method does nothing. It cannot results in returning a row that could be
      rejected as the condition t2.a=t1.b will be checked later anyway.        
      
      
      mysql-test/r/subselect3.result:
        Added a test case for bug #27870.
      mysql-test/t/subselect3.test:
        Added a test case for bug #27870.
      sql/item_subselect.h:
        Fixed bug #27870. The bug that causes crashes manifests itself at some
        conditions when executing an equijoin query with WHERE condition
        containing a subquery predicate of the form join_attr NOT IN (SELECT ...).
        
        Forced Item_in_subselect::set_cond_guard_var to check that the guard
        array has been created before setting a guard variable on. Otherwise the
        method does nothing.
      e9446176
  5. 17 Apr, 2007 7 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/data0/bk/mysql-5.0 · 4f3efddd
      unknown authored
      into  bk-internal.mysql.com:/data0/bk/mysql-5.0-marvel
      
      
      sql/ha_ndbcluster.cc:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/sql_delete.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      4f3efddd
    • unknown's avatar
      Merge bk-internal.mysql.com:/data0/bk/mysql-5.1 · 6b71b0ed
      unknown authored
      into  bk-internal.mysql.com:/data0/bk/mysql-5.1-marvel
      
      
      mysql-test/r/strict.result:
        Auto merged
      sql/ha_ndbcluster.cc:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/sql_delete.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      6b71b0ed
    • unknown's avatar
      Raise version number after cloning 5.0.40 · 7455a7ff
      unknown authored
      7455a7ff
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1-marvel · 4d07b3dc
      unknown authored
      into  mysql.com:/home/my/mysql-5.1
      
      4d07b3dc
    • unknown's avatar
      Fixed federated and some replication tests to not stop slave until it's up and running. · 6b222f52
      unknown authored
      (Removes some warnings about UNIX_TIMESTAMP from the slave.err logs)
      Marked federated_server as a '--big-test'
      Change error in net_clear to 'Note', as it interfered with mysql-test-run.
      
      
      client/mysqltest.c:
        More DBUG messages
        Adding missing DBUG_RETURN
      mysql-test/extra/rpl_tests/rpl_max_relay_size.test:
        Added missing sync_slave_with_master
      mysql-test/extra/rpl_tests/rpl_relayrotate.test:
        Added missing sync_slave_with_master
      mysql-test/include/federated.inc:
        Don't do stop slave before the slave has started properly
        (Removes some warnings about UNIX_TIMESTAMP from the slave.err logs)
      mysql-test/include/federated_cleanup.inc:
        Trivial cleanup
      mysql-test/t/federated_server.test:
        Don't run this unless under --big-test
        Made test-loop smaller. (We will find out errors in code over time, as the test is run under a lot of difference machines which will compensate for the smaller loop)
      mysql-test/t/rpl_flushlog_loop.test:
        Added missing sync_slave_with_master
      sql/net_serv.cc:
        Change error to Note (low level warning), as it interfered with mysql-test-run.
        This is probably fine as we in some context on sever shutdown can get information about connection shutdown on the connection while we are doing a query at the same time.
        Still, in normal context one should get this, so it's good to have it in the log as it enables one to find errors easier.
      sql/slave.cc:
        Added reason to why things failed to error message
      6b222f52
    • unknown's avatar
      Reverting to use time_t instead of my_time_t since the latter caused · 28af0d78
      unknown authored
      compile warnings on windows machines.
      
      28af0d78
    • unknown's avatar
      Fixing test case and result file for rpl_ndb_circular_simplex. · 66d6a171
      unknown authored
      
      mysql-test/r/rpl_ndb_circular_simplex.result:
        Result change
      mysql-test/t/rpl_ndb_circular_simplex.test:
        Using master port on slave side instead of slave port (which should be
        used on master side).
      66d6a171
  6. 16 Apr, 2007 5 commits
    • unknown's avatar
      Bug #27395 OPTION_STATUS_NO_TRANS_UPDATE is not preserved at the end of SF() · ba5727ac
      unknown authored
      refining the test with active innodb
      
      
      mysql-test/r/sp_trans_log.result:
        changed
      mysql-test/t/sp_trans_log.test:
        innodb activated
      ba5727ac
    • unknown's avatar
      Bug #27395 OPTION_STATUS_NO_TRANS_UPDATE is not preserved at the end of SF() · 0aade480
      unknown authored
      tests for the bug and associated is moved into another file because
      they appeared to be binlog-format sensitive.
      
      
      mysql-test/r/sp_trans.result:
        results changed
      mysql-test/t/sp_trans.test:
        binlog format sensitive piece of test moved to sp_trans_log.
      mysql-test/r/sp_trans_log.result:
        new results
      mysql-test/t/sp_trans_log.test:
        binlog-format sensitive part of sp_trans.test
      0aade480
    • unknown's avatar
      Clear field_alloc when it's moved to result set (allows us to always call free_root on field_alloc) · 03cf9a57
      unknown authored
      Change to use remove_file instead of 'system rm' in a lot of tests. (Should fix some windows test problems)
      Removed memory leak in mysql_test if sync_with_master fails.
      Do not terminate ndb_cluster_binary_log before the util thread has finnished. This should fix a shutdown bug where a thread is accessing injector_mutex after it's freed.
      Patch may fix Bug#27622 "mysqld shutdown, util thread continues, while binlog thread exits"
      
      
      client/mysqltest.c:
        Added missing 'mysql_free_result' (fixed confusing memory leak when sync_with_master fails)ug
      mysql-test/mysql-test-run.pl:
        Add the test case name to the instance manager log files
      mysql-test/r/rpl_log_pos.result:
        Made test more portable (for powermac)
      mysql-test/t/disabled.def:
        Disabled im_life_cycle (added bug#27851)
      mysql-test/t/myisam-system.test:
        Use remove_file instead of "system rm"
      mysql-test/t/ndb_autodiscover.test:
        Use remove_file instead of "system rm"
      mysql-test/t/ndb_loaddatalocal.test:
        Use remove_file instead of "system rm"
      mysql-test/t/rpl_loaddatalocal.test:
        Use remove_file instead of "system rm"
      mysql-test/t/rpl_log_pos.test:
        Made test more portable (for powermac)
      mysql-test/t/rpl_misc_functions.test:
        Use remove_file instead of "system rm"
      mysql-test/t/rpl_rbr_to_sbr.test:
        Use remove_file instead of "system rm"
      mysql-test/t/rpl_row_NOW.test:
        Use remove_file instead of "system rm"
      mysql-test/t/rpl_row_sp001.test:
        Use remove_file instead of "system rm"
      mysql-test/t/rpl_row_sp011.test:
        Use remove_file instead of "system rm"
      mysql-test/t/show_check.test:
        Use remove_file instead of "system rm"
      mysys/my_alloc.c:
        Don't return on zero argument, as this may hide other errors
      server-tools/instance-manager/log.cc:
        Log errors to both stdout and stderr (to know in which context we got the error)
      server-tools/instance-manager/thread_registry.cc:
        Log error before common assert (to know in which context we fail)
      sql/ha_ndbcluster.cc:
        Do not terminate ndb_cluster_binary_log before the util thread has finnished.
      sql/ha_ndbcluster.h:
        Do not terminate ndb_cluster_binary_log before the util thread has finnished.
      sql/ha_ndbcluster_binlog.cc:
        Do not terminate ndb_cluster_binary_log before the util thread has finnished.
      sql-common/client.c:
        Clear field_alloc when it's moved to result set (allows us to always call free_root on field_alloc)
      03cf9a57
    • unknown's avatar
      Merge romeo.(none):/home/bkroot/mysql-5.1-rpl · 1f1e385d
      unknown authored
      into  romeo.(none):/home/bk/b27779-mysql-5.1-rpl
      
      1f1e385d
    • unknown's avatar
      Updating tests to eliminate some sporadic non-critical failures. · fdb04da9
      unknown authored
      
      mysql-test/r/rpl_ndb_circular_simplex.result:
        Result change.
      mysql-test/t/rpl_ndb_circular_simplex.test:
        Blanking out field that are not critical for the result.
      fdb04da9