1. 15 Oct, 2010 7 commits
  2. 14 Oct, 2010 7 commits
    • Jimmy Yang's avatar
      9eedd927
    • Jimmy Yang's avatar
      f3ea4a4f
    • Alexander Nozdrin's avatar
      A patch for Bug#48874 (Test "is_triggers" fails because of wrong charset info). · 49a9df57
      Alexander Nozdrin authored
      The thing is that the following attributes are fixed (remembered) when a trigger
      is created:
        - character_set_client
        - character_set_results
        - collation_connection
      
      There are two triggers created in mysql-test/include/mtr_warnings.sql.
      They were created using "current default" character set / collation.
      is_triggers.test shows definition of these triggers including recorded
      character set information.
      
      The problem was that if "current default" changed, the recorded character
      set information was not accurate.
      
      There might be two ways to fix that:
        a) update is_triggers.test so that it does not put character-set information
           into result-file;
        b) update mtr_warnings.sql so that the triggers are created using
           hard-coded character sets.
      
      This patch implements option b).
      49a9df57
    • Vasil Dimov's avatar
      Tune the test for Bug#56143 too many foreign keys causes output of show create... · a90b6bee
      Vasil Dimov authored
      Tune the test for Bug#56143 too many foreign keys causes output of show create table to become invalid
      
      Use a CREATE statement with all the FKs instead of ALTERing the table many
      times because it is faster (11 seconds vs 3 seconds).
      
      a90b6bee
    • Vasil Dimov's avatar
      Fix Bug#56143 too many foreign keys causes output of show create table to become invalid · 6cc06928
      Vasil Dimov authored
      This is a port of the following changeset from
      5.1/storage/innobase to 5.1/storage/innodb_plugin:
      
        ------------------------------------------------------------
        revno: 3626
        revision-id: vasil.dimov@oracle.com-20101013171859-gi9n558yj89x9v3w
        parent: klewis@mysql.com-20101012175933-ce9kkgl0z8oeqffa
        committer: Vasil Dimov <vasil.dimov@oracle.com>
        branch nick: mysql-5.1-innodb
        timestamp: Wed 2010-10-13 20:18:59 +0300
        message:
          Fix Bug#56143 too many foreign keys causes output of show create table to become invalid
          
          Just remove the check whether the file is "too big".
          A similar code exists in ha_innobase::update_table_comment() but that
          method does not seem to be used.
      
      Also use a CREATE statement with all the FKs instead of ALTERing the
      table 550 times because it is faster.
      6cc06928
    • Sunny Bains's avatar
      Bug# 55681 - MTR slowdown after default storage engine was changed to InnoDB · 3293ea96
      Sunny Bains authored
      Add new function os_cond_wait_timed(). Change the os_thread_sleep() calls
      to timed conditional waits. Signal the background threads during the shutdown
      phase so that we avoid waiting for the sleep to timeout thus saving some time.
      
      rb://439 -- Approved by Jimmy Yang
      3293ea96
    • Davi Arnaut's avatar
      Bug#56096: STOP SLAVE hangs if executed in parallel with user sleep · c908dd31
      Davi Arnaut authored
      The root of the problem is that to interrupt a slave SQL thread
      wait, the STOP SLAVE implementation uses thd->awake(THD::NOT_KILLED).
      This appears as a spurious wakeup (e.g. from a sleep on a
      condition variable) to the code that the slave SQL thread is
      executing at the time of the STOP. If the code is not written
      to be spurious-wakeup safe, unexpected behavior can occur. For
      the reported case, this problem led to an infinite loop around
      the interruptible_wait() function in item_func.cc (SLEEP()
      function implementation).  The loop was not being properly
      restarted and, consequently, would not come to an end. Since the
      SLEEP function sleeps on a timed event in order to be killable
      and to perform periodic checks until the requested time has
      elapsed, the spurious wake up was causing the requested sleep
      time to be reset every two seconds.
      
      The solution is to calculate the requested absolute time only
      once and to ensure that the thread only sleeps until this
      time is elapsed. In case of a spurious wake up, the sleep is
      restarted using the previously calculated absolute time. This
      restores the behavior present in previous releases. If a slave
      thread is executing a SLEEP function, a STOP SLAVE statement
      will wait until the time requested in the sleep function
      has elapsed.
      
      mysql-test/extra/rpl_tests/rpl_start_stop_slave.test:
        Add test case for Bug#56096.
      mysql-test/suite/rpl/r/rpl_stm_start_stop_slave.result:
        Add test case result for Bug#56096.
      sql/item_func.cc:
        Reorganize interruptible_wait into a class so that the absolute
        time can be preserved across calls to the wait function. This
        allows the sleep to be properly restarted in the presence of
        spurious wake ups, including those generated by a STOP SLAVE.
      c908dd31
  3. 13 Oct, 2010 4 commits
  4. 14 Oct, 2010 1 commit
  5. 13 Oct, 2010 7 commits
  6. 12 Oct, 2010 6 commits
  7. 11 Oct, 2010 8 commits