1. 04 May, 2021 3 commits
  2. 03 May, 2021 1 commit
  3. 02 May, 2021 1 commit
  4. 01 May, 2021 1 commit
  5. 30 Apr, 2021 3 commits
  6. 29 Apr, 2021 2 commits
  7. 28 Apr, 2021 4 commits
    • Vladislav Vaintroub's avatar
      MDEV-24382 Assertion in tdc_remove_table · 65e73b56
      Vladislav Vaintroub authored
      The assert is no more reproducible in the lastest 10.5-10.6
      
      The patch only adds testcase from MDEV-24382.
      65e73b56
    • Krunal Bauskar's avatar
      MDEV-25093: Adaptive flushing fails to kick in even if · 3f4b7ed9
      Krunal Bauskar authored
                  innodb_adaptive_flushing_lwm is hit. (possible regression)
      
      adaptive flushing should kick in if
      a. dirty_pct (dirty pages in buffer pool) > innodb_max_dirty_pages_pct_lwm
      OR
      b. innodb_adaptive_flushing_lwm limit is reached (default to 10%)
      
      both conditions are mutually exclusive and whichever is first to evaluate
      true should kick-start the adaptive flushing.
      
      After recent changes to simplify the flushing algorithm logic, (b) got ignored
      that introduced the said regression.
      3f4b7ed9
    • Daniele Sciascia's avatar
      MDEV-25553 : Avoid unnecessary rollbacks with SR · b1b2689f
      Daniele Sciascia authored
      This patch changes statement rollback for streaming replication.
      Previously, a statement rollback was turned into full transaction
      rollback in the case where the transaction had already replicated a
      fragment. This was introduced in the initial implementation of
      streaming replication due to the fact that we do not have a mechanism
      to perform a statement rollback on the applying side.
      This policy is however overly pessimistic, causing full rollbacks even
      in cases where a local statement rollback, would not require a
      statement rollback on the applying side. This happens to be case when
      the statement itself has not replicated any fragments.
      So the patch changes the condition that determines if a statement
      rollback should be turned into a full rollback accordingly.
      Reviewed-by: default avatarJan Lindström <jan.lindstrom@mariadb.com>
      b1b2689f
    • mkaruza's avatar
      MDEV-22227 Assertion `state_ == s_exec' failed in wsrep::client_state::start_transaction · 206d630e
      mkaruza authored
      Removed redundant code for BF abort transaction in `thr_lock.cc`.
      
      TOI operations will ignore provided lock_wait_timeout and use `LONG_TIMEOUT`
      until operation is finished.
      Reviewed-by: default avatarJan Lindström <jan.lindstrom@mariadb.com>
      206d630e
  8. 27 Apr, 2021 6 commits
  9. 26 Apr, 2021 5 commits
    • Daniel Black's avatar
      MDEV-25513: raise systemd LimitNOFILE limits to match server defaults · a35cde8c
      Daniel Black authored
      Quoting MDEV reporter Daniel Lewart:
      
      Starting MariaDB with default configuration causes the following problems:
      
          "[Warning] Could not increase number of max_open_files to more than 16384 (request: 32186)"
          silently reduces table_open_cache_instances from 8 (default) to 4
      
      Default Server System Variables:
      
          extra_max_connections = 1
          max_connections = 151
          table_open_cache = 2000
          table_open_cache_instances = 8
          thread_pool_size = 4
      
      LimitNOFILE=16834 is in the following files:
      
          support-files/mariadb.service.in
          support-files/mariadb@.service.in
      
      Looking at sql/mysqld.cc lines 3837-3917:
      wanted_files= (extra_files + max_connections + extra_max_connections +
      tc_size * 2 * tc_instances);
      wanted_files+= threadpool_size;
      
      Plugging in the default values:
      wanted_files = (30 + 151 + 1 + 2000 * 2 * 8 + 4) = 32186
      
      However, systemd configuration has LimitNOFILE = 16384, which is far smaller.
      
      I suggest increasing LimitNOFILE to 32768.
      a35cde8c
    • Marko Mäkelä's avatar
      MDEV-24758 heap-use-after-poison in innobase_add_instant_try/rec_copy · 4d412e98
      Marko Mäkelä authored
      This is a backport of
      commit fd9ca2a7 (MDEV-23295) and
      commit 9a156e1a (MDEV-23345) to 10.3.
      
      An instant ADD/DROP/reorder column could create a dummy table
      object with the wrong ROW_FORMAT when innodb_default_row_format
      was changed between CREATE TABLE and ALTER TABLE.
      
      prepare_inplace_alter_table_dict(): If we had promised that
      ALGORITHM=INPLACE is supported, we must preserve the ROW_FORMAT.
      
      The rest of the changes are related to adding
      Alter_inplace_info::inplace_supported to cache the return value of
      handler::check_if_supported_inplace_alter().
      4d412e98
    • Marko Mäkelä's avatar
      MDEV-15756: Remove some garbage output · dd07cfce
      Marko Mäkelä authored
      os_aio_print(): Remove output that should have been removed in
      commit 5e62b6a5 (MDEV-16264).
      dd07cfce
    • Daniele Sciascia's avatar
      Fix MTR test wsrep.variables_debug · 9e6310e3
      Daniele Sciascia authored
      The test was changing variable wsrep_provider dynamically,
      but wsrep_provider was recently made read-only.
      
      followup for ce3a2a68
      9e6310e3
    • Sujatha's avatar
      MDEV-24773: slave_compressed_protocol doesn't work properly with semi-sync replication · 391f1aa6
      Sujatha authored
      Back port upstream fix
      
      commit 1800b015a1d487330f7b15f2020b887be348a66b
      Author: Venkatesh Duggirala <venkatesh.duggirala@oracle.com>
      Date:   Fri Sep 8 20:29:22 2017 +0530
      
      Bug#26027024    SLAVE_COMPRESSED_PROTOCOL DOESN'T WORK WITH
      SEMI-SYNC REPLICATION IN MYSQL-5.7
      
      Analysis: In mysql-5.6, dump thread (the thread that is created
      on Master after Slave requested for a binlog dump) is also used
      to receive acknowledgements from the Slave and act on them accordingly.
      For performance reasons, a special thread called Ack Receiver thread
      is added in mysql-5.7 Semi synchronous replication plugin.
      This thread does not have special handling to receive acknowledgements
      if Slave has enabled compression in the protocol. Hence Master is
      unable to handle any slave if Slave_compressed_protocol is enabled
      on it.
      
      Fix: Enable compress flag on the communication channels if the Slave
      has Slave_compressed_protocol ON.
      391f1aa6
  10. 25 Apr, 2021 6 commits
  11. 24 Apr, 2021 4 commits
    • Igor Babaev's avatar
      This commit adds the same call of st_select_lex::set_unique_exclude() that · 2c9bf0ae
      Igor Babaev authored
      complemented the fix for MDEV-24823 in 10.2. As it is the only call of
      this function in 10.3 the commit also has added the code of the function.
      2c9bf0ae
    • Marko Mäkelä's avatar
      Merge 10.2 into 10.3 · c425d93b
      Marko Mäkelä authored
      except commit 1288dfff
      c425d93b
    • Marko Mäkelä's avatar
      MDEV-23026/MDEV-25474 fixup: Assertion ib_table->stat_initialized · 14a18d7d
      Marko Mäkelä authored
      It is possible that an object that was originally created by
      open_purge_table() will remain cached and reused for SQL execution.
      Our previous fix wrongly assumed that ha_innobase::open() would
      always be called before SQL execution starts. Therefore, we must
      invoke dict_stats_init() in ha_innobase::info_low() instead of
      only doing it in ha_innobase::open().
      
      Note: Concurrent execution of dict_stats_init() on the same table
      is possible, but it also was possible between two calls to
      ha_innobase::open(), with no ill effects observed.
      
      This should fix the assertion failure on stat_initialized.
      A possibly easy way to reproduce it would have been
      to run the server with innodb_force_recovery=2 (disable the purge of
      history), update a table so that an indexed virtual column will be
      affected, and finally restart the server normally (purge enabled),
      to observe a crash when the table is accessed from SQL.
      
      The problem was first observed and this fix verified by
      Elena Stepanova. Also Thirunarayanan Balathandayuthapani
      repeated the problem.
      14a18d7d
    • Marko Mäkelä's avatar
      MDEV-25459 MVCC read from index on CHAR or VARCHAR wrongly omits rows · 25ed665a
      Marko Mäkelä authored
      row_sel_sec_rec_is_for_clust_rec(): If the field in the
      clustered index record stored off page, always fetch it,
      also when the secondary index field has been built on the
      entire column. This was broken ever since the InnoDB Plugin
      for MySQL Server 5.1 introduced ROW_FORMAT=DYNAMIC and
      ROW_FORMAT=COMPRESSED for InnoDB tables. That code was first
      introduced in this tree in
      commit 3945d5e5.
      
      For the original ROW_FORMAT=REDUNDANT and the MySQL 5.0.3
      ROW_FORMAT=COMPRESSED, there was no problem, because for
      those tables we always stored at least a 768-byte prefix of
      each column in the clustered index record.
      
      row_sel_sec_rec_is_for_blob(): Allow prefix_len==0 for matching
      the full column.
      25ed665a
  12. 23 Apr, 2021 4 commits