1. 19 Jul, 2007 2 commits
  2. 18 Jul, 2007 3 commits
    • unknown's avatar
      Fixed bug #28524. · 00bb9cfa
      unknown authored
      For each view the mysqldump utility creates a temporary table
      with the same name and the same columns as the view 
      in order to satisfy views that depend on this view.
      After the creation of all tables, mysqldump drops all
      temporary tables and creates actual views.
      However, --skip-add-drop-table and --compact flags disable
      DROP TABLE statements for those temporary tables. Thus, it was
      impossible to create the views because of existence of the
      temporary tables with the same names.
      
      
      client/mysqldump.c:
        Fixed bug #28524.
        The mysqldump utility has been modified to unconditionally drop
        temporary tables before the creation of views.
      mysql-test/t/mysqldump.test:
        Updated test case for bug #28524 and updated result of previous tests.
      mysql-test/r/mysqldump.result:
        Updated test case for bug #28524 and updated result of previous tests.
      00bb9cfa
    • unknown's avatar
      Bug #29325: create table overwrites .MYD file of other · 640868be
      unknown authored
      table (datadir)
      Set errno when retunring an error in my_create_with_symlink.
      
      
      mysys/my_symlink2.c:
        Bug #29325: set errno when retunring 
        an error in my_create_with_symlink
      640868be
    • unknown's avatar
      Mark deadcode for gcov · 67b1e409
      unknown authored
      67b1e409
  3. 17 Jul, 2007 4 commits
  4. 16 Jul, 2007 1 commit
    • unknown's avatar
      Bug #29687 mysql_stmt_store_result memory leak in libmysqld · 0bb6e313
      unknown authored
      In embedded server we use result->alloc to store field data for the
      result, but we didn't clean the result->alloc if the query returned
      an empty recordset. Cleaning for the empty recordset enabled
      
      
      libmysql/libmysql.c:
        Bug #29687 mysql_stmt_store_result memory leak in libmysqld
        
        we should clean result->alloc even if we have nothin in 'data' field
      0bb6e313
  5. 15 Jul, 2007 4 commits
    • unknown's avatar
      item_cmpfunc.cc: · d1dd69f5
      unknown authored
        A typo fixed.
      
      
      sql/item_cmpfunc.cc:
        A typo fixed.
      d1dd69f5
    • unknown's avatar
      item_cmpfunc.cc: · cb6cac53
      unknown authored
        Fixed compiler warning.
      
      
      sql/item_cmpfunc.cc:
        Fixed compiler warning.
      cb6cac53
    • unknown's avatar
      item_cmpfunc.cc: · 5f2a94b8
      unknown authored
        A comment changed.
      
      
      sql/item_cmpfunc.cc:
        A comment changed.
      5f2a94b8
    • unknown's avatar
      Extended fix for the bug#29555. · 376073e1
      unknown authored
      The get_time_value function is added. It is used to obtain TIME values both
      from items the can return time as an integer and from items that can return
      time only as a string.
      The Arg_comparator::compare_datetime function now uses pointer to a getter
      function to obtain values to compare. Now this function is also used for
      comparison of TIME values.
      The get_value_func variable is added to the Arg_comparator class.
      It points to a getter function for the DATE/DATETIME/TIME comparator.
      
      
      mysql-test/t/type_time.test:
        Extended test case for the bug#29555.
      mysql-test/r/type_time.result:
        Extended test case for the bug#29555.
      sql/item_cmpfunc.cc:
        Extended fix for the bug#29555.
        The get_time_value function is added. It is used to obtain TIME values both
        from items the can return time as an integer and from items that can return
        time only as a string.
        The Arg_comparator::compare_datetime function now uses pointer to a getter
        function to obtain values to compare. Now this function is also used for
        comparison of TIME values.
      sql/item_cmpfunc.h:
        Extended fix for the bug#29555.
        The get_value_func variable is added to the Arg_comparator class.
        It points to a getter function for the DATE/DATETIME/TIME comparator.
      376073e1
  6. 14 Jul, 2007 5 commits
  7. 13 Jul, 2007 4 commits
  8. 12 Jul, 2007 4 commits
    • unknown's avatar
      Bug#29739: Incorrect time comparison in BETWEEN. · 793e4442
      unknown authored
      Time values were compared by the BETWEEN function as strings. This led to a
      wrong result in cases when some of arguments are less than 100 hours and other
      are greater.
      
      Now if all 3 arguments of the BETWEEN function are of the TIME type then
      they are compared as integers.
      
      
      mysql-test/t/type_time.test:
        Added a tes tcase for the bug#29739: Incorrect time comparison in BETWEEN.
      mysql-test/r/type_time.result:
        Added a tes tcase for the bug#29739: Incorrect time comparison in BETWEEN.
      sql/item_cmpfunc.cc:
        Bug#29739: Incorrect time comparison in BETWEEN.
        Now if all 3 arguments of the BETWEEN function are of the TIME type then
        they are compared as integers.
      793e4442
    • unknown's avatar
      e4d6b9e5
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.0-opt · eaba3341
      unknown authored
      into  olga.mysql.com:/home/igor/dev-opt/mysql-5.0-opt-bug29604
      
      eaba3341
    • unknown's avatar
      Fixed bug #29604. · 07c0e6af
      unknown authored
      A bug in the restore_prev_nj_state function allowed interleaving 
      inner tables of outer join operations with outer tables. With the
      current implementation of the nested loops algorithm it could lead
      to wrong result sets for queries with nested outer joins.
      Another bug in this procedure effectively blocked evaluation of some
      valid execution plans for queries with nested outer joins. 
      
      
      mysql-test/r/join_nested.result:
        Added a test case for bug #29604.
      mysql-test/t/join_nested.test:
        Added a test case for bug #29604.
      07c0e6af
  9. 11 Jul, 2007 11 commits
    • unknown's avatar
      Merge gshchepa@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 4e98d043
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      4e98d043
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0-opt · 3cc4928f
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt-29360
      
      3cc4928f
    • unknown's avatar
      field_conv.cc: · 0d4add75
      unknown authored
        Additional fix for bug #29360.
      
      
      sql/field_conv.cc:
        Additional fix for bug #29360.
      0d4add75
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · c6b64d5c
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/29555-bug-5.0-opt-mysql
      
      c6b64d5c
    • unknown's avatar
      Bug#29555: Comparing time values as strings may lead to a wrong result. · b0a5febe
      unknown authored
      Time values were compared as strings. This led to a wrong comparison
      result when comparing values one of which is under 100 hours and another is
      over 100 hours.
      
      Now when the Arg_comparator::set_cmp_func function sees that both items to
      compare are of the TIME type it sets the comparator to the
      Arg_comparator::compare_e_int or the Arg_comparator::compare_int_unsigned
      functions.
      
      
      sql/item_cmpfunc.cc:
        Bug#29555: Comparing time values as strings may lead to a wrong result.
        Now when the Arg_comparator::set_cmp_func function sees that both items to
        compare are of the TIME type it sets the comparator to the
        Arg_comparator::compare_e_int or the Arg_comparator::compare_int_unsigned
        functions.
      mysql-test/r/type_time.result:
        Added a test case for the bug#29555: Comparing time values as strings may
        lead to a wrong result.
      mysql-test/t/type_time.test:
        Added a test case for the bug#29555: Comparing time values as strings may
        lead to a wrong result.
      b0a5febe
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0-opt-29360 · b796bddf
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      b796bddf
    • unknown's avatar
      Fixed bug #29360. · 54286cd5
      unknown authored
      The special `zero' enum value was coerced to the normal
      empty string enum value during a field-to-field copy.
      This bug affected CREATE ... SELECT statements and
      SELECT aggregate GROUP BY enum field statements.
      
      Also this bug made unnecessary warnings during
      the execution of CREATE ... SELECT statements:
      Warning       1265    Data truncated for column...
      
      
      sql/field_conv.cc:
        Fixed bug #29360.
        The field_conv function has been modified to properly convert
        the special `zero' enum value between enum fields.
      mysql-test/t/type_enum.test:
        Updated test case for bug #29360.
      mysql-test/r/type_enum.result:
        Updated test case for bug #29360.
      mysql-test/r/type_ranges.result:
        Updated test case for bug #29360.
      54286cd5
    • unknown's avatar
      Addendum to bug 29325: · 768db64b
      unknown authored
      test if TRUNCATE TABLE works with keep_files_on_create
      
      768db64b
    • unknown's avatar
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 7efab26b
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B29325-5.0-opt
      
      
      include/my_base.h:
        Auto merged
      7efab26b
    • unknown's avatar
      Bug #29325: · 41bbdb8d
      unknown authored
      By default MyISAM overwrites .MYD and .MYI files no 
      DATA DIRECTORY option is used. This can lead to two tables
      using the same .MYD and .MYI files (that can't be dropped).
      
      To prevent CREATE TABLE from overwriting a file a new option
      is introduced : keep_files_on_create
      When this is on the CREATE TABLE throws an error if either
      the .MYD or .MYI exists for a MyISAM table.
      The option is off by default (resulting in compatible behavior).
      
      
      include/my_base.h:
        Bug #29325: introduce keep_files_on_create
      myisam/mi_create.c:
        Bug #29325: introduce keep_files_on_create
      mysql-test/r/create.result:
        Bug #29325: test case
      mysql-test/t/create.test:
        Bug #29325: test case
      sql/ha_myisam.cc:
        Bug #29325: introduce keep_files_on_create
      sql/set_var.cc:
        Bug #29325: introduce keep_files_on_create
      sql/sql_class.h:
        Bug #29325: introduce keep_files_on_create
      sql/sql_table.cc:
        Bug #29325: introduce keep_files_on_create
      sql/unireg.cc:
        Bug #29325: introduce keep_files_on_create
      41bbdb8d
  10. 10 Jul, 2007 2 commits
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · c62f52ea
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B29070-5.0-opt
      
      c62f52ea
    • unknown's avatar
      Bug #29469: Client dies if a query is issued after hitting Ctrl + C · baa4f64d
      unknown authored
      The Ctrl-C handler in mysql closes the console while ReadConsole()
      waits for console input.
      But the main thread was detecting that ReadConsole() haven't read 
      anything and was processing as if there're data in the buffer.
      Fixed to handle correctly this error condition.
      No test case added as the test relies on Ctrl-C sent to the client
      from its console.
      
      
      client/mysql.cc:
        Bug #29469: handle correctly console read error
      mysys/my_conio.c:
        Bug #29469: 
         1. handle correctly console read error
         2. add boundry checks for console buffer.
      baa4f64d