1. 19 Jul, 2005 7 commits
    • unknown's avatar
      Fixed some test cases that was not forgotten in a recent patch · 8b0dfd96
      unknown authored
      
      sql/sql_show.cc:
        Cleanup comment
        Removed extra end space
      8b0dfd96
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · 0410399f
      unknown authored
      into  mishka.local:/home/my/mysql-4.1
      
      0410399f
    • unknown's avatar
      Simple fixes during review of new code · b11046f5
      unknown authored
      
      include/my_global.h:
        Added floatget() to read unaligned flaot
      mysql-test/r/select.result:
        Added test for found_rows()
      mysql-test/t/select.test:
        Added test for found_rows()
      sql/des_key_file.cc:
        Moved initalization of LOCK_des_key_file to mysqld to make simpler code and avoid theoretical race condition
      sql/field_conv.cc:
        Added optimizzed varsion of do_cut_string (for simple character sets)
      sql/item_func.cc:
        Simplify code (and ensure DBUG_ENTER is excuted before main code)
      sql/item_strfunc.cc:
        Safe calculation of max_length
        This was needed as max_length can now be 1<<32-1 (after konstantins recent patch to fix BLOB_LENGTH)
        Remove init_des_key_file() as this is not initialized in mysqld.cc
      sql/item_timefunc.cc:
        Safe calculation of max_length
        This was needed as max_length can now be 1<<32-1 (after konstantins recent patch to fix BLOB_LENGTH)
      sql/log_event.cc:
        Simplify code
      sql/mysql_priv.h:
        Moved initalization of LOCK_des_key_file to mysqld to make simpler code and avoid theoretical race condition
      sql/mysqld.cc:
        Moved initalization of LOCK_des_key_file to mysqld to make simpler code and avoid theoretical race condition
        Revert wrong patch of calling close_connection() in first close_connections() loop. (Bug #7403)
        Instead we now print a warning for closed connections only if mysqld is sarted with --warnings
        Added comments to make the close_connections() logic clearer
      sql/sql_prepare.cc:
        Use floatget() and doubleget() to protect against unaligned data
      sql/sql_select.cc:
        Fixed some cases unlikely cases where found_rows() would return wrong for queries that would return 0 or 1 rows
      b11046f5
    • unknown's avatar
      7298a9d6
    • unknown's avatar
      ConfigInfo.cpp: · fb9c378a
      unknown authored
        BUG#12028, cannot use default section for hostname in cluster config
        made clearer error message
      
      
      ndb/src/mgmsrv/ConfigInfo.cpp:
        BUG#12028, cannot use default section for hostname in cluster config
        made clearer error message
      fb9c378a
    • unknown's avatar
      BUG#12028, cannot use default value for HostName in cluster config · d001d3f7
      unknown authored
      + added switch --print-full-config
      + removed unused REP configuration
      
      d001d3f7
    • unknown's avatar
      perror.c: · 65f9d950
      unknown authored
        BUG#11999, incorrect --help on perror with ndb
      
      
      extra/perror.c:
        BUG#11999, incorrect --help on perror with ndb
      65f9d950
  2. 18 Jul, 2005 6 commits
  3. 17 Jul, 2005 2 commits
    • unknown's avatar
      select.result, select.test: · bbee428d
      unknown authored
        Added a test case for bug #11745.
      sql_select.cc:
        Fixed bug # 11745.
        Added support of where clause for queries with FROM DUAL.
      sql_yacc.yy:
        Fixed bug # 11745.
        Added optional where clause for queries with FROM DUAL.
      
      
      sql/sql_yacc.yy:
        Fixed bug # 11745.
        Added optional where clause for queries with FROM DUAL.
      sql/sql_select.cc:
        Fixed bug # 11745.
        Added support of where clause for queries with FROM DUAL.
      mysql-test/t/select.test:
        Added a test case for bug #11745.
      mysql-test/r/select.result:
        Added a test case for bug #11745.
      bbee428d
    • unknown's avatar
      Merge ibabaev@bk-internal.mysql.com:/home/bk/mysql-4.1 · a8b81f72
      unknown authored
      into rurik.mysql.com:/home/igor/mysql-4.1
      
      
      sql/sql_select.cc:
        Auto merged
      a8b81f72
  4. 16 Jul, 2005 4 commits
    • unknown's avatar
      Added test for Bug #11521 · 3fc69476
      unknown authored
      "Negative integer keys incorrectly substituted for 0 during range analysis."
      
      The problem is that the range optimizer incorrectly replaces any negative
      constant with '0' for all types except BIGINT because the method save_in_field()
      casts negative integers to non-negative. This causes incorrect query
      results where (0 = any_negative_number).
      
      The problem caused by this bug is fixed by the patch for BUG#11185.
      That patch constitutes an optimization due to which the problem code is
      never called with negative constants. This patch adds a test so we are sure
      that the problem does not reappear.
      
      
      mysql-test/r/select.result:
        Test for BUG#11521.
      mysql-test/t/select.test:
        Test for BUG#11521.
      3fc69476
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-4.1 · 3a9ea232
      unknown authored
      into  mysql.com:/home/jimw/my/mysql-4.1-clean
      
      3a9ea232
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-4.1 · fdd9c510
      unknown authored
      into moonbone.local:/work/mysql-4.1-bug-11868
      
      fdd9c510
    • unknown's avatar
      Fix bug#11868 NOT NULL ref optimization in subquery used in update must be · eb944444
      unknown authored
      disabled if ref is built with a key from the updated table
      
      Problem was in add_not_null_conds() optimization function.
      It contains following code:
      JOIN_TAB *referred_tab= not_null_item->field->table->reginfo.join_tab;
      ...
      add_cond_and_fix(&referred_tab->select_cond, notnull);
      For UPDATE described in bug report referred_tab is 0 and dereferencing it
      crashes the server.
      
      
      
      sql/sql_select.cc:
        Fix bug #11868 NOT NULL ref optimization in subquery used in update must be
        disabled if ref is built with a key from the updated table
      mysql-test/r/update.result:
        Test case for bug#11868 Update with subquery with ref built with a key from
        the updated table crashes server.
      mysql-test/t/update.test:
        Test case for bug#11868 Update with subquery with ref built with a key from the updated table crashes server
      eb944444
  5. 15 Jul, 2005 20 commits
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-4.1 · 0ec69075
      unknown authored
      into  mysql.com:/home/jimw/my/mysql-4.1-clean
      
      0ec69075
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · dc4e24ad
      unknown authored
      into  mysql.com:/opt/local/work/mysql-4.1-root
      
      dc4e24ad
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-4.1 · 23c604d9
      unknown authored
      into  mysql.com:/home/jimw/my/mysql-4.1-clean
      
      23c604d9
    • unknown's avatar
      Merge rburnett@bk-internal.mysql.com:/home/bk/mysql-4.1 · 44dd2bca
      unknown authored
      into  linux.site:/home/reggie/bk/bug7403
      
      44dd2bca
    • unknown's avatar
      A fix and a test case for Bug#9359 "Prepared statements take snapshot · 0b9cb876
      unknown authored
       of system vars at PREPARE time": implement a special Item
      to handle system variables. This item substitutes itself with 
      a basic constant containing variable value at fix_fields.
      
      
      mysql-test/r/ps.result:
        - test results fixed (Bug#9359).
      mysql-test/t/ps.test:
        - add a test case for Bug#9359 "Prepared statements take snapshot
         of system vars at PREPARE time"
      sql/item_func.cc:
        - implement Item_func_get_system_var: we should not evaluate system
        variables in the parser, but instead should create an item which 
        is evaluated to a constant at execute.
        - remove an unused function
      sql/item_func.h:
        Add a new item, Item_func_get_system_var
      sql/mysql_priv.h:
        Move necessary declarations to make set_var.h objects visible in 
        item_func.h
      sql/set_var.cc:
        - we should not print to network from get_system_var: if it's called
        from prepared statement prepare, we get packets out of order when using
        the binary protocol. Instead report the error to be sent to the user later.
        This is a backport from 5.0.
      sql/set_var.h:
        - declaration of enum_var_type moved to mysql_priv.h
      0b9cb876
    • unknown's avatar
      Fix bug#11482 4.1.12 produces different resultset for a complex query · 653e2989
      unknown authored
        than in previous 4.1.x
      
      Wrongly applied optimization were adding NOT NULL constraint which results in
      rejecting valid rows and reduced result set.
      
      The problem was that add_notnull_conds() while checking subquery were adding
      NOT NULL constraint to left joined table, to which, normally, optimization 
      don't have to be applied.
      
      
      sql/sql_select.cc:
        Fix bug #11482 Wrongly applied optimization was erroneously rejecting valid rows
        Constraint were added to optimization appliance test.
      mysql-test/t/select.test:
        Test case for bug #11482  Wrongly applied optimization was erroneously rejecting valid rows
      mysql-test/r/select.result:
        Test case for bug #11482  Wrongly applied optimization was erroneously rejecting valid rows
      653e2989
    • unknown's avatar
      Fix error in formatting metadata in mysqltest. · ac3e1a93
      unknown authored
      
      client/mysqltest.c:
        Fix reporting of length and max_length when displaying metadata
        -- they are unsigned int.
      ac3e1a93
    • unknown's avatar
      Merge mysql.com:/home/jimw/my/mysql-4.1-9979 · 636c1542
      unknown authored
      into  mysql.com:/home/jimw/my/mysql-4.1-clean
      
      
      sql/sql_parse.cc:
        Auto merged
      636c1542
    • unknown's avatar
      Merge rburnett@bk-internal.mysql.com:/home/bk/mysql-4.1 · fca5a3ca
      unknown authored
      into  linux.site:/home/reggie/bk/bug7403
      
      fca5a3ca
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-4.1 · 6f3929e3
      unknown authored
      into poseidon.ndb.mysql.com:/home/tomas/mysql-4.1-new
      
      
      tests/mysql_client_test.c:
        Auto merged
      6f3929e3
    • unknown's avatar
      Merge poseidon.ndb.mysql.com:/home/tomas/mysql-4.1-release · e7c4937e
      unknown authored
      into poseidon.ndb.mysql.com:/home/tomas/mysql-4.1-new
      
      
      mysql-test/t/ctype_utf8.test:
        Auto merged
      ndb/src/common/mgmcommon/ConfigRetriever.cpp:
        Auto merged
      ndb/src/common/transporter/TransporterRegistry.cpp:
        Auto merged
      ndb/src/mgmclient/CommandInterpreter.cpp:
        Auto merged
      ndb/src/mgmsrv/MgmtSrvr.cpp:
        Auto merged
      ndb/src/mgmsrv/MgmtSrvr.hpp:
        Auto merged
      ndb/src/mgmsrv/Services.cpp:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      e7c4937e
    • unknown's avatar
      Merge mysqldev@production.mysql.com:my/mysql-4.1-release · 701d93a4
      unknown authored
      into poseidon.ndb.mysql.com:/home/tomas/mysql-4.1-release
      
      701d93a4
    • unknown's avatar
      BUG#11898 ndb_mgmd not releasing resources, added "ping" on add_listener · 61af1b50
      unknown authored
            + added close of some fd's
            + debug prints
      
      61af1b50
    • unknown's avatar
      Bug #11132, reverted bug-fix, it introduces another bug. Ndbd's may get the same nodeid · 10bd1edb
      unknown authored
      In 4.1 the connection to the management server _must_ stay, that is how we
      ensure that the nodeids are reserved correctly
      
      
      10bd1edb
    • unknown's avatar
      added a comment referring to the bug report · 26aaec17
      unknown authored
      26aaec17
    • unknown's avatar
      BUG#11596 (partial fix), IP addresses not shown in ndb_mgm SHOW command on... · ed89d702
      unknown authored
       BUG#11596 (partial fix), IP addresses not shown in ndb_mgm SHOW command on second ndb_mgmd (or on ndb_mgmd restart)
      
      
      ed89d702
    • unknown's avatar
      Merge mysql.com:/space/my/mysql-4.1.13-clone · 2cdbde76
      unknown authored
      into mysql.com:/space/my/mysql-4.1-build
      
      
      sql/sql_prepare.cc:
        Auto merged
      2cdbde76
    • unknown's avatar
      - manual merge of the fix for BUG#10984: create a "mysql" user group and assign the · ec27a6d3
      unknown authored
        mysql user account to that group in the server postinstall section of the RPM spec
        file
      
      
      support-files/mysql.spec.sh:
        - manual merge of the fix for BUG#10984: create a "mysql" user group and assign the 
          mysql user account to that group in the server postinstall section.
      ec27a6d3
    • unknown's avatar
      RPM spec file improvements: · e944ba20
      unknown authored
      - create a "mysql" user group and assign the mysql user account to that group
        in the server postinstall section. (BUG 10984)
      - backported some changes from the 4.1 RPM spec file (cleanups: removed the incomplete
        Brazilian translations, more consequent use of macros)
      
      
      support-files/mysql.spec.sh:
        - create a "mysql" user group and assign the mysql user account to that group
          in the server postinstall section. (BUG 10984)
        - backported some changes from the 4.1 RPM spec file (cleanups: removed the incomplete
          Brazilian translations, more consequent use of macros)
      e944ba20
    • unknown's avatar
      Jim's fix for the #10443. · 6f5c55a1
      unknown authored
      Fix handling of floats and doubles when using prepared statements             
      API in the embedded server. 
      
      
      sql/sql_prepare.cc:
        Jim's fix for the #10443.
        
        Within the embedded server, there's no need to use float4get()              
        and float8get() for setting parameters, since they are never                
        stored.
      6f5c55a1
  6. 14 Jul, 2005 1 commit
    • unknown's avatar
      Fix ps.test in --ps-protocol · 5868951f
      unknown authored
      
      mysql-test/t/ps.test:
        Disable prepared statements for a part of the test to avoid
        result mismatch.
      5868951f