1. 18 May, 2019 6 commits
  2. 17 May, 2019 5 commits
  3. 16 May, 2019 6 commits
    • Sujatha's avatar
      MDEV-18970: uninited var can be read in gtid_delete_pending() · cacdcfd0
      Sujatha authored
      Problem:
      ========
      gcc 8 -O2 seems to indicate a real error for this code:
      
      direct_pos= table->file->ha_table_flags() & HA_PRIMARY_KEY_REQUIRED_FOR_POSITION;
      
      the warning: /mariadb/10.4/sql/rpl_gtid.cc:980:7:
      warning: 'direct_pos' may be used uninitialized in this function [-Wmaybe-uninitialized]
      
      Analysis:
      =========
      'direct_pos' is a variable which holds 'table_flags'. If this flag is set it means
      that a record within a table can be directly located by using its position. If
      this flag is set to '0' means there is no direct access is available, hence
      index scan must be initiated to locate the record.  This direct_pos is used to
      locate a row within mysql.gtid_slave_pos table for deletion.
      
      Prior to the initialization of 'direct_pos' following steps take place.
      
      1. mysql.gtid_slave_pos table is opened and 'table_opened' flag is set to true.
      2. State check for mysql.gtid_slave_pos table is initiated.
      
      If there is a failure during step2 code will be redirected to the error handling
      part. This error handling code will access uninitialized value of 'direct_pos'.
      This results in above mentioned warning.
      
      Another issue found during analysis is the error handling code uses '!direct_pos'
      to identify if the index is initialized or not. This is incorrect.
      
      The index initialization code is shown below.
      
        if (!direct_pos && (err= table->file->ha_index_init(0, 0)))
          {
            table->file->print_error(err, MYF(0));
            goto end;
          }
      
      In case there is a failure during ha_index_init code will be redirected to end
      part which tries to close the uninitialized index. It will result in an assert
      
      10.4/sql/handler.h:3186: int handler::ha_index_end(): Assertion `inited==INDEX'
      failed.
      
      Fix:
      ===
      Introduce a new variable named 'index_inited'. Set this variable upon successful
      initialization of index initialization otherwise by default it is false. Use
      this variable during error handling.
      cacdcfd0
    • Alexander Barkov's avatar
      A joint patch for MDEV-19284 and MDEV-19285 (INSTANT ALTER) · c59d6395
      Alexander Barkov authored
      This patch fixes:
      
      - MDEV-19284 INSTANT ALTER with ucs2-to-utf16 conversion produces bad data
      - MDEV-19285 INSTANT ALTER from ascii_general_ci to latin1_general_ci produces corrupt data
      
      These regressions were introduced in 10.4.3 by:
      - MDEV-15564 Avoid table rebuild in ALTER TABLE on collation or charset changes
      
      Changes:
      
      1. Cleanup: Adding a helper method
         Field_longstr::csinfo_change_allows_instant_alter(),
         to remove some duplicate code in field.cc.
      
      2. Cleanup: removing Type_handler::Charsets_are_compatible() and static
         function charsets_are_compatible() and
         introducing new methods in the recently added class Charset instead:
         - encoding_allows_reinterpret_as()
         - encoding_and_order_allow_reinterpret_as()
      
      3. Bug fix: Removing the code that allowed instant conversion for
         ascii-to->8bit and ucs2-to->utf16.
         This actually fixes MDEV-19284 and MDEV-19285.
      
      4. Bug fix: Adding a helper method Charset::collation_specific_name().
         The old corresponding code in Type_handler::Charsets_are_compatible()
         was not safe against (badly named) user-defined collations whose
         character set name can be longer than collation name.
      c59d6395
    • Marko Mäkelä's avatar
      MDEV-19485: Crash on purge after ADD SPATIAL INDEX · 9aa80fcf
      Marko Mäkelä authored
      row_build_spatial_index_key(): Return early if the column is missing
      in the table row tuple.
      
      This is a regression that was introduced by
      commit 0e5a4ac2.
      9aa80fcf
    • Sergei Petrunia's avatar
      MDEV-19134: EXISTS() slower if ORDER BY is defined · d448cfc9
      Sergei Petrunia authored
      Step #2: "[ORDER BY ...] LIMIT n" should not prevent EXISTS-to-IN
      conversion, as long as
      - the LIMIT clause doesn't have OFFSET
      - the LIMIT is not "LIMIT 0".
      d448cfc9
    • Sergei Petrunia's avatar
      MDEV-19134: EXISTS() slower if ORDER BY is defined · b1f828a8
      Sergei Petrunia authored
      Step 1: Removal of ORDER BY [LIMIT] from the subquery should be done
      earlier and for broader class of subqueries.
      
      The rewrite was done in Item_in_subselect::select_in_like_transformer(),
      but this had problems:
      - It didn't cover EXISTS subqueries
      - It covered IN-subqueries, but was done after the semi-join transformation
        was considered inapplicable, because ORDER BY was present.
      
      Remaining issue:
      - EXISTS->IN transformation happens before
        check_and_do_in_subquery_rewrites() is called, so it is still prevented
        by the present ORDER BY.
      b1f828a8
    • Anel Husakovic's avatar
      Fix echo message · 366bf104
      Anel Husakovic authored
      366bf104
  4. 15 May, 2019 3 commits
  5. 14 May, 2019 4 commits
  6. 13 May, 2019 4 commits
  7. 11 May, 2019 2 commits
    • Varun Gupta's avatar
      MDEV-13628: ORed condition in pushed index condition is not removed from the WHERE · 6a365e0b
      Varun Gupta authored
      So to push index condition for each join tab we have calculate the index condition that can be pushed and then
      remove this index condition from the original condition. This is done through the function make_cond_remainder.
      The problem is the function make_cond_remainder does not remove index condition when there is an OR operator.
      
      Fixed this by making the function make_cond_remainder to keep in mind of the OR operator.
      Also updated results for multiple test files which were incorrectly updated by the commit e0c1b3f2
      
      code which was supposed to remove the condition present in the index
      condition was not getting executed when the condition had OR operator, with AND the pushed
      index condition was getting removed from where.
      
      This problem affects all versions starting from 5.5 but this is a performance improvement, so fixing it in 10.4
      6a365e0b
    • Monty's avatar
      Fixed that storage/funcs tests works with Aria · 9965966a
      Monty authored
      Problem was that SHOW CREATE didn't remove PAGE_CHECKSUM=1
      9965966a
  8. 10 May, 2019 2 commits
    • hygonsoc's avatar
      add Hygon Dhyana support in check-cpu · 6f3b0999
      hygonsoc authored
      Signed-off-by: default avatarhygonsoc <hygonsoc@gmail.com>
      6f3b0999
    • Daniel Black's avatar
      MDEV-8553: Impossible where for a!=a, a<a, a>a · d2fa5f8c
      Daniel Black authored
      For a table column `a`, the above expressions logically
      equate to false in all cases.
      
      With this patch the optimizer knows about this and queries
      like:
      
      SELECT * FROM t1 WHERE a!=a
      
      no longer need to evaluate a!=a for every row.
      
      The same applies if the expression was `a<a`, or `a>a`
      
      An `EXPLAIN SELECT COOUNT(*) FROM t1 WHERE a<a` will show:
      
      id     select_type     table   type    possible_keys   key     key_len ref     rows    Extra
      1      SIMPLE  NULL    NULL    NULL    NULL    NULL    NULL    NULL    Impossible WHERE
      
      Similarly `NOT (a!=a)` is always true.
      
      EXPLAIN SELECT COUNT(*) FROM t1 WHERE not (a!=a);
      id     select_type     table   type    possible_keys   key     key_len ref     rows    Extra
      1      SIMPLE  NULL    NULL    NULL    NULL    NULL    NULL    NULL    Select tables optimized away
      d2fa5f8c
  9. 09 May, 2019 2 commits
    • Vladislav Vaintroub's avatar
      MDEV-19235 MariaDB Server compiled for 128 Indexes crashes at startup · ad36d380
      Vladislav Vaintroub authored
      With MAX_INDEXIES=64(default), key_map=Bitmap<64> is just a wrapper around
      ulonglong and thus "trivial" (can be bzero-ed, or memcpy-ed, and stays
      valid still)
      
      With MAX_INDEXES=128, key_map = Bitmap<128> is not a "trivial" type
      anymore. The implementation uses MY_BITMAP, and MY_BITMAP contains pointers
      which make Bitmap invalid, when it is memcpy-ed/bzero-ed.
      
      The problem in 10.4 is that there are many new key_map members, inside TABLE
      or KEY, and those are often memcopied and bzeroed
      
      The fix makes Bitmap "trivial", by inlining most of MY_BITMAP functionality.
      pointers/heap allocations are not used anymore.
      ad36d380
    • Monty's avatar
      Disable 5733_tokudb as the result is not stable · 44b8b002
      Monty authored
      44b8b002
  10. 07 May, 2019 1 commit
  11. 06 May, 2019 5 commits