1. 06 Oct, 2011 8 commits
  2. 05 Oct, 2011 4 commits
  3. 04 Oct, 2011 6 commits
    • Sergei Golubchik's avatar
      tests for feedback plugin, · 2a8987bb
      Sergei Golubchik authored
      bugfix: garbage in PLUGIN_VAR_STR variables when INSTALL'ing a plugin
      
      mysql-test/include/default_mysqld.cnf:
        disable feedback plugin by default.
        when enabled - tag is as a test run
      2a8987bb
    • Sergei Golubchik's avatar
      merge feedback plugin · 31f49f26
      Sergei Golubchik authored
      31f49f26
    • Sergei Golubchik's avatar
      fix for static plugins in mariadb. · c0e11db7
      Sergei Golubchik authored
      send "startup" message 5 minutes after startup, not immediately
      
      Makefile.am:
        mariadb uses .la libraries for static plugins.
        mysql - .a libraries
      plug.in:
        mariadb uses .la libraries for static plugins.
        mysql - .a libraries
      sender_thread.cc:
        send "startup" message 5 minutes after startup, not immediately
      url_http.cc:
        avoid "unused variable https" warning
      c0e11db7
    • Sergei Golubchik's avatar
      support for plugins on windows · 1f8cbe22
      Sergei Golubchik authored
      CMakeLists.txt:
        1. add -DSAFEMALLOC -DSAFE_MUTEX in the top-level CMakeLists.txt
           don't force plugins to copy-paste these lines in their CMakeLists.txt
        2.1 search plugin/* for plugins (not only storage/*),
        2.2 recognize MYSQL_PLUGIN (not only MYSQL_STORAGE_ENGINE),
        2.3 extract library names from the plug.in (don't force library names to
            be ha_<engine>.dll and <engine>.lib)
      include/mysql/plugin.h:
        define MYSQL_PLUGIN_EXPORT appropriately
        (backport from 5.5)
      libmysqld/CMakeLists.txt:
        remove unnecessary workaround
      plugin/fulltext/CMakeLists.txt:
        build fulltext example plugin on windows
      storage/maria/CMakeLists.txt:
        The library is called libmaria_s.lib, not maria.lib
      storage/maria/unittest/CMakeLists.txt:
        The library is called libmaria_s.lib, not maria.lib
      storage/myisam/CMakeLists.txt:
        The library is called libmyisam_s.lib, not myisam.lib
      storage/mysql_storage_engine.cmake:
        introduce MYSQL_PLUGIN macro.
        don't force library names to be ha_<engine>.dll and <engine>.lib
      storage/xtradb/CMakeLists.txt:
        remove a condition from include
      win/README:
        don't use deprecated syntax
      win/configure-mariadb.sh:
        don't use deprecated syntax
      win/configure.js:
        1. support MYSQL_PLUGIN in addition to MYSQL_STORAGE_ENGINE.
        2. support plugin/* in addition to storage/*
      1f8cbe22
    • Sergei Golubchik's avatar
      my_gethwaddr() on Solaris and Windows · b3e0991b
      Sergei Golubchik authored
      b3e0991b
    • Sergei Golubchik's avatar
      remove redundant declarations · c7b7c5d6
      Sergei Golubchik authored
      c7b7c5d6
  4. 03 Oct, 2011 1 commit
  5. 01 Oct, 2011 1 commit
  6. 16 Sep, 2011 3 commits
  7. 15 Sep, 2011 2 commits
  8. 14 Sep, 2011 1 commit
  9. 13 Sep, 2011 1 commit
    • Michael Widenius's avatar
      Increased version number · cbad4f48
      Michael Widenius authored
      Give proper error to client on shutdown.
      
      configure.in:
        Increased version number
      mysql-test/mysql-test-run.pl:
        Ignore errors that one can get while running with --mysqld=--log-warnings=2
      mysql-test/r/variables.result:
        Remember original value of log_warnings
      mysql-test/suite/rpl/r/rpl_idempotency.result:
        Ignore errors that one can get while running with --mysqld=--log-warnings=2
      mysql-test/suite/rpl/t/rpl_idempotency.test:
        Ignore errors that one can get while running with --mysqld=--log-warnings=2
      mysql-test/t/variables.test:
        Remember original value of log_warnings
      sql/mysqld.cc:
        Give proper error to close_connection() on shutdown
      storage/maria/ha_maria.cc:
        Added missing DBUG_RETURN
      cbad4f48
  10. 10 Sep, 2011 1 commit
  11. 09 Sep, 2011 1 commit
    • Michael Widenius's avatar
      Fixed that automatic killing of delayed insert thread (in flush, alter table... · b08627f9
      Michael Widenius authored
      Fixed that automatic killing of delayed insert thread (in flush, alter table etc) will not abort auto-repair of MyISAM table.
      Give more information when finding an error in a MyISAM table.
      When killing system thread, use KILL_SYSTEM_THREAD instead of KILL_CONNECTION to make it easier to ignore the signal in sensitive context (like auto-repair)
      Added new kill level: KILL_SERVER that will in the future to be used to signal killed by shutdown.
      Add more warnings about killed connections when warning level > 3
      
      include/myisamchk.h:
        Added counting of printed info/notes
      mysys/mf_iocache.c:
        Remove duplicate assignment
      sql/handler.cc:
        Added test of KILL_SERVER
      sql/log.cc:
        Ignore new 'kill' error ER_NEW_ABORTING_CONNECTION when requesting query error code.
      sql/mysqld.cc:
        Add more warnings for killed connections when warning level > 3
      sql/scheduler.cc:
        Added checks for new kill signals
      sql/slave.cc:
        Ignore new kill signal ER_NEW_ABORTING_CONNECTION
      sql/sp_head.cc:
        Fixed assignment to bool
        Added testing of new kill signals
      sql/sql_base.cc:
        Use KILL_SYSTEM_THREAD to auto-kill system threads
      sql/sql_class.cc:
        Add more warnings for killed connections when warning level > 3
        thd_killed() now ignores KILL_BAD_DATA and THD::KILL_SYSTEM_THREAD as these should not abort sensitive operations.
      sql/sql_class.h:
        Added KILL_SYSTEM_THREAD and KILL_SERVER
      sql/sql_connect.cc:
        Added handling of KILL_SERVER
      sql/sql_insert.cc:
        Use KILL_SYSTEM_THREAD to auto-kill system threads
        Added handling of KILL_SERVER
      sql/sql_parse.cc:
        Add more warnings for killed connections when warning level > 3
        Added checking that thd->abort_on_warning is reset at end of query.
      sql/sql_show.cc:
        Update condition for when a query is 'killed'
      storage/myisam/ha_myisam.cc:
        Added counting of info/notes printed
      storage/myisam/mi_check.c:
        Always print an an error if we find data errors when checking/repairing a MyISAM table.
        When a repair was killed, don't retry repair.
        Added assert if sort_get_next_record() returned an error without an error message.
        Removed nonsence check "if (sort_param->read_cache.error < 0)" in repair.
      storage/myisam/myisamchk.c:
        Added counting of notes printed
      storage/pbxt/src/thread_xt.cc:
        Better error message.
      b08627f9
  12. 08 Sep, 2011 1 commit
    • unknown's avatar
      LP BUG#813418 fix. · 8820f80a
      unknown authored
      The problem was that optimization code did not take into account later feature when instad of NOT before BETWEEN it has negated flag into the Item_func_between inherited from Item_func_neg_opt. So optimizer tried process NOT BETWEEN as BETWEEN.
      
      The patch just switches off the optimisation for NOT BETWEEN as it was before when NOT function was really used.
      8820f80a
  13. 05 Sep, 2011 2 commits
    • unknown's avatar
      Fix of LP BUG#780386. · 9625b891
      unknown authored
        
        ALL subquery should return TRUE if subquery rowa set is empty independently
        of left part.  The problem was that Item_func_(eq,ne,gt,ge,lt,le) do not
        call execution of second argument if first is NULL no in this case subquery
        will not be executed and when Item_func_not_all calls any_value() of the
        subquery or aggregation function which report that there was rows. So for
        NULL < ALL (SELECT...) result was FALSE instead of TRUE.
        
        Fix is just swapping of arguments of Item_func_(eq,ne,gt,ge,lt,le) (with
        changing the operation if it is needed) so that result will be the same
        (for examole a < b is equal to b > a). This fix exploit the fact that
        first argument will be executed in any case.
      9625b891
    • unknown's avatar
      52397f16
  14. 02 Sep, 2011 2 commits
    • Michael Widenius's avatar
      Fixed lp:814238 "safe_mutex issues must be assertions in debug binary" · a0917f26
      Michael Widenius authored
      Added --debug-assert-on-error variable which, if set, will cause safe_mutex to assert if it founds an error.
      
      include/my_sys.h:
        Added my_assert_on_error
      mysys/my_static.c:
        Added my_assert_on_error
      mysys/thr_mutex.c:
        Assert when found wrong mutex usage if my_assert_on_error is set
      sql/mysqld.cc:
        Added setting of my_assert_on_error
      a0917f26
    • unknown's avatar
      LP BUG#823169 fix. · 5579224c
      unknown authored
      For ANY subqueries NULLs should be ignored (if there is other values) when finding max min.
      For ALL subqueries NULLs should be saved if they found.
      
      Optimisation for ALL suqbueries if NULL is possible in the SELECT list with max/min aggregate function switched off.
      
      Some test changed where NULL is not used but optimization with max/min aggregate function important so NOT NULL added.
      
      mysql-test/r/explain.result:
        Forced old optimization.
      mysql-test/r/subselect.result:
        Forced old optimization.
        
        New test suite.
      mysql-test/t/explain.test:
        Forced old optimization.
      mysql-test/t/subselect.test:
        Forced old optimization.
        
        New test suite.
      sql/item_subselect.cc:
        Store converted subquery type.
        
        Switch off aggregate function optimisation for ALL and nulls.
      sql/sql_class.cc:
        Fixed NULL comparison.
      sql/sql_class.h:
        Store converted subquery type.
      5579224c
  15. 01 Sep, 2011 3 commits
    • Michael Widenius's avatar
      Added logging of all errors from my_read/my_write/my_pread/my_pwrite/my_open &... · b7339445
      Michael Widenius authored
      Added logging of all errors from my_read/my_write/my_pread/my_pwrite/my_open & my_malloc to mysqld error log if one sets log-warning to 10 or 11
      The idea is that my_global_flags is ored to the MyFlags parameter for the above functions if the MY_WME flag is not set.
      As the my_global_flags has ME_JUST_INFO (mark error as 'note') and possible ME_NOREFRESH (write error to log) this will force mysqld to log the not critical error to the log as a note.
      
      
       
      
      include/my_sys.h:
        Moved MY_SYNC_DIR to ensure it never clashes with ME_JUST_INFO
        Added my_global_flags
      mysql-test/Makefile.am:
        Removed not used bugs directory
      mysys/my_init.c:
        Added my_global_flags, a variable that is ored to MyFlags in a those mysys functions we want extra logging.
      mysys/my_malloc.c:
        Added support for my_global_flags
      mysys/my_open.c:
        Added support for my_global_flags
      mysys/my_pread.c:
        Added support for my_global_flags
      mysys/my_read.c:
        Added support for my_global_flags
      mysys/my_static.c:
        Added my_global_flags
      mysys/my_write.c:
        Added support for my_global_flags
      sql/mysqld.cc:
        Set my_global_flags for warning levels 10 & 11
      sql/sql_base.cc:
        Don't increment unhandled errors for notes or warnings.
      b7339445
    • Michael Widenius's avatar
      Fixed non critical buffer overflow bug in open_binary_frm() that could cause ASSERT · 20cb0a6c
      Michael Widenius authored
      Added more printing of errors to myisamchk.
      
      mysys/mf_iocache.c:
        Write error message if failed seek.
      sql/table.cc:
        Fixed buffer overflow bug:
        - It's not enough to check for mysql_version to to detect partion indicator as the version may have been updated by mysql_upgrade.
      storage/myisam/ha_myisam.cc:
        Don't log same error twice.
        Don't reset log_all_errors if it's set
      storage/myisam/mi_check.c:
        Fixed bug that caused repair() to not report error if called twice (as when doing retry)
        More printing of errors.
      storage/myisam/sort.c:
        Set my_errno in case of out of memory errors.
      20cb0a6c
    • Michael Widenius's avatar
      Added variable ARIA_CHECKPOINT_LOG_ACTIVITY to allow one to specify how often... · 821eafcd
      Michael Widenius authored
      Added variable ARIA_CHECKPOINT_LOG_ACTIVITY to allow one to specify how often we should do a checkpoint.
      Added more error printing to log if log_warnings > 2
      Give an error if checkpoint record is not correct,
      
      mysql-test/suite/maria/r/compat_aliases.result:
        Added ARIA_CHECKPOINT_LOG_ACTIVITY
      mysql-test/suite/maria/r/maria3.result:
        Added ARIA_CHECKPOINT_LOG_ACTIVITY
      storage/maria/ha_maria.cc:
        Added ARIA_CHECKPOINT_LOG_ACTIVITY
        Added more error printing to log if log_warnings > 2
        Added db and table name to error message when printing to log
      storage/maria/ma_check.c:
        Fixed bug where we didn't reset some variables between repair() calls
      storage/maria/ma_checkpoint.c:
        Made maria_checkpoint_min_activity global.
        Don't do checkpoint if no data logged.
        Changed test for if we should do checkpoint to test separately for if log has grown or if we have had a lot of of cache writes.
      storage/maria/ma_recovery.c:
        Give an error if checkpoint record is not correct
      storage/maria/trnman.c:
        Don't print not needed long_transaction_id entries for checkpoints.
      821eafcd
  16. 29 Aug, 2011 1 commit
    • Michael Widenius's avatar
      Added logging of all messages (also system warnings) one gets during a MyISAM... · 68d4e393
      Michael Widenius authored
      Added logging of all messages (also system warnings) one gets during a MyISAM recovery or auto-recovery.
      
      
      sql/mysqld.cc:
        Log errors if thd->log_all_errors is set
      sql/sql_class.cc:
        Add log_all_errors
      sql/sql_class.h:
        Add log_all_errors
      storage/myisam/ha_myisam.cc:
        Write db and table name for all logged errors
        Log errors also during auto_recovery
        During auto_recovery, set thd->log_all_errors if log_warnings >2 to ensure that system errors are also logged to file
      68d4e393
  17. 16 Aug, 2011 2 commits