1. 04 May, 2006 14 commits
    • unknown's avatar
      Fixed a test case that got broken during merge. · 99f7bc65
      unknown authored
      99f7bc65
    • unknown's avatar
      Merge ua141d10.elisa.omakaista.fi:/home/my/bk/mysql-4.1 · b6b05068
      unknown authored
      into  ua141d10.elisa.omakaista.fi:/home/my/bk/mysql-5.0
      
      
      mysql-test/r/gis-rtree.result:
        Auto merged
      mysql-test/r/ansi.result:
        Merged from 4.1
      mysql-test/r/auto_increment.result:
        Merged from 4.1
      mysql-test/r/mysqldump.result:
        Merged from 4.1
      mysql-test/r/symlink.result:
        Merged from 4.1
      mysql-test/t/auto_increment.test:
        Merged from 4.1
      mysql-test/t/mysqldump.test:
        Merged from 4.1
      sql/set_var.cc:
        Merged from 4.1
      sql/sql_show.cc:
        Merged from 4.1
      b6b05068
    • unknown's avatar
      Merge jamppa@bk-internal.mysql.com:/home/bk/mysql-5.0 · 7aed267e
      unknown authored
      into  ua141d10.elisa.omakaista.fi:/home/my/bk/mysql-5.0
      
      7aed267e
    • unknown's avatar
      Added test case for Bug#18712: Truncation problem. The test · 96b1fa1a
      unknown authored
      is only to make sure that this will not be fixed, as it is
      intended behaviour. Documentation will be improved accordingly.
      
      96b1fa1a
    • unknown's avatar
      Merge rurik.mysql.com:/home/igor/mysql-5.0 · 36bfdc21
      unknown authored
      into  rurik.mysql.com:/home/igor/dev/mysql-5.0-0
      
      36bfdc21
    • unknown's avatar
      Fixed heap_btree test failure on 64-bit boxes. · 24860544
      unknown authored
      24860544
    • unknown's avatar
      Merge jamppa@bk-internal.mysql.com:/home/bk/mysql-4.1 · 029e4410
      unknown authored
      into  hundin.mysql.fi:/home/jani/mysql-4.1
      
      
      sql/sql_show.cc:
        Auto merged
      029e4410
    • unknown's avatar
      Merge tnurnberg@bk-internal.mysql.com:/home/bk/mysql-4.1 · 7c68a3ee
      unknown authored
      into  mysql.com:/home/mysql-4.1-19025e
      
      7c68a3ee
    • unknown's avatar
      Merge abotchkov@bk-internal.mysql.com:/home/bk/mysql-5.0 · 163f0bf1
      unknown authored
      into mysql.com:/home/hf/work/mysql-5.0.mrg
      
      163f0bf1
    • unknown's avatar
      Merge mysql.com:/home/hf/work/mysql-4.1.mrg · 8c243188
      unknown authored
      into mysql.com:/home/hf/work/mysql-5.0.mrg
      
      
      mysql-test/mysql-test-run.pl:
        Auto merged
      mysql-test/r/mysqltest.result:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      8c243188
    • unknown's avatar
      test result fixed · 6104ece0
      unknown authored
      
      mysql-test/r/mysqltest.result:
        result fixed
      6104ece0
    • unknown's avatar
      Post-review changes. · 102f40a7
      unknown authored
      102f40a7
    • unknown's avatar
      Merge rurik.mysql.com:/home/igor/mysql-5.0 · 3ef8178e
      unknown authored
      into  rurik.mysql.com:/home/igor/dev/mysql-5.0-0
      
      
      mysql-test/r/subselect.result:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      3ef8178e
    • unknown's avatar
      Bug#19025 4.1 mysqldump doesn't correctly dump "auto_increment = [int]" · 64828eeb
      unknown authored
      mysqldump / SHOW CREATE TABLE will show the NEXT available value for
      the PK, rather than the *first* one that was available (that named in
      the original CREATE TABLE ... AUTO_INCREMENT = ... statement).
      
      This should produce correct and robust behaviour for the obvious use
      cases -- when no data were inserted, then we'll produce a statement
      featuring the same value the original CREATE TABLE had; if we dump
      with values, INSERTing the values on the target machine should set the
      correct next_ID anyway (and if not, we'll still have our AUTO_INCREMENT =
      ... to do that). Lastly, just the CREATE statement (with no data) for
      a table that saw inserts would still result in a table that new values
      could safely be inserted to).
      
      There seems to be no robust way however to see whether the next_ID
      field is > 1 because it was set to something else with CREATE TABLE
      ... AUTO_INCREMENT = ..., or because there is an AUTO_INCREMENT column
      in  the table (but no initial value was set with AUTO_INCREMENT = ...)
      and then one or more rows were INSERTed, counting up next_ID. This
      means that in both cases, we'll generate an AUTO_INCREMENT =
      ... clause in SHOW CREATE TABLE / mysqldump.  As we also show info on,
      say, charsets even if the user did not explicitly give that info in
      their own CREATE TABLE, this shouldn't be an issue.
      
      As per above, the next_ID will be affected by any INSERTs that have
      taken place, though.  This /should/ result in correct and robust
      behaviour, but it may look non-intuitive to some users if they CREATE
      TABLE ... AUTO_INCREMENT = 1000 and later (after some INSERTs) have
      SHOW CREATE TABLE give them a different value (say, CREATE TABLE
      ... AUTO_INCREMENT = 1006), so the docs should possibly feature a
      caveat to that effect.
      
      It's not very intuitive the way it works now (with the fix), but it's
      *correct*.  We're not storing the original value anyway, if we wanted
      that, we'd have to change on-disk representation?
      
      If we do dump/load cycles with empty DBs, nothing will change.  This
      changeset includes an additional test case that proves that tables
      with rows will create the same next_ID for AUTO_INCREMENT = ... across
      dump/restore cycles.
      
      Confirmed by support as likely solution for client's problem.
      
      
      mysql-test/r/auto_increment.result:
        test for creation of AUTO_INCREMENT=... clause
      mysql-test/r/gis-rtree.result:
        Add AUTO_INCREMENT=... clauses where appropriate
      mysql-test/r/mysqldump.result:
        show that AUTO_INCREMENT=... will survive dump/restore cycles
      mysql-test/r/symlink.result:
        Add AUTO_INCREMENT=... clauses where appropriate
      mysql-test/t/auto_increment.test:
        test for creation of AUTO_INCREMENT=... clause
      mysql-test/t/mysqldump.test:
        show that AUTO_INCREMENT=... will survive dump/restore cycles
      sql/sql_show.cc:
        Add AUTO_INCREMENT=... to output of SHOW CREATE TABLE if there is an
        AUTO_INCREMENT column, and NEXT_ID > 1 (the default).  We must not print
        the clause for engines that do not support this as it would break the
        import of dumps, but as of this writing, the test for whether
        AUTO_INCREMENT columns are allowed and wether AUTO_INCREMENT=...
        is supported is identical, !(file->table_flags() & HA_NO_AUTO_INCREMENT))
        Because of that, we do not explicitly test for the feature,
        but may extrapolate its existence from that of an AUTO_INCREMENT column.
      64828eeb
  2. 03 May, 2006 22 commits
    • unknown's avatar
      Merge svojtovich@bk-internal.mysql.com:/home/bk/mysql-5.0 · 82debf53
      unknown authored
      into  production.mysql.com:/usersnfs/svojtovich/mysql-5.0
      
      82debf53
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.0 · 288aaf1a
      unknown authored
      into mysql.com:/home/hf/work/mysql-5.0.mrg
      
      
      sql/sql_table.cc:
        Auto merged
      288aaf1a
    • unknown's avatar
      Merge pnousiainen@bk-internal.mysql.com:/home/bk/mysql-4.1 · 9bf3234c
      unknown authored
      into  mysql.com:/space/pekka/ndb/version/my50
      
      
      mysql-test/r/ndb_blob.result:
        Auto merged
      mysql-test/t/ndb_blob.test:
        Auto merged
      ndb/include/kernel/signaldata/TcKeyReq.hpp:
        Auto merged
      ndb/include/ndbapi/NdbBlob.hpp:
        Auto merged
      ndb/src/ndbapi/NdbBlob.cpp:
        Auto merged
      ndb/test/ndbapi/testBlobs.cpp:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      ndb/tools/delete_all.cpp:
        nuts
      9bf3234c
    • unknown's avatar
      Merge aivanov@bk-internal.mysql.com:/home/bk/mysql-5.0 · 644d0b9d
      unknown authored
      into  mysql.com:/home/alexi/innodb/mysql-5.0-ss521
      
      644d0b9d
    • unknown's avatar
      Applied innodb-5.0-ss521 snapshot. · b055c169
      unknown authored
       Fixed BUG#19366: "consistent_snapshot.test fails".
      
      
      innobase/include/dict0dict.ic:
        Applied innodb-5.0-ss521 snapshot.
         Remove too strict assertions from some dict_table_t
         accessor functions (bug #19366).
      b055c169
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-4.1 · 3d57e628
      unknown authored
      into mysql.com:/home/hf/work/mysql-4.1.mrg
      
      3d57e628
    • unknown's avatar
      Merge aivanov@bk-internal.mysql.com:/home/bk/mysql-4.1 · 4581901b
      unknown authored
      into  mysql.com:/home/alexi/innodb/mysql-4.1-ss26
      
      4581901b
    • unknown's avatar
      Merge mysql.com:/home/alexi/innodb/mysql-4.1-ss26-work · e5dc6c7f
      unknown authored
      into  mysql.com:/home/alexi/innodb/mysql-5.0-ss521-work
       Null-merge.
      
      
      innobase/include/dict0dict.ic:
        Null-merge.
      e5dc6c7f
    • unknown's avatar
      Applied innodb-4.1-ss26 snapshot. · 6d74e0ee
      unknown authored
       Fixed BUG#19366: "consistent_snapshot.test fails".
      
      
      innobase/include/dict0dict.ic:
        Applied innodb-4.1-ss26 snapshot.
         Remove too strict assertions from some dict_table_t
         accessor functions (Bug#19366).
      6d74e0ee
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-4.1 · 5fe0c00d
      unknown authored
      into mysql.com:/home/hf/work/mysql-4.1.mrg
      
      
      mysql-test/mysql-test-run.pl:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      5fe0c00d
    • unknown's avatar
      merging fix · 44832fa7
      unknown authored
      44832fa7
    • unknown's avatar
      merging fix · 2614a125
      unknown authored
      2614a125
    • unknown's avatar
      Merge mysql.com:/home/hf/work/mysql-5.0.18455 · 672ec2e8
      unknown authored
      into mysql.com:/home/hf/work/mysql-5.0.mrg
      
      672ec2e8
    • unknown's avatar
      merging · dc52a279
      unknown authored
      
      mysql-test/t/sp_notembedded.test:
        Auto merged
      dc52a279
    • unknown's avatar
      merging · 22482ca0
      unknown authored
      
      sql/handler.h:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      22482ca0
    • unknown's avatar
      Merge svojtovich@bk-internal.mysql.com:/home/bk/mysql-5.0 · f586163f
      unknown authored
      into  april.(none):/home/svoj/devel/mysql/BUG17810/mysql-5.0
      
      f586163f
    • unknown's avatar
      Merge april.(none):/home/svoj/devel/mysql/BUG18160/mysql-5.0 · d424fe72
      unknown authored
      into  april.(none):/home/svoj/devel/mysql/BUG17810/mysql-5.0
      
      d424fe72
    • unknown's avatar
      merging · 1dfc1e03
      unknown authored
      
      mysql-test/mysql-test-run.pl:
        Auto merged
      mysql-test/mysql-test-run.sh:
        Auto merged
      mysql-test/r/analyze.result:
        Auto merged
      mysql-test/t/analyze.test:
        Auto merged
      mysql-test/t/mysql_client_test.test:
        Auto merged
      mysql-test/t/mysqltest.test:
        Auto merged
      1dfc1e03
    • unknown's avatar
      Merge hf@192.168.21.28:work/mysql-4.1.16892 · 010cd169
      unknown authored
      into mysql.com:/home/hf/work/mysql-4.1.mrg
      
      010cd169
    • unknown's avatar
      Merge mysql.com:/home/hf/work/mysql-4.1.15442 · 5267bc2b
      unknown authored
      into mysql.com:/home/hf/work/mysql-4.1.mrg
      
      5267bc2b
    • unknown's avatar
      Merge mysql.com:/home/hf/work/mysql-4.1.15225 · 864d8312
      unknown authored
      into mysql.com:/home/hf/work/mysql-4.1.mrg
      
      
      sql/sql_table.cc:
        Auto merged
      864d8312
    • unknown's avatar
      Fixed bug #14292: performance degradation for a benchmark query. · 80ab59b4
      unknown authored
      This performance degradation was due to the fact that some
      cost evaluation code added into 4.1 in the function find_best was
      not merged into the code of the function best_access_path added
      together with other code for greedy optimizer.
      Added a parameter to the function print_plan. The parameter contains
      accumulated cost for a given partial join.
       
      The patch does not include a special test case since this performance
      degradation is hard to reproduse with a simple example.
      
      TODO: make the function find_best use the function best_access_path
      in order to remove duplication of code which might result in incomplete
      merges in the future.
      
      
      mysql-test/r/delete.result:
        Fixed bug #14292: performance degradation for a benchmark query.
        Adjusted test results.
      mysql-test/r/subselect.result:
        Fixed bug #14292: performance degradation for a benchmark query.
        Adjusted test results.
      sql/mysql_priv.h:
        Fixed bug #14292: performance degradation for a benchmark query.
        Added a parameter to the function print_plan. The parameter contains
        accumulated cost for a given partial join.
      sql/sql_select.cc:
        Fixed bug #14292: performance degradation for a benchmark query.
        This performance degradation was due to the fact that some
        cost evaluation code added into 4.1 in the function find_best was
        not merged into the code of the function best_access_path added
        together with other code for greedy optimizer.
      sql/sql_test.cc:
        Fixed bug #14292: performance degradation for a benchmark query.
        Added a parameter to the function print_plan. The parameter contains
        accumulated cost for a given partial join.
      80ab59b4
  3. 02 May, 2006 4 commits