- 14 Feb, 2020 2 commits
-
-
Sergei Petrunia authored
Partitioning storage now supports MRR but doesn't support Index Condition Pushdown (aka ICP). This causes counter-intuitive query plans for queries that use BKA and conditions that depend on index fields: - If the condition refers to other tables, BKA's variant of ICP is used to handle it. - If the condition depends on this table only, the optimizer will try to use regular ICP for it, which will fail because the storage engine doesn't support ICP. Make the optimizer be smarter in the second case: if we were not able to use regular ICP, use BKA's variant of ICP..
-
Daniel Black authored
No longer used.
-
- 13 Feb, 2020 2 commits
-
-
Eugene Kosov authored
-
Eugene Kosov authored
MDEV-21669 InnoDB: Table ... contains <n> indexes inside InnoDB, which is different from the number of indexes <n> defined in the MariaDB compare_keys_but_name(): do not use KEY_PART_INFO::field for Field::is_equal(). Following the logic of that code we need to compare fields of a table. But KEY_PART_INFO::field sometimes (when key part is shorter than table field) is a different field. In that case Field::is_equal() returns incorrect result and problems occur. KEY_PART_INFO::field may become some strange field in open_frm_error open_table_from_share(). I think this is an incorrect logic, some tecnhical debt. I'm not fixing it right now, because I don't have time. But I'm making Field::field_length a const class member. Then, the only fishy code which changed that field requires now a const_cast<>. I'm bringing attention to that code with it. This change should not affect logic of the program in any way.
-
- 12 Feb, 2020 1 commit
-
-
Sergey Vojtovich authored
MDEV-20867 - Perform careful review of "Server crashes with BACKUP STAGE and FLUSH TABLE table_name" Reverted original patch (c2e0a0b1). For consistency with "LOCK TABLE <table_name> READ" and "FLUSH TABLES WITH READ LOCK", which are forbidden under "BACKUP STAGE", forbid "FLUSH TABLE <table_name> FOR EXPORT" and "FLUSH TABLE <table_name> WITH READ LOCK" as well. It'd allow consistent fixes for problems like MDEV-18643.
-
- 11 Feb, 2020 1 commit
-
-
Oleksandr Byelkin authored
-
- 10 Feb, 2020 5 commits
-
-
Oleksandr Byelkin authored
-
Anel Husakovic authored
-
Oleksandr Byelkin authored
-
Oleksandr Byelkin authored
-
Vladislav Vaintroub authored
Context involves semicolon batching, and the error starts 10.2 No reproducible examples were made yet, but TCP trace suggests multiple packets that are "squeezed" together (e.g overlong OK packet that has a trailer which is belongs to another packet) Remove thd->get_stmt_da()->set_skip_flush() when processing a batch. skip_flush stems from the COM_MULTI code, which was checked in during 10.2 (and is never used) The fix is confirmed to work, when evaluated by bug reporter (one of them) We never reproduced it locally, with multiple tries thus the root cause analysis is still missing.
-
- 09 Feb, 2020 4 commits
-
-
Jan Lindström authored
Problem seems to be the fact that we did not enforce correct applier thread numbers after every command that effects them. Test changes only.
-
Jan Lindström authored
* Remove those tests that will not be supported on that release. * Make sure that correct tests are disabled and have MDEVs * Sort test names This should not be merged upwards.
-
Jan Lindström authored
Problem seems to be the fact that we did not enforce correct applier thread numbers after every command that effects them. Test changes only.
-
Jan Lindström authored
* Remove those tests that will not be supported on that release. * Make sure that correct tests are disabled and have MDEVs * Sort test names This should not be merged upwards.
-
- 08 Feb, 2020 2 commits
-
-
Marko Mäkelä authored
The symbol SRV_MASTER_PURGE_INTERVAL became unused in mysql/mysql-server@42f36919584e82c621dbec1e69fd05ab023c54c6 when separate purge threads were introduced in MySQL 5.6.5.
-
Igor Babaev authored
Do not materialize a semi-join nest if it contains a materialized derived table /view that potentially can be subject to the split optimization. Splitting of materialization of such nest would help, but currently there is no code to support this technique.
-
- 07 Feb, 2020 4 commits
-
-
Oleksandr Byelkin authored
-
Oleksandr Byelkin authored
-
Thirunarayanan Balathandayuthapani authored
- n_ext value may be less than dtuple_get_n_ext(dtuple) when PK is being updated and new record inherits the externally stored fields from delete mark old record.
-
Thirunarayanan Balathandayuthapani authored
- Added the test case in innodb_fts suite - Updated copyright year in row0mysql.cc
-
- 06 Feb, 2020 3 commits
-
-
Thirunarayanan Balathandayuthapani authored
Problem: ======= After discarding the table, fts_optimize_thread aborts during shutdown. InnoDB fails to remove the table from fts_optimize_wq and it leads to the fts_optimize_thread to lookup for the auxiliary table and fails. Fix: ==== While discarding the fts table, remove the table from fts_optimize_wq.
-
Marko Mäkelä authored
buf_flush_or_remove_pages(): Only define BUF_LRU_DROP_SEARCH_SIZE and dependent code when the adaptive hash index has been enabled.
-
Aurélien LEQUOY authored
JIRA:https://jira.mariadb.org/browse/MDEV-17292 Closes #1443
-
- 05 Feb, 2020 4 commits
-
-
Oleksandr Byelkin authored
Quotes added to output.
-
Oleksandr Byelkin authored
For automatic number of opened files limit take into account number of table instances for table cache
-
Oleksandr Byelkin authored
MDEV-21616: Server crash when using "SET STATEMENT max_statement_time=0 FOR desc xxx" lead to collapse Main select should be pushed first.
-
Marko Mäkelä authored
row_log_table_get_pk_old_col(): For replacing a NULL value for a column of the being-added primary key, look up the correct default value, even if columns had been instantly reordered or dropped earlier. This ought to have been broken ever since commit 0e5a4ac2 (MDEV-15562).
-
- 04 Feb, 2020 4 commits
-
-
Sergei Petrunia authored
-
Marko Mäkelä authored
ha_innobase::commit_inplace_alter_table(): After ALTER_STORED_COLUMN_ORDER, ensure that the virtual column metadata will be reloaded also when the table is not being rebuilt.
-
Jan Lindström authored
We need to release global system variables mutex before doing wsrep_init to avoid race with next show status and we need to save wsrep_on value as it is changed on wsrep_init. Added test case.
-
Julius Goryavsky authored
-
- 03 Feb, 2020 4 commits
-
-
Jan Lindström authored
When wsrep_on is changed to ON we might need to run wsrep_init if wsrep-provider is set and wsrep is not inited.
-
Marko Mäkelä authored
Use of freed memory is better caught by AddressSanitizer, especially with ASAN_POISON_MEMORY_REGION that is aliased by MEM_NOACCESS and UNIV_MEM_FREE.
-
Marko Mäkelä authored
The column INFORMATION_SCHEMA.INNODB_MUTEXES.NAME is not populated ever since commit 2e814d47 applied the InnoDB changes from MySQL 5.7.9 to MariaDB Server 10.2.2. Since the same commit, the view is only providing information about rw_lock_t, not any mutexes. For now, let us convert the source code file name and line number of the rw_lock_t creation into a name. A better option in the future might be to store the information somewhere where it can be looked up by mysql_pfs_key_t, and possibly to remove the CREATE_FILE and CREATE_LINE columns.
-
Sachin authored
MDEV-20001 Potential dangerous regression: INSERT INTO >=100 rows fail for myisam table with HASH indexes Problem:- So the issue is when we do bulk insert with rows > MI_MIN_ROWS_TO_DISABLE_INDEXES(100) , We try to disable the indexes to speedup insert. But current logic also disables the long unique indexes. Solution:- In ha_myisam::start_bulk_insert if we find long hash index (HA_KEY_ALG_LONG_HASH) we will not disable the index. This commit also refactors the mi_disable_indexes_for_rebuild function, Since this is function is called at only one place, it is inlined into start_bulk_insert mi_clear_key_active is added into myisamdef.h because now it is also used in ha_myisam.cc file. (Same is done for Aria Storage engine)
-
- 02 Feb, 2020 4 commits
-
-
Aleksey Midenkov authored
-
Aleksey Midenkov authored
Use FLOOR rounding for DECIMAL_RESULT item_expr in partition function.
-
Aleksey Midenkov authored
See also original report: http://bugs.debian.org/946671 Using mysqlhotcopy, the following error occurs: DBD::mysql::db do failed: You can't use locks with log tables at /usr/bin/mysqlhotcopy line 545. Author: Paul Szabo psz@maths.usyd.edu.au http://www.maths.usyd.edu.au/u/psz/ School of Mathematics and Statistics University of Sydney Australia
-
Aleksey Midenkov authored
-