1. 28 Apr, 2023 2 commits
  2. 27 Apr, 2023 2 commits
  3. 26 Apr, 2023 5 commits
  4. 25 Apr, 2023 2 commits
    • Andrei's avatar
      MDEV-30620 Trying to lock uninitialized LOCK_parallel_entry · e22a57da
      Andrei authored
      The error was seen by a number of mtr tests being caused
      by overdue initialization of rpl_parallel::LOCK_parallel_entry.
      Specifically, SHOW-SLAVE-STATUS might find in
      rpl_parallel::workers_idle() a gtid domain hash entry
      already inserted whose mutex had not done
      mysql_mutex_init().
      
      Fixed with swapping the mutex init and the its entry's stack insertion.
      
      Tested with a generous number of `mtr --repeat` of a few of the reported
      to fail tests, incl rpl.parallel_backup.
      e22a57da
    • Sergei Petrunia's avatar
      MDEV-31121: ANALYZE statement produces 0 for all timings in embedded server · a72b2c3f
      Sergei Petrunia authored
      Timers require my_timer_init() call.
      It was made only in mysqld_main(). Call it also from init_embedded_server().
      a72b2c3f
  5. 24 Apr, 2023 5 commits
    • Brandon Nesterenko's avatar
      MDEV-30430: Enabling system versioning on tables without primary key breaks replication · 29fb0410
      Brandon Nesterenko authored
      When replicating MDL events for a table that uses system versioning
      without primary keys, ensure that for data sets with duplicate
      records, the updates to these records with duplicates are enacted on
      the correct row. That is, there was a bug (reported in MDEV-30430)
      such that the function to find the row to update would stop after
      finding the first matching record. However, in the absence of
      primary keys, the version of the record is needed to compare the row
      to ensure we are updating the correct one.
      
      The fix, therefore, updates the record comparison functionality to
      use system version columns when there are no primary keys on the
      table.
      
      Reviewed By:
      ============
      Andrei Elkin <andrei.elkin@mariadb.com>
      29fb0410
    • Brandon Nesterenko's avatar
      MDEV-28798: Cosmetic Changes Only · 4ec3dca3
      Brandon Nesterenko authored
      Removed trailing whitespaces
      4ec3dca3
    • Brandon Nesterenko's avatar
      MDEV-28798: Previously Binlog Encrypted Master Segfaults on Binlog Dump with Using_Gtid=Slave_Pos · d3e7dba3
      Brandon Nesterenko authored
      Problem:
      ========
      A master can segfault if it can't set up decryption for its binary
      log during a binlog dump with Using_Gtid=Slave_Pos. If slave
      connects using GTID mode, the master will call into
      log.cc::get_gtid_list_event(), which iterate through binlog events
      looking for a Gtid_list_log_event. On an encrypted binlog that the
      master cannot decrypt, the first event will be a
      START_ENCRYPTION_EVENT which will call into the following decryption branch
      
      if (fdle->start_decryption((Start_encryption_log_event*) ev))
        errormsg= ‘Could not set up decryption for binlog.’;
      
      The event iteration however, does not stop in spite of this error.
      The master will try to read the next event, but segfault while
      trying to decrypt it because decryption failed to initialize.
      
      Solution:
      ========
      Break the event iteration if decryption cannot be set up.
      
      Reviewed By:
      ============
      Andrei Elkin <andrei.elkin@mariadb.com>
      d3e7dba3
    • Igor Babaev's avatar
      MDEV-31102 Crash when pushing condition into view defined as union · 5dc9a6b4
      Igor Babaev authored
      This bug could manifest itself at the first execution of prepared statement
      created for queries using a materialized view defined as union. A crash
      could happen for sure if the query contained a condition pushable into
      the view and this condition was over the column defined via a complex string
      expression requiring implicit conversion from one charset to another for
      some of its sub-expressions. The bug could cause crashes when executing
      PS for some other queries whose optimization needed building clones for
      such expressions.
      
      This bug was introduced in the patch for MDEV-29988 where the class
      Item_direct_ref_to_item was added. The implementations of the virtual
      methods get_copy() and build_clone() were invalid for the class and this
      could cause crashes after the method build_clone() was called for
      expressions containing objects of the Item_direct_ref_to_item type.
      
      Approved by Sergei Golubchik <serg@mariadb.com>
      5dc9a6b4
    • Alexander Barkov's avatar
      A cleanup for MDEV-30968 mariadb-backup does not copy Aria logs if aria_log_dir_path is used · d3e394b3
      Alexander Barkov authored
      Fixing buildbot failures on mariabackup.aria_log_dir_path_rel.
      
      The problem was that directory_exists() was called with the
      relative aria_log_dir_path value, while the current directory
      in mariadb-backup is not necessarily equal to datadir when MTR is running.
      
      Fix:
      
      - Moving building the absolute path un level upper:
        from the function copy_back_aria_logs() to the function copy_back().
      - Passing the built absolute path to both directory_exists() and
        copy_back_aria_logs() as a parameter.
      d3e394b3
  6. 22 Apr, 2023 1 commit
  7. 21 Apr, 2023 3 commits
    • Alexander Barkov's avatar
      MDEV-30968 mariadb-backup does not copy Aria logs if aria_log_dir_path is used · 9f98a2ac
      Alexander Barkov authored
      - `mariadb-backup --backup` was fixed to fetch the value of the
         @@aria_log_dir_path server variable and copy aria_log* files
         from @@aria_log_dir_path directory to the backup directory.
         Absolute and relative (to --datadir) paths are supported.
      
         Before this change aria_log* files were copied to the backup
         only if they were in the default location in @@datadir.
      
      - `mariadb-backup --copy-back` now understands a new my.cnf and command line
         parameter --aria-log-dir-path.
      
        `mariadb-backup --copy-back` in the main loop in copy_back()
         (when copying back from the backup directory to --datadir)
         was fixed to ignore all aria_log* files.
      
         A new function copy_back_aria_logs() was added.
         It consists of a separate loop copying back aria_log* files from
         the backup directory to the directory specified in --aria-log-dir-path.
         Absolute and relative (to --datadir) paths are supported.
         If --aria-log-dir-path is not specified,
         aria_log* files are copied to --datadir by default.
      
      - The function is_absolute_path() was fixed to understand MTR style
        paths on Windows with forward slashes, e.g.
         --aria-log-dir-path=D:/Buildbot/amd64-windows/build/mysql-test/var/...
      9f98a2ac
    • Daniel Black's avatar
      MDEV-30713 field length handling for CONNECT engine · da1c91fb
      Daniel Black authored
      fp->field_length was unsigned and therefore the negative
      condition around it.
      
      Backport of cc182aca fixes it, however to correct the
      consistent use of types pcf->Length needs to be unsigned
      too.
      
      At one point pcf->Precision is assigned from pcf->Length so
      that's also unsigned.
      
      GetTypeSize is assigned to length and has a length argument.
      A -1 default value seemed dangerious to case, so at least 0
      should assert if every hit.
      da1c91fb
    • Oleksandr Byelkin's avatar
      Merge branch '10.3' into 10.4 · 3d27f6d7
      Oleksandr Byelkin authored
      3d27f6d7
  8. 20 Apr, 2023 1 commit
    • Mikhail Chalov's avatar
      Minimize unsafe C functions usage - replace strcat() and strcpy() · fc6e8a3d
      Mikhail Chalov authored
      Similar to 567b6812 continue to replace use of strcat() and
      strcpy() with safer options strncat() and strncpy().
      
      All new code of the whole pull request, including one or several files
      that are either new files or modified ones, are contributed under the BSD-new
      license. I am contributing on behalf of my employer Amazon Web Services
      fc6e8a3d
  9. 19 Apr, 2023 5 commits
  10. 18 Apr, 2023 2 commits
    • Daniele Sciascia's avatar
      MDEV-30955 Explicit locks released too early in rollback path · feeeacc4
      Daniele Sciascia authored
      Assertion `thd->mdl_context.is_lock_owner()` fires when a client is
      disconnected, while transaction and and a table is opened through
      `HANDLER` interface.
      Reason for the assertion is that when a connection closes, its ongoing
      transaction is eventually rolled back in
      `Wsrep_client_state::bf_rollback()`. This method also releases explicit
      which are expected to survive beyond the transaction lifetime.
      This patch also removes calls to `mysql_ull_cleanup()`. User level
      locks are not supported in combination with Galera, making these calls
      unnecessary.
      feeeacc4
    • Daniele Sciascia's avatar
      MDEV-30862 Assertion `mode_ == m_high_priority' failed · bc3bfcf9
      Daniele Sciascia authored
      CREATE TABLE AS SELECT is not supported in combination with streaming
      replication.
      bc3bfcf9
  11. 17 Apr, 2023 1 commit
    • Florian Weimer's avatar
      rocksdb: Define _GNU_SOURCE during fallocate CMake probe · f575de39
      Florian Weimer authored
      The glibc headers declare fallocate only if _GNU_SOURCE is defined.
      Without this change, the probe fails with C compilers which do not
      support implicit function declarations even if the system does in
      fact support the fallocate function.
      
      Upstream rocksdb does not need this because the probe is run with the
      C++ compiler, and current g++ versions define _GNU_SOURCE
      automatically.
      f575de39
  12. 13 Apr, 2023 2 commits
    • Daniel Black's avatar
      alloca() fix · 2e1c532b
      Daniel Black authored
      Corrections from 1e58b8af.
      * Re-add #pragma alloca for AIX - now in my_alloca.h
      2e1c532b
    • Julius Goryavsky's avatar
      MDEV-30402: Encrypted mariabackup SST breaks on distributions with newer socat · d1a4315f
      Julius Goryavsky authored
      This commit adds a new 'no-sni' option to socat which is required to
      properly authenticate with newer socat versions (after version 1.7.4+).
      This option is needed to disable the automatic use of the SNI feature
      (Server Name Indication) since the SST script directly specifies the
      commonname if necessary and automatic activation of the SNI feature
      is unnecessary in such scenarios.
      d1a4315f
  13. 12 Apr, 2023 2 commits
    • Igor Babaev's avatar
      MDEV-20773 Error from UPDATE when estimating selectivity of a range · ef4d0994
      Igor Babaev authored
      This bug could affect multi-update statements as well as single-table
      update statements processed as multi-updates when the where condition
      contained a range condition over a non-indexed varchar column. The
      optimizer calculates selectivity of such range conditions using histograms.
      For each range the buckets containing endpoints of the the range are
      determined with a procedure that stores the values of the endpoints in the
      space of the record buffer where values of the columns are usually stored.
      For a range over a varchar column the value of a endpoint may exceed the
      size of the buffer and in such case the value is stored with truncation.
      This truncations cannot affect the result of the calculation of the range
      selectivity as the calculation employes only the beginning of the value
      string. However it can trigger generation of an unexpected error on this
      truncation if an update statement is processed.
      This patch prohibits truncation messages when selectivity of a range
      condition is calculated for a non-indexed column.
      
      Approved by Oleksandr Byelkin <sanja@mariadb.com>
      ef4d0994
    • Alexander Barkov's avatar
      MDEV-31039 mariadb-backup: remove global variables ds_data and ds_meta · 7bcfa00a
      Alexander Barkov authored
      This is a non-functional change.
      
      simplifying the code logic:
      - removing global variables ds_data and ds_meta
      - passing these variables as parameters to functions instead
      - adding helper classes: Datasink_free_list and Backup_datasinks
      - moving some function accepting a ds_ctxt parameter
        as methods to ds_ctxt.
      7bcfa00a
  14. 11 Apr, 2023 1 commit
  15. 10 Apr, 2023 1 commit
  16. 06 Apr, 2023 2 commits
  17. 05 Apr, 2023 1 commit
    • Sergei Golubchik's avatar
      MDEV-25887 "Got notification message from PID xxxx, but reception only... · 79e27a6b
      Sergei Golubchik authored
      MDEV-25887 "Got notification message from PID xxxx, but reception only permitted for main PID yyyy" in systemd during SST
      
      server has systemd support and calls sd_notify() to communicate
      the status to systemd.
      
      mariabackup links the whole server in, but it should not notify
      systemd, because it's not started or managed by systemd.
      79e27a6b
  18. 04 Apr, 2023 2 commits