1. 11 Oct, 2004 1 commit
    • unknown's avatar
      Fix for BUG#5949 "error code 1223 in binlog when using innobackup": · c5f9a412
      unknown authored
      when one connection had done FLUSH TABLES WITH READ LOCK, some updates, and then COMMIT,
      it was accepted but my_error() was called and so, while client got no error, error was logged in binlog.
      We now don't call my_error() in this case; we assume the connection know what it does.
      This problem was specific to 4.0.21. The change is needed to make replication work with existing versions of innobackup.
      
      
      sql/lock.cc:
        If a connection has done FLUSH TABLES WITH READ LOCK and now is doing COMMIT, don't give error
        (applies only if it's the same connection; others' COMMITs are still blocked).
      c5f9a412
  2. 24 Sep, 2004 1 commit
    • unknown's avatar
      Fix for BUG#3248 "Doc says MyISAM warns if disk full but it does not": · c8682133
      unknown authored
      we force the message to the error log, and we make it more informative;
      we treat EDQUOT like ENOSPC.
      
      
      mysys/errors.c:
        more informative message
      mysys/my_fstream.c:
        Treat EDQUOT like ENOSPC.
      mysys/my_pread.c:
        Treat EDQUOT like ENOSPC.
      mysys/my_write.c:
        Treat EDQUOT like ENOSPC.
      mysys/mysys_priv.h:
        Define EDQUOT when it does not exist. Finally decided to put it here after discussion with Monty:
        as this constant is used only in 3 files only in mysys/, I don't make it visible everywhere
        (there currently is no file of choice for such defines; my_base.h does not contain any).
        Using a value which never happens avoids collisions.
      sql/mysqld.cc:
        If ME_NOREFRESH, we write message to error log, even if it has been saved for client (because if operation
        is hanging, the message does not get to client now; example is MyISAM waiting for free disk space).
      c8682133
  3. 23 Sep, 2004 4 commits
  4. 22 Sep, 2004 3 commits
  5. 20 Sep, 2004 1 commit
    • unknown's avatar
      When coyright text is changed, autotools must be run after all · e4e919f9
      unknown authored
      other actions, as otherwise timestamps of "config.h.in" will 
      cause re-run on compilation machine (fatal version problem!).
      
      
      Build-tools/mysql-copyright:
        1) Ensure that autotools are run as last action, after copyright
        change, for proper timestamps.
        2) Move the trimming of subtrees to an own function "trim_the_fat".
        3) Align 4.0 and 4.1 versions.
      e4e919f9
  6. 19 Sep, 2004 3 commits
  7. 18 Sep, 2004 3 commits
    • unknown's avatar
      Merge mysql.com:/home/mydev/mysql-4.0 · 9dbd8179
      unknown authored
      into mysql.com:/home/mydev/mysql-4.0-bug2831
      
      
      9dbd8179
    • unknown's avatar
      bug#2831 - --extenral-locking does not fully work with --myisam-recover. · a7919a11
      unknown authored
      Changed the semantics of open_count so that it is decremented
      at every unlock (if it was incremented due to data changes).
      So it indicates a crash, if it is non-zero after a lock.
      The table will then be repaired.
      
      
      myisam/mi_close.c:
        bug#2831 - --extenral-locking does not fully work with --myisam-recover.
        To avoid flushing the open_count at every unlock,
        we need to do so at close at least.
      myisam/mi_locking.c:
        bug#2831 - --extenral-locking does not fully work with --myisam-recover.
        open_count is now decremented at unlock (from a writelock) with
        mi_unlock_open_count(). After every new lock the state is read
        from the index file and the open_count checked. If not zero,
        another server must have crashed, so the table is marked as crashed.
        In certain situations the decremented open_count mut be flushed to
        the index file. I tried to keep these extra flushes as seldom as possible.
      sql/ha_myisam.cc:
        bug#2831 - --extenral-locking does not fully work with --myisam-recover.
        Added code to repair the table, if it is marked crashed after
        successful locking and the --myisam-recover option is set.
      sql/sql_table.cc:
        This does not really belong to the bugfix for #2831.
        But it was detected during fixing the external locking.
      a7919a11
    • unknown's avatar
  8. 17 Sep, 2004 1 commit
    • unknown's avatar
      Bug#5553 - Multi table UPDATE IGNORE fails on dup key · e84eb55a
      unknown authored
        We don't want the update to abort when IGNORE is specified
      
      
      mysql-test/r/update.result:
        Bug#5553 - UPDATE IGNORE fails on dup key
          New test
      mysql-test/t/update.test:
        Bug#5553 - UPDATE IGNORE fails on dup key
          New test
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      e84eb55a
  9. 16 Sep, 2004 1 commit
    • unknown's avatar
      dict0dict.h, dict0dict.c, row0row.c, pars0opt.c: · a2d94d92
      unknown authored
        Fix bug #5180: having a column prefix index in the primary key, and the same column fully in a secondary key could cause an assertion failure in row_build_row_ref()
      
      
      innobase/pars/pars0opt.c:
        Fix bug #5180: having a column prefix index in the primary key, and the same column fully in a secondary key could cause an assertion failure in row_build_row_ref()
      innobase/row/row0row.c:
        Fix bug #5180: having a column prefix index in the primary key, and the same column fully in a secondary key could cause an assertion failure in row_build_row_ref()
      innobase/dict/dict0dict.c:
        Fix bug #5180: having a column prefix index in the primary key, and the same column fully in a secondary key could cause an assertion failure in row_build_row_ref()
      innobase/include/dict0dict.h:
        Fix bug #5180: having a column prefix index in the primary key, and the same column fully in a secondary key could cause an assertion failure in row_build_row_ref()
      a2d94d92
  10. 14 Sep, 2004 4 commits
  11. 13 Sep, 2004 4 commits
    • unknown's avatar
      sync0arr.c: · e6503e1e
      unknown authored
        Correct the comment on the 'waiting' field in sync_cell_struct
      
      
      innobase/sync/sync0arr.c:
        Correct the comment on the 'waiting' field in sync_cell_struct
      e6503e1e
    • unknown's avatar
      row0mysql.h: · fb91884f
      unknown authored
        Improve the comment on stored_select_lock_type
      ha_innodb.cc:
        Let InnoDB remember select_lock_type inside LOCK TABLES, also over plain consistent read SELECTs; fix Bug #5538 : assertion failure when using mysqldump with the -l option; in MERGING this patch to 4.1, there may be PROBLEMS; that is because previous patch was never merged to 4.1; Heikki Tuuri has to polish the code in 4.1 after this patch has been merged.
      
      
      sql/ha_innodb.cc:
        Let InnoDB remember select_lock_type inside LOCK TABLES, also over plain consistent read SELECTs; fix Bug #5538 : assertion failure when using mysqldump with the -l option; in MERGING this patch to 4.1, there may be PROBLEMS; that is because previous patch was never merged to 4.1; Heikki Tuuri has to polish the code in 4.1 after this patch has been merged.
      innobase/include/row0mysql.h:
        Improve the comment on stored_select_lock_type
      fb91884f
    • unknown's avatar
    • unknown's avatar
      Fix for bug #4809 (Backticks not handled in mysql) · 4015c585
      unknown authored
      
      client/mysql.cc:
        Code added to handle backticks
      4015c585
  12. 11 Sep, 2004 1 commit
    • unknown's avatar
      os0file.c: · c1e84276
      unknown authored
        Add more precise diagnostics about the state of the I/O threads of InnoDB; print in SHOW INNODB STATUS if the event wait semaphore of each I/O thread is set
      
      
      innobase/os/os0file.c:
        Add more precise diagnostics about the state of the I/O threads of InnoDB; print in SHOW INNODB STATUS if the event wait semaphore of each I/O thread is set
      c1e84276
  13. 10 Sep, 2004 2 commits
  14. 09 Sep, 2004 10 commits
  15. 08 Sep, 2004 1 commit
    • unknown's avatar
      [This patch has already been approved by Serge. I am recommitting and pushing... · 773a256e
      unknown authored
      [This patch has already been approved by Serge.  I am recommitting and pushing from a new repository because there were other changesets that couldn't be pushed.]
      
      BUG# 5229 --password=foobar does not override the empty 'password' option in the my.cnf
      This is a backport of a change made by jani in the 4.1 tree.
      
      mysql.cc:
        Add tty_password=0 in the p case handling in get_one_option
      
      
      client/mysql.cc:
        Add tty_password=0 in the p case handling in get_one_option
      773a256e