1. 02 Jul, 2007 1 commit
  2. 01 Jul, 2007 5 commits
    • unknown's avatar
      Corrected a test case. · 052477f1
      unknown authored
      052477f1
    • unknown's avatar
      Post.merge fixes · 0af678ae
      unknown authored
      Fixed warnings
      Fixed error numbers
      
      
      mysql-test/extra/rpl_tests/rpl_loaddata.test:
        Fixed warnings
      mysql-test/r/ndb_single_user.result:
        Post-merge fixes
        Changed error numbers
      mysql-test/t/bigint.test:
        Fixed warnings
      mysql-test/t/ndb_single_user.test:
        Post-merge fixes
        Changed error numbers
      0af678ae
    • unknown's avatar
      Made test case platform independent. · 1c38ba3b
      unknown authored
      1c38ba3b
    • unknown's avatar
      Post-merge fix. · 9521abc5
      unknown authored
      9521abc5
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.0-opt · 7b7b720c
      unknown authored
      into  olga.mysql.com:/home/igor/dev-opt/mysql-5.1-opt
      
      
      mysql-test/r/binary.result:
        Auto merged
      mysql-test/r/ctype_collate.result:
        Auto merged
      mysql-test/r/ctype_utf8.result:
        Auto merged
      mysql-test/t/binary.test:
        Auto merged
      mysql-test/t/create.test:
        Auto merged
      mysql-test/t/ctype_utf8.test:
        Auto merged
      sql/field_conv.cc:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item_subselect.cc:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      sql/item_sum.h:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql-common/client.c:
        Auto merged
      sql/sql_select.h:
        Auto merged
      sql/table.cc:
        Auto merged
      storage/myisam/mi_open.c:
        Auto merged
      strings/ctype-simple.c:
        Auto merged
      mysql-test/r/create.result:
        Manual merge.
      mysql-test/r/subselect.result:
        Manual merge.
      mysql-test/r/type_enum.result:
        Manual merge.
      mysql-test/t/type_enum.test:
        Manual merge.
      mysql-test/include/mix1.inc:
        Manual merge.
      mysql-test/r/innodb_mysql.result:
        Manual merge.
      mysql-test/t/subselect.test:
        Manual merge.
      sql/sql_parse.cc:
        Manual merge.
      storage/myisam/mi_key.c:
        Manual merge.
      7b7b720c
  3. 30 Jun, 2007 5 commits
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-4.1-opt · 0796e7c2
      unknown authored
      into  olga.mysql.com:/home/igor/mysql-5.0-opt
      
      
      mysql-test/r/type_enum.result:
        Auto merged
      mysql-test/t/type_enum.test:
        Auto merged
      sql/field_conv.cc:
        SCCS merged
      0796e7c2
    • unknown's avatar
      Post-merge fixes. · 9ad37fe1
      unknown authored
      
      sql/ha_partition.cc:
        Post-merge fixes.
        The new function HA_EXTRA_INSERT_WITH_UPDATE needs to be handled in
        ha_partition::extra().
      storage/federated/ha_federated.cc:
        Post-merge fixes.
        Removed leftover characters.
        Added a missing brace.
        Fixed and improved parenthesis handling in ha_federated::append_stmt_insert().
        Moved code from HA_EXTRA_RESET to ha_federated::reset().
      storage/federated/ha_federated.h:
        Post-merge fixes.
        Changed byte to uchar.
        Added declaration for ha_federated::reset().
      9ad37fe1
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · 4dd3c3e9
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B29157-5.1-opt
      
      4dd3c3e9
    • unknown's avatar
      Merge synthia.local:/home/mydev/mysql-5.0-axmrg · ba71ecd1
      unknown authored
      into  synthia.local:/home/mydev/mysql-5.1-axmrg
      
      
      mysql-test/r/federated.result:
        Auto merged
      mysql-test/t/federated.test:
        Auto merged
      include/my_base.h:
        Manual merge
      sql/sql_insert.cc:
        Manual merge
      storage/federated/ha_federated.cc:
        Manual merge
      storage/federated/ha_federated.h:
        Manual merge
      ba71ecd1
    • unknown's avatar
      Merge synthia.local:/home/mydev/mysql-5.0-ateam · cc3ace49
      unknown authored
      into  synthia.local:/home/mydev/mysql-5.0-axmrg
      
      cc3ace49
  4. 29 Jun, 2007 21 commits
    • unknown's avatar
      Merge synthia.local:/home/mydev/mysql-5.0-axmrg · 513b7b9e
      unknown authored
      into  synthia.local:/home/mydev/mysql-5.1-axmrg
      
      513b7b9e
    • unknown's avatar
      Merge synthia.local:/home/mydev/mysql-5.1-amain · 3d535df5
      unknown authored
      into  synthia.local:/home/mydev/mysql-5.1-axmrg
      
      
      configure.in:
        Auto merged
      libmysql/libmysql.c:
        Auto merged
      3d535df5
    • unknown's avatar
      Merge synthia.local:/home/mydev/mysql-5.1-ateam · e1b7035f
      unknown authored
      into  synthia.local:/home/mydev/mysql-5.1-axmrg
      
      e1b7035f
    • unknown's avatar
      Merge anubis.xiphis.org:/usr/home/antony/work/p2-bug25513.5 · 0663ced9
      unknown authored
      into  anubis.xiphis.org:/usr/home/antony/work/5.0-engines-merge
      
      0663ced9
    • unknown's avatar
      fix Visual Studio build - strictness of compiler could not cast · 8314baa2
      unknown authored
      pointer into a BOOL type.
      
      8314baa2
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0-opt-29205 · 1f866bcf
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      1f866bcf
    • unknown's avatar
      Fixed bug #29205. · bf7a9ad2
      unknown authored
      When a UNION statement forced conversion of an UTF8
      charset value to a binary charset value, the byte
      length of the result values was truncated to the
      CHAR_LENGTH of the original UTF8 value.
      
      
      sql/item.cc:
        Fixed bug #29205.
        The calculation of data length was modified in
        the Item_type_holder::join_types method to take into
        account possible conversion of a multibyte charset
        value to a binary charset value, when each
        multibyte character is converted into a sequence
        of bytes (not to a single byte of binary charset).
      mysql-test/t/ctype_utf8.test:
        Updated test case for bug #29205.
      mysql-test/r/ctype_utf8.result:
        Updated test case for bug #29205.
      bf7a9ad2
    • unknown's avatar
      Merge anubis.xiphis.org:/usr/home/antony/work/mysql-5.0-engines · c72506ba
      unknown authored
      into  anubis.xiphis.org:/usr/home/antony/work/5.0-engines-merge
      
      c72506ba
    • unknown's avatar
      Merge anubis.xiphis.org:/usr/home/antony/work/p2-bug25511.5 · 556cba1a
      unknown authored
      into  anubis.xiphis.org:/usr/home/antony/work/p2-bug25513.5
      
      
      sql/ha_federated.cc:
        Auto merged
      556cba1a
    • unknown's avatar
      add and amend comments for clarity · 0c182379
      unknown authored
      
      include/my_base.h:
        amend comment for clarity
      sql/ha_federated.cc:
        add comment
      0c182379
    • unknown's avatar
      Merge synthia.local:/home/mydev/mysql-5.0-amain · 20782321
      unknown authored
      into  synthia.local:/home/mydev/mysql-5.0-axmrg
      
      20782321
    • unknown's avatar
      Merge synthia.local:/home/mydev/mysql-5.0-ateam · f5693a39
      unknown authored
      into  synthia.local:/home/mydev/mysql-5.0-axmrg
      
      f5693a39
    • unknown's avatar
      Merge mysqldev@production:/data0/mysqldev/my/mysql-5.1-release · a75eedfe
      unknown authored
      into  synthia.local:/home/mydev/mysql-5.1-axmrg
      
      a75eedfe
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 49ab98f9
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/29261-bug-5.0-opt-mysql
      
      49ab98f9
    • unknown's avatar
      Bug#29261: Sort order of the collation wasn't used when comparing trailing · 80824e67
      unknown authored
      spaces.
      
      When the my_strnncollsp_simple function compares two strings and one is a prefix
      of another then this function compares characters in the rest of longer key
      with the space character to find whether the longer key is greater or less.
      But the sort order of the collation isn't used in this comparison. This may
      lead to a wrong comparison result, wrongly created index or wrong order of the
      result set of a query with the ORDER BY clause.
      
      Now the my_strnncollsp_simple function uses collation sort order to compare
      the characters in the rest of longer key with the space character.
      
      
      mysql-test/t/ctype_collate.test:
        Added a test case for the bug#29261: Sort order of the collation wasn't used
        when comparing trailing spaces.
      mysql-test/r/ctype_collate.result:
        Added a test case for the bug#29261: Sort order of the collation wasn't used
        when comparing trailing spaces.
      strings/ctype-simple.c:
        Bug#29261: Sort order of the collation wasn't used when comparing trailing
        spaces.
        Now the my_strnncollsp_simple function uses collation sort order to compare
        the characters in the rest of longer key with the space character.
      80824e67
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · b01a04eb
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B27333-gcov-5.0-opt
      
      b01a04eb
    • unknown's avatar
      Bug#27333: subquery grouped for aggregate of outer · 7d6c4d8d
      unknown authored
      query / no aggregate of subquery
       The optimizer counts the aggregate functions that 
       appear as top level expressions (in all_fields) in 
       the current subquery. Later it makes a list of these
       that it uses to actually execute the aggregates in
       end_send_group().
       That count is used in several places as a flag whether
       there are aggregates functions.
       While collecting the above info it must not consider
       aggregates that are not aggregated in the current 
       context. It must treat them as normal expressions 
       instead. Not doing that leads to incorrect data about
       the query, e.g. running a query that actually has no
       aggregate functions as if it has some (and hence is
       expected to return only one row).
       Fixed by ignoring the aggregates that are not aggregated
       in the current context. 
       One other smaller omission discovered and fixed in the 
       process : the place of aggregation was not calculated for
       user defined functions. Fixed by calling 
       Item_sum::init_sum_func_check() and 
       Item_sum::check_sum_func() as it's done for the rest of 
       the aggregate functions.
      
      
      mysql-test/r/subselect.result:
        Bug #27333: test case
      mysql-test/t/subselect.test:
        Bug #27333: test case
      sql/item_subselect.cc:
        Bug#27333: need select_lex to filter out
         aggregates that are not aggregated in
         the current select.
      sql/item_sum.cc:
        Bug#27333: need select_lex to filter out
         aggregates that are not aggregated in
         the current select.
      sql/item_sum.h:
        Bug#27333: calculate the place of 
         aggregation for user defined functions.
      sql/sql_select.cc:
        Bug#27333: When counting the aggregated functions
         and collecting a list of them we must not consider
         the aggregates that are not aggregated in the local
         context as "local" : i.e. we must treat them as 
         normal functions and not add them to the aggregate
         functions list.
      sql/sql_select.h:
        Bug#27333: need select_lex to filter out
         aggregates that are not aggregated in
         the current select.
      7d6c4d8d
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.1-opt · 64f8e49d
      unknown authored
      into  mysql.com:/home/hf/work/29247/my51-29247
      
      
      sql-common/client.c:
        Auto merged
      sql/handler.h:
        Auto merged
      64f8e49d
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.0-opt · d71167d6
      unknown authored
      into  mysql.com:/home/hf/work/29247/my50-29247
      
      
      sql-common/client.c:
        Auto merged
      d71167d6
    • unknown's avatar
      Merge mysql.com:/home/hf/work/29252/my51-29252 · ca8ba45d
      unknown authored
      into  mysql.com:/home/hf/work/29247/my51-29247
      
      ca8ba45d
    • unknown's avatar
      Merge mysql.com:/home/hf/work/29247/my50-29247 · f1d9fefc
      unknown authored
      into  mysql.com:/home/hf/work/29247/my51-29247
      
      
      sql-common/client.c:
        Auto merged
      f1d9fefc
  5. 28 Jun, 2007 8 commits
    • unknown's avatar
      Bug#25513 · 9cb9e9bc
      unknown authored
        "Federared Transactions Failure"
        Bug occurs when the user performs an operation which inserts more than 
        one row into the federated table and the federated table references a 
        remote table stored within a transactional storage engine. When the
        insert operation for any one row in the statement fails due to 
        constraint violation, the federated engine is unable to perform 
        statement rollback and so the remote table contains a partial commit. 
        The user would expect a statement to perform the same so a statement 
        rollback is expected.
        This bug was fixed by implementing  bulk-insert handling into the
        federated storage engine. This will relieve the bug for most common
        situations by enabling the generation of a multi-row insert into the
        remote table and thus permitting the remote table to perform 
        statement rollback when neccessary.
        The multi-row insert is limited to the maximum packet size between 
        servers and should the size overflow, more than one insert statement 
        will be sent and this bug will reappear. Multi-row insert is disabled
        when an "INSERT...ON DUPLICATE KEY UPDATE" is being performed.
        The bulk-insert handling will offer a significant performance boost 
        when inserting a large number of small rows.
      This patch builds on Bug29019 and Bug25511
      
      
      sql/ha_federated.cc:
        bug25513
          new member methods:
            start_bulk_insert() - initializes memory for bulk insert
            end_bulk_insert() - sends any remaining bulk insert and frees memory
            append_stmt_insert() - create the INSERT statement
      sql/ha_federated.h:
        bug25513
          new member value:
            bulk_insert
          new member methods:
            start_bulk_insert(), end_bulk_insert(), append_stmt_insert()
          make member methods private:
            read_next(), index_read_idx_with_result_set()
      mysql-test/r/federated_innodb.result:
        New BitKeeper file ``mysql-test/r/federated_innodb.result''
      mysql-test/t/federated_innodb-slave.opt:
        New BitKeeper file ``mysql-test/t/federated_innodb-slave.opt''
      mysql-test/t/federated_innodb.test:
        New BitKeeper file ``mysql-test/t/federated_innodb.test''
      9cb9e9bc
    • unknown's avatar
      Bug#25511 · 01f714fd
      unknown authored
        "Federated INSERT failures"
        Federated does not correctly handle "INSERT...ON DUPLICATE KEY UPDATE"
        However, implementing such support is not reasonably possible without
        increasing complexity of the storage engine: checking that constraints
        on remote server match local server and parsing error messages.
        This patch causes 'ON DUPLICATE KEY' to fail with ER_DUP_KEY message
        if a conflict occurs and not to fail silently.
      
      
      include/my_base.h:
        bug25511
          new storage engine hint: HA_EXTRA_INSERT_WITH_UPDATE
      mysql-test/r/federated.result:
        test for bug25511
      mysql-test/t/federated.test:
        test for bug25511
      sql/ha_federated.cc:
        bug25511
          implement support for handling HA_EXTRA_INSERT_WITH_UPDATE hint
      sql/ha_federated.h:
        bug25511
          new property: insert_dup_update
      sql/sql_insert.cc:
        bug25511
          implement support for HA_EXTRA_INSERT_WITH_UPDATE
          When checking duplicates flag, if it is DUP_UPDATE, send hint
          to the storage engine.
      01f714fd
    • unknown's avatar
      Bug #29157: UPDATE, changed rows incorrect · ecc52aeb
      unknown authored
      Sometimes the number of really updated rows (with changed
      column values) cannot be determined at the server level
      alone (e.g. if the storage engine does not return enough
      column values to verify that). So the only dependable way
      in such cases is to let the storage engine return that
      information if possible.
      Fixed the bug at server level by providing a way for the 
      storage engine to return information about wether it 
      actually updated the row or the old and the new column 
      values are the same. It can do that by returning 
      HA_ERR_RECORD_IS_THE_SAME in ha_update_row().
      Note that each storage engine may choose not to try to
      return this status code, so this behaviour remains 
      storage engine specific.
      
      
      include/my_base.h:
        Bug #29157: handle the row not updated special return value
      sql/log_event.cc:
        Bug #29157: handle the row not updated special return value
      sql/sp.cc:
        Bug #29157: handle the row not updated special return value
      sql/sql_acl.cc:
        Bug #29157: handle the row not updated special return value
      sql/sql_insert.cc:
        Bug #29157: handle the row not updated special return value
      sql/sql_servers.cc:
        Bug #29157: handle the row not updated special return value
      sql/sql_update.cc:
        Bug #29157: handle the row not updated special return value
      ecc52aeb
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · 9ea9d974
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B26564-5.1-opt
      
      9ea9d974
    • unknown's avatar
      BUG#29207 - archive table reported as corrupt by check table · e02c97f6
      unknown authored
      After merge fix.
      
      
      mysql-test/r/archive.result:
        After merge fix.
      e02c97f6
    • unknown's avatar
      events_bugs.test didn't remove all the objects it created · 4343cfe2
      unknown authored
      what caused some consequitive tests failures
      
      
      mysql-test/r/events_bugs.result:
        test result fixed
      mysql-test/t/events_bugs.test:
        typo fixed, event removed
      4343cfe2
    • unknown's avatar
      Bug#29019 · 54bad031
      unknown authored
        "REPLACE/INSERT IGNORE/UPDATE IGNORE doesn't work"
        Federated does not record neccessary HA_EXTRA flags in order to
        support REPLACE/INSERT IGNORE/UPDATE IGNORE.
        Implement ::extra() to capture flags neccessary for functionality.
      New function append_ident() to better escape identifiers consistantly.
      
      
      mysql-test/r/federated.result:
        test for bug29019
      mysql-test/t/federated.test:
        test for bug29019
      sql/ha_federated.cc:
        Bug29019
          Federated does not record neccessary HA_EXTRA flags in order to
          support REPLACE/INSERT IGNORE/UPDATE IGNORE.
          Implement ::extra() to capture flags neccessary for functionality.
        New function append_ident() to better escape identifiers consistantly.
      sql/ha_federated.h:
        bug29019
          add 2 member values to ha_federated class
            ignore_duplicates and replace_duplicates.
          add 1 member method to ha_federated class
            extra()
      54bad031
    • unknown's avatar
      Merge mysql.com:/home/svoj/devel/mysql/BUG29250/mysql-5.0-engines · a37272b2
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/BUG29250/mysql-5.1-engines
      
      
      mysql-test/t/archive.test:
        Auto merged
      mysql-test/r/archive.result:
        Use local.
      storage/archive/ha_archive.cc:
        Manual merge.
      a37272b2