1. 08 Apr, 2010 3 commits
  2. 07 Apr, 2010 1 commit
    • Michael Widenius's avatar
      Fixed suppression of compiler/test warnings · 23652768
      Michael Widenius authored
      Fixed some timing issues in test suite
      
      
      
      mysql-test/mysql-test-run.pl:
        Added suppression of errors that comes when master is killed before slave has connect (like with rpl_udf.test)
      mysql-test/suite/funcs_1/datadict/processlist_priv.inc:
        Wait for check thread to end
      mysql-test/suite/pbxt/t/status.test:
        Added longer sleep to avoid timing issue
      support-files/compiler_warnings.supp:
        Fixed wrong suppression
      23652768
  3. 06 Apr, 2010 1 commit
    • Michael Widenius's avatar
      Removed compiler warnings · c8b3cd4a
      Michael Widenius authored
      Removed random failures from test suite
      
      mysql-test/extra/rpl_tests/rpl_insert_id_pk.test:
        Make test predicatable.
      mysql-test/include/maria_empty_logs.inc:
        We can't use 'Threads_connected' for syncronization, as the 'check_warnings' thread that just quit may still be counted in 'Threads_connected'
        Now we just wait until MySQLD answers again, which should be good enough for our purposes
      mysql-test/suite/binlog/r/binlog_index.result:
        Updated results file
      mysql-test/suite/binlog/t/binlog_index-master.opt:
        Added option file to not get stack traces in .err file.
      mysql-test/suite/binlog/t/binlog_index.test:
        Added 'flush tables' to remove warning about crashed suppression file from logs
      mysql-test/suite/pbxt/r/multi_statement.result:
        Updated results
      mysql-test/suite/pbxt/t/multi_statement-master.opt:
        Added options so that slow query testing makes sense
      sql/events.cc:
        Don't write Event Scheduler startup message if warnings are turned off.
      sql/handler.cc:
        Removed compiler warning
      sql/log.cc:
        Removed compiler warning
      sql/mysqld.cc:
        Added option 'test-expect-abort'; If this is set, we don't write message to log in case of 'DBUG_ABORT'.
        (Gives us smaller, easier to read log files)
      sql/set_var.cc:
        Removed compiler warning
      sql/slave.cc:
        Removed compiler warning
      sql/sql_plugin.cc:
        Don't write warnings about disabled plugin if using --log_warnings=0
      storage/xtradb/include/ut0lst.h:
        Removed compiler warning
      support-files/compiler_warnings.supp:
        Supress warning from xtradb
      c8b3cd4a
  4. 01 Apr, 2010 2 commits
  5. 31 Mar, 2010 2 commits
    • Michael Widenius's avatar
      Added missing space from last push · 197c7c01
      Michael Widenius authored
      Fixed compiler warnings
      
      mysys/my_gethostbyname.c:
        Added missing space from last push
      storage/xtradb/handler/i_s.cc:
        Removed not used variable
      storage/xtradb/log/log0recv.c:
        Removed not used variable
      197c7c01
    • Michael Widenius's avatar
      Fixed compiler warnings · 69203a6b
      Michael Widenius authored
      Fixed random failure in test system
      
      BUILD/compile-solaris-sparc:
        Addex EXTRA_FLAGS to configure line (to get rid of warnings for not initialzed variables on buildbot)
      cmd-line-utils/libedit/filecomplete.c:
        Remove not used variables
      mysql-test/suite/rpl/r/rpl_optimize.result:
        Updated result
      mysql-test/suite/rpl/t/rpl_optimize.test:
        Use sync_salve_with_master to ensure cleanup on slave
      support-files/compiler_warnings.supp:
        Added suppression of libedit files
      69203a6b
  6. 30 Mar, 2010 1 commit
    • Michael Widenius's avatar
      Removed compiler warning · d5d4905f
      Michael Widenius authored
      Disable pbxt for test cases not using pbxt (speeds up test suite)
      
      extra/comp_err.c:
        Added cast to get rid of compiler warning
      extra/libevent/kqueue.c:
        Added cast to get rid of compiler warning
      mysql-test/lib/mtr_cases.pm:
        Use --skip-pbxt for test cases that doesn't need pbxt
        Collect default-storage-engine from suite.opt file (should actually be my.cnf file, but that wasn't easy to do)
      mysql-test/suite/pbxt/t/suite.opt:
        Added marker for mysql-test-run.pl that this suite require pbxt
      mysys/mf_keycache.c:
        Use LINT_INIT() to remove compiler warnings
      mysys/my_gethostbyname.c:
        Remove compiler warnings
      sql/handler.cc:
        Reset variable that may be used uninitialized
      sql/item.h:
        Remove compiler warning
      sql/mysqld.cc:
        Use LINT_INIT() to remove compiler warnings
      sql/sql_class.h:
        Remove compiler warning
      sql/sql_table.cc:
        Ensure variable is always set (to remove compiler warning)
      sql/sql_view.cc:
        Use LINT_INIT() to remove compiler warnings
      storage/maria/ma_loghandler.c:
        Use LINT_INIT() to remove compiler warnings
      storage/myisammrg/ha_myisammrg.cc:
        Fixed wrong type to printf
      storage/myisammrg/myrg_open.c:
        Use LINT_INIT() to remove compiler warnings
      storage/xtradb/include/ut0lst.h:
        Trivial change of macro to remove compiler warning
      strings/ctype-ucs2.c:
        Use LINT_INIT() to remove compiler warnings
      strings/ctype-utf8.c:
        Use LINT_INIT() to remove compiler warnings
      support-files/compiler_warnings.supp:
        Suppress some not relevant warnings
      unittest/mysys/waiting_threads-t.c:
        Don't use ftruncate() as this gives warning about ignored return value
      d5d4905f
  7. 29 Mar, 2010 1 commit
    • Michael Widenius's avatar
      Fixed random failure in test system · 3517ce24
      Michael Widenius authored
      Removed and suppressed compiler warnings
      
      
      mysql-test/suite/parts/t/rpl_partition.test:
        Mark as big test (as test takes > 5 minutes)
      mysql-test/suite/rpl/t/rpl_row_trig003.test:
        Fixed random failure
      sql/item_create.cc:
        Renamed create -> create_builder() to avoid compiler warnings about function hidden by others
      sql/net_serv.cc:
        Removed compiler warning
      support-files/compiler_warnings.supp:
        Supress some warnings
        Remove suppresstion from set_var.cc, as this has already been fixed
        Added missing \ before .c
        Added suppression of warnings that are due to gcc bug (.*discards qualifiers from pointer target type.*)
      3517ce24
  8. 28 Mar, 2010 1 commit
    • Michael Widenius's avatar
      Fixed compiler warnings and sporadic failures in test cases · 691b295a
      Michael Widenius authored
      
      mysql-test/extra/rpl_tests/rpl_tmp_table_and_DDL.test:
        Added missing sync_slave_with_master; Fixes random failures
      mysql-test/include/default_mysqld.cnf:
        default-character-set -> character-set-server (removes warning in error files for usage of deprecated options)
      mysql-test/lib/My/SafeProcess/safe_process.cc:
        Fixed compiler warning
      mysql-test/lib/v1/mysql-test-run.pl:
        default-character-set -> character-set-server (removes warning in error files for usage of deprecated options)
      mysql-test/suite/rpl/r/rpl_do_grant.result:
        Updated test results
      mysql-test/suite/rpl/t/rpl_do_grant.test:
        Added missing sync_slave_with_master; Fixes random failures
        Had to explictely do stop slave before DROP USER to avoid failure on slave as the user is already dropped on slave.
      mysql-test/suite/rpl/t/rpl_name_const.test:
        Added missing sync_slave_with_master; Fixes random failures
      mysql-test/suite/rpl/t/rpl_row_basic_11bugs.test:
        Added missing sync_slave_with_master; Fixes random failures
      mysql-test/t/bug47671-master.opt:
        default-character-set -> character-set-server (removes warning in error files for usage of deprecated options)
      mysql-test/t/ctype_latin1_de-master.opt:
        default-character-set -> character-set-server (removes warning in error files for usage of deprecated options)
      mysql-test/t/ctype_ucs2_def-master.opt:
        default-character-set -> character-set-server (removes warning in error files for usage of deprecated options)
      sql-common/client.c:
        Fixed compiler warning
      sql/item.cc:
        Renamed function to remove compiler warnings (with gcc)
      sql/item.h:
        Renamed function to remove compiler warnings (with gcc)
      sql/item_cmpfunc.cc:
        Renamed function to remove compiler warnings (with gcc)
      sql/item_create.cc:
        Renamed function to remove compiler warnings (with gcc)
      sql/item_create.h:
        Renamed function to remove compiler warnings (with gcc)
      sql/item_sum.cc:
        Renamed function to remove compiler warnings (with gcc)
      sql/item_sum.h:
        Renamed function to remove compiler warnings (with gcc)
      sql/set_var.cc:
        Don't use bit_do_set() / bot_is_set() / bit_do_clear() as this generates compiler warnings
        (They are also of no use as we know the value can hold the bits)
      sql/sql_yacc.yy:
        Renamed function to remove compiler warnings (with gcc)
      storage/example/ha_example.h:
        Fixed old read_time() prototype
      storage/maria/ma_search.c:
        Added extra variables to remove compiler warnings
      storage/maria/maria_def.h:
        Added extra variables to remove compiler warnings
      storage/myisam/ft_stopwords.c:
        Added cast to get rid of compiler warning
      storage/xtradb/fil/fil0fil.c:
        Added cast to get rid of compiler warning
      storage/xtradb/include/page0page.h:
        Added const to get rid of compiler warning
      storage/xtradb/include/page0page.ic:
        Added const to get rid of compiler warning
      support-files/compiler_warnings.supp:
        Added suppression of strict-aliasing
      691b295a
  9. 24 Mar, 2010 1 commit
  10. 12 Mar, 2010 2 commits
  11. 10 Mar, 2010 6 commits
    • Michael Widenius's avatar
      Fix for Bug #534626 MyISAM table created in MariaDB not readable by MySQL · 6f6e94db
      Michael Widenius authored
      storage/myisam/mi_create.c:
        Don't set HA_OPTION_NULL_FIELDS if table is not using CHECKSUM as this makes the table incompatible with MySQL.
      6f6e94db
    • Michael Widenius's avatar
      Automatic merge · 2f543bbc
      Michael Widenius authored
      2f543bbc
    • Michael Widenius's avatar
      Fix for: Bug#44987 DELETE IGNORE and FK constraint · 85702855
      Michael Widenius authored
      - Now DELETE IGNORE skips over rows with a foreign key constraints (as it was supposed to do)
      
      
      mysql-test/r/foreign_key.result:
        Test case for Bug#44987 DELETE IGNORE and FK constraint
      mysql-test/t/foreign_key.test:
        Test case for Bug#44987 DELETE IGNORE and FK constraint
      sql/sql_delete.cc:
        Firx for Bug#44987 DELETE IGNORE and FK constraint
        Now DELETE IGNORE skips over rows with a foreign key constraints (as it was supposed to do)
        Bug fix inspired by: Moritz Mertinkat
      85702855
    • unknown's avatar
      Fix some compiler warnings seen in Buildbot. · afc4c8c4
      unknown authored
      Add some extra error output and code cleanup in an attempt to fix/debug
      a rare random testsuite problem in check_warnings, where the exit code
      from mysqltest is somehow corrupted inside mysql-test-run.pl.
      
      include/my_global.h:
        Fix compiler warnings on some platforms.
      mysql-test/lib/My/SafeProcess.pm:
        Move dereference of $? subprocess exit code closer to where it is generated,
        to make the code more robust and on the chance that this will fix the
        occasional problems in check_warnings we see in Buildbot.
      mysql-test/mysql-test-run.pl:
        When check_warnings failed, also log the mysqld server for which it failed.
      sql/sql_lex.cc:
        Fix compiler warning about possibly uninitialised value, by rewriting a for()
        loop that is always executed at least once into a do .. while() loop with an
        assert.
      sql/table.cc:
        Fix compiler warning about uninitialised value.
      storage/federatedx/ha_federatedx.cc:
        Fix uninitialised variable.
      storage/maria/ma_delete.c:
        Fix compiler warning about uninitialised value.
      storage/maria/ma_loghandler.c:
        Fix compiler warning about uninitialised value.
      storage/myisam/ft_stopwords.c:
        Fix compiler warning.
      storage/myisam/mi_write.c:
        Fix compiler warning about possibly uninitialised value, by rewriting a while()
        loop that is always executed at least once into a do .. while() loop with an
        assert.
      storage/xtradb/btr/btr0cur.c:
        Fix compiler warning about possibly uninitialised value.
      support-files/compiler_warnings.supp:
        Fix warning suppression to cover all cases in yassl.
      vio/viossl.c:
        Fix compiler warning.
      afc4c8c4
    • unknown's avatar
      5ede158e
    • unknown's avatar
      Fixes for two test failures in Buildbot. · 768e96a8
      unknown authored
       - Adjust timing in test case, to avoid test failures caused by high load
         on machines and consequent race conditions in the test case.
      
       - Add another variant of Valgrind suppressions for memory leak in system
         libraries when unloading dynamic object files.
      
      
      mysql-test/r/information_schema.result:
        Adjust timing to avoid test failures due to races.
      mysql-test/t/information_schema.test:
        Adjust timing to avoid test failures due to races.
      mysql-test/valgrind.supp:
        Add another variant of valgrind suppression for leak in system libs.
      768e96a8
  12. 09 Mar, 2010 4 commits
    • unknown's avatar
      Fix a buildbot memory leak due to JOIN::destroy() not being called for EXPLAIN · cceade1c
      unknown authored
      query:
      - When subquery is located in ORDER BY, EXPLAIN will run as follows:
        select_describe() will run JOIN::prepare()/optimize() for the subquery;
        then at some point subselect_single_select_engine::prepare() will be called,
        which will create another join and run join->prepare().
      
        In mainline mysql this is not a problem because subquery's join will be 
        destroyed after the first call. 
        In MariaDB, it won't (table elimination needs to keep JOIN objects around
        for longer in order to know which tables were eliminated when constructing
        EXPLAIN EXTENDED warning).
      
        Fix the problem of memory leak by calling select_lex->cleanup() in 
        subselect_single_select_engine::prepare().
      cceade1c
    • unknown's avatar
      Automerge MySQL 5.1.44 merge into MariaDB trunk. · 52679413
      unknown authored
      52679413
    • Michael Widenius's avatar
      Added count of my_sync calls (to SHOW STATUS) · 4ca2c06d
      Michael Widenius authored
      tmp_table_size can now be set to 0 (to disable in memory internal temp tables)
      Improved speed for internal Maria temp tables:
      - Don't use packed keys, except with long text fields.
      - Don't copy key all accessed pages during key search.
      Some new benchmark tests to sql-bench (for group by)
      
      BUILD/compile-pentium64-gcov:
        Update script to use same pentium_config flags as other tests
      BUILD/compile-pentium64-gprof:
        Update script to use same pentium_config flags as other tests
      include/my_sys.h:
        Added count of my_sync calls
      mysql-test/r/variables.result:
        tmp_table_size can now be set to 0
      sql-bench/test-select.sh:
        Added some new test for GROUP BY on a not key field and group by with different order by
      sql/mysqld.cc:
        Added count of my_sync calls
        tmp_table_size can now be set to 0 (to disable in memory internal temp tables)
      sql/sql_select.cc:
        If tmp_table_size is 0, don't use in memory temp tables (good for benchmarking MyISAM/Maria temp tables)
        Don't pack keys for Maria tables;  The 8K page size makes packed keys too slow for temp tables.
      storage/maria/ma_key_recover.h:
        Moved definition to maria_def.h
      storage/maria/ma_page.c:
        Moved code used to simplify comparing of identical Maria tables to own function (page_cleanup())
        Fixed that one can read a page with a read lock.
      storage/maria/ma_rkey.c:
        For not exact key reads, cache the page where we found key (to speed up future read-next/read-prev calls)
      storage/maria/ma_search.c:
        Moved code to cache last key page to separate function.
        Instead of copying pages, only get a link to the page. This notable speeds up key searches on bigger tables.
      storage/maria/ma_write.c:
        Added comment
      storage/maria/maria_def.h:
        Moved page_cleanup() to separate function.
      4ca2c06d
    • unknown's avatar
      A number of after-merge fixes following merge of MySQL 5.1.44 into MariaDB. · 848df231
      unknown authored
      Bug#46949: memory leak with failed alter table to create partitions based on extract()
      
      Bug#51830: Incorrect partition pruning on range partition (regression)
      
      Fixed valgrind failure in select_describe(), read of uninitialized 
        Item_subselect::eliminated.
      
      PBXT test file updates to reflect changes done in MySQL.
      
      mysql-test/suite/pbxt/r/partition_error.result:
        Result file update following MySQL 5.1.44 changes.
      mysql-test/suite/pbxt/r/partition_pruning.result:
        Result file update following MySQL 5.1.44 changes.
      mysql-test/suite/pbxt/t/partition_error.test:
        Test file update following MySQL 5.1.44 changes.
      sql/item_subselect.cc:
          Fixed valgrind failure in select_describe(), read of uninitialized 
          Item_subselect::eliminated: 
          - it turns out we can call select_describe() without having fixed 
            subquery items for child subselects. These are not the kind of subqueries
            that we could eliminate, so the fix is to ensure that 
            item_subselect->eliminated==FALSE even before fix_fields is called.
            Also added code to reset item_subselect->eliminated back to FALSE in
            Item::reset() call.
      sql/item_subselect.h:
          Fixed valgrind failure in select_describe(), read of uninitialized 
          Item_subselect::eliminated: 
          - it turns out we can call select_describe() without having fixed 
            subquery items for child subselects. These are not the kind of subqueries
            that we could eliminate, so the fix is to ensure that 
            item_subselect->eliminated==FALSE even before fix_fields is called.
            Also added code to reset item_subselect->eliminated back to FALSE in
            Item::reset() call.
      sql/sql_partition.cc:
        Fix Bug#51830: Revert part of the patch for Bug#49742, which caused the regression.
      sql/table.cc:
        Fix Bug#46949: memory leak in failed ALTER TABLE with partitioning.
      848df231
  13. 08 Mar, 2010 2 commits
  14. 06 Mar, 2010 1 commit
    • Sergey Petrunya's avatar
      LPBUG#524025 Running RQG outer_join test leads to crash · 4080e909
      Sergey Petrunya authored
      Save no-records constant tables in JOIN::const_table_map before we invoke
      eliminate_tables(). Failure to do so caused crash when the same table was
      marked as constant two times
      
      mysql-test/r/table_elim.result:
        LPBUG#524025 Running RQG outer_join test leads to crash
        - Testcase
      mysql-test/t/table_elim.test:
        LPBUG#524025 Running RQG outer_join test leads to crash
        - Testcase
      sql/sql_select.cc:
        LPBUG#524025 Running RQG outer_join test leads to crash
        Save no-records constant tables in JOIN::const_table_map before we invoke eliminate_tables(). Failure to do so caused crash when the same table was marked as constant two times.
      4080e909
  15. 04 Mar, 2010 1 commit
  16. 23 Feb, 2010 2 commits
  17. 19 Feb, 2010 1 commit
  18. 18 Feb, 2010 1 commit
    • Sergey Petrunya's avatar
      LPBUG#523593: Running RQG optimizer_no_subquery crashes MariaDB · e2322dc8
      Sergey Petrunya authored
      - When analying multiple equalities, take into account that they 
        may not have a single table field that belongs to one of the tables
        that we're trying to eliminate (and they are not useful for table
        elimination in that case)
      
      mysql-test/r/table_elim.result:
        LPBUG#523593: Running RQG optimizer_no_subquery crashes MariaDB
        - Testcase
      mysql-test/t/table_elim.test:
        LPBUG#523593: Running RQG optimizer_no_subquery crashes MariaDB
        - Testcase
      e2322dc8
  19. 17 Feb, 2010 2 commits
  20. 12 Feb, 2010 1 commit
  21. 11 Feb, 2010 1 commit
  22. 10 Feb, 2010 2 commits
    • Michael Widenius's avatar
      Added option --temporary-tables to test speed of temporary tables · d01b9d0e
      Michael Widenius authored
      mysql-test/suite/parts/t/partition_repair_myisam-master.opt:
        Added missing file from last push
      sql-bench/bench-init.pl.sh:
        Added options:
        --temporary-tables to test speed of temporary tables
      sql-bench/server-cfg.sh:
        Added limit for number of temporary tables one can create
      sql-bench/test-connect.sh:
        Skip test that doesn't work with temporary tables.
      sql-bench/test-create.sh:
        Added limit for number of temporary tables one can create
      d01b9d0e
    • Michael Widenius's avatar
      When one does a drop table, the indexes are not flushed to disk before drop... · c7b97d14
      Michael Widenius authored
      When one does a drop table, the indexes are not flushed to disk before drop anymore (with MyISAM/Maria)
      myisam-recover options changed from OFF to 'DEFAULT' to get less change of data loss when using MyISAM.
      (The disadvantage is that changed MyISAM tables will be checked at access time; Use --myisam-recover=OFF for old behavior)
      Don't call extra(HA_EXTRA_FORCE_REOPEN) in ALTER TABLE if table is locked as this will mark table as crashed!
      Added assert to detect if we accidently would use MyISAM versioning in MySQL
      
      include/my_base.h:
        Mark NOT_USED as USED, as we now use this as a flag to not call extra()
      mysql-test/mysql-test-run.pl:
        Don't write all options when there is something wrong with the arguments
      mysql-test/r/sp-destruct.result:
        Add missing flush of mysql.proc (as the test copied live tables)
      mysql-test/r/variables.result:
        myisam-recover options changed to 'default'
      mysql-test/r/view.result:
        Don't show create time in result
      mysql-test/suite/maria/t/maria-recovery2-master.opt:
        Don't run test with myisam-recover (as this produces extra warnings during simulated death)
      mysql-test/t/sp-destruct.test:
        Add missing flush of mysql.proc (as the test copied live tables)
      mysql-test/t/view.test:
        Don't show create time in result
      sql/lock.cc:
        Added marker if table was deleted to argument list
      sql/mysql_priv.h:
        Added marker if table was deleted to argument list
      sql/mysqld.cc:
        myisam-recover options changed from OFF to 'DEFAULT' to get less change of data loss when using MyISAM
        Allow one to specify OFF as argument to myisam-recover (was default before but one couldn't specify it)
      sql/sql_base.cc:
        Mark if table is going to be deleted
      sql/sql_delete.cc:
        Mark if table is going to be deleted
      sql/sql_table.cc:
        Mark if table is going to be deleted
        Don't call extra(HA_EXTRA_FORCE_REOPEN) in ALTER TABLE if table is locked as this will mark table as crashed!
      sql/table.cc:
        Signal to handler if table is getting deleted as part of getting droped from table cache.
      sql/table.h:
        Added marker if table is going to be deleted.
      storage/maria/ha_maria.cc:
        Don't search for transaction handler if file is not transactional or outside of transaction
        (Fixed possible core dump)
      storage/maria/ma_blockrec.c:
        Don't write changed information if table is going to be deleted.
      storage/maria/ma_close.c:
        Don't write changed information if table is going to be deleted.
      storage/maria/ma_extra.c:
        Mark tables that are deleted as crased, to ensure good behavior on restart if we suddenly crash.
      storage/maria/ma_locking.c:
        Cleanup
      storage/maria/ma_recovery.c:
        We need trnman to be inited during redo phase (to be able to open tables checked with maria_chk)
      storage/maria/maria_def.h:
        Added marker if table is going to be deleted.
      storage/myisam/mi_close.c:
        Don't write changed information if table is going to be deleted.
      storage/myisam/mi_extra.c:
        Mark tables that are deleted as crased, to ensure good behavior on restart if we suddenly crash.
      storage/myisam/mi_open.c:
        Added assert to detect if we accidently would use MyISAM versioning in MySQL
      storage/myisam/myisamdef.h:
        Added marker if table is going to be deleted.
      c7b97d14
  23. 09 Feb, 2010 1 commit