1. 01 Sep, 2004 5 commits
    • unknown's avatar
      ha_innodb.cc: · e348a2ce
      unknown authored
        If ALTER TABLE ... DROP FOREIGN KEY ... fails because of a wrong constraint name, return a table handler error number 150 instead of 152; the value 152 was misleading, as it referred to '152 = Cannot delete a parent row', whereas '150 = Foreign key constraint is incorrectly formed' is less misleading
      
      
      sql/ha_innodb.cc:
        If ALTER TABLE ... DROP FOREIGN KEY ... fails because of a wrong constraint name, return a table handler error number 150 instead of 152; the value 152 was misleading, as it referred to '152 = Cannot delete a parent row', whereas '150 = Foreign key constraint is incorrectly formed' is less misleading
      e348a2ce
    • unknown's avatar
      Merge jbruehe@bk-internal.mysql.com:/home/bk/mysql-4.0 · d422f67e
      unknown authored
      into mysql.com:/M40/mysql-4.0
      
      d422f67e
    • unknown's avatar
      Correct a typo error: cpp symbol is "BIG_TABLES", not "BIG_FILES" · 2e24ddd4
      unknown authored
      (backport from 4.1).
      
      
      configure.in:
        Defining "BIG_TABLES" works around a problem with the Sun Forte
        compiler for Solaris on x86 platforms: improper handling of "long long".
        Error shows up on the "limit_rows_found" variable in test "union".
        Old "BIG_FILES" was a typing error (backport from 4.1).
      2e24ddd4
    • unknown's avatar
      Merge pgalbraith@bk-internal.mysql.com:/home/bk/mysql-4.0 · 0c032417
      unknown authored
      into krsna.patg.net:/home/patg/mysql-4.0
      
      0c032417
    • unknown's avatar
      mysqld_safe.sh: · 40ed009d
      unknown authored
        bug #5001, added conditional if to test if port set, then only kill the processes
        for this port, not all processes (in the case of this bug where multiple servers 
        are killed.)
        The change to the 'grep' to make sure mysqld_safe isn't killed was per Serg's
        discovery that mysqld_safe would get killed. 
        In my testing, in killing one of the pids for a running server, the "if test ! -f $pid_file"
        was the case that evaluated as true, so in order to test, I had to comment that block
        out.
      
      
      scripts/mysqld_safe.sh:
        bug #5001, added conditional if to test if port set, then only kill the processes
        for this port, not all processes (in the case of this bug where multiple servers 
        are killed.)
        
        The change to the 'grep' to make sure mysqld_safe isn't killed was per Serg's
        discovery that mysqld_safe would get killed. 
        
        In my testing, in killing one of the pids for a running server, the "if test ! -f $pid_file"
        was the case that evaluated as true, so in order to test, I had to comment that block
        out.
      40ed009d
  2. 31 Aug, 2004 2 commits
    • unknown's avatar
      Do-compile: · 200b51ad
      unknown authored
        Remove --warnings for mysql-test-run. Devs don't use it, and Serg says it's not needed anymore.
      
      
      Build-tools/Do-compile:
        Remove --warnings for mysql-test-run. Devs don't use it, and Serg says it's not needed anymore.
      200b51ad
    • unknown's avatar
      Added global my_getopt_error_reporter function pointer which is · c3f7e3bb
      unknown authored
      used in the handle_options() function (instead of using additional 
      handle_option() parameter). The default value of the 
      my_getopt_error_reporter is default_reporter(). One can set it to
      other functions if case of need.
      
      
      client/mysql.cc:
        Removed extra handle_optins()'s parameter.
      client/mysqladmin.c:
        Removed extra handle_optins()'s parameter.
      client/mysqlbinlog.cc:
        Removed extra handle_optins()'s parameter.
      client/mysqlcheck.c:
        Removed extra handle_optins()'s parameter.
      client/mysqldump.c:
        Removed extra handle_optins()'s parameter.
      client/mysqlimport.c:
        Removed extra handle_optins()'s parameter.
      client/mysqlmanager-pwgen.c:
        Removed extra handle_optins()'s parameter.
      client/mysqlmanagerc.c:
        Removed extra handle_optins()'s parameter.
      client/mysqlshow.c:
        Removed extra handle_optins()'s parameter.
      client/mysqltest.c:
        Removed extra handle_optins()'s parameter.
      extra/my_print_defaults.c:
        Removed extra handle_optins()'s parameter.
      extra/mysql_install.c:
        Removed extra handle_optins()'s parameter.
      extra/mysql_waitpid.c:
        Removed extra handle_optins()'s parameter.
      extra/perror.c:
        Removed extra handle_optins()'s parameter.
      extra/resolve_stack_dump.c:
        Removed extra handle_optins()'s parameter.
      extra/resolveip.c:
        Removed extra handle_optins()'s parameter.
      include/my_getopt.h:
        Removed extra handle_optins()'s parameter.
      isam/isamchk.c:
        Removed extra handle_optins()'s parameter.
      isam/pack_isam.c:
        Removed extra handle_optins()'s parameter.
      myisam/mi_test1.c:
        Removed extra handle_optins()'s parameter.
      myisam/myisam_ftdump.c:
        Removed extra handle_optins()'s parameter.
      myisam/myisamchk.c:
        Removed extra handle_optins()'s parameter.
      myisam/myisampack.c:
        Removed extra handle_optins()'s parameter.
      sql/gen_lex_hash.cc:
        Removed extra handle_optins()'s parameter.
      sql/mysqld.cc:
        Removed extra handle_optins()'s parameter.
      tools/mysqlmanager.c:
        Removed extra handle_optins()'s parameter.
      c3f7e3bb
  3. 30 Aug, 2004 4 commits
    • unknown's avatar
      If the system has 64 bit "long", then "long long" does not add new · 832cdfff
      unknown authored
      functionality. The existing code takes advantage of this when
      "typedef"ing 'longlong' in 'my_global.h'. This holds for Alpha CPUs.
      If the compiler then has prototypes for C99 functions 'strtoll()' and
      'strtoull()' but no implementation, the existing code in 'strtoull.c'
      collides with that prototype. These collisions are avoided now.
      (backport from 4.1)
      
      
      include/m_string.h:
        Extend the "fake" approach from 'strtoull()' onto 'strtoll()'
        (backport from 4.1).
      strings/strto.c:
        Ensure that calling file has included necessary headers,
        as these are needed at the upper level already
        (backport from 4.1).
      strings/strtol.c:
        Cleanup/alignment with the "long long" functions.
      strings/strtoll.c:
        When "long" is 64 bit already, system function 'strtol()' can be used.
        Header files 'my_global.h' and 'm_string.h' will manage that,
        if they are included early enough (backport from 4.1).
      strings/strtoul.c:
        Cleanup/alignment with the "long long" functions.
      strings/strtoull.c:
        When "long" is 64 bit already, system function 'strtoul()' can be used.
        Header files 'my_global.h' and 'm_string.h' will manage that,
        if they are included early enough (backport from 4.1).
      832cdfff
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-4.0/ · 8de79646
      unknown authored
      into serg.mylan:/usr/home/serg/Abk/mysql-4.0
      
      8de79646
    • unknown's avatar
      typo fixed · ecc514b9
      unknown authored
      ecc514b9
    • unknown's avatar
      - removed mysql-test/t/flush_block_commit-master.opt as it collided · cf837604
      unknown authored
         with the sleep value we use for the test suite run during the
         release builds
      
      
      BitKeeper/deleted/.del-flush_block_commit-master.opt~3bcd295d5bf68796:
        Delete: mysql-test/t/flush_block_commit-master.opt
      cf837604
  4. 29 Aug, 2004 3 commits
    • unknown's avatar
      log.cc: · 6e3e3eae
      unknown authored
        Fixed missing * in comment in setup_windows_event_source
      
      
      sql/log.cc:
        Fixed missing * in comment in setup_windows_event_source
      6e3e3eae
    • unknown's avatar
      Merge gbichot@bk-internal.mysql.com:/home/bk/mysql-4.0 · f2449efa
      unknown authored
      into mysql.com:/home/mysql_src/mysql-4.0
      
      
      sql/log.cc:
        Auto merged
      f2449efa
    • unknown's avatar
      Fix for BUG#4500 "set character set replicates incorrectly" · 804238d3
      unknown authored
      We must not reset the charset in slave after each statement, otherwise the SET CHARACTER SET is cancelled immediately.
      Instead, we write a SET CHARACTER SET DEFAULT to the master's binlog when needed (like we already do for SET FOREIGN_KEY_CHECKS);
      such writing is not necessary in 4.1 (in 4.1 the bug does not exist, as the SET ONE_SHOT syntax is used).
      I have written a test and it works, but I'm not pushing the test as it requires building with all charsets.
      I have noticed differences between what is inserted in the master's table in 4.0 and 4.1, and alerted Bar.
      
      
      sql/log.cc:
        When SET CHARACTER SET has been used, we must reset the charset after the writing the statement, in the binlog.
        In 4.1, this resetting is already achieved by the SET ONE_SHOT syntax.
      sql/log_event.cc:
        In slave, we must not simply reset the charset after each statement: if we do this, the charset gets
        immediately after executing the SET CHARACTER SET! (BUG#4500).
      804238d3
  5. 28 Aug, 2004 1 commit
  6. 27 Aug, 2004 4 commits
    • unknown's avatar
      Code style fixes. · d15fefa9
      unknown authored
      Initialize LOG_error_log before get_options to not use an uninitalized mutex in case of an error from handle_options()
      
      
      mysql-test/r/lowercase_table.result:
        Changed foo database -> mysqltest
        More test cases
      mysql-test/t/lowercase_table.test:
        Changed foo database -> mysqltest
        More test cases
      mysys/my_getopt.c:
        Fix new code to use MySQL indentation style
      sql/log.cc:
        Change to use MySQL indentation style and naming conventions
        Remove usage of strlen() and strcat()
      sql/mysqld.cc:
        Initialize LOG_error_log before get_options to not use an uninitalized mutex in case of an error from handle_options()
      sql/sql_base.cc:
        Added comment
      sql/table.cc:
        Added #if MYSQL_VERSION_ID < 40100 to ensure code is merged correctly
      d15fefa9
    • unknown's avatar
      Compile all charset conversion tables if --with-extra-charsets=all · 2fddfe2f
      unknown authored
      or --with-extra-charsets=complex is given.
      
      2fddfe2f
    • unknown's avatar
      table.cc: · 4b5953b9
      unknown authored
        Bug #4558 Escape handling error for ENUM values in SJIS encoding
      
      
      sql/table.cc:
        Bug #4558 Escape handling error for ENUM values in SJIS encoding
      4b5953b9
    • unknown's avatar
      win1251.conf: · 33b9755d
      unknown authored
        Wrong UPPER/LOWER translation for Cyrillic letter tse was fixed.
        bug#5110
      
      
      sql/share/charsets/win1251.conf:
        Wrong UPPER/LOWER translation for Cyrillic letter tse was fixed.
        bug#5110
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      33b9755d
  7. 26 Aug, 2004 11 commits
  8. 25 Aug, 2004 6 commits
    • unknown's avatar
      merge · 7c0a7b2d
      unknown authored
      
      sql/mysql_priv.h:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      mysql-test/mysql-test-run.sh:
        merge (use new code)
      7c0a7b2d
    • unknown's avatar
      Remove default argument to mysql_truncate() · 7586eae8
      unknown authored
      Update to new valgrind
      
      
      mysql-test/mysql-test-run.sh:
        Update for new valgrind
      sql/mysql_priv.h:
        Remove default argument to mysql_truncate()
      sql/sql_parse.cc:
        Remove default argument to mysql_truncate()
      7586eae8
    • unknown's avatar
      Test case for Bug #4792 lower_case_table_names does not resolve db.tbl.column in SELECT list · 81798982
      unknown authored
      lowercase_table.result:
        New results for modified lowercase_table test
      lowercase_table.test:
        Added test case for all uppercase database when running under lower_case_table_names.  This really only failed under Windows.  Bug# 4792
      
      
      mysql-test/t/lowercase_table.test:
        Added test case for all uppercase database when running under lower_case_table_names.  This really only failed under Windows.  Bug# 4792
      mysql-test/r/lowercase_table.result:
        New results for modified lowercase_table test
      81798982
    • unknown's avatar
      Bug #4792 lower_case_table_names does not resolve db.tbl.column in SELECT list · 32fd1ca1
      unknown authored
      sql_base.cc:
        Added code to lowercase database name in insert_fields when lower_case_table_names=1. This fixes bug# 4792
      
      
      sql/sql_base.cc:
        Added code to lowercase database name in insert_fields when lower_case_table_names=1. This fixes bug# 4792
      32fd1ca1
    • unknown's avatar
      Adding binary version information for debug/release version of libmysqld.dll · 83d20542
      unknown authored
      This was a customer request for to get the XP Logo Certification.
      
      Note for LenZ:
      Adding to the project libmysqld.dsp the file libmysqld.rc at compilation time will be created
      the libmysqld.res and this linked. For every release edit the libmysqld.rc
      version number.
      
      83d20542
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.0 · cc54eba4
      unknown authored
      into build.mysql.com:/users/rburnett/mysql-4.0
      
      
      BitKeeper/etc/logging_ok:
        auto-union
      client/mysql.cc:
        Auto merged
      sql/log.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      cc54eba4
  9. 24 Aug, 2004 4 commits
    • unknown's avatar
      buf0rea.c: · abfdace0
      unknown authored
        Fix bug: if there was little file I/O in InnoDB, but the insert buffer was used, it could happen that 'Pending normal aio reads' was bigger than 0, but the I/O handler thread did not get waken up in 600 seconds. This resulted in a hang, and crashing of InnoDB.
      
      
      innobase/buf/buf0rea.c:
        Fix bug: if there was little file I/O in InnoDB, but the insert buffer was used, it could happen that 'Pending normal aio reads' was bigger than 0, but the I/O handler thread did not get waken up in 600 seconds. This resulted in a hang, and crashing of InnoDB.
      abfdace0
    • unknown's avatar
      All 'Makefile's must use '$(AR)' (not just 'ar') because the variable may contain options. · f3f69563
      unknown authored
      
      libmysqld/Makefile.am:
        Always use 'make' variable '$(AR)' so that options (AIX 64 bit!) are included.
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      f3f69563
    • unknown's avatar
      Fix warning VC++ and fix applied fisrt to source 4.1 · 009fcf12
      unknown authored
      
      mysys/my_lib.c:
        Same fix for bug #4737 that wrongly I did first on tree 4.1
      mysys/my_vsnprintf.c:
        Fix VC++ warning assuming that my_vsnprintf() is external
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      009fcf12
    • unknown's avatar
      Merge sgluhov@bk-internal.mysql.com:/home/bk/mysql-4.0 · 51f3953a
      unknown authored
      into gluh.mysql.r18.ru:/home/gluh/MySQL-BUGS/mysql-4.0
      
      51f3953a