- 12 Mar, 2017 2 commits
-
-
Sergei Petrunia authored
-
Sergei Petrunia authored
-
- 11 Mar, 2017 4 commits
-
-
Sergei Petrunia authored
-
Sergei Petrunia authored
Manually resolved a few conflicts
-
Otto Kekäläinen authored
Compatibility links ended up looking like this: libmysqlclient.so.18 -> /tmp/buildd/mariadb-10.2-10.2.0/debian/tmp/usr/lib/i386-linux-gnu/libmariadb.so.3 This change fixes ln syntax to create links with correct target paths.
-
Sergei Petrunia authored
commit ba00e640f658ad8d0a4dff09a497a51b8a4de935 Author: Herman Lee <herman@fb.com> Date: Wed Feb 22 06:30:06 2017 -0800 Improve add_index_alter_cardinality test Summary: Split add_index_inplace_cardinality test out and add a debug_sync point to it so that the flush of the memtable occurs while the alter is running. Closes https://github.com/facebook/mysql-5.6/pull/539 Reviewed By: alxyang Differential Revision: D4597887 Pulled By: hermanlee fbshipit-source-id: faedda2
-
- 10 Mar, 2017 7 commits
-
-
Oleksandr Byelkin authored
-
Vladislav Vaintroub authored
-
Vladislav Vaintroub authored
Reason : after running sysbench tests (rw,update_no_index), in all cases the throughout was considerably (approx 15%) better with the patch removed. Reverted commit info commit 8dc03bee3ade2edcc53a3a257346f4a0a9f0b44c Author: Yasufumi Kinoshita <yasufumi.kinoshita@oracle.com> Date: Wed Nov 20 17:02:24 2013 +0900 Bug #17824101 : WL#7050 CAUSES RW PERFORMANCE REGRESSION AT SOME WINDOWS ENVIRONMENT
-
Sergei Petrunia authored
#define __STDC_FORMAT_MACROS. Unfortunately there is no single location that would be #includ'ed before everything else. Have to put the #define into each .cc file
-
Marko Mäkelä authored
InnoDB undo logs currently always use the innodb_page_size, whether they are stored in the system tablespace, in a dedicated undo tablespace, or in the temporary tablespace. Remove redundant page_size parameters. TrxUndoRsegsIterator::set_next(): return bool instead of page_size.
-
Marko Mäkelä authored
trx_rseg_mem_create(): Remove the parameter rseg_array. Update trx_sys->rseg_array directly.
-
Marko Mäkelä authored
TrxUndoRsegsIterator::m_purge_sys: Remove. There is only one purge_sys. purge_sys_t: Renamed from trx_purge_t. Define a constructor and destructor. Allocate rseg_iter, purge_queue inline. purge_sys->trx: Remove. Use purge_sys->sess->trx instead. purge_sys->view_active: Remove. Access to purge_sys->view is always protected by purge_sys->latch. trx_purge_sys_create(): Replaced by purge_sys_t::purge_sys_t(). trx_purge_sys_close(): Replaced by purge_sys_t::~purge_sys_t().
-
- 09 Mar, 2017 8 commits
-
-
Vladislav Vaintroub authored
Also in log_checkpoint(), where fil_flush_file_spaces() was not done on Windows, it is not done.
-
Vladislav Vaintroub authored
Remove srv_win_file_flush_method - Rename srv_unix_file_flush_method to srv_file_flush_method, and rename constants to remove UNIX from them, i.e SRV_UNIX_FSYNC=>SRV_FSYNC - Add SRV_ALL_O_DIRECT_FSYNC corresponding to current Windows default (no buffering for either log or data, flush on both log and data) - change os_file_open on Windows to behave identically to Unix wrt O_DIRECT and O_DSYNC settings. map O_DIRECT to FILE_FLAG_NO_BUFFERING and O_DSYNC to FILE_FLAG_WRITE_THROUGH - remove various #ifdef _WIN32
-
Oleksandr Byelkin authored
MDEV-11363: Assertion `!derived->first_sel ect()->first_inner_unit() || derived->first_select()->first_inner_unit()->first_select()-> exclude_from_table_unique_test' failed in TABLE_LIST::set_check_materialized() Do not try to materialize derived table which already merged (irreversebly).
-
Marko Mäkelä authored
-
Marko Mäkelä authored
InnoDB needs to collect transactions from the persistent data files in trx_rseg_array_init() before trx_lists_init_at_db_start() is executed. But there is no need to create purge_sys->purge_queue separately from purge_sys. trx_sys_init_at_db_start(): Change the return type to void. Remove the direct call to trx_rseg_array_init(). It will be called by trx_lists_init_at_db_start(), which we are calling. Initialize the purge system read view. trx_lists_init_at_db_start(): Call trx_purge_sys_create(), which will invoke trx_rseg_array_init() to read the undo log segments. trx_purge_sys_create(): Remove the parameters. Do not initialize the purge system read view, because trx_sys->rw_trx_list has not been recovered yet. The purge_sys->view will be initialized at the end of trx_sys_init_at_db_start(). trx_rseg_array_init(): Remove the parameter. Use purge_sys->purge_queue directly. innobase_start_or_create_for_mysql(): Remove the local variable purge_queue. Do not call trx_purge_sys_create(), because it will be called by trx_sys_init_at_db_start().
-
Marko Mäkelä authored
In MySQL 5.7, there is some redundant code for supposedly handling an upgrade from an earlier version of InnoDB. An upgrade of InnoDB between major versions should include a slow shutdown (innodb_fast_shutdown=0) of the previous version. A comment in trx_lists_init_at_db_start() confused clean shutdown and slow shutdown. A clean shutdown does not necessarily guarantee that there are no active transactions. A slow shutdown guarantees that. Because there was no code to handle rollback of recovered transactions that happened to use the rollback segment slots that MySQL 5.7.2 repurposed for temporary undo logs, the upgrade is not working in all cases, and we may as well remove the code to handle purging. trx_sys_t::pending_purge_rseg_array: Remove. trx_undo_get_undo_rec_low(): Define as static. Remove the parameter is_redo_rseg. trx_undo_get_undo_rec(), trx_rseg_get_on_id(): Remove the parameter is_redo_rseg. trx_rseg_mem_free(): Remove the second parameter. trx_sys_get_nth_rseg(): Replace with trx_rseg_get_on_id(). trx_rseg_schedule_pending_purge(): Remove.
-
Oleksandr Byelkin authored
Prepare os ANALYZE now respond as EXPLAIN.
-
Marko Mäkelä authored
This fixes some GCC 6.3.0 warnings and makes the code a little more debugging-friendly.
-
- 08 Mar, 2017 6 commits
-
-
Vladislav Vaintroub authored
-
Marko Mäkelä authored
After starting MariaDB 10.2 with an invalid value of --innodb-flush-method= (the empty string), shutdown would attempt to dereference some NULL pointers. This was probably broken in commit 81b7fe9d which implemented shutdown after aborted startup. logs_empty_and_mark_files_at_shutdown(): Allow shutdown even if lock_sys, log_sys, or fil_system is NULL. os_aio_free(): Tolerate os_aio_segment_wait_events==NULL. innobase_start_or_create_for_mysql(): Do not invoke srv_init_abort() before initializing all mutexes for the temporary files. innodb_shutdown(): Tolerate buf_pool_ptr==NULL.
-
Marko Mäkelä authored
Provide more useful progress reporting of crash recovery. recv_sys_t::progress_time: The time of the last report. recv_sys_t::report(ib_time_t): Determine whether progress should be reported. recv_scan_print_counter: Remove. log_group_read_log_seg(): After after each I/O request, invoke recv_sys_t::report() and report progress if needed. recv_apply_hashed_log_recs(): Change the return type back to void (DB_SUCCESS was always returned), and rename the parameter to last_batch. At the start of each batch, if there are pages to be recovered, issue a message.
-
Oleksandr Byelkin authored
MDEV-10704: Assertion `field->field->table == table_arg' failed in fill_record(THD*, TABLE*, List<Item>&, List<Item>&, bool, bool) the bug test suite
-
Daniel Black authored
Introduced 2f63e2e2 Compiler error was: sql/log_event.cc: In function ‘size_t log_event_print_value(IO_CACHE*, const uchar*, uint, uint, char*, size_t)’: sql/log_event.cc:2897:7: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation] if (!ptr) ^~ sql/log_event.cc:2900:9: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘if’ int32 i32= uint2korr(ptr); ^~~~~ Added in 950abd52 Error was: sql/item_sum.cc:3478:5: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation] if ((!args[i]->fixed && ^~ /sql/item_sum.cc:3482:7: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘if’ with_subselect|= args[i]->with_subselect; ^~~~~~~~~~~~~~ Signed-off-by: Daniel Black <daniel.black@au.ibm.com>
-
Igor Babaev authored
The bug was caused by a wrong order of statements in With_clause::print(). As a result any view definition containing WITH clause with several CTE specifications was put the frm file in a syntactically incorrect form.
-
- 07 Mar, 2017 10 commits
-
-
Vladislav Vaintroub authored
Also get rid of example ini files, they do not provide any value, just confusion
-
Marko Mäkelä authored
The InnoDB redo log record type MLOG_COMP_REC_SEC_DELETE_MARK has been unused for a long time, and it has never been written after WL#8845 introduced the redo log format identifier in MySQL 5.7.9 or MariaDB Server 10.2.2. Thus, removing the record type does not constitute any functional change.
-
Marko Mäkelä authored
Define my_thread_id as an unsigned type, to avoid mismatch with ulonglong. Change some parameters to this type. Use size_t in a few more places. Declare many flag constants as unsigned to avoid sign mismatch when shifting bits or applying the unary ~ operator. When applying the unary ~ operator to enum constants, explictly cast the result to an unsigned type, because enum constants can be treated as signed. In InnoDB, change the source code line number parameters from ulint to unsigned type. Also, make some InnoDB functions return a narrower type (unsigned or uint32_t instead of ulint; bool instead of ibool).
-
Daniel Black authored
-
Daniel Black authored
To facilitate multiple build types in Travis, the environment variable MYSQL_{BUILD_CC,BUILD_CXX} will be passed to cmake if used. This will fallback to $CC/$CXX otherwise. Added MYSQL_COMPILER_LAUNCHER (usually ccache) which isn't supported until cmake-3.4, which isn't in travis (trusty), but hopefully a later version can use it or in CI systems other than travis. Signed-off-by: Daniel Black <daniel.black@au.ibm.com>
-
Vladislav Vaintroub authored
Remove some GCC specific pragmas, use #ifdef __GNUC__ in other places. Only use pthread_setname_np on Linux. Fix a mismerge
-
Alexander Barkov authored
-
Alexander Barkov authored
Merge branch '10.2-MDEV-120555-test_binlog_stm_ctype_ucs' of https://github.com/grooverdan/mariadb-server into grooverdan-10.2-MDEV-120555-test_binlog_stm_ctype_ucs
-
Sergei Petrunia authored
For example, on Windows.
-
Sergei Petrunia authored
Define __STDC_FORMAT_MACROS before using PRIu64. RocksDB does this in many files
-
- 06 Mar, 2017 3 commits
-
-
Sergei Petrunia authored
-
Sergei Petrunia authored
-
Marko Mäkelä authored
The function thd_supports_xa() was removed in MySQL 5.7 in WL#8843.
-