Commit 9d67f32d authored by Jérome Perrin's avatar Jérome Perrin

fixup! slapproxy tests: start external proxy using local ipv4 if provided in env.

this XXX comment no longer apply
parent 94c029b3
...@@ -986,7 +986,6 @@ class TestMultiMasterSupport(MasterMixin): ...@@ -986,7 +986,6 @@ class TestMultiMasterSupport(MasterMixin):
def setUp(self): def setUp(self):
self.addCleanup(self.stopExternalProxy) self.addCleanup(self.stopExternalProxy)
# XXX don't use lo
self.external_proxy_host = os.environ.get('LOCAL_IPV4', '127.0.0.1') self.external_proxy_host = os.environ.get('LOCAL_IPV4', '127.0.0.1')
self.external_proxy_port = 8281 self.external_proxy_port = 8281
self.external_master_url = 'http://%s:%s' % (self.external_proxy_host, self.external_proxy_port) self.external_master_url = 'http://%s:%s' % (self.external_proxy_host, self.external_proxy_port)
......
  • I believe this was a missing part of 368d0da0 we no longer use localhost here ( It's a minor change in code comment so I pushed directly on master )

    /cc @rafael @luke

Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment