Commit a3d78907 authored by Łukasz Nowak's avatar Łukasz Nowak

slapgrid: Try harder during partition destroy

Files on the partition can be created with mode disallowing removal, so use
slapos.util.rmtree to ensure they will get removed instead of failing.
parent 2527ee4e
...@@ -844,7 +844,7 @@ class Partition(object): ...@@ -844,7 +844,7 @@ class Partition(object):
""" """
for root, dirs, file_list in os.walk(folder_path): for root, dirs, file_list in os.walk(folder_path):
for directory in dirs: for directory in dirs:
shutil.rmtree(os.path.join(folder_path, directory)) rmtree(os.path.join(folder_path, directory))
for file in file_list: for file in file_list:
os.remove(os.path.join(folder_path, file)) os.remove(os.path.join(folder_path, file))
......
...@@ -537,3 +537,33 @@ class TestPartitionDestructionLock(MasterMixin, unittest.TestCase): ...@@ -537,3 +537,33 @@ class TestPartitionDestructionLock(MasterMixin, unittest.TestCase):
with open(partition.retention_lock_date_file_path) as f: with open(partition.retention_lock_date_file_path) as f:
deployed_date = float(f.read()) deployed_date = float(f.read())
self.assertEqual(delay * 3600 * 24 + int(now), int(deployed_date)) self.assertEqual(delay * 3600 * 24 + int(now), int(deployed_date))
class TestPartitionDestructionUnwritable(MasterMixin, unittest.TestCase):
def setUp(self):
MasterMixin.setUp(self)
Partition.generateSupervisorConfigurationFile = FakeCallAndNoop()
utils.bootstrapBuildout = FakeCallAndNoop()
utils.launchBuildout = FakeCallAndStore()
def tearDown(self):
MasterMixin.tearDown(self)
Partition.generateSupervisorConfigurationFile = originalPartitionGenerateSupervisorConfigurationFile
def test(self):
software = self.createSoftware()
partition = self.createPartition(software.url)
partition.install()
directory = os.path.join(partition.instance_path, 'directory')
top_file = os.path.join(partition.instance_path, 'file')
os.mkdir(directory)
directory_file = os.path.join(directory, 'file')
for f in [top_file, directory_file]:
with open(f, 'w') as fh:
fh.write('test')
os.chmod(f, 0o440)
os.chmod(directory, 0o550)
self.assertTrue(partition.destroy())
self.assertFalse(os.path.exists(directory_file))
self.assertFalse(os.path.exists(directory))
self.assertFalse(os.path.exists(top_file))
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment