GitLab

cc @rafael

mentioned in merge request slapos.toolbox!17 (merged)

Tests are missing on this method, could ou add? It should not be hard:

def _fake_execute(self, **kw): return kw

try:
   original_execute = db._execute
   db._execute = _fake_execute
   self.assertEquals(expected, db.select(xxx, ...))
finally:
    db._execute =  original_execute

Added 1 commit:

• fd1ce407 - Move Consumption report utils to a new class so it can be reused

Added 1 commit:

• 649a7e57 - Move Consumption report utils to a new class so it can be reused

@rafael added test and moved created a new class to subclass in slapos.toolbox as discussed slapos.toolbox!17 (merged) both pull requests are ready should be ready to merge

Do you have a test result for those changes?

Added 1 commit:

• 8cf4b8d9 - Move Consumption report utils to a new class so it can be reused

@rafael https://nexedi.erp5.net/test_result_module/20170925-4E964CE3/6

Status changed to merged

Beleza :thumbs_up_reverse: , merged.