playbook: Use correctly roles/vars

The previous usage lead to impossilibity of overriding variables defined
in role, because they were included forcibly in the tasks for
standalone-shared.

By using default Ansible apporach to role vars, they can be overriden on
playbook basis.

/reviewed-on nexedi/slapos.package!48

playbook/roles/standalone-shared/tasks/main.yml

 ---
   - include: debian9-gcc-4.9.yml
 
-  - name: fetch shared vars
-    include_vars: erp5-common.yml
-
   - name: Store public IPv4 for other scripts
     copy: content="{{ ansible_default_ipv4.address }}" dest=/tmp/playbook-public-ipv4 mode=0644
 

playbook/roles/standalone-shared/vars/erp5-common.yml → playbook/roles/standalone-shared/vars/main.yml

@@ -5,4 +5,4 @@ firewall_setup_template: setup-firewall.j2
 frontend_master_reference: master-frn-{{ playbook_name }}
 frontend_slave_reference: slave-srn-{{ playbook_name }}
 backend_url_path: /tmp/playbook-{{ playbook_name }}-backend-url
-public_ipv4_path: /tmp/playbook-{{ playbook_name }}-public_ipv4
+public_ipv4_path: /tmp/playbook-{{ playbook_name }}-public_ipv4
\ No newline at end of file

[Rafael Monnerat]

This seems not enough to fix the problem.

The roles vars still been used instead the playbook ones (at least on 2.x):

http://docs.ansible.com/ansible/latest/user_guide/playbooks_variables.html#id18

So I will remove request_instance_template from vars/main.yml and make it mandatory to be declared on the playbook.

[Łukasz Nowak]

This seems not enough to fix the problem.

That's bad, thank you for checking it out.

The roles vars still been used instead the playbook ones (at least on 2.x): http://docs.ansible.com/ansible/latest/user_guide/playbooks_variables.html#id18

So it seems that variable order is quite complex in ansible, and relying on it is dangerous.

So I will remove request_instance_template from vars/main.yml and make it mandatory to be declared on the playbook.

Ok, please ping me when it is done or you have MR.