many promises: fix anomaly not returning AnomalyResult

Also add a comment when we really don't want an AnomalyResult.

See merge request !137

slapos/promise/plugin/check_error_on_http_log.py

@@ -81,4 +81,4 @@ class RunPromise(GenericPromise):
 
   def anomaly(self):
     # only check the result of the two latest sense call
-    return self._test(result_count=2, failure_amount=2, latest_minute=self.custom_frequency*3)
+    return self._anomaly(result_count=2, failure_amount=2, latest_minute=self.custom_frequency*3)

slapos/promise/plugin/check_error_on_zope_longrequest_log.py

@@ -52,4 +52,4 @@ class RunPromise(GenericPromise):
     return self._test(result_count=1, failure_amount=1)
 
   def anomaly(self):
-    return self._test(result_count=3, failure_amount=3)
+    return self._anomaly(result_count=3, failure_amount=3)

slapos/promise/plugin/check_free_disk_space.py

@@ -364,4 +364,10 @@ class RunPromise(GenericPromise):
     return self._test(result_count=1, failure_amount=1)
 
   def anomaly(self):
-    return self._test(result_count=3, failure_amount=3)
\ No newline at end of file
+    """
+      Anomaly returns a TestResult instead of AnomalyResult because we don't
+      want to call bang when there is a problem. Usually the problem won't be
+      in the deployment of this instance but rather in one of the partition
+      taking too much space.  This will need a human intervention.
+    """
+    return self._test(result_count=3, failure_amount=3)

slapos/promise/plugin/check_icmp_packet_lost.py

@@ -45,4 +45,4 @@ class RunPromise(GenericPromise):
 
   def anomaly(self):
     # only check the result of the two latest sense call
-    return self._test(result_count=2, failure_amount=2, latest_minute=self.custom_frequency*3)
+    return self._anomaly(result_count=2, failure_amount=2, latest_minute=self.custom_frequency*3)

slapos/promise/plugin/check_partition_deployment_state.py

@@ -48,4 +48,4 @@ class RunPromise(GenericPromise):
     return self._test(result_count=1, failure_amount=1)
 
   def anomaly(self):
-    return self._test(result_count=2, failure_amount=2)
+    return self._anomaly(result_count=2, failure_amount=2)

slapos/promise/plugin/check_re6st_optimal_status.py

@@ -63,4 +63,4 @@ class RunPromise(GenericPromise):
 
   def anomaly(self):
     # only check the result of the two latest sense call
-    return self._test(result_count=2, failure_amount=2, latest_minute=self.custom_frequency*3)
+    return self._anomaly(result_count=2, failure_amount=2, latest_minute=self.custom_frequency*3)

slapos/promise/plugin/check_server_cpu_load.py

@@ -52,5 +52,11 @@ class RunPromise(GenericPromise):
     return self._test(result_count=10, failure_amount=10)
 
   def anomaly(self):
-    # fail if load is higher than the threshold for more than 30 minutes
+    """
+      Anomaly returns a TestResult instead of AnomalyResult because we don't
+      want to call bang when there is a problem of load.
+      This will need a human intervention to find where the load come from.
+
+      We fail if load is higher than the threshold for more than 30 minutes.
+    """
     return self._test(result_count=10, failure_amount=10)

slapos/promise/plugin/check_surykatka_json.py

@@ -395,5 +395,10 @@ class RunPromise(GenericPromise):
     self.emitLog()
 
   def anomaly(self):
+    """
+      Anomaly returns a TestResult instead of AnomalyResult because we don't
+      want to call bang when there is a problem.
+      This will need a human intervention.
+    """
     return self._test(
       result_count=self.result_count, failure_amount=self.failure_amount)

slapos/promise/plugin/check_url_available.py

@@ -117,4 +117,4 @@ class RunPromise(GenericPromise):
       log("%s request to %r %s (%s)", request_type, url, result, message)
 
   def anomaly(self):
-    return self._test(result_count=3, failure_amount=3)
+    return self._anomaly(result_count=3, failure_amount=3)

slapos/promise/plugin/check_websocket_available.py

@@ -73,4 +73,4 @@ class RunPromise(GenericPromise):
       ws.close()
 
   def anomaly(self):
-    return self._test(result_count=3, failure_amount=3)
+    return self._anomaly(result_count=3, failure_amount=3)

slapos/promise/plugin/monitor_partition_space.py

@@ -236,4 +236,10 @@ class RunPromise(GenericPromise):
     return self._test(result_count=1, failure_amount=1)
 
   def anomaly(self):
+    """
+      Anomaly returns a TestResult instead of AnomalyResult because we don't
+      want to call bang when there is a problem. Usually the problem won't be
+      in the deployment of this instance but rather in this partition taking
+      too much space.  This will need a human intervention.
+    """
     return self._test(result_count=3, failure_amount=3)