GeoLite2 updated

component/geoip2/buildout.cfg

@@ -17,5 +17,5 @@ rpath = ${:library-dirs}
 [geolite2-country]
 recipe = slapos.recipe.build:download-unpacked
 url = http://geolite.maxmind.com/download/geoip/database/GeoLite2-Country.tar.gz
-md5sum = 5abb7465655c29709a287d83bd780169
+md5sum = 17ee7db01dc5ac73a09e2009f9e5ed04
 strip-top-level-dir = true

[Vincent Pelletier]

Same URL but different content ? This is not slapos-compatible, as it means any caching (shacache) will be broken when the SR hash is updated like this.

Would a url fragment be included in shacache lookup ? If so, what about changing the URL into http://geolite.maxmind.com/download/geoip/database/GeoLite2-Country.tar.gz#20180710 or so ?

[Julien Muchembled]

Same URL but different content ? This is not slapos-compatible, as it means any caching (shacache) will be broken when the SR hash is updated like this.

Not necessarily. A shacache entry can have a multi-valued key. See binary cache (SR path + machine + ...) and slapos.recipe.build:gitclone

But indeed, for buildout downloads, shacache is used in a simple way and such url is probably wrong.

Using a URL fragment is a good idea if it works. I can't find another example. I'd prefer #${:md5sum} to avoid any mistake.

[Vincent Pelletier]

I like the idea of #${:md5sum} indeed.