software/neoppod: Add a software release for myrocks. If you want to test rocksdb in neo, use this.
-
Owner
Not nice to push this to master without explaining so much complexity. That's also a lot of code duplication, that looks unnecessary even if 2 versions of MariaDB are needed.
-
Owner
My purpose is to share my result to someone who wants to build myrocks for neo and this file achieved it. So I think it is ok. My purpose is not to provide a clean easy-to-read configuration file which is good for long-term maintenance, but it was commited to save someone's time and avoid duplication work. I will remove this file once myrocks was officially released with mariadb(10.2?).
-
Owner
10.2 won't be released early enough, and it's worth doing something a little cleaner in the meantime. I'd like to commit the support of RocksDB in the master branch of NEO, and the easiest way to avoid test failures (because some test would be run with this new engine) is that they run with MariaDB 10.2
Can you explain this issues that led you to this ?
-
Owner
I found two problems.
- /opt/slapos/parts/bison/bin/bison does not generate sql_yacc.cc and sql_yacc.h from sql_yacc.yy. They are pregenerated in official release files. So I added ../../component/bison/buildout.cfg and use this bison binary.
- 10.2-mariarocks branch does not contain libmysql and [python-mysqlclient] fails. So I added [mariadb10.1-client] to build libmysqlclient.
-
Owner
10.2-mariarocks branch does not contain libmysql and [python-mysqlclient] fails. So I added [mariadb10.1-client] to build libmysqlclient.
See https://jira.mariadb.org/browse/MDEV-9055 (changed in 10.2.2)
So we'll want to take this change into account even for stable releases.
-
Owner
Oh I see. I hope "-DWITHOUT_SERVER=ON" this option works as I expected, then only client library should be built.
-
Owner
I added MariaDB Connector/C and build python-mysql with it on erp5-component branch.
Anyway I strongly recommend using erp5-component branch (or even a dedicated branch for you) for such experimental work, that can be still suitable to share your work with others.