erp5_web_renderjs_ui: datetime field formats date in the interface language

Also hide seconds as it weights down the interface, and to follow the behavior of XML style

bt5/erp5_web_renderjs_ui/PathTemplateItem/web_page_module/rjs_gadget_erp5_datetimefield_js.js

@@ -32,7 +32,7 @@
   ];
 
   rJS(window)
-
+    .declareAcquiredMethod('getSelectedLanguage', 'getSelectedLanguage')
     .declareMethod('render', function (options) {
       var field_json = options.field_json || {},
         state_dict = {
@@ -228,24 +228,52 @@
       } else {
         queue
           .push(function (gadget_list) {
-            var text_content = "",
+            return RSVP.all([
+              gadget.getSelectedLanguage(),
+              gadget_list
+            ]);
+          })
+          .push(function (result_list) {
+            var language = result_list[0],
+              gadget_list = result_list[1],
+              text_content = "",
               state_date,
+              locale_formatted_state_date,
               offset_time_zone;
             if (gadget.state.value) {
               state_date = new Date(gadget.state.value);
+              /* Ideally we would like to use {timeStyle: "short"} as option
+               * to hide seconds. Unfortunately it doesn't work in older
+               * versions of firefox. Luckily, by using
+               *   {hour: "numeric", minute: "numeric"}
+               * it hides seconds, and still respects the locale.
+               * >> date = new Date(2019, 1, 1, 1, 1)
+               * >> date.toLocaleTimeString(
+               *      'en', {hour: "numeric", minute: "numeric"}
+               *    )
+               *    "1:01 AM"
+               * >> date.toLocaleTimeString(
+               *      'fr', {hour: "numeric", minute: "numeric"}
+               *    )
+               *    "01:01"
+               */
+              locale_formatted_state_date = state_date.toLocaleTimeString(
+                language,
+                {hour: "numeric", minute: "numeric"}
+              );
               if (gadget.state.timezone_style) {
-                text_content = state_date.toLocaleDateString();
+                text_content = state_date.toLocaleDateString(language);
                 if (!gadget.state.date_only) {
-                  text_content += " " + state_date.toLocaleTimeString();
+                  text_content += " " + locale_formatted_state_date;
                 }
               } else {
                 //get timezone difference between server and local browser
                 offset_time_zone = timezone + (state_date.getTimezoneOffset() / 60);
                 //adjust hour in order to get correct date time string
                 state_date.setUTCHours(state_date.getUTCHours() + offset_time_zone);
-                text_content = state_date.toLocaleDateString();
+                text_content = state_date.toLocaleDateString(language);
                 if (!gadget.state.date_only) {
-                  text_content += " " + state_date.toLocaleTimeString();
+                  text_content += " " + locale_formatted_state_date;
                 }
               }
             }

bt5/erp5_web_renderjs_ui/PathTemplateItem/web_page_module/rjs_gadget_erp5_datetimefield_js.xml

@@ -142,11 +142,13 @@
   </record>
   <record id="3" aka="AAAAAAAAAAM=">
     <pickle>
-      <global name="WorkflowHistoryList" module="Products.ERP5Type.patches.WorkflowTool"/>
+      <global name="WorkflowHistoryList" module="Products.ERP5Type.Workflow"/>
     </pickle>
     <pickle>
-      <tuple>
-        <none/>
+      <dictionary>
+        <item>
+            <key> <string>_log</string> </key>
+            <value>
               <list>
                 <dictionary>
                   <item>
@@ -190,16 +192,20 @@
                   </item>
                 </dictionary>
               </list>
-      </tuple>
+            </value>
+        </item>
+      </dictionary>
     </pickle>
   </record>
   <record id="4" aka="AAAAAAAAAAQ=">
     <pickle>
-      <global name="WorkflowHistoryList" module="Products.ERP5Type.patches.WorkflowTool"/>
+      <global name="WorkflowHistoryList" module="Products.ERP5Type.Workflow"/>
     </pickle>
     <pickle>
-      <tuple>
-        <none/>
+      <dictionary>
+        <item>
+            <key> <string>_log</string> </key>
+            <value>
               <list>
                 <dictionary>
                   <item>
@@ -222,7 +228,7 @@
                   </item>
                   <item>
                       <key> <string>serial</string> </key>
-                <value> <string>965.12118.35525.1655</string> </value>
+                      <value> <string>980.55051.50282.19404</string> </value>
                   </item>
                   <item>
                       <key> <string>state</string> </key>
@@ -240,7 +246,7 @@
                           </tuple>
                           <state>
                             <tuple>
-                        <float>1517930509.55</float>
+                              <float>1577775957.85</float>
                               <string>UTC</string>
                             </tuple>
                           </state>
@@ -249,7 +255,9 @@
                   </item>
                 </dictionary>
               </list>
-      </tuple>
+            </value>
+        </item>
+      </dictionary>
     </pickle>
   </record>
 </ZopeData>

bt5/erp5_web_renderjs_ui_test/PathTemplateItem/portal_tests/renderjs_ui_date_time_field_zuite/testDateTimeDefaultToNow.zpt

@@ -153,6 +153,19 @@
   <td>glob:${now}*</td>
 </tr>
 
+<!-- Seconds should also be invisible in non-editable mode,
+     and that output follows locale (here "en") -->
+
+<tal:block metal:use-macro="here/Zuite_CommonTemplateForRenderjsUi/macros/toggle_editable_mode" />
+<tal:block metal:use-macro="here/Zuite_CommonTemplateForRenderjsUi/macros/verify_is_non_editable_mode" />
+<tal:block metal:use-macro="here/Zuite_CommonTemplateForRenderjsUi/macros/wait_for_content_loaded" />
+
+<tr>
+  <td>assertText</td>
+  <td>//div[@data-gadget-scope='field_my_start_date']//p</td>
+  <td>regexp:1?\d/[123]?\d/20\d\d \d\d?:\d\d (AM|PM)</td>
+</tr>
+
 </tbody></table>
 </body>
 </html>
\ No newline at end of file

bt5/erp5_web_renderjs_ui_test/PathTemplateItem/portal_tests/renderjs_ui_date_time_field_zuite/testDisplayWithAndWithoutTimeZone.zpt

@@ -82,7 +82,7 @@
 
 <tr>
   <td>assertElementPresent</td>
-  <td>//div[@data-gadget-scope='field_my_start_date']//div[@data-gadget-scope='field']//p[contains(text(), '11:00:00')]</td>
+  <td>//div[@data-gadget-scope='field_my_start_date']//div[@data-gadget-scope='field']//p[contains(text(), '11:00')]</td>
   <td></td>
 </tr>
 

bt5/erp5_web_renderjs_ui_test/PathTemplateItem/portal_tests/renderjs_ui_date_time_field_zuite/testSetDateTimeZone.zpt

@@ -82,7 +82,7 @@
 
 <tr>
   <td>assertElementPresent</td>
-  <td>//div[@data-gadget-scope='field_my_start_date']//div[@data-gadget-scope='field']//p[contains(text(), '11:00:00')]</td>
+  <td>//div[@data-gadget-scope='field_my_start_date']//div[@data-gadget-scope='field']//p[contains(text(), '11:00')]</td>
   <td></td>
 </tr>