Skip to content

S
slapos.core
Commit 476bddaf authored by Alain Takoudjou's avatar Alain Takoudjou
Browse files
Options

fix: include instance and hosting_subscription title in instance parameter_dict

parent ade3960f
Hide whitespace changes
Inline Side-by-side
Showing with 113 additions and 20 deletions
master/bt5/slapos_slap_tool/TestTemplateItem/portal_components/test.erp5.testSlapOSSlapTool.py
View file @ 476bddaf
......@@ -66,6 +66,14 @@ class TestSlapOSSlapToolMixin(testSlapOSMixin):
class TestSlapOSSlapToolComputerAccess(TestSlapOSSlapToolMixin):
def test_getFullComputerInformation(self):
self._makeComplexComputer(with_slave=True)
partition_1_root_instance_title = self.computer.partition1.getAggregateRelatedValue(
portal_type='Software Instance').getSpecialiseValue().getTitle()
partition_2_root_instance_title = self.computer.partition2.getAggregateRelatedValue(
portal_type='Software Instance').getSpecialiseValue().getTitle()
partition_3_root_instance_title = self.computer.partition3.getAggregateRelatedValue(
portal_type='Software Instance').getSpecialiseValue().getTitle()
self.login(self.computer_id)
response = self.portal_slap.getFullComputerInformation(self.computer_id)
self.assertEqual(200, response.status)
......@@ -139,6 +147,8 @@ class TestSlapOSSlapToolComputerAccess(TestSlapOSSlapToolMixin):
<dictionary id='i11'>
<string>full_ip_list</string>
<list id='i12'/>
<string>instance_title</string>
<unicode>%(partition_3_instance_title)s</unicode>
<string>ip_list</string>
<list id='i13'>
<tuple>
......@@ -148,6 +158,8 @@ class TestSlapOSSlapToolComputerAccess(TestSlapOSSlapToolMixin):
</list>
<unicode>paramé</unicode>
<unicode>%(partition_3_param)s</unicode>
<string>root_instance_title</string>
<unicode>%(partition_3_root_instance_title)s</unicode>
<string>slap_computer_id</string>
<unicode>%(computer_id)s</unicode>
<string>slap_computer_partition_id</string>
......@@ -207,6 +219,8 @@ class TestSlapOSSlapToolComputerAccess(TestSlapOSSlapToolMixin):
<dictionary id='i22'>
<string>full_ip_list</string>
<list id='i23'/>
<string>instance_title</string>
<unicode>%(partition_2_instance_title)s</unicode>
<string>ip_list</string>
<list id='i24'>
<tuple>
......@@ -216,6 +230,8 @@ class TestSlapOSSlapToolComputerAccess(TestSlapOSSlapToolMixin):
</list>
<unicode>paramé</unicode>
<unicode>%(partition_2_param)s</unicode>
<string>root_instance_title</string>
<unicode>%(partition_2_root_instance_title)s</unicode>
<string>slap_computer_id</string>
<unicode>%(computer_id)s</unicode>
<string>slap_computer_partition_id</string>
......@@ -275,6 +291,8 @@ class TestSlapOSSlapToolComputerAccess(TestSlapOSSlapToolMixin):
<dictionary id='i33'>
<string>full_ip_list</string>
<list id='i34'/>
<string>instance_title</string>
<unicode>%(partition_1_instance_title)s</unicode>
<string>ip_list</string>
<list id='i35'>
<tuple>
......@@ -284,6 +302,8 @@ class TestSlapOSSlapToolComputerAccess(TestSlapOSSlapToolMixin):
</list>
<unicode>paramé</unicode>
<unicode>%(partition_1_param)s</unicode>
<string>root_instance_title</string>
<unicode>%(partition_1_root_instance_title)s</unicode>
<string>slap_computer_id</string>
<unicode>%(computer_id)s</unicode>
<string>slap_computer_partition_id</string>
......@@ -376,18 +396,24 @@ class TestSlapOSSlapToolComputerAccess(TestSlapOSSlapToolMixin):
computer_id=self.computer_id,
destroy_requested_url=self.destroy_requested_software_installation.getUrlString(),
partition_1_instance_guid=self.computer.partition1.getAggregateRelatedValue(portal_type='Software Instance').getReference(),
partition_1_instance_title=self.computer.partition1.getAggregateRelatedValue(portal_type='Software Instance').getTitle(),
partition_1_root_instance_title=partition_1_root_instance_title,
partition_1_instance_software_type=self.computer.partition1.getAggregateRelatedValue(portal_type='Software Instance').getSourceReference(),
partition_1_param=self.computer.partition1.getAggregateRelatedValue(portal_type='Software Instance').getInstanceXmlAsDict()['paramé'],
partition_1_sla=self.computer.partition1.getAggregateRelatedValue(portal_type='Software Instance').getSlaXmlAsDict()['paramé'],
partition_1_software_release_url=self.computer.partition1.getAggregateRelatedValue(portal_type='Software Instance').getUrlString(),
partition_1_timestamp=int(self.computer.partition1.getAggregateRelatedValue(portal_type='Software Instance').getModificationDate()),
partition_2_instance_guid=self.computer.partition2.getAggregateRelatedValue(portal_type='Software Instance').getReference(),
partition_2_instance_title=self.computer.partition2.getAggregateRelatedValue(portal_type='Software Instance').getTitle(),
partition_2_root_instance_title=partition_2_root_instance_title,
partition_2_instance_software_type=self.computer.partition2.getAggregateRelatedValue(portal_type='Software Instance').getSourceReference(),
partition_2_param=self.computer.partition2.getAggregateRelatedValue(portal_type='Software Instance').getInstanceXmlAsDict()['paramé'],
partition_2_sla=self.computer.partition2.getAggregateRelatedValue(portal_type='Software Instance').getSlaXmlAsDict()['paramé'],
partition_2_software_release_url=self.computer.partition2.getAggregateRelatedValue(portal_type='Software Instance').getUrlString(),
partition_2_timestamp=int(self.computer.partition2.getAggregateRelatedValue(portal_type='Software Instance').getModificationDate()),
partition_3_instance_guid=self.computer.partition3.getAggregateRelatedValue(portal_type='Software Instance').getReference(),
partition_3_instance_title=self.computer.partition3.getAggregateRelatedValue(portal_type='Software Instance').getTitle(),
partition_3_root_instance_title=partition_3_root_instance_title,
partition_3_instance_software_type=self.computer.partition3.getAggregateRelatedValue(portal_type='Software Instance').getSourceReference(),
partition_3_param=self.computer.partition3.getAggregateRelatedValue(portal_type='Software Instance').getInstanceXmlAsDict()['paramé'],
partition_3_sla=self.computer.partition3.getAggregateRelatedValue(portal_type='Software Instance').getSlaXmlAsDict()['paramé'],
......@@ -953,6 +979,8 @@ class TestSlapOSSlapToolInstanceAccess(TestSlapOSSlapToolMixin):
<dictionary id='i9'>
<string>full_ip_list</string>
<list id='i10'/>
<string>instance_title</string>
<unicode>%(instance_title)s</unicode>
<string>ip_list</string>
<list id='i11'>
<tuple>
......@@ -962,6 +990,8 @@ class TestSlapOSSlapToolInstanceAccess(TestSlapOSSlapToolMixin):
</list>
<unicode>paramé</unicode>
<unicode>%(param)s</unicode>
<string>root_instance_title</string>
<unicode>%(root_instance_title)s</unicode>
<string>slap_computer_id</string>
<unicode>%(computer_id)s</unicode>
<string>slap_computer_partition_id</string>
......@@ -1020,6 +1050,8 @@ class TestSlapOSSlapToolInstanceAccess(TestSlapOSSlapToolMixin):
""" % dict(
computer_id=self.computer_id,
instance_guid=self.start_requested_software_instance.getReference(),
instance_title=self.start_requested_software_instance.getTitle(),
root_instance_title=self.start_requested_software_instance.getSpecialiseValue().getTitle(),
software_release_url=self.start_requested_software_instance.getUrlString(),
software_type=self.start_requested_software_instance.getSourceReference(),
param=self.start_requested_software_instance.getInstanceXmlAsDict()['paramé'],
......@@ -1167,6 +1199,8 @@ class TestSlapOSSlapToolInstanceAccess(TestSlapOSSlapToolMixin):
<dictionary id='i6'>
<string>full_ip_list</string>
<list id='i7'/>
<string>instance_title</string>
<unicode>%(instance_title)s</unicode>
<string>ip_list</string>
<list id='i8'>
<tuple>
......@@ -1176,6 +1210,8 @@ class TestSlapOSSlapToolInstanceAccess(TestSlapOSSlapToolMixin):
</list>
<unicode>paramé</unicode>
<unicode>%(param)s</unicode>
<string>root_instance_title</string>
<unicode>%(root_instance_title)s</unicode>
<string>slap_computer_id</string>
<unicode>%(computer_id)s</unicode>
<string>slap_computer_partition_id</string>
......@@ -1235,6 +1271,8 @@ class TestSlapOSSlapToolInstanceAccess(TestSlapOSSlapToolMixin):
software_release_url=self.start_requested_software_instance.getUrlString(),
timestamp=int(self.start_requested_software_instance.getModificationDate()),
instance_guid=self.start_requested_software_instance.getReference(),
instance_title=self.start_requested_software_instance.getTitle(),
root_instance_title=self.start_requested_software_instance.getSpecialiseValue().getTitle(),
software_type=self.start_requested_software_instance.getSourceReference(),
slave_1_param=self.start_requested_slave_instance.getInstanceXmlAsDict()['paramé'],
slave_1_software_type=self.start_requested_slave_instance.getSourceReference(),
......@@ -1291,6 +1329,8 @@ class TestSlapOSSlapToolInstanceAccess(TestSlapOSSlapToolMixin):
<dictionary id='i6'>
<string>full_ip_list</string>
<list id='i7'/>
<string>instance_title</string>
<unicode>%(instance_title)s</unicode>
<string>ip_list</string>
<list id='i8'>
<tuple>
......@@ -1300,6 +1340,8 @@ class TestSlapOSSlapToolInstanceAccess(TestSlapOSSlapToolMixin):
</list>
<unicode>paramé</unicode>
<unicode>%(param)s</unicode>
<string>root_instance_title</string>
<unicode>%(root_instance_title)s</unicode>
<string>slap_computer_id</string>
<unicode>%(computer_id)s</unicode>
<string>slap_computer_partition_id</string>
......@@ -1346,6 +1388,8 @@ class TestSlapOSSlapToolInstanceAccess(TestSlapOSSlapToolMixin):
software_release_url=self.start_requested_software_instance.getUrlString(),
timestamp=int(self.start_requested_software_instance.getModificationDate()),
instance_guid=self.start_requested_software_instance.getReference(),
instance_title=self.start_requested_software_instance.getTitle(),
root_instance_title=self.start_requested_software_instance.getSpecialiseValue().getTitle(),
software_type=self.start_requested_software_instance.getSourceReference()
)
self.assertEqual(expected_xml, got_xml,
......@@ -2248,6 +2292,8 @@ class TestSlapOSSlapToolPersonAccess(TestSlapOSSlapToolMixin):
<dictionary id='i6'>
<string>full_ip_list</string>
<list id='i7'/>
<string>instance_title</string>
<unicode>%(instance_title)s</unicode>
<string>ip_list</string>
<list id='i8'>
<tuple>
......@@ -2257,6 +2303,8 @@ class TestSlapOSSlapToolPersonAccess(TestSlapOSSlapToolMixin):
</list>
<unicode>paramé</unicode>
<unicode>%(param)s</unicode>
<string>root_instance_title</string>
<unicode>%(root_instance_title)s</unicode>
<string>slap_computer_id</string>
<unicode>%(computer_id)s</unicode>
<string>slap_computer_partition_id</string>
......@@ -2316,6 +2364,8 @@ class TestSlapOSSlapToolPersonAccess(TestSlapOSSlapToolMixin):
software_release_url=self.start_requested_software_instance.getUrlString(),
timestamp=int(self.start_requested_software_instance.getModificationDate()),
instance_guid=self.start_requested_software_instance.getReference(),
instance_title=self.start_requested_software_instance.getTitle(),
root_instance_title=self.start_requested_software_instance.getSpecialiseValue().getTitle(),
software_type=self.start_requested_software_instance.getSourceReference(),
slave_1_param=self.start_requested_slave_instance.getInstanceXmlAsDict()['paramé'],
slave_1_software_type=self.start_requested_slave_instance.getSourceReference(),
......@@ -2372,6 +2422,8 @@ class TestSlapOSSlapToolPersonAccess(TestSlapOSSlapToolMixin):
<dictionary id='i6'>
<string>full_ip_list</string>
<list id='i7'/>
<string>instance_title</string>
<unicode>%(instance_title)s</unicode>
<string>ip_list</string>
<list id='i8'>
<tuple>
......@@ -2381,6 +2433,8 @@ class TestSlapOSSlapToolPersonAccess(TestSlapOSSlapToolMixin):
</list>
<unicode>paramé</unicode>
<unicode>%(param)s</unicode>
<string>root_instance_title</string>
<unicode>%(root_instance_title)s</unicode>
<string>slap_computer_id</string>
<unicode>%(computer_id)s</unicode>
<string>slap_computer_partition_id</string>
......@@ -2427,6 +2481,8 @@ class TestSlapOSSlapToolPersonAccess(TestSlapOSSlapToolMixin):
software_release_url=self.start_requested_software_instance.getUrlString(),
timestamp=int(self.start_requested_software_instance.getModificationDate()),
instance_guid=self.start_requested_software_instance.getReference(),
instance_title=self.start_requested_software_instance.getTitle(),
root_instance_title=self.start_requested_software_instance.getSpecialiseValue().getTitle(),
software_type=self.start_requested_software_instance.getSourceReference()
)
self.assertEqual(expected_xml, got_xml,
......@@ -2625,6 +2681,8 @@ class TestSlapOSSlapToolPersonAccess(TestSlapOSSlapToolMixin):
<string>%(state)s</string>
<string>full_ip_list</string>
<list id='i7'/>
<string>instance_title</string>
<unicode>%(instance_title)s</unicode>
<string>ip_list</string>
<list id='i8'>
<tuple>
......@@ -2632,6 +2690,8 @@ class TestSlapOSSlapToolPersonAccess(TestSlapOSSlapToolMixin):
<unicode>%(ip)s</unicode>
</tuple>
</list>
<string>root_instance_title</string>
<unicode>%(root_instance_title)s</unicode>
<string>slap_computer_id</string>
<unicode>%(computer_id)s</unicode>
<string>slap_computer_partition_id</string>
......@@ -2649,6 +2709,8 @@ class TestSlapOSSlapToolPersonAccess(TestSlapOSSlapToolMixin):
</marshal>
""" % dict(
instance_guid=self.start_requested_software_instance.getReference(),
instance_title=self.start_requested_software_instance.getTitle(),
root_instance_title=self.start_requested_software_instance.getSpecialiseTitle(),
state="started",
url_string=self.start_requested_software_instance.getUrlString(),
type=self.start_requested_software_instance.getSourceReference(),
......
master/bt5/slapos_slap_tool/TestTemplateItem/portal_components/test.erp5.testSlapOSSlapTool.xml
View file @ 476bddaf
......@@ -6,10 +6,22 @@
</pickle>
<pickle>
<dictionary>
<item>
<key> <string>_recorded_property_dict</string> </key>
<value>
<persistent> <string encoding="base64">AAAAAAAAAAI=</string> </persistent>
</value>
</item>
<item>
<key> <string>default_reference</string> </key>
<value> <string>testSlapOSSlapTool</string> </value>
</item>
<item>
<key> <string>description</string> </key>
<value>
<none/>
</value>
</item>
<item>
<key> <string>id</string> </key>
<value> <string>test.erp5.testSlapOSSlapTool</string> </value>
......@@ -35,23 +47,23 @@
<value>
<tuple>
<string>W: 29, 10: Use of eval (eval-used)</string>
<string>W: 38, 2: Arguments number differs from overridden method (arguments-differ)</string>
<string>W:467, 13: Use of eval (eval-used)</string>
<string>W:518, 13: Use of eval (eval-used)</string>
<string>W:743, 13: Use of eval (eval-used)</string>
<string>W:1307, 13: Use of eval (eval-used)</string>
<string>W:1420, 13: Use of eval (eval-used)</string>
<string>W:1474, 13: Use of eval (eval-used)</string>
<string>W:1514, 13: Use of eval (eval-used)</string>
<string>W:1921, 2: Arguments number differs from overridden method (arguments-differ)</string>
<string>W:2017, 13: Use of eval (eval-used)</string>
<string>W:2372, 13: Use of eval (eval-used)</string>
<string>W:2426, 13: Use of eval (eval-used)</string>
<string>W:2453, 13: Use of eval (eval-used)</string>
<string>W:2598, 13: Use of eval (eval-used)</string>
<string>W:2626, 13: Use of eval (eval-used)</string>
<string>W:2675, 13: Use of eval (eval-used)</string>
<string>W:2722, 13: Use of eval (eval-used)</string>
<string>W: 38, 2: Arguments number differs from overridden \'afterSetUp\' method (arguments-differ)</string>
<string>W:517, 13: Use of eval (eval-used)</string>
<string>W:568, 13: Use of eval (eval-used)</string>
<string>W:793, 13: Use of eval (eval-used)</string>
<string>W:1399, 13: Use of eval (eval-used)</string>
<string>W:1512, 13: Use of eval (eval-used)</string>
<string>W:1566, 13: Use of eval (eval-used)</string>
<string>W:1606, 13: Use of eval (eval-used)</string>
<string>W:2013, 2: Arguments number differs from overridden \'afterSetUp\' method (arguments-differ)</string>
<string>W:2109, 13: Use of eval (eval-used)</string>
<string>W:2492, 13: Use of eval (eval-used)</string>
<string>W:2546, 13: Use of eval (eval-used)</string>
<string>W:2573, 13: Use of eval (eval-used)</string>
<string>W:2728, 13: Use of eval (eval-used)</string>
<string>W:2756, 13: Use of eval (eval-used)</string>
<string>W:2805, 13: Use of eval (eval-used)</string>
<string>W:2852, 13: Use of eval (eval-used)</string>
</tuple>
</value>
</item>
......@@ -62,13 +74,28 @@
<item>
<key> <string>workflow_history</string> </key>
<value>
<persistent> <string encoding="base64">AAAAAAAAAAI=</string> </persistent>
<persistent> <string encoding="base64">AAAAAAAAAAM=</string> </persistent>
</value>
</item>
</dictionary>
</pickle>
</record>
<record id="2" aka="AAAAAAAAAAI=">
<pickle>
<global name="PersistentMapping" module="Persistence.mapping"/>
</pickle>
<pickle>
<dictionary>
<item>
<key> <string>data</string> </key>
<value>
<dictionary/>
</value>
</item>
</dictionary>
</pickle>
</record>
<record id="3" aka="AAAAAAAAAAM=">
<pickle>
<global name="PersistentMapping" module="Persistence.mapping"/>
</pickle>
......@@ -81,7 +108,7 @@
<item>
<key> <string>component_validation_workflow</string> </key>
<value>
<persistent> <string encoding="base64">AAAAAAAAAAM=</string> </persistent>
<persistent> <string encoding="base64">AAAAAAAAAAQ=</string> </persistent>
</value>
</item>
</dictionary>
......@@ -90,7 +117,7 @@
</dictionary>
</pickle>
</record>
<record id="3" aka="AAAAAAAAAAM=">
<record id="4" aka="AAAAAAAAAAQ=">
<pickle>
<global name="WorkflowHistoryList" module="Products.ERP5Type.patches.WorkflowTool"/>
</pickle>
......
master/product/Vifib/Tool/SlapTool.py
View file @ 476bddaf
......@@ -1476,6 +1476,8 @@ class SlapTool(BaseTool):
if (newtimestamp > timestamp):
timestamp = newtimestamp
hosting_subscription = software_instance.getSpecialiseValue()
ip_list = []
full_ip_list = []
for internet_protocol_address in computer_partition.contentValues(portal_type='Internet Protocol Address'):
......@@ -1519,6 +1521,8 @@ class SlapTool(BaseTool):
timestamp = newtimestamp
return {
'instance_guid': software_instance.getReference().decode("UTF-8"),
'instance_title': software_instance.getTitle().decode("UTF-8"),
'root_instance_title': hosting_subscription.getTitle().decode("UTF-8"),
'xml': software_instance.getTextContent(),
'connection_xml': software_instance.getConnectionXml(),
'filter_xml': software_instance.getSlaXml(),
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7